[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5021/ -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 04:30:06 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5020/ -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 04:19:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5019/ -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 28 Sep 2019 03:24:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 14: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5018/ -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 14 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 03:08:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4673/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 00:52:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 00:26:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/14059/14/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/14059/14/tests/common/impala_connection.py@323 PS14, Line 323: if 'NoneType' not in str(e): Can we restrict this to HTTP connections only? Would be nice not to swallow exceptions unless necessary. http://gerrit.cloudera.org:8080/#/c/14059/14/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/14059/14/tests/common/test_dimensions.py@117 PS14, Line 117: # IMPALA-8864: Older python versions do not support SSLContext object that the thrift http client nit: long line http://gerrit.cloudera.org:8080/#/c/14059/14/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14059/14/tests/shell/test_shell_interactive.py@293 PS14, Line 293: self.create_impala_clients() Should this be in a finally? So that a failure here doesn't cause follow-on effects. Probably OK to ignore, would just reduce noise if the test fails. http://gerrit.cloudera.org:8080/#/c/14059/14/tests/shell/test_shell_interactive.py@335 PS14, Line 335: self.create_impala_clients() Same here (I think I created this problem in the first place by closing the clients and not reopening, under the assumption that they would be re-created). I guess the other way we could solve is by reopening the clients automatically in the test setup if they were closed. But don't need to do that. -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 14 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 00:25:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5021/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 00:12:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14304/5/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/14304/5/bin/impala-config.sh@170 PS5, Line 170: export CDH_BUILD_NUMBER=1392050 > I uploaded artifacts for 1474057, maybe move to that newer version? Done -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 00:12:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Lars Volker has uploaded a new patch set (#6) to the change originally created by Kurt Deschler. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue Automated tests were failing while creating Kudu tables with openssl1.1.1 installed on the machine This issue was previously reported under KUDU-2871 and resolved by disabling TLS 1.3 in Kudu source. This change bumps the Kudu version in impala-config.sh to pull in the fix for KUDU-2871. Testing: Create kudu table via automated tests passes Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 --- M bin/impala-config.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14304/6 -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5020/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 28 Sep 2019 00:02:48 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4672/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 23:55:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 23:45:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14304/5/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/14304/5/bin/impala-config.sh@170 PS5, Line 170: export CDH_BUILD_NUMBER=1392050 I uploaded artifacts for 1474057, maybe move to that newer version? -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 23:41:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4670/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 23:28:02 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 ) Change subject: Remove hard-coded localhost from impala_test_suite.py .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4671/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 23:27:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Hello Thomas Tauber-Marshall, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14318 to look at the new patch set (#2). Change subject: Remove hard-coded localhost from impala_test_suite.py .. Remove hard-coded localhost from impala_test_suite.py Hard-coding "localhost" into the test framework breaks being able to run the tests against deployed/non-local clusters. Tested by running tests against a deployed cluster from a local checkout of the repo, and confirming that we can connect to the remote debug page. Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d --- M tests/common/impala_test_suite.py 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/14318/2 -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5019/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 23:11:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
David Knupp has posted comments on this change. (
http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
..
Patch Set 2:
(1 comment)
> Patch Set 1:
>
> (1 comment)
Thanons
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py@128
PS1, Line 128: VARZ_URL = 'http://{0}:25000/varz?json'.format(IMPALAD_HOSTNAME)
> IMPALAD_HOSTNAME?
Done
Thanks Thomas -- good point. I wasn't looking above.
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Fri, 27 Sep 2019 23:15:12 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4669/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 23:11:53 + Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Thomas Tauber-Marshall has posted comments on this change. (
http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py@128
PS1, Line 128: impalad_hostname =
pytest.config.option.impalad.split(',')[0].split(':')[0]
IMPALAD_HOSTNAME?
Also, maybe better to combine this with the stuff above to reduce duplication,
i.e. define IMPALAD_HOSTNAME immediately after IMPALAD above, and then use it
when constructing IMPALAD_HS2_HOST_PORT, etc.
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Fri, 27 Sep 2019 22:52:20 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 7: Code-Review+2 (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1313 PS6, Line 1313: catalog_.addVersionsForInflightEvents(db, newCatalogVersion); > The ALTER_DATABASE event is generated by the applyAlterDatabase() function Thanks for the explanation! -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 22:35:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14318 Change subject: Remove hard-coded localhost from impala_test_suite.py .. Remove hard-coded localhost from impala_test_suite.py Hard-coding "localhost" into the test framework breaks being able to run the tests against deployed/non-local clusters. Tested by running tests against a deployed cluster from a local checkout of the repo, and confirming that we can connect to the remote debug page. Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d --- M tests/common/impala_test_suite.py 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/14318/1 -- To view, visit http://gerrit.cloudera.org:8080/14318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d Gerrit-Change-Number: 14318 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 14: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5018/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 14 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 22:50:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue
Lars Volker has uploaded a new patch set (#5) to the change originally created by Kurt Deschler. ( http://gerrit.cloudera.org:8080/14304 ) Change subject: IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue .. IMPALA-8973: Update Kudu version to fix openssl1.1.1 compatibility issue Automated tests were failing while creating Kudu tables with openssl1.1.1 installed on the machine This issue was previously reported under KUDU-2871 and resolved by disabling TLS 1.3 in Kudu source. This change bumps the Kudu version in impala-config.sh to pull in the fix for KUDU-2871. Testing: Create kudu table via automated tests passes Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 --- M bin/impala-config.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14304/5 -- To view, visit http://gerrit.cloudera.org:8080/14304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic34520b4b260e9fe610bc6a5a0e8acf8066dfa69 Gerrit-Change-Number: 14304 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Anurag Mantripragada has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. IMPALA-8968: Alter database events on dropped database should not put events processor in error state. This change is two-fold: 1. If an alter database event is received on database that does not exist, the event can be safely ignored. The events processor should only go into an error state if updateDb() fails. 2. This change also adds catalog service identifiers to create/drop function operations as Impala generates alter database events with these operations and they should be detected as self-events and ignored. Testing: Add tests to verify both the above changes to MetastoreEventsProcessorTest. Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 4 files changed, 110 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14296/7 -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] Fix --webserver interface for remote cluster tests
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14313 ) Change subject: Fix --webserver_interface for remote cluster tests .. Patch Set 3: > Patch Set 3: > > ...a comma-delimited string of multiple hosts + port 21000 (from conftest.py, > L46): > > DEFAULT_IMPALADS = "localhost:21000,localhost:21001,localhost:21002" I meant to write comma-delimited string of multiple hosts + port 2100x. -- To view, visit http://gerrit.cloudera.org:8080/14313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b8adefe4e2bb8f7013d9af70fd3e5dfd7ee18f Gerrit-Change-Number: 14313 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 22:19:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1313 PS6, Line 1313: catalog_.addVersionsForInflightEvents(db, newCatalogVersion); > Could you explain why we don't need this for persistent java functions? In The ALTER_DATABASE event is generated by the applyAlterDatabase() function above. For persistent Java functions, we call hms api for createFunction() which will not create an alter database function. -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 22:27:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Fix --webserver interface for remote cluster tests
David Knupp has posted comments on this change. (
http://gerrit.cloudera.org:8080/14313 )
Change subject: Fix --webserver_interface for remote cluster tests
..
Patch Set 3:
Sorry that I'm coming to this late, but I don't think this will address testing
against a remote cluster. Another issue is that when we run these tests against
a remote clusters, the local minicluster is NOT required to be running, which
means L124 and L125 from impala_test_suite.py will break:
METRICS_URL = 'http://localhost:25000/metrics?json'
VARZ_URL = 'http://localhost:25000/varz?json'
...since there's nothing listening at localhost:25000.
tests/common/impala_test_suite.py:339: in get_var_current_val
varz = self.get_debug_page(VARZ_URL)
tests/common/impala_test_suite.py:332: in get_debug_page
response = requests.get(page_url)
infra/python/env/local/lib/python2.7/site-packages/requests/api.py:69: in get
return request('get', url, params=params, **kwargs)
infra/python/env/local/lib/python2.7/site-packages/requests/api.py:50: in
request
response = session.request(method=method, url=url, **kwargs)
infra/python/env/local/lib/python2.7/site-packages/requests/sessions.py:465:
in request
resp = self.send(prep, **send_kwargs)
infra/python/env/local/lib/python2.7/site-packages/requests/sessions.py:573:
in send
r = adapter.send(request, **kwargs)
infra/python/env/local/lib/python2.7/site-packages/requests/adapters.py:415:
in send
raise ConnectionError(err, request=request)
E ConnectionError: ('Connection aborted.', error(111, 'Connection refused'))
Basically, hard-coding "localhost" anywhere in any part of the test framework
is always a bad idea. The better solution is to use whatever pytest thinks the
"impalad" value is -- although the problem there is that it's variably either a
comma-delimited string of multiple hosts + port 21000 (from conftest.py, L46):
DEFAULT_IMPALADS = "localhost:21000,localhost:21001,localhost:21002"
or else simply "hostname:21000" if specified on the command line with
"--impalad". So the hardcoded port numbers are an issue as well. :-(
I just ran a quick test, and this approach, as ugly as it looks, works. I'll
open a new patch soon.
impalad_hostname = pytest.config.option.impalad.split(',')[0].split(':')[0]
METRICS_URL = 'http://{0}:25000/metrics?json'.format(impalad_hostname)
VARZ_URL = 'http://{0}:25000/varz?json'.format(impalad_hostname)
--
To view, visit http://gerrit.cloudera.org:8080/14313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5b8adefe4e2bb8f7013d9af70fd3e5dfd7ee18f
Gerrit-Change-Number: 14313
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Fri, 27 Sep 2019 22:10:23 +
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7984: Port runtime filter from Thrift RPC to KRPC
Fang-Yu Rao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC
..
Patch Set 24:
(6 comments)
Hi Michael and Thomas, I have addressed some of the comments in the previous
iteration. There are still two unresolved comments in runtime-filter-bank.cc.
Please let me know your thoughts on my replies. Thanks!
http://gerrit.cloudera.org:8080/#/c/13882/24/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/13882/24/be/src/runtime/coordinator.cc@1134
PS24, Line 1134: std::string(
: reinterpret_cast(sidecar_slice.data()), sidecar_slice.size());
> Why not std::move(sidecar_slice.ToString()) ?
Thanks for pointing this out! I have replaced the original statement with
'std::move(sidecar_slice.ToString())' to make it more elegant.
http://gerrit.cloudera.org:8080/#/c/13882/24/be/src/runtime/runtime-filter-bank.cc
File be/src/runtime/runtime-filter-bank.cc:
http://gerrit.cloudera.org:8080/#/c/13882/24/be/src/runtime/runtime-filter-bank.cc@174
PS24, Line 174: UpdateFilterParamsPB* params = obj_pool_.Add(new
UpdateFilterParamsPB);
> Can you please double check if the parameters need to be preserved beyond t
Thank you for pointing this out! You are correct. 'params' can be freed once
the asynchronous RPC call is done. I have replaced the original statement with
'std::unique_ptr params =
std::make_unique();' and revised the following code
accordingly.
http://gerrit.cloudera.org:8080/#/c/13882/24/be/src/runtime/runtime-filter-bank.cc@175
PS24, Line 175: UpdateFilterResultPB* res = obj_pool_.Add(new
UpdateFilterResultPB);
: RpcController* controller = obj_pool_.Add(new
RpcController);
> I wonder if we can keep these in thread local storage and initialize them o
Thank you very much for the suggestion!
After briefly taking a look at the related sequence of calls, I found that
starting from QueryState::ExecFInstance() (which will call
FragmentInstanceState::Exec()), we will reach PhjBuilder::FlushFinal(). In
PhjBuilder::FlushFinal(), we have a function call to
PhjBuilder::PublishRuntimeFilters(), which will make a call to
RuntimeFilterBank::UpdateFilterFromLocal() for each FilterContext associated
with this PhjBuilder (refer to
https://github.com/apache/impala/blob/master/be/src/exec/partitioned-hash-join-builder.cc#L488-L507).
Considering that RuntimeFilterBank::UpdateFilterFromLocal() is an asynchronous
RPC now, it seems we are not able to reuse 'UpdateFilterResultPB' and
'UpdateFilterResultPB'.
Another possible solution is to create an instance of UpdateFilterResultPB and
UpdateFilterResultPB here in UpdateFilterFromLocal() and then release the
memory they occupy in RuntimeFilterBank::UpdateFilterCompleteCb().
I could probably miss something. Please let me know if I misunderstand anything.
http://gerrit.cloudera.org:8080/#/c/13882/24/be/src/runtime/runtime-filter-bank.cc@320
PS24, Line 320: // Wait for all inflight rpcs to complete before closing the
filters.
: {
: std::unique_lock l1(num_inflight_rpcs_lock_);
: while (num_inflight_rpcs_ > 0) {
: krpcs_done_cv_.wait(l1);
: }
: }
:
: lock_guard l2(runtime_filter_lock_);
: closed_ = true;
> Do you need to set closed_ to true before waiting for all in-flight RPCs to
Thanks very much for the comment.
After reading the related code paths, I think the case where a thread may sneak
in and try to issue an RPC again after we break out of the critical section
could not happen.
According to my current understanding, in the propagation stage of the runtime
filter protocol, starting from FragmentInstanceState::Exec(), the thread
executing this function will first call FragmentInstanceState::Open(), which
will (1) call
RuntimeFilterBank::AllocateScratchBloomFilter()/AllocateScratchMinMaxFilter()
to allocate the memory space for the corresponding RuntimeFilter, and (2) call
RuntimeFilterBank::UpdateFilterFromLocal() on the RuntimeFilter just allocated.
After FragmentInstanceState::Open() returns, the same thread above will call
FragmentInstanceState::Close(), which in turn will lead us to
RuntimeFilterBank::Close().
When RuntimeFilterBank::Close() is called, the calling thread has already made
all the RPC's it wants to perform (There could still be inflight RPC's but
there won't be any new RPC's issued). No thread will attempt to make any RPC
resulting from RuntimeFilterBank::UpdateFilterFromLocal() and then increment
'num_inflight_rpcs_' associated with this instance of RuntimeFilterBank. Hence
the case where a thread sneaks in and try to issue RPC after leaving the
critical section cannot happen.
We have also added a
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 13: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5017/ -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 13 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 20:06:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 12: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4668/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 12 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 19:27:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 6: (3 comments) Still have one more question and a nit http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1226 PS6, Line 1226: nit: wrong indent here http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1313 PS6, Line 1313: catalog_.addVersionsForInflightEvents(db, newCatalogVersion); Could you explain why we don't need this for persistent java functions? In previous patch versions, it's in the if-branch below. http://gerrit.cloudera.org:8080/#/c/14296/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2017 PS6, Line 2017: catalog_.addVersionsForInflightEvents(db, newCatalogVersion); same here. -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 19:00:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/14059/12/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/14059/12/tests/common/test_dimensions.py@116 PS12, Line 116: def create_client_protocol_dimension(): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/14059/12/tests/common/test_dimensions.py@117 PS12, Line 117: t flake8: E501 line too long (99 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 12 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 18:48:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4667/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 18:54:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14059 to look at the new patch set (#12). Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. IMPALA-8863: Add support to run tests over HTTP/HS2 This change adds support to run backend tests over HTTP using a new version of Impyla. It also adds a test that exercises authentication over HTTP. Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 --- M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java A fe/src/test/java/org/apache/impala/customcluster/LdapImpylaHttpTest.java A fe/src/test/java/org/apache/impala/customcluster/RunShellCommand.java M infra/python/deps/compiled-requirements.txt M tests/common/impala_connection.py M tests/common/impala_test_suite.py M tests/common/test_dimensions.py M tests/custom_cluster/test_client_ssl.py M tests/custom_cluster/test_hs2.py M tests/custom_cluster/test_session_expiration.py M tests/custom_cluster/test_shell_interactive.py M tests/custom_cluster/test_shell_interactive_reconnect.py M tests/query_test/test_cast_with_format.py M tests/query_test/test_chars.py M tests/query_test/test_date_queries.py M tests/query_test/test_decimal_queries.py M tests/query_test/test_queries.py M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py A tests/util/run_impyla_http_query.py 20 files changed, 361 insertions(+), 115 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/14059/12 -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 12 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4666/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 18:52:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8863: Add support to run tests over HTTP/HS2
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 ) Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5017/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 13 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 18:50:43 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 18:18:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. IMPALA-8968: Alter database events on dropped database should not put events processor in error state. This change is two-fold: 1. If an alter database event is received on database that does not exist, the event can be safely ignored. The events processor should only go into an error state if updateDb() fails. 2. This change also adds catalog service identifiers to create/drop function operations as Impala generates alter database events with these operations and they should be detected as self-events and ignored. Testing: Add tests to verify both the above changes to MetastoreEventsProcessorTest. Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 4 files changed, 110 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14296/5 -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14296/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14296/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2217 PS3, Line 2217: :*/ > remove? Done -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 18:13:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Anurag Mantripragada has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. IMPALA-8968: Alter database events on dropped database should not put events processor in error state. This change is two-fold: 1. If an alter database event is received on database that does not exist, the event can be safely ignored. The events processor should only go into an error state if updateDb() fails. 2. This change also adds catalog service identifiers to create/drop function operations as Impala generates alter database events with these operations and they should be detected as self-events and ignored. Testing: Add tests to verify both the above changes to MetastoreEventsProcessorTest. Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 4 files changed, 110 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/14296/6 -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 6 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7378ac1a490a6c89a0a4349aae86cbc0fbc80f8 Gerrit-Change-Number: 12621 Gerrit-PatchSet: 16 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 27 Sep 2019 17:25:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13944 ) Change subject: IMPALA-8198: DATE: Read from avro. .. IMPALA-8198: DATE: Read from avro. This change is a follow-up to IMPALA-7368 and adds support for DATE type to the avro scanner. Similarly to parquet, avro uses DATE logical type for dates. DATE logical type annotates an INT32 that stores the number of days since the unix epoch, 1 January 1970. This representation introduces an avro interoperability issue between Impala and older versions of Hive: - Before version 3.1, Hive used Julian calendar to represent dates up to 1582-10-05 and Gregorian calendar for dates starting with 1582-10-15. Dates between 1582-10-05 and 1582-10-15 were lost. - Impala uses proleptic Gregorian calendar, extending the Gregorian calendar backward to dates preceding its official introduction in 1582-10-15. This means that pre-1582-10-15 dates written to an avro table by Hive will be read back incorrectly by Impala. Note that Hive 3.1 switched to proleptic Gregorian calendar too, so for Hive 3.1+ this is no longer an issue. Dependency changes: - BE uses avro 1.7.4-p5 from native-toolchain. Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959 Reviewed-on: http://gerrit.cloudera.org:8080/13944 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/codegen/gen_ir_descriptions.py M be/src/exec/hdfs-avro-scanner-ir.cc M be/src/exec/hdfs-avro-scanner-test.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-avro-scanner.h M be/src/util/avro-util.cc M common/thrift/generate_error_codes.py M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java M fe/src/test/java/org/apache/impala/catalog/CatalogObjectToFromThriftTest.java M testdata/avro_schema_resolution/create_table.sql M testdata/avro_schema_resolution/file_schema2.avsc M testdata/avro_schema_resolution/records2.avro M testdata/avro_schema_resolution/records2.json M testdata/bad_avro_snap/README A testdata/bad_avro_snap/hive2_pre_gregorian_date.avro A testdata/bad_avro_snap/hive3_pre_gregorian_date.avro A testdata/bad_avro_snap/out_of_range_date.avro M testdata/bin/generate-schema-statements.py M testdata/data/README M testdata/data/date_tbl.avro A testdata/data/date_tbl.orc M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv M testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test M testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test M testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test A testdata/workloads/functional-query/queries/QueryTest/avro_date.test M testdata/workloads/functional-query/queries/QueryTest/date-fileformat-support.test M testdata/workloads/functional-query/queries/QueryTest/date-partitioning.test M testdata/workloads/functional-query/queries/QueryTest/hive2-pre-gregorian-date.test M testdata/workloads/functional-query/queries/QueryTest/out-of-range-date.test M tests/query_test/test_date_queries.py 35 files changed, 435 insertions(+), 76 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959 Gerrit-Change-Number: 13944 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 ) Change subject: IMPALA-8198: DATE: Read from avro. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959 Gerrit-Change-Number: 13944 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 17:18:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Fix --webserver interface for remote cluster tests
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14313 ) Change subject: Fix --webserver_interface for remote cluster tests .. Fix --webserver_interface for remote cluster tests IMPALA-4057 updated our test infrastructure to allow setting the flag --webserver_interface. In some cases, that patch used a default value of '127.0.0.1', which works for running the tests against the local minicluster but fails when the tests are run against a remote cluster. This patch fixes this by removing the use of '127.0.0.1' and replacing it with the specified hostname. Change-Id: Ic5b8adefe4e2bb8f7013d9af70fd3e5dfd7ee18f Reviewed-on: http://gerrit.cloudera.org:8080/14313 Tested-by: Impala Public Jenkins Reviewed-by: Joe McDonnell --- M tests/common/impala_service.py M tests/common/impala_test_suite.py 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b8adefe4e2bb8f7013d9af70fd3e5dfd7ee18f Gerrit-Change-Number: 14313 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8968: Alter database events on dropped database should not put events processor in error state.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 ) Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. .. Patch Set 4: Code-Review+1 (1 comment) Quanlong can you +2 it if you have no further comments? http://gerrit.cloudera.org:8080/#/c/14296/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14296/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2217 PS3, Line 2217: Throws :* DatabaseNotFoundException if db was removed before update starts. remove? -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 27 Sep 2019 17:00:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode
Quanlong Huang has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Removed reviewer Todd Lipcon. -- To view, visit http://gerrit.cloudera.org:8080/14307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ib61a7ab1ffa062620ffbc2dadc34bd7a8ca9e549 Gerrit-Change-Number: 14307 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode
Quanlong Huang has restored this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Restored -- To view, visit http://gerrit.cloudera.org:8080/14307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Ib61a7ab1ffa062620ffbc2dadc34bd7a8ca9e549 Gerrit-Change-Number: 14307 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] Fix --webserver interface for remote cluster tests
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14313 ) Change subject: Fix --webserver_interface for remote cluster tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b8adefe4e2bb8f7013d9af70fd3e5dfd7ee18f Gerrit-Change-Number: 14313 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 16:36:15 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4665/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 14:44:49 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5016/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 14:05:37 + Gerrit-HasComments: No
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 ) Change subject: [WIP] Add POC Kudu VARCHAR .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14197/6/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14197/6/be/src/exec/kudu-util.cc@234 PS6, Line 234: case DataType::VARCHAR: return ColumnType::CreateVarcharType(type_attributes.length()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 14:04:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [WIP] Add POC Kudu VARCHAR
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14197 to look at the new patch set (#6). Change subject: [WIP] Add POC Kudu VARCHAR .. [WIP] Add POC Kudu VARCHAR Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 --- M be/src/exec/kudu-util.cc M bin/impala-config.sh M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 7 files changed, 40 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/14197/6 -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. Patch Set 16: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5015/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/12621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7378ac1a490a6c89a0a4349aae86cbc0fbc80f8 Gerrit-Change-Number: 12621 Gerrit-PatchSet: 16 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Daniel Becker Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 27 Sep 2019 13:13:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 ) Change subject: IMPALA-8198: DATE: Read from avro. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5014/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959 Gerrit-Change-Number: 13944 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 12:56:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 ) Change subject: IMPALA-8198: DATE: Read from avro. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959 Gerrit-Change-Number: 13944 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 12:56:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8498: Write column index for floating types when NaN is not present
Zoltan Borok-Nagy has removed a vote on this change. Change subject: IMPALA-8498: Write column index for floating types when NaN is not present .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/14264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ic9d367500243c8ca142a16ebfeef6c841f013434 Gerrit-Change-Number: 14264 Gerrit-PatchSet: 4 Gerrit-Owner: Norbert Luksa Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Norbert Luksa Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14291 ) Change subject: IMPALA-8704: ISO:SQL:2016 datetime patterns - Milestone 2 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py@578 PS2, Line 578: test_text_token > I'm confused about how a backslash character should be represented inside t Thanks for spotting this. The code is not really prepared to handle backslashes inside the text token. What makes this complicated is that when parsing we don't know if the content of the text token is escaped or double escaped (latter can happen when the surrounding double quotes of the text token are escaped themselves.) so we won't know how many backslashes to skip. I'll give this a second though, or if I can't figure out anything we might want to emphasize that backslashes are not supported only for escaping double quotes. http://gerrit.cloudera.org:8080/#/c/14291/2/tests/query_test/test_cast_with_format.py@580 PS2, Line 580: ''' : r''' > You can probably remove these from the end of the L580 and the beginning of It might work, but I wanted to not include a new line char in the query string. I don't see much benefit of removing these. -- To view, visit http://gerrit.cloudera.org:8080/14291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d2f6656054371476aaa8bd0d51f572b9369855 Gerrit-Change-Number: 14291 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 27 Sep 2019 11:36:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Fix --webserver interface for remote cluster tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14313 ) Change subject: Fix --webserver_interface for remote cluster tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5b8adefe4e2bb8f7013d9af70fd3e5dfd7ee18f Gerrit-Change-Number: 14313 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Sep 2019 05:56:09 + Gerrit-HasComments: No
