[Impala-ASF-CR] IMPALA-5392: Display full Java stacktraces in /jvm-threadz
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19632 ) Change subject: IMPALA-5392: Display full Java stacktraces in /jvm-threadz .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/19632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6730336600a8130e6452c682bcf249cac528ceee Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 20 Mar 2023 03:51:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5392: Display full Java stacktraces in /jvm-threadz
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19632 ) Change subject: IMPALA-5392: Display full Java stacktraces in /jvm-threadz .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9156/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6730336600a8130e6452c682bcf249cac528ceee Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Mon, 20 Mar 2023 03:54:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11992: Support setting query options in Hive JDBC's connection URL
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19612 ) Change subject: IMPALA-11992: Support setting query options in Hive JDBC's connection URL .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9155/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/19612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie184a0c2404f36a3ee28296336f6545615a5c6ca Gerrit-Change-Number: 19612 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 20 Mar 2023 03:15:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5392: Display full Java stacktraces in /jvm-threadz
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19632 ) Change subject: IMPALA-5392: Display full Java stacktraces in /jvm-threadz .. Patch Set 1: Code-Review+1 Thanks for fixing this! -- To view, visit http://gerrit.cloudera.org:8080/19632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6730336600a8130e6452c682bcf249cac528ceee Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 20 Mar 2023 00:33:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5392: Display full Java stacktraces in /jvm-threadz
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19632 ) Change subject: IMPALA-5392: Display full Java stacktraces in /jvm-threadz .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12647/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/19632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6730336600a8130e6452c682bcf249cac528ceee Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 19 Mar 2023 21:37:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5392: Display full Java stacktraces in /jvm-threadz
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19632 Change subject: IMPALA-5392: Display full Java stacktraces in /jvm-threadz .. IMPALA-5392: Display full Java stacktraces in /jvm-threadz jvm-threadz provides information about all the JVM threads running in an Impalad/Catalogd. Currently, this relies on ThreadInfo.toString() for a text representation of the thread information and stack. This output only contains the first few frames, which can be an issue for deeper stacks (e.g. the Catalog talking to HMS via Thrift). The output does contain useful non-stacktrace information like what lock the thread is waiting on. This keeps the first line of the ThreadInfo.toString() output that contains non-stacktrace information. Then it walks through the StackTraceElements from ThreadInfo.getStackTrace() and adds the full stack string. This is intended to mimic the jstack output (with indentation and "at"). To avoid licensing issues, I have not looked at any of the OpenJDK code (which is GPL 2.0) or any of the previous attempts at solving this issue (which consulted OpenJDK code). To make the stacks display correctly in the WebUI page, this puts the thread information in a with "white-space: pre-wrap", which respects the newlines in the original output. Testing: - gdb attached to the HMS and then issued a select in impala-shell to force a metadata load. Then, looked at the catalogd /jvm-threadz page to see the longer stacks. Change-Id: I6730336600a8130e6452c682bcf249cac528ceee --- M fe/src/main/java/org/apache/impala/common/JniUtil.java M www/jvm-threadz.tmpl 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/19632/1 -- To view, visit http://gerrit.cloudera.org:8080/19632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6730336600a8130e6452c682bcf249cac528ceee Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19628/4/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/19628/4/be/src/util/runtime-profile.h@315 PS4, Line 315: RuntimeProfileBase(ObjectPool* pool, const std::string& name, : Counter* total_time_counter, Counter* inactive_timer); : RuntimeProfileBase(ObjectPool* pool, const std::string& name, : Counter* total_time_counter, Counter* inactive_timer, bool add_default_counters); We could combine two overloaded functions as one by defining the default value of "add_default_counters" as true. http://gerrit.cloudera.org:8080/#/c/19628/4/fe/src/main/java/org/apache/impala/service/FrontendProfile.java File fe/src/main/java/org/apache/impala/service/FrontendProfile.java: http://gerrit.cloudera.org:8080/#/c/19628/4/fe/src/main/java/org/apache/impala/service/FrontendProfile.java@187 PS4, Line 187: Preconditions.checkState(profile_ != null, "already emitted profile"); it's already called in addToCounter() and setToCounter() -- To view, visit http://gerrit.cloudera.org:8080/19628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c0ac7f5216d631e4439fe97702e21e06d2eda8a Gerrit-Change-Number: 19628 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Abhishek Rawat Gerrit-Reviewer: David Rorke Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Sun, 19 Mar 2023 07:24:34 + Gerrit-HasComments: Yes
