[native-toolchain-CR] Don't use MADV FREE on linux
helifu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15955 ) Change subject: Don't use MADV_FREE on linux .. Don't use MADV_FREE on linux Change-Id: I5e6ca41f054e17ce4f30d6c6cd58da3c358af11a --- M buildall.sh A source/gperftools/gperftools-2.5-patches/0001-Don-t-use-MADV_FREE-on-Linux.patch 2 files changed, 34 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/55/15955/2 -- To view, visit http://gerrit.cloudera.org:8080/15955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e6ca41f054e17ce4f30d6c6cd58da3c358af11a Gerrit-Change-Number: 15955 Gerrit-PatchSet: 2 Gerrit-Owner: helifu
[native-toolchain-CR] Don't use MADV FREE on linux
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15955 Change subject: Don't use MADV_FREE on linux .. Don't use MADV_FREE on linux Change-Id: I5e6ca41f054e17ce4f30d6c6cd58da3c358af11a --- M buildall.sh A source/gperftools/gperftools-2.5-patches/0001-Don-t-use-MADV_FREE-on-Linux.patch 2 files changed, 34 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/55/15955/1 -- To view, visit http://gerrit.cloudera.org:8080/15955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5e6ca41f054e17ce4f30d6c6cd58da3c358af11a Gerrit-Change-Number: 15955 Gerrit-PatchSet: 1 Gerrit-Owner: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 13: > > Patch Set 13: > > > > > Thanks for the fix. > > > > should i rebase to the newest master branch? > > The merge will auto-rebase. Thanks for your help, good night:) -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 13 Gerrit-Owner: helifu Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: helifu Gerrit-Comment-Date: Fri, 03 May 2019 15:27:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 13: > Thanks for the fix. should i rebase to the newest master branch? -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 13 Gerrit-Owner: helifu Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: helifu Gerrit-Comment-Date: Fri, 03 May 2019 15:22:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#12).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/query_test/test_kudu.py
9 files changed, 96 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/12
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 12
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 9: It seems there is something wrong with hdfs package, below is my local compilation error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project impala-frontend: Compilation failure [ERROR] /mnt/ceph/impala/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java:[868,51] cannot find symbol [ERROR] symbol: method getFileName() By the way, how to quote my reply? :) -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 9 Gerrit-Owner: helifu Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: helifu Gerrit-Comment-Date: Tue, 30 Apr 2019 02:47:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#9).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/query_test/test_kudu.py
8 files changed, 95 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/9
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 9
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. (
http://gerrit.cloudera.org:8080/12977 )
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
Patch Set 8:
(1 comment)
--helifu Apr 10 8:47 AM↩
Patch Set 1:
The latest kudu client is required, otherwise the compilation fails
http://gerrit.cloudera.org:8080/#/c/12977/8/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
http://gerrit.cloudera.org:8080/#/c/12977/8/tests/metadata/test_ddl.py@737
PS8, Line 737: self.client.execute("drop table {0}".format(table))
> Instead of dropping, we can just create two different tables for the first
Done
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 8
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
Gerrit-Comment-Date: Sun, 28 Apr 2019 05:25:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#8).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/query_test/test_kudu.py
8 files changed, 95 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/8
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 8
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. (
http://gerrit.cloudera.org:8080/12977 )
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
Patch Set 7:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12977/7/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
File fe/src/main/java/org/apache/impala/catalog/KuduColumn.java:
http://gerrit.cloudera.org:8080/#/c/12977/7/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java@116
PS7, Line 116:
> nit: remove two extra spaces
Done
http://gerrit.cloudera.org:8080/#/c/12977/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/12977/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2607
PS7, Line 2607:
> nit: remove one extra space for the indentation
Done
http://gerrit.cloudera.org:8080/#/c/12977/7/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
http://gerrit.cloudera.org:8080/#/c/12977/7/tests/metadata/test_ddl.py@733
PS7, Line 733: create table {0} (i int PRIMARY KEY) STORED AS KUDU
> nit: use lower case to be consistent with the style in this file
Done
http://gerrit.cloudera.org:8080/#/c/12977/7/tests/metadata/test_ddl.py@735
PS7, Line 735: comment = self._get_column_comment(table, 'i')
> can we have similar test case for "create table {0} (x int comment 'x', pri
Done
http://gerrit.cloudera.org:8080/#/c/12977/7/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/12977/7/tests/metadata/test_ddl_base.py@122
PS7, Line 122: or len(cols) == 9
> if len(cols) <= 9 is better since it will work on both kudu and on kudu tab
Done
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 7
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
Gerrit-Comment-Date: Sun, 28 Apr 2019 01:35:20 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#7).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/query_test/test_kudu.py
8 files changed, 89 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/7
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 7
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#6).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/query_test/test_kudu.py
8 files changed, 88 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/6
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 6
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#5).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
M tests/query_test/test_kudu.py
8 files changed, 84 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/5
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 5
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. (
http://gerrit.cloudera.org:8080/12977 )
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12977/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/12977/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3896
PS3, Line 3896: if
(!updateColumnComment(msTbl.getPartitionKeysIterator(), columnName, comment)) {
> line too long (92 > 90)
Done
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 3
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
Gerrit-Comment-Date: Thu, 25 Apr 2019 00:32:31 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#4).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu-table with column comment;
2) alter kudu-table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu-table;
5) invalidate metadata;
6) comment on column is { '' | null | 'comment' }
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
5 files changed, 39 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/4
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 4
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12977
to look at the new patch set (#3).
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
IMPALA-5351: Support storing column comment of kudu table
This patch intends to support storing column comment of kudu table
on impala side.
Belows tests passed:
1) creata kudu table with column comment;
2) alter kudu table with (add/alter[delete] column comment);
3) show create kudu table;
4) describe kudu table;
5) invalidate metadata;
6) comment on column is {'' | null | 'comment'}
Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
5 files changed, 38 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/3
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 3
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. (
http://gerrit.cloudera.org:8080/12977 )
Change subject: IMPALA-5351: Support storing column comment of kudu table
..
Patch Set 2:
(6 comments)
sorry for the late update.
http://gerrit.cloudera.org:8080/#/c/12977/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12977/2//COMMIT_MSG@9
PS2, Line 9: This patch intends to support storing column comment of kudu table
: on impala side.
> it's okay if we don't it in this patch, but do we plan to support COMMENT O
Done
http://gerrit.cloudera.org:8080/#/c/12977/2//COMMIT_MSG@12
PS2, Line 12: Belows tests passed:
: 1) creata kudu table with column comment;
: 2) alter kudu table with (add/alter[delete] column comment);
: 3) show create kudu table;
: 4) describe kudu table;
> Can you add tests into the following files?
Done
http://gerrit.cloudera.org:8080/#/c/12977/2/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
File fe/src/main/java/org/apache/impala/catalog/KuduColumn.java:
http://gerrit.cloudera.org:8080/#/c/12977/2/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java@88
PS2, Line 88: String comment = null;
: if (!colSchema.getComment().isEmpty()) comment =
colSchema.getComment();
> nit: can be inlined
Done
http://gerrit.cloudera.org:8080/#/c/12977/2/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java@116
PS2, Line 116: String comment = null;
: if (column.isSetComment() && !column.getComment().isEmpty())
{
: comment = column.getComment();
: }
> nit; same as above. It can be inlined.
Done
http://gerrit.cloudera.org:8080/#/c/12977/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/12977/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@298
PS2, Line 298: String comment = null;
: if (!colSchema.getComment().isEmpty()) {
: comment = colSchema.getComment();
: }
> nit: inline this.
Done
http://gerrit.cloudera.org:8080/#/c/12977/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@303
PS2, Line 303: type.toSql().toLowerCase(),
: comment));
> nit Impala doesn't use this code style. Continued indentation is 4 spaces.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 2
Gerrit-Owner: helifu
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Marshall
Gerrit-Reviewer: helifu
Gerrit-Comment-Date: Wed, 24 Apr 2019 11:30:32 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#2). Change subject: IMPALA-5351: Support storing column comment of kudu table .. IMPALA-5351: Support storing column comment of kudu table This patch intends to support storing column comment of kudu table on impala side. Belows tests passed: 1) creata kudu table with column comment; 2) alter kudu table with (add/alter[delete] column comment); 3) show create kudu table; 4) describe kudu table; Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c --- M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java 3 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/2 -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 2 Gerrit-Owner: helifu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: helifu
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12977/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/12977/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@302 PS1, Line 302: cols.add(new FieldSchema(colSchema.getName(), type.toSql().toLowerCase(), comment)); > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 1 Gerrit-Owner: helifu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 10 Apr 2019 01:02:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: The latest kudu client is required, otherwise the compilation fails -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 1 Gerrit-Owner: helifu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: helifu Gerrit-Comment-Date: Wed, 10 Apr 2019 00:47:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12977 Change subject: IMPALA-5351: Support storing column comment of kudu table .. IMPALA-5351: Support storing column comment of kudu table This patch intends to support storing column comment of kudu table on impala side. Belows tests passed: 1) creata kudu table with column comment; 2) alter kudu table with (add/alter[delete] column comment); 3) show create kudu table; 4) describe kudu table; Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c --- M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java 3 files changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/12977/1 -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 1 Gerrit-Owner: helifu
