[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG@7
PS2, Line 7: cumstom
typo


http://gerrit.cloudera.org:8080/#/c/13500/2//COMMIT_MSG@9
PS2, Line 9: cumstom
typo



--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 21:20:26 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 20:56:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4392/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 20:57:17 +
Gerrit-HasComments: No

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 2:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/3487/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:39:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@250
PS1, Line 250: if [[ "$FE_TEST" == true && "${TARGET_FILESYSTEM}" != "s3" 
]]; then
> I think it would be better to check if FE_TEST is true. I think we want to
Done


http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@257
PS1, Line 257: fi
> pushd and popd are now mismatched.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 19:24:13 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Hao Hao (Code Review) 
Hello Thomas Marshall, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13500

to look at the new patch set (#2).

Change subject: Disable cumstom cluster/service FE tests on S3
..

Disable cumstom cluster/service FE tests on S3

This patch disables the cumstom cluster/service FE tests when running
against S3, as only S3 FE tests should be ran under such environment.

Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
---
M bin/run-all-tests.sh
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13500/2
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 1: Code-Review-1

(2 comments)

I think the mismatched pushd/popd will cause problems in the S3 case.

http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@250
PS1, Line 250: if [[ "${TARGET_FILESYSTEM}" != "s3" ]]; then
I think it would be better to check if FE_TEST is true. I think we want to skip 
it for other similar filesystems, e.g. ADLS.


http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@257
PS1, Line 257: popd
pushd and popd are now mismatched.



--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:54:53 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3483/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:53:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Thomas Marshall (Code Review) 
Thomas Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:16:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13500 )

Change subject: Disable cumstom cluster/service FE tests on S3
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4390/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:15:00 +
Gerrit-HasComments: No

[Impala-ASF-CR] Disable cumstom cluster/service FE tests on S3

2019-06-03 Thread Hao Hao (Code Review) 
Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13500


Change subject: Disable cumstom cluster/service FE tests on S3
..

Disable cumstom cluster/service FE tests on S3

This patch disables the cumstom cluster/service FE tests when running
against S3, as only S3 FE tests should be ran under such environment.

Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
---
M bin/run-all-tests.sh
1 file changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13500/1
--
To view, visit http://gerrit.cloudera.org:8080/13500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245
Gerrit-Change-Number: 13500
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao