[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 25 Jul 2020 04:28:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..

IMPALA-10007: Impala development environment does not support
Ubuntu 20.4

This work addresses the current limitation in Impala development
environment in that Ubuntu 20.4 is not supportd. The fix modifies
bootstrap_system.sh and bootstrap_toolchain.py to specifically
allow the bootstrapping of the development environment on a maching
running Ubuntu 20.4. Limited use shows that the environment is useful
and stable, similar to the one running on Ubuntu 18.4.

Testing on a box running Ubuntu 20.4:
1. Successfully bootstrapped the entire Impala development environment
2. Interacted with the enviroment through the following tools:
gdb
jdb
clang-format
impalad GUI
vim
3. Ran all tests

Limitations found with Ubuntu 20.4 environment.
1. gdb in Impala toolchain is not compatible with Impala C++ test
   code ${IMPALA_HOME}/be/build/latest/service\
   /unifiedbetests (invoked by ${IMPALA_HOME}/be/build/latest/\
   scheduling/admission-controller-test) and reports the following
   error, after attaching to the test process.

   BFD (GNU Binutils) 2.25.51 internal error, aborting at elf64-x86-64.c
   ine 5583 in elf_x86_64_get_plt_sym_val

Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Reviewed-on: http://gerrit.cloudera.org:8080/16238
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M bin/bootstrap_system.sh
M bin/bootstrap_toolchain.py
2 files changed, 16 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 5:

(3 comments)

just a few nits

http://gerrit.cloudera.org:8080/#/c/16238/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16238/5//COMMIT_MSG@8
PS5, Line 8: 20.4
nit: its 20.04 and 18.04


http://gerrit.cloudera.org:8080/#/c/16238/5//COMMIT_MSG@13
PS5, Line 13: maching
nit: typo


http://gerrit.cloudera.org:8080/#/c/16238/5/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/16238/5/bin/bootstrap_system.sh@241
PS5, Line 241: or
nit: should be "and" instead of "or", and should change "install" back to 
"installs".

I think sentence is basically saying that by default Ubuntu 18.04 and 20.04 
have OpenJDK 11 installed.



--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 25 Jul 2020 00:58:44 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16238/5/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/16238/5/bin/bootstrap_toolchain.py@95
PS5, Line 95:   OsMapping('ubuntu20.04', "ec2-package-ubuntu-18-04", 
"ubuntu1804")
The  second 2 strings should be modified to 20.04 ?



--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:30:38 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:17:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 4: Code-Review+2

LGTM. I also had hacked together an Ubuntu 20.04 environment after I upgraded 
my laptop and it's been working OK for me.

There might still be rough edges but we can always figure them out as more 
people upgrade.


--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:16:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6181/ 
DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:17:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6708/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 21:55:46 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6707/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 21:53:16 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6706/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Sahil Takiar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 24 Jul 2020 21:47:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..

IMPALA-10007: Impala development environment does not support
Ubuntu 20.4

This work addresses the current limitation in Impala development
environment in that Ubuntu 20.4 is not supportd. The fix modifies
bootstrap_system.sh and bootstrap_toolchain.py to specifically
allow the bootstrapping of the development environment on a maching
running Ubuntu 20.4. Limited use shows that the environment is useful
and stable, similar to the one running on Ubuntu 18.4.

Testing on a box running Ubuntu 20.4:
1. Successfully bootstrapped the entire Impala development environment
2. Interacted with the enviroment through the following tools:
gdb
jdb
clang-format
impalad GUI
vim
3. Ran all tests

Limitations found with Ubuntu 20.4 environment.
1. gdb in Impala toolchain is not compatible with Impala C++ test
   code ${IMPALA_HOME}/be/build/latest/service\
   /unifiedbetests (invoked by ${IMPALA_HOME}/be/build/latest/\
   scheduling/admission-controller-test) and reports the following
   error, after attaching to the test process.

   BFD (GNU Binutils) 2.25.51 internal error, aborting at elf64-x86-64.c
   ine 5583 in elf_x86_64_get_plt_sym_val

Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
---
M bin/bootstrap_system.sh
M bin/bootstrap_toolchain.py
2 files changed, 16 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/16238/4
--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/16238 )

Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..

IMPALA-10007: Impala development environment does not support
Ubuntu 20.4

This work addresses the current limitation in Impala development
environment in that Ubuntu 20.4 is not supportd. The fix modifies
bootstrap_system.sh and bootstrap_toolchain.py to specifically
allow the bootstrapping of the development environment on a maching
running Ubuntu 20.4. Limited use shows that the environment is useful
and stable, similar to the one running on Ubuntu 18.4.

Testing on a box running Ubuntu 20.4:
1. Bootstrapped the entire Impala development environment;
2. Interacted with the enviroment in following aspects
gdb
jdb
clang-format
impalad GUI
vim
3. Ran all tests

Limitations found with Ubuntu 20.4 environment.
1. gdb in Impala toolchain is not compatible with Impala C++ test
   code ${IMPALA_HOME}/be/build/latest/service\
   /unifiedbetests (invoked by ${IMPALA_HOME}/be/build/latest/\
   scheduling/admission-controller-test) and reports the following
   error, after attaching to the test process.

   BFD (GNU Binutils) 2.25.51 internal error, aborting at elf64-x86-64.c
   ine 5583 in elf_x86_64_get_plt_sym_val

Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
---
M bin/bootstrap_system.sh
M bin/bootstrap_toolchain.py
2 files changed, 16 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/16238/2
--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.4

2020-07-24 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16238


Change subject: IMPALA-10007: Impala development environment does not support 
Ubuntu 20.4
..

IMPALA-10007: Impala development environment does not support
Ubuntu 20.4

This work addresses the current limitation in Impala development
environment in that Ubuntu 20.4 is not supportd. The fix modifies
bootstrap_system.sh and bootstrap_toolchain.py to specifically
allow the bootstrapping of the development environment on a maching
running Ubuntu 20.4. Limited use shows that the environment is useful
and stable, similar to the one running on Ubuntu 18.4.

Testing on a box running Ubuntu 20.4:
1. Bootstrapped the entire Impala development environment;
2. Interacted with the enviroment in following aspects
gdb
jdb
clang-format
impalad GUI
vim
3. Ran all tests

Limitations found with Ubuntu 20.4 environment.
1. gdb in Impala toolchain is not compatible with the Impala test
   code built (such as ${IMPALA_HOME}/be/build/latest/service/unifiedbetests
   involved by 
${IMPALA_HOME}/be/build/latest/scheduling/admission-controller-test)
   and shows the following error, after attaching to the test process.

   BFD (GNU Binutils) 2.25.51 internal error, aborting at elf64-x86-64.c
   ine 5583 in elf_x86_64_get_plt_sym_val

Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
---
M bin/bootstrap_system.sh
M bin/bootstrap_toolchain.py
2 files changed, 16 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/16238/1
--
To view, visit http://gerrit.cloudera.org:8080/16238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen 
Gerrit-Reviewer: Tim Armstrong