[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 6 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 29 Oct 2020 17:45:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. This function receives a string that is a serialized Apache DataSketches HLL sketch and optional kappa that is a number of standard deviations from the mean: 1, 2 or 3 (default 2). Returns estimate and bounds with the values separated with commas. The result is three values: estimate, lower bound and upper bound. ds_hll_estimate_bounds_as_string(sketch [, kappa]) Kappa: 1 represent the 68.3% confidence bounds 2 represent the 95.4% confidence bounds 3 represent the 99.7% confidence bounds Note, ds_hll_estimate_bounds() should return an Array of doubles as the result but with that we have to wait for the complex type support. Until, we provide ds_hll_estimate_bounds_as_string() that can be deprecated once we have array support. Tracking Jira for returning complex types from functions is IMPALA-9520. Example: select ds_hll_estimate_bounds_as_string(ds_hll_sketch(int_col)) from functional_parquet.alltypestiny; +--+ | ds_hll_estimate_bounds_as_string(ds_hll_sketch(int_col)) | +--+ | 2,2,2.0002 | +--+ Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Reviewed-on: http://gerrit.cloudera.org:8080/16626 Reviewed-by: Gabor Kaszab Tested-by: Impala Public Jenkins --- M be/src/exprs/datasketches-common.h M be/src/exprs/datasketches-functions-ir.cc M be/src/exprs/datasketches-functions.h M common/function-registry/impala_functions.py M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test 5 files changed, 103 insertions(+), 0 deletions(-) Approvals: Gabor Kaszab: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 7 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6616/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 6 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 29 Oct 2020 12:24:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 6 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 29 Oct 2020 12:22:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG@10 PS4, Line 10: > nit: please remove the trailing spaces Done http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG@11 PS4, Line 11: returns > nit: start with capital letter Done -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 29 Oct 2020 08:58:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Hello Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16626 to look at the new patch set (#5). Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. This function receives a string that is a serialized Apache DataSketches HLL sketch and optional kappa that is a number of standard deviations from the mean: 1, 2 or 3 (default 2). Returns estimate and bounds with the values separated with commas. The result is three values: estimate, lower bound and upper bound. ds_hll_estimate_bounds_as_string(sketch [, kappa]) Kappa: 1 represent the 68.3% confidence bounds 2 represent the 95.4% confidence bounds 3 represent the 99.7% confidence bounds Note, ds_hll_estimate_bounds() should return an Array of doubles as the result but with that we have to wait for the complex type support. Until, we provide ds_hll_estimate_bounds_as_string() that can be deprecated once we have array support. Tracking Jira for returning complex types from functions is IMPALA-9520. Example: select ds_hll_estimate_bounds_as_string(ds_hll_sketch(int_col)) from functional_parquet.alltypestiny; +--+ | ds_hll_estimate_bounds_as_string(ds_hll_sketch(int_col)) | +--+ | 2,2,2.0002 | +--+ Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 --- M be/src/exprs/datasketches-common.h M be/src/exprs/datasketches-functions-ir.cc M be/src/exprs/datasketches-functions.h M common/function-registry/impala_functions.py M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test 5 files changed, 103 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/16626/5 -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 5 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 4: Code-Review+1 (2 comments) Thanks for the changes! I have some nits but apart from those I'm fine with the patch. Will give a +2 once you address these. http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG@10 PS4, Line 10: nit: please remove the trailing spaces http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG@11 PS4, Line 11: returns nit: start with capital letter -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 29 Oct 2020 07:03:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 2: (9 comments) Thanks for the review! Addressed the comments. http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. > Could you mention that there are 2 versions of this function. One that acce Done http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG@15 PS2, Line 15: butwith > typo Done http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG@16 PS2, Line 16: ds_kll_cdf_as_string > wrong function name, guess copy-pasted from the CDF change :) Done http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-common.h File be/src/exprs/datasketches-common.h: http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-common.h@43 PS2, Line 43: DS_DEFAULR_KAPPA > typo Done http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-functions.h File be/src/exprs/datasketches-functions.h: http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-functions.h@50 PS2, Line 50: disinct > typo Done http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-functions.h@55 PS2, Line 55: static StringVal DsHllEstimateBoundsAsString(FunctionContext* ctx, > I wouldn't write this whole comment for this function. I'd rather mention t Only the kappa param specification is retained http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test: http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@291 PS2, Line 291: select ds_hll_estimate_bounds_as_string(ds_kll_sketch(cast(f2 as float))) from functional_parquet.emptytable; > Could you wrap these lines into 90 chars. If the output of a query is too l Done http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@313 PS2, Line 313: 4 > Please add a test for fraction inputs as well. Done http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@315 PS2, Line 315: UDF ERROR: Kappa may not be less than 1 or greater than 3. > I'd change this error msg to explicitly say these 3 values that are allowed Done -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 28 Oct 2020 05:19:38 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7574/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 28 Oct 2020 04:31:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10132: Implement ds hll estimate bounds as string() function.
Hello Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16626 to look at the new patch set (#4). Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. .. IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() function. This function receives a string that is a serialized Apache DataSketches HLL sketch and optional kappa that is a number of standard deviations from the mean: 1, 2 or 3 (default 2). returns estimate and bounds with the values separated with commas. The result is three values: estimate, lower bound and upper bound. ds_hll_estimate_bounds_as_string(sketch [, kappa]) Kappa: 1 represent the 68.3% confidence bounds 2 represent the 95.4% confidence bounds 3 represent the 99.7% confidence bounds Note, ds_hll_estimate_bounds() should return an Array of doubles as the result but with that we have to wait for the complex type support. Until, we provide ds_hll_estimate_bounds_as_string() that can be deprecated once we have array support. Tracking Jira for returning complex types from functions is IMPALA-9520. Example: select ds_hll_estimate_bounds_as_string(ds_hll_sketch(int_col)) from functional_parquet.alltypestiny; +--+ | ds_hll_estimate_bounds_as_string(ds_hll_sketch(int_col)) | +--+ | 2,2,2.0002 | +--+ Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 --- M be/src/exprs/datasketches-common.h M be/src/exprs/datasketches-functions-ir.cc M be/src/exprs/datasketches-functions.h M common/function-registry/impala_functions.py M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test 5 files changed, 103 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/16626/4 -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10132 Implement ds hll estimate bounds as string() function.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 2: (9 comments) Thanks for taking care of this implementation! The patch is in quite a good shape I just had some minor comments. http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. Could you mention that there are 2 versions of this function. One that accepts a kappa parameter and one that doesn't. Also it would help to understand this feature to explain this kappa parameter here and it's purpose. http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG@15 PS2, Line 15: butwith typo http://gerrit.cloudera.org:8080/#/c/16626/2//COMMIT_MSG@16 PS2, Line 16: ds_kll_cdf_as_string wrong function name, guess copy-pasted from the CDF change :) http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-common.h File be/src/exprs/datasketches-common.h: http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-common.h@43 PS2, Line 43: DS_DEFAULR_KAPPA typo http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-functions.h File be/src/exprs/datasketches-functions.h: http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-functions.h@50 PS2, Line 50: disinct typo http://gerrit.cloudera.org:8080/#/c/16626/2/be/src/exprs/datasketches-functions.h@55 PS2, Line 55: static StringVal DsHllEstimateBoundsAsString(FunctionContext* ctx, I wouldn't write this whole comment for this function. I'd rather mention that this is similar to the function above with the exception of this kappa param (and would explain this param.) No strong feelings here though, it's up to you. http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test: http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@291 PS2, Line 291: select ds_hll_estimate_bounds_as_string(ds_kll_sketch(cast(f2 as float))) from functional_parquet.emptytable; Could you wrap these lines into 90 chars. If the output of a query is too long then there is no need to wrap but the comments and the queries shouldn't be longer than 90 chars for more readability. http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@313 PS2, Line 313: 4 Please add a test for fraction inputs as well. http://gerrit.cloudera.org:8080/#/c/16626/2/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@315 PS2, Line 315: UDF ERROR: Kappa may not be less than 1 or greater than 3. I'd change this error msg to explicitly say these 3 values that are allowed. With the current msg one might have the impression that e.g. 1.5 is also a valid input. -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 2 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 27 Oct 2020 11:43:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10132 Implement ds hll estimate bounds as string() function.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7516/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 22 Oct 2020 14:41:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10132 Implement ds hll estimate bounds as string() function.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16626 ) Change subject: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. .. Patch Set 1: https://jenkins.impala.io/job/pre-review-test/755/ -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 22 Oct 2020 14:28:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10132 Implement ds hll estimate bounds as string() function.
Fucun Chu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16626 Change subject: IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. .. IMPALA-10132 Implement ds_hll_estimate_bounds_as_string() function. This function receives a string that is a serialized Apache DataSketches HLL sketch and returns estimate and bounds with the values separated with commas. The result is three values: estimate, lower bound and upper bound. Note, ds_hll_estimate_bounds() should return an Array of doubles as the result butwith that we have to wait for the complex type support. Until, we provide ds_kll_cdf_as_string() that can be deprecated once we have array support. Tracking Jira for returning complex types from functions is IMPALA-9520. Example: select ds_hll_estimate_bounds_as_string(ds_hll_sketch(float_col)) from functional_parquet.alltypestiny; ++ | ds_hll_estimate_bounds_as_string(ds_hll_sketch(float_col)) | ++ | 2,2,2.0002 | ++ Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 --- M be/src/exprs/datasketches-common.h M be/src/exprs/datasketches-functions-ir.cc M be/src/exprs/datasketches-functions.h M common/function-registry/impala_functions.py M testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test 5 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/16626/1 -- To view, visit http://gerrit.cloudera.org:8080/16626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153 Gerrit-Change-Number: 16626 Gerrit-PatchSet: 1 Gerrit-Owner: Fucun Chu Gerrit-Reviewer: Impala Public Jenkins