[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 10 Feb 2021 06:05:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. IMPALA-10397 : Reduce flakiness in test_single_workload This test failed recently due to a timeout waiting for executors to come up. The logs showed that the executors came up on time but it was not recognized by the coordinator. This patch attempts to reduce flakiness by increasing the timeout and adding more logging in case this happens in the future. Testing: Ran in a loop on my local for a few hours. Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Reviewed-on: http://gerrit.cloudera.org:8080/17028 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_auto_scaling.py 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8110/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 10 Feb 2021 00:43:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 10 Feb 2021 00:24:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6879/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 10 Feb 2021 00:24:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 2: Code-Review+2 (2 comments) Carrying over +2 http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@54 PS1, Line 54: > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@60 PS1, Line 60: metric_val = self.impalad_test_service.get_metric_value(TOTAL_BACKENDS_METRIC_NAME) > Nit: tidier to use a variable for "cluster-membership.backends.total" rathe Done -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 10 Feb 2021 00:24:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17028 to look at the new patch set (#2). Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. IMPALA-10397 : Reduce flakiness in test_single_workload This test failed recently due to a timeout waiting for executors to come up. The logs showed that the executors came up on time but it was not recognized by the coordinator. This patch attempts to reduce flakiness by increasing the timeout and adding more logging in case this happens in the future. Testing: Ran in a loop on my local for a few hours. Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 --- M tests/custom_cluster/test_auto_scaling.py 1 file changed, 16 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17028/2 -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 1: Code-Review+2 (2 comments) LGTM, a few cosmetic nits http://gerrit.cloudera.org:8080/#/c/17028/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17028/1//COMMIT_MSG@12 PS1, Line 12: falkiness by increasing the timeout and adding more logging in case nit: flakiness http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@60 PS1, Line 60: "cluster-membership.backends.total") Nit: tidier to use a variable for "cluster-membership.backends.total" rather than repeating the name -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 06 Feb 2021 01:24:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8085/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 05 Feb 2021 22:00:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@54 PS1, Line 54: ) flake8: E501 line too long (91 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 05 Feb 2021 21:41:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17028 Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. IMPALA-10397 : Reduce flakiness in test_single_workload This test failed recently due to a timeout waiting for executors to come up. The logs showed that the executors came up on time but it was not recognized by the coordinator. This patch attempts to reduce falkiness by increasing the timeout and adding more logging in case this happens in the future. Testing: Ran in a loop on my local for a few hours. Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 --- M tests/custom_cluster/test_auto_scaling.py 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/17028/1 -- To view, visit http://gerrit.cloudera.org:8080/17028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514 Gerrit-Change-Number: 17028 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
