[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 23 Feb 2021 04:37:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. IMPALA-10510: Change code to help with third party extensions Made ArithmeticExpr.Operator public and made various changes to HdfsTable which will allow third party extensions greater visibility. Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Reviewed-on: http://gerrit.cloudera.org:8080/17079 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java 2 files changed, 21 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6912/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 22 Feb 2021 22:51:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 22 Feb 2021 22:51:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 3: Code-Review+2 These changes look okay to me. -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Steve Carlin Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 22 Feb 2021 22:51:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8176/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 20 Feb 2021 15:28:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
scar...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 3: ...and one small change regarding how nullPartitionKeyValue is fetched, but that shouldn't affect how the code runs either. -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 20 Feb 2021 15:09:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
scar...@cloudera.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. IMPALA-10510: Change code to help with third party extensions Made ArithmeticExpr.Operator public and made various changes to HdfsTable which will allow third party extensions greater visibility. Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 --- M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java 2 files changed, 21 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/17079/3 -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
scar...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1224 PS1, Line 1224: protected > I think it would be useful to update the documentation of this method to de Done. As for those other methods, you are correct. The method loadSchema was changed in a different Jira (sorry, we should have batched them up). The "loadValidWriteIdList" method was already declared as protected. The "loadAllColumnStats" method was in the base "Table" class so it was also declared as protected. -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 20 Feb 2021 14:18:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 1: (1 comment) Patch itself it fairly simple. I just have some nits/questions below. Otherwise, this looks okay to me. http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1224 PS1, Line 1224: protected I think it would be useful to update the documentation of this method to describe why this is protected or what could be a potential usecase. Also, does it make sense to have loadSchema, loadAllColumnStats, loadConstraintsInfo and loadValidWriteIdList as protected as well then? -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Sat, 20 Feb 2021 00:42:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8153/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 18 Feb 2021 04:41:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions
scar...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17079 Change subject: IMPALA-10510: Change code to help with third party extensions .. IMPALA-10510: Change code to help with third party extensions Made ArithmeticExpr.Operator public and HdfsTable.loadConstraintsInfo() protected allowing third party extensions the access that is needed. Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 --- M fe/src/main/java/org/apache/impala/analysis/ArithmeticExpr.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/17079/1 -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
