[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 24 Feb 2021 23:06:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build Fixed a data race issue when running testcase DiskIoMgrTest.WriteToRemotePartialFileSuccess in the tsan build. The cause is the TmpFileBufferPool is not released gracefully while destruction. Tests: Reran all testcases of DiskIoMgrTest with tsan and asan build. Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Reviewed-on: http://gerrit.cloudera.org:8080/17100 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr.cc 2 files changed, 19 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6918/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 24 Feb 2021 17:29:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 24 Feb 2021 17:29:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 24 Feb 2021 17:29:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8219/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Wed, 24 Feb 2021 01:49:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Yida Wu has posted comments on this change. (
http://gerrit.cloudera.org:8080/17100 )
Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess
failed in tsan build
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc
File be/src/runtime/tmp-file-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc@170
PS5, Line 170: TmpFileMgr::~TmpFileMgr() {
> nit: no need to delete the blank line before this
Done
http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc@1954
PS5, Line 1954:
tmp_file_mgr_->GetSpillBufferWaitTimeout()/MICROS_PER_SEC));
> The formatting here was correct before
Done
--
To view, visit http://gerrit.cloudera.org:8080/17100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f
Gerrit-Change-Number: 17100
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Yida Wu
Gerrit-Comment-Date: Wed, 24 Feb 2021 01:26:19 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Yida Wu has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build Fixed a data race issue when running testcase DiskIoMgrTest.WriteToRemotePartialFileSuccess in the tsan build. The cause is the TmpFileBufferPool is not released gracefully while destruction. Tests: Reran all testcases of DiskIoMgrTest with tsan and asan build. Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr.cc 2 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17100/6 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Thomas Tauber-Marshall has posted comments on this change. (
http://gerrit.cloudera.org:8080/17100 )
Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess
failed in tsan build
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc
File be/src/runtime/tmp-file-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc@170
PS5, Line 170: TmpFileMgr::~TmpFileMgr() {
nit: no need to delete the blank line before this
http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc@1954
PS5, Line 1954:
tmp_file_mgr_->GetSpillBufferWaitTimeout()/MICROS_PER_SEC));
The formatting here was correct before
--
To view, visit http://gerrit.cloudera.org:8080/17100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f
Gerrit-Change-Number: 17100
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Yida Wu
Gerrit-Comment-Date: Wed, 24 Feb 2021 01:21:03 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8211/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 23 Feb 2021 23:51:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Yida Wu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build Fixed a data race issue when running testcase DiskIoMgrTest.WriteToRemotePartialFileSuccess in the tsan build. The cause is the TmpFileBufferPool is not released gracefully while destruction. Tests: Reran all testcases of DiskIoMgrTest with tsan and asan build. Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr.cc 2 files changed, 20 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17100/4 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Tue, 23 Feb 2021 01:24:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 22 Feb 2021 20:38:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6908/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 22 Feb 2021 19:42:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8196/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 22 Feb 2021 19:30:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc@171 PS1, Line 171: if > formatting (needs a space after 'if') Done http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc@1954 PS1, Line 1954: > The formatting here was correct before. Done -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Mon, 22 Feb 2021 19:12:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build Fixed a data race issue when running testcase DiskIoMgrTest.WriteToRemotePartialFileSuccess in the tsan build. The cause is the TmpFileBufferPool is not released gracefully while destruction. Tests: Reran all testcases of DiskIoMgrTest with tsan and asan build. Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr.cc 2 files changed, 19 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17100/2 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc@171 PS1, Line 171: if( formatting (needs a space after 'if') http://gerrit.cloudera.org:8080/#/c/17100/1/be/src/runtime/tmp-file-mgr.cc@1954 PS1, Line 1954: / The formatting here was correct before. If you're not already aware, there's a tool called clang-format-diff that you can use to do the formatting automatically, see: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 22 Feb 2021 18:19:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8193/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 22 Feb 2021 14:51:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17100 Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build Fixed a data race issue when running testcase DiskIoMgrTest.WriteToRemotePartialFileSuccess in the tsan build. The cause is the TmpFileBufferPool is not released gracefully while destruction. Tests: Reran all testcases of DiskIoMgrTest with tsan and asan build. Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f --- M be/src/runtime/tmp-file-mgr-internal.h M be/src/runtime/tmp-file-mgr.cc 2 files changed, 20 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17100/1 -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu
