[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. IMPALA-10591: Handle failed ReleaseQueryBackends rpcs When the admission control service is in use, coordinators will retry failed ReleaseQueryBackends rpcs 3 times before giving up. This can potentially result in resources not being released when they are no longer in use. This patch fixes the issue by automatically releasing all remaining backends when ReleaseQuery is called in the context of the admission control service (either as the result of a ReleaseQUery rpc or when cleaning up a query's resources with the heartbeat mechanism). Testing: - Added a custom cluster test that simulates failed ReleaseQueryBackends rpcs and ensures that query resources are eventually released. Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Reviewed-on: http://gerrit.cloudera.org:8080/17208 Tested-by: Impala Public Jenkins Reviewed-by: Thomas Tauber-Marshall --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M tests/custom_cluster/test_admission_controller.py 4 files changed, 115 insertions(+), 48 deletions(-) Approvals: Impala Public Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Thu, 01 Apr 2021 16:27:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Thu, 01 Apr 2021 02:07:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8483/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:39:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7033/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:26:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 4: gvo aborted because I forgot to commit the fix for Bikram's comment -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:25:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Hello Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17208 to look at the new patch set (#4). Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. IMPALA-10591: Handle failed ReleaseQueryBackends rpcs When the admission control service is in use, coordinators will retry failed ReleaseQueryBackends rpcs 3 times before giving up. This can potentially result in resources not being released when they are no longer in use. This patch fixes the issue by automatically releasing all remaining backends when ReleaseQuery is called in the context of the admission control service (either as the result of a ReleaseQUery rpc or when cleaning up a query's resources with the heartbeat mechanism). Testing: - Added a custom cluster test that simulates failed ReleaseQueryBackends rpcs and ensures that query resources are eventually released. Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M tests/custom_cluster/test_admission_controller.py 4 files changed, 115 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/17208/4 -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7032/ -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:25:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7032/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:14:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 3: Code-Review+2 (1 comment) carrying forward http://gerrit.cloudera.org:8080/#/c/17208/2/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/17208/2/be/src/scheduling/admission-controller.h@855 PS2, Line 855: per_backend_resources > nit: update comment to mention that only the backends currently executing e Done -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 31 Mar 2021 20:14:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17208/2/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/17208/2/be/src/scheduling/admission-controller.h@855 PS2, Line 855: per_backend_resources nit: update comment to mention that only the backends currently executing exist and released ones get removed. -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 19 Mar 2021 23:36:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8408/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 19 Mar 2021 19:20:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17208 to look at the new patch set (#2). Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. IMPALA-10591: Handle failed ReleaseQueryBackends rpcs When the admission control service is in use, coordinators will retry failed ReleaseQueryBackends rpcs 3 times before giving up. This can potentially result in resources not being released when they are no longer in use. This patch fixes the issue by automatically releasing all remaining backends when ReleaseQuery is called in the context of the admission control service (either as the result of a ReleaseQUery rpc or when cleaning up a query's resources with the heartbeat mechanism). Testing: - Added a custom cluster test that simulates failed ReleaseQueryBackends rpcs and ensures that query resources are eventually released. Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M tests/custom_cluster/test_admission_controller.py 4 files changed, 113 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/17208/2 -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17208 ) Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8406/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 19 Mar 2021 18:46:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17208 Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs .. IMPALA-10591: Handle failed ReleaseQueryBackends rpcs When the admission control service is in use, coordinators will retry failed ReleaseQueryBackends rpcs 3 times before giving up. This can potentially result in resources not being released when they are no longer in use. This patch fixes the issue by automatically releasing all remaining backends when ReleaseQuery is called in the context of the admission control service (either as the result of a ReleaseQUery rpc or when cleaning up a query's resources with the heartbeat mechanism). Testing: - Added a custom cluster test that simulates failed ReleaseQueryBackends rpcs and ensures that query resources are eventually released. Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M tests/custom_cluster/test_admission_controller.py 4 files changed, 104 insertions(+), 45 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/17208/1 -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall
