[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 8: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 8
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:25:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..

IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

For /etc/sysconfig/clock, when a row has a '#', we can skip that row,
and optimize the content of parsing lines.
This will fix the parsing problem caused by the '# Zone="utc"'.

Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Reviewed-on: http://gerrit.cloudera.org:8080/18958
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/exprs/timezone_db.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 9
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 7: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:17:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8997/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 8
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:18:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 8: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 8
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:18:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 7:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/12261/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Mon, 30 Jan 2023 10:15:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Baike Xia (Code Review) 
Baike Xia has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 7:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@184
PS4, Line 184: \"");
> You could extract this string to a constant (or constexpr) so we wouldn't h
Done


http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@187
PS4, Line 187: erase(
> Something like 'header_len' would be clearer.
Done


http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@188
PS4, Line 188:
> Why do you prefer substr() instead of erase()? Because of the assignment we
This change was controversial and didn't make much sense, so I went back to the 
way it was before.


http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@188
PS4, Line 188:
> We could extract this to a variable, for example 'result_len'.
Done



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Mon, 30 Jan 2023 09:55:52 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-30 Thread Baike Xia (Code Review) 
Baike Xia has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..

IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

For /etc/sysconfig/clock, when a row has a '#', we can skip that row,
and optimize the content of parsing lines.
This will fix the parsing problem caused by the '# Zone="utc"'.

Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
---
M be/src/exprs/timezone_db.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18958/7
--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 7
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2023-01-17 Thread Daniel Becker (Code Review) 
Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@184
PS4, Line 184: "ZONE=\""
You could extract this string to a constant (or constexpr) so we wouldn't have 
to repeat it on L187.


http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@187
PS4, Line 187: header
Something like 'header_len' would be clearer.


http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@188
PS4, Line 188: p_end - p_start - header
We could extract this to a variable, for example 'result_len'.


http://gerrit.cloudera.org:8080/#/c/18958/4/be/src/exprs/timezone_db.cc@188
PS4, Line 188: substr
Why do you prefer substr() instead of erase()? Because of the assignment we end 
up modifying 'result' in this case too.



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Daniel Becker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Tue, 17 Jan 2023 14:26:46 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-09 Thread Baike Xia (Code Review) 
Baike Xia has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc@183
PS1, Line 183:   if (result.rfind("#", 0) == 0) continue;
> Hi all, what if line start with '\t#'? or even line is 'ZONE=UTC # some com
I thnik this should be defined as the wrong way of writing, and this should be 
a small probability event.



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Sun, 09 Oct 2022 09:33:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-09 Thread Xiang Yang (Code Review) 
Xiang Yang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc@183
PS1, Line 183:   if (result.rfind("#", 0) == 0) continue;
> Yes, `result` is started with "#" , it's better that way.
Hi all, what if line start with '\t#'? or even line is 'ZONE=UTC # some 
comments' ?



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Reviewer: Xiang Yang 
Gerrit-Comment-Date: Sun, 09 Oct 2022 09:19:12 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-08 Thread Baike Xia (Code Review) 
Hello Jian Zhang, Csaba Ringhofer, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/18958

to look at the new patch set (#4).

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..

IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

For /etc/sysconfig/clock, when a row has a '#', we can skip that row,
and optimize the content of parsing lines.
This will fix the parsing problem caused by the '# Zone="utc"'.

Note:
The erase() function modifies the original string instead of creating
a new string.
The substr() function returns a new string with
the specified characters instead of modifying the original string.

Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
---
M be/src/exprs/timezone_db.cc
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18958/4
--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 4
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-08 Thread Baike Xia (Code Review) 
Baike Xia has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG@7
PS2, Line 7: Optimized
> Won't the behavior change if we bump to a commented out zone line? e.g.
Oh, Yes, this will fix the situation, this resolves to the content after '#' 
before fixing. Thanks.



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Sun, 09 Oct 2022 02:58:01 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-08 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG@7
PS2, Line 7: Optimized
> This change only is  an optimization.(I updated the commit message)
Won't the behavior change if we bump to a commented out zone line? e.g.

# ZONE="utc"



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Sat, 08 Oct 2022 15:58:28 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11570/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Sat, 08 Oct 2022 12:17:00 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-10-08 Thread Baike Xia (Code Review) 
Baike Xia has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..

IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

For /etc/sysconfig/clock, when a row has a '#', we can skip that row,
and optimize the content of parsing lines.

Note:
The erase() function modifies the original string instead of creating
a new string.
The substr() function returns a new string with
the specified characters instead of modifying the original string.

Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
---
M be/src/exprs/timezone_db.cc
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18958/3
--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 3
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-26 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG@7
PS2, Line 7: Optimized
This change is both an optimization (skipping # lines quickly) and potential 
fix,right? Can you add an example where this change leads to a different result?


http://gerrit.cloudera.org:8080/#/c/18958/2/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

http://gerrit.cloudera.org:8080/#/c/18958/2/be/src/exprs/timezone_db.cc@183
PS2, Line 183: result.rfind("#", 0) == 0
Can you explain what does this mean?
Based on https://cplusplus.com/reference/string/string/rfind/ the second 
argument of rfind means the last charecter to check, so 0 means that only the 
first character is checked. I think that result.size()>0 && result[0] == '#' 
would be easier to understand (thought it is longer)



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 2
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Mon, 26 Sep 2022 14:07:10 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-13 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 2
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Tue, 13 Sep 2022 13:50:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-13 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8565/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 2
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Tue, 13 Sep 2022 09:02:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11325/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 2
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Fri, 09 Sep 2022 10:14:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-09 Thread Jian Zhang (Code Review) 
Jian Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 2: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 2
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Fri, 09 Sep 2022 10:05:14 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-09 Thread Baike Xia (Code Review) 
Baike Xia has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..

IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

For /etc/sysconfig/clock, human error may sometimes lead
to abnormal situations such as spaces in the file.

Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
---
M be/src/exprs/timezone_db.cc
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18958/2
--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 2
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-09 Thread Jian Zhang (Code Review) 
Jian Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc
File be/src/exprs/timezone_db.cc:

http://gerrit.cloudera.org:8080/#/c/18958/1/be/src/exprs/timezone_db.cc@183
PS1, Line 183:   if (result.find("#") != string::npos) continue;
should we check whether `result` is started with "#" instead of whether 
`result` contains "#"?



--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 1
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Jian Zhang 
Gerrit-Comment-Date: Fri, 09 Sep 2022 08:30:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 1
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 09 Sep 2022 08:13:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11323/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 1
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 09 Sep 2022 03:51:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-08 Thread Baike Xia (Code Review) 
Baike Xia has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/18958


Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..

IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

For /etc/sysconfig/clock, human error may sometimes lead
to abnormal situations such as spaces in the file.

Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
---
M be/src/exprs/timezone_db.cc
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18958/1
--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 1
Gerrit-Owner: Baike Xia

[Impala-ASF-CR] IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone

2022-09-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18958 )

Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time 
zone
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8555/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/18958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458
Gerrit-Change-Number: 18958
Gerrit-PatchSet: 1
Gerrit-Owner: Baike Xia 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 09 Sep 2022 03:30:05 +
Gerrit-HasComments: No