[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-10-09 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 4:

> Patch Set 4:
>
> > > Patch Set 3:
>  > >
>  > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/
>  > >
>  > > Is the build server disk space insufficient?
>  >
>  > There are test failures that need to be addressed:
>  > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17721
>  > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6414
>  > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17722
>
> I have adjusted the unit test cases.
> But my local environment cannot compile (due to Amazon s3 warehouse problem), 
> According to this 
> document:https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests.

There are other end-to-end test (not just unit test) failures that need to fix, 
e.g. 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17721/testReport/junit/query_test.test_queries/TestQueries/test_subquery_protocol__hs2___exec_optiontest_replan___1___batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0table_format__parquet_none_/

If you can't compile Impala locally, you can't reproduce the failure. It'd be 
nice if you can verify your fix locally first before sending it for review.

Are you still hitting s3 download issues? You might need a VPN to achieve 
better download speed if you are in China. You can also try some steps 
mentioned in IMPALA-9078.


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sun, 09 Oct 2022 23:17:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-10-08 Thread Anonymous Coward (Code Review) 
jhkc...@qq.com has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 4:

> > Patch Set 3:
 > >
 > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/
 > >
 > > Is the build server disk space insufficient?
 >
 > There are test failures that need to be addressed:
 > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17721
 > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6414
 > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17722

I have adjusted the unit test cases.
But my local environment cannot compile (due to Amazon s3 warehouse problem), 
According to this 
document:https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests.


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sun, 09 Oct 2022 02:15:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-10-08 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 4:

> Patch Set 3:
>
> > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/
>
> Is the build server disk space insufficient?

There are test failures that need to be addressed:
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17721
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6414
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17722


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sat, 08 Oct 2022 11:32:04 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-10-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11563/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Sat, 08 Oct 2022 06:22:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-10-07 Thread Anonymous Coward (Code Review) 
Hello Quanlong Huang, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19049

to look at the new patch set (#4).

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..

IMPALA-11612: fix ORDER BY expression rewrite bug

When the query SQL is overwritten, both the selectList and groupByList
fields are preprocessed except for the orderByList fields, the result
of rewoten orderByList is not same as selectList and groupByList.
It occur exception in method SelectStmt.verifyAggregation.
So we should add preprocessing before the orderByList be rewrote.

Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
---
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
2 files changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/19049/4
--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-30 Thread Anonymous Coward (Code Review) 
jhkc...@qq.com has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 3:

> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/

Is the build server disk space insufficient?


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 30 Sep 2022 07:47:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 30 Sep 2022 07:23:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-29 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8642/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Fri, 30 Sep 2022 02:10:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-28 Thread Anonymous Coward (Code Review) 
Hello Quanlong Huang, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/19049

to look at the new patch set (#3).

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..

IMPALA-11612: fix ORDER BY expression rewrite bug

When the query SQL is overwritten, both the selectList and groupByList
fields are preprocessed except for the orderByList fields, the result
of rewoten orderByList is not same as selectList and groupByList.
It occur exception in method SelectStmt.verifyAggregation.
So we should add preprocessing before the orderByList be rewrote.

Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
---
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
2 files changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/19049/3
--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-28 Thread Quanlong Huang (Code Review) 
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 2:

(1 comment)

Thanks for your contribution! Let's start with adding the commit message.

http://gerrit.cloudera.org:8080/#/c/19049/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19049/2//COMMIT_MSG@8
PS2, Line 8:
Please write a good, clear commit message, with a short, descriptive title and 
a message that is exactly long enough to explain what the problem was, and how 
it was fixed. Each should have 72 or fewer characters if possible.

https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala



--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Comment-Date: Thu, 29 Sep 2022 05:47:41 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-28 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11465/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 28 Sep 2022 07:20:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-27 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/11461/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 28 Sep 2022 03:34:35 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-27 Thread Anonymous Coward (Code Review) 
jhkc...@qq.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/19049


Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..

IMPALA-11612: fix ORDER BY expression rewrite bug

Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
---
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
2 files changed, 20 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/19049/1
--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward

[Impala-ASF-CR] IMPALA-11612: fix ORDER BY expression rewrite bug

2022-09-27 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19049 )

Change subject: IMPALA-11612: fix ORDER BY expression rewrite bug
..


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java:

http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@388
PS1, Line 388: "select (case when (1 = 1 and `t1`.`dt` = '2022-05-13') 
then '2022-05-13' end) d0 "
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@390
PS1, Line 390: + "group by (case when (1 = 1 and `t1`.`dt` = 
'2022-05-13') then '2022-05-13' end) "
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@391
PS1, Line 391: + "order by (case when (1 = 1 and `t1`.`dt` = 
'2022-05-13') then '2022-05-13' end) "
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@393
PS1, Line 393: "SELECT (CASE WHEN (1 = 1 AND `t1`.`dt` = '2022-05-13') 
THEN '2022-05-13' END) d0 "
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@395
PS1, Line 395: + "GROUP BY (CASE WHEN (1 = 1 AND `t1`.`dt` = 
'2022-05-13') THEN '2022-05-13' END) "
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/19049/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@396
PS1, Line 396: + "ORDER BY (CASE WHEN (1 = 1 AND `t1`.`dt` = 
'2022-05-13') THEN '2022-05-13' END) "
line too long (96 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/19049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438c61c647e3f99665c94ea15e3a9d98b9ff9912
Gerrit-Change-Number: 19049
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 28 Sep 2022 03:14:31 +
Gerrit-HasComments: Yes