[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Michael Smith has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20387 )
Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance
related checks
..
IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
This enables several Clang Tidy performance checks and fixes
the flagged code locations. The specific checks enabled are:
1. performance-faster-string-find
"warning: 'find' called with a string literal consisting of a
single character; consider using the more effective overload
accepting a character"
Fix: Use char literals rather than string literals
2. performance-for-range-copy
"warning: loop variable is copied but only used as const reference;
consider making it a const reference"
Fix: Use const & for some locations of auto
3. performance-implicit-cast-in-loop
"warning: the type of the loop variable '$VAR' is different from
the one returned by the iterator and generates an implicit cast;
you can either change the type to the correct one ('$TYPE' but
'const auto&' is always an option) or remove the reference to make
it explicit that you are creating a new value"
Fix: Use the right type or const auto&
4. performance-inefficient-vector-operation
"warning: 'push_back' is called inside a loop; consider pre-allocating
the vector capacity before the loop"
Fix: Call reserve() on the vector before the loop
5. performance-type-promotion-in-math-fn - not encountered in our code
This disables a few performance checks temporarily to keep the
change a reasonable size.
Testing:
- Ran bin/run_clang_tidy.sh with the new checks
- Ran GVO
Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
Reviewed-on: http://gerrit.cloudera.org:8080/20387
Tested-by: Impala Public Jenkins
Reviewed-by: Michael Smith
---
M .clang-tidy
M be/src/benchmarks/convert-timestamp-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-util.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/logging.cc
M be/src/exec/hdfs-columnar-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner-test.cc
M be/src/exec/parquet/parquet-bool-decoder-test.cc
M be/src/exec/parquet/parquet-page-index-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/exprs/anyval-util.cc
M be/src/exprs/timezone_db.cc
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/bufferpool/free-list-test.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/io/data-cache-test.cc
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/io/error-converter.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/types.cc
M be/src/runtime/types.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/service/client-request-state.cc
M be/src/service/fe-support.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/udf/uda-test.cc
M be/src/udf_samples/uda-sample-test.cc
M be/src/util/dict-test.cc
M be/src/util/ldap-simple-bind.cc
M be/src/util/mem-info.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/simple-logger-test.cc
M be/src/util/string-util.cc
M be/src/util/webserver-test.cc
44 files changed, 74 insertions(+), 39 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
Gerrit-Change-Number: 20387
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Michael Smith has posted comments on this change. (
http://gerrit.cloudera.org:8080/20387 )
Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance
related checks
..
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15
PS2, Line 15: Fix: Use char literals rather than string literals
> Oops, done
Done
http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@23
PS2, Line 23:you can either change the type to the correct one ('$TYPE' but
> Good point, I was missing the rest. Fixed
Done
--
To view, visit http://gerrit.cloudera.org:8080/20387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
Gerrit-Change-Number: 20387
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Smith
Gerrit-Comment-Date: Fri, 08 Sep 2023 21:52:44 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 08:35:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9686/ -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 07:29:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/13949/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:39:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20387
to look at the new patch set (#4).
Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance
related checks
..
IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
This enables several Clang Tidy performance checks and fixes
the flagged code locations. The specific checks enabled are:
1. performance-faster-string-find
"warning: 'find' called with a string literal consisting of a
single character; consider using the more effective overload
accepting a character"
Fix: Use char literals rather than string literals
2. performance-for-range-copy
"warning: loop variable is copied but only used as const reference;
consider making it a const reference"
Fix: Use const & for some locations of auto
3. performance-implicit-cast-in-loop
"warning: the type of the loop variable '$VAR' is different from
the one returned by the iterator and generates an implicit cast;
you can either change the type to the correct one ('$TYPE' but
'const auto&' is always an option) or remove the reference to make
it explicit that you are creating a new value"
Fix: Use the right type or const auto&
4. performance-inefficient-vector-operation
"warning: 'push_back' is called inside a loop; consider pre-allocating
the vector capacity before the loop"
Fix: Call reserve() on the vector before the loop
5. performance-type-promotion-in-math-fn - not encountered in our code
This disables a few performance checks temporarily to keep the
change a reasonable size.
Testing:
- Ran bin/run_clang_tidy.sh with the new checks
- Ran GVO
Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
---
M .clang-tidy
M be/src/benchmarks/convert-timestamp-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-util.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/logging.cc
M be/src/exec/hdfs-columnar-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner-test.cc
M be/src/exec/parquet/parquet-bool-decoder-test.cc
M be/src/exec/parquet/parquet-page-index-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/exprs/anyval-util.cc
M be/src/exprs/timezone_db.cc
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/bufferpool/free-list-test.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/io/data-cache-test.cc
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/io/error-converter.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/types.cc
M be/src/runtime/types.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/service/client-request-state.cc
M be/src/service/fe-support.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/udf/uda-test.cc
M be/src/udf_samples/uda-sample-test.cc
M be/src/util/dict-test.cc
M be/src/util/ldap-simple-bind.cc
M be/src/util/mem-info.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/simple-logger-test.cc
M be/src/util/string-util.cc
M be/src/util/webserver-test.cc
44 files changed, 74 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/20387/4
--
To view, visit http://gerrit.cloudera.org:8080/20387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
Gerrit-Change-Number: 20387
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9688/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 04:16:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Fixed new clang-tidy performance-for-range-copy location introduced from rebasing -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 03:59:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/13946/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 03:33:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9686/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 03:06:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15 PS2, Line 15: Fix: Use char rather literals than string literals > "Use character literals rather than string literals" Oops, done http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@23 PS2, Line 23:you can either change the type to the correct one" > nit: incomplete sentence fragment, did you leave off the rest of the warnin Good point, I was missing the rest. Fixed -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Fri, 08 Sep 2023 03:05:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20387
to look at the new patch set (#3).
Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance
related checks
..
IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
This enables several Clang Tidy performance checks and fixes
the flagged code locations. The specific checks enabled are:
1. performance-faster-string-find
"warning: 'find' called with a string literal consisting of a
single character; consider using the more effective overload
accepting a character"
Fix: Use char literals rather than string literals
2. performance-for-range-copy
"warning: loop variable is copied but only used as const reference;
consider making it a const reference"
Fix: Use const & for some locations of auto
3. performance-implicit-cast-in-loop
"warning: the type of the loop variable '$VAR' is different from
the one returned by the iterator and generates an implicit cast;
you can either change the type to the correct one ('$TYPE' but
'const auto&' is always an option) or remove the reference to make
it explicit that you are creating a new value"
Fix: Use the right type or const auto&
4. performance-inefficient-vector-operation
"warning: 'push_back' is called inside a loop; consider pre-allocating
the vector capacity before the loop"
Fix: Call reserve() on the vector before the loop
5. performance-type-promotion-in-math-fn - not encountered in our code
This disables a few performance checks temporarily to keep the
change a reasonable size.
Testing:
- Ran bin/run_clang_tidy.sh with the new checks
- Ran GVO
Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
---
M .clang-tidy
M be/src/benchmarks/convert-timestamp-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-util.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/logging.cc
M be/src/exec/hdfs-columnar-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner-test.cc
M be/src/exec/parquet/parquet-bool-decoder-test.cc
M be/src/exec/parquet/parquet-page-index-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/exprs/anyval-util.cc
M be/src/exprs/timezone_db.cc
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/bufferpool/free-list-test.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/io/data-cache-test.cc
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/io/error-converter.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/types.cc
M be/src/runtime/types.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/service/client-request-state.cc
M be/src/service/fe-support.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/udf/uda-test.cc
M be/src/udf_samples/uda-sample-test.cc
M be/src/util/dict-test.cc
M be/src/util/ldap-simple-bind.cc
M be/src/util/mem-info.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/simple-logger-test.cc
M be/src/util/string-util.cc
M be/src/util/webserver-test.cc
43 files changed, 71 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/20387/3
--
To view, visit http://gerrit.cloudera.org:8080/20387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
Gerrit-Change-Number: 20387
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15 PS2, Line 15: Fix: Use char rather literals than string literals > "char rather" -> "character"? "Use character literals rather than string literals" http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@23 PS2, Line 23:you can either change the type to the correct one" nit: incomplete sentence fragment, did you leave off the rest of the warning? -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 16:23:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20387/2//COMMIT_MSG@15 PS2, Line 15: Fix: Use char rather literals than string literals "char rather" -> "character"? -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Wed, 06 Sep 2023 16:12:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 30 Aug 2023 09:19:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9651/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 30 Aug 2023 04:59:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9637/ -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 26 Aug 2023 04:16:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9637/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/20387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 26 Aug 2023 00:02:18 + Gerrit-HasComments: No
