[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/14941/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 12 Jan 2024 04:13:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/14943/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Fri, 12 Jan 2024 07:16:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Tamas Mate (Code Review) 
Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 3:

(1 comment)

Hi Zihao Ye, thank you for catching and fixing this issue.
The change looks good to me and can +2 after a small commit message change.

http://gerrit.cloudera.org:8080/#/c/20890/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20890/3//COMMIT_MSG@12
PS3, Line 12:
On the Impala project we usually add a short: "Tests" or "Testing" section to 
the commit message to highlight how the testing was done. In this case a simple:

```
Testing:
 - Added E2E test to cover this case
```

would suffice in my opinion.



--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Comment-Date: Mon, 15 Jan 2024 10:20:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Zihao Ye (Code Review) 
Hello Tamas Mate, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/20890

to look at the new patch set (#4).

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..

IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

Currently, When querying some metadata tables of an empty iceberg table,
a null pointer exception occurs. This patch fixes the issue and adds
corresponding test cases in test_metadata_tables.

Testing:
 - Added E2E test to cover this case

Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
---
M fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java
M 
testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
2 files changed, 25 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/20890/4
--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 4
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Zihao Ye (Code Review) 
Zihao Ye has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 3:

(1 comment)

Hi Tamas, thank you for your review!

http://gerrit.cloudera.org:8080/#/c/20890/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20890/3//COMMIT_MSG@12
PS3, Line 12:
> On the Impala project we usually add a short: "Tests" or "Testing" section
Done



--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Mon, 15 Jan 2024 11:31:36 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 5
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Mon, 15 Jan 2024 13:06:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10152/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 5
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Mon, 15 Jan 2024 13:06:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Tamas Mate (Code Review) 
Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 4: Code-Review+2

Thanks Zihao Ye! LGTM!


--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 4
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Mon, 15 Jan 2024 13:06:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12704: Fix NPE when quering empty iceberg table's metadata

2024-01-15 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20890 )

Change subject: IMPALA-12704: Fix NPE when quering empty iceberg table's 
metadata
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/20890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b4d4fb81a45214045b8809a4bdd910a1f1f3843
Gerrit-Change-Number: 20890
Gerrit-PatchSet: 5
Gerrit-Owner: Zihao Ye 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tamas Mate 
Gerrit-Reviewer: Zihao Ye 
Gerrit-Comment-Date: Mon, 15 Jan 2024 17:46:49 +
Gerrit-HasComments: No