[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 22 May 2024 05:32:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10658/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 22 May 2024 00:21:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 2: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10656/ -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Wed, 22 May 2024 00:12:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10656/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 21 May 2024 19:05:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10652/ -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Tue, 21 May 2024 03:27:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16193/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 20 May 2024 22:29:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10652/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 20 May 2024 22:18:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21444 ) Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16192/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0 Gerrit-Change-Number: 21444 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Riza Suminto Gerrit-Comment-Date: Mon, 20 May 2024 22:06:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for release builds
Riza Suminto has posted comments on this change. (
http://gerrit.cloudera.org:8080/21444 )
Change subject: IMPALA-12800: Skip O(n^2) ExprSubstitutionMap::verify() for
release builds
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21444/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java
File fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java:
http://gerrit.cloudera.org:8080/#/c/21444/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java@178
PS1, Line 178: private void verify() {
What if we move the check inside the verify() method?
if (!BackendConfig.INSTANCE.isReleaseBuild()) return;
--
To view, visit http://gerrit.cloudera.org:8080/21444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeacfec6a5b487076ce5b19747319630616411f0
Gerrit-Change-Number: 21444
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Riza Suminto
Gerrit-Comment-Date: Mon, 20 May 2024 21:53:03 +
Gerrit-HasComments: Yes
