[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..

IMPALA-2746: part 1: enable LSAN for many backend tests

This turns on leak sanitizer for backend tests that required
relatively small modifications to pass. We suppress a few
leaks, mainly related to the embedded JVM.

Testing:
Ran core tests under ASAN.

Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Reviewed-on: http://gerrit.cloudera.org:8080/10668
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/CMakeLists.txt
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/mem-tracker.cc
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/udf/udf.cc
M be/src/util/CMakeLists.txt
M be/src/util/decompress-test.cc
A bin/lsan-suppressions.txt
28 files changed, 297 insertions(+), 242 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 10: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 19 Jun 2018 00:23:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 9:

Ran ASAN tests one more time to make sure that everything still worked.


--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 18 Jun 2018 21:02:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 10: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 18 Jun 2018 21:02:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2695/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 18 Jun 2018 21:02:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Joe McDonnell (Code Review) 
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 9: Code-Review+2

(1 comment)

This all looks good. It's great to get this enabled.

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt
File be/src/runtime/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt@83
PS8, Line 83: ADD_BE_TEST(data-stream-test) # TODO: this test leaks
> I fixed a couple of easy ones; the hard ones are around the lifecycles of t
Ok, cool



--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 15 Jun 2018 23:20:29 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Tim Armstrong (Code Review) 
Hello Philip Zeyliger, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10668

to look at the new patch set (#9).

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..

IMPALA-2746: part 1: enable LSAN for many backend tests

This turns on leak sanitizer for backend tests that required
relatively small modifications to pass. We suppress a few
leaks, mainly related to the embedded JVM.

Testing:
Ran core tests under ASAN.

Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
---
M be/CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/CMakeLists.txt
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/mem-tracker.cc
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/udf/udf.cc
M be/src/util/CMakeLists.txt
M be/src/util/decompress-test.cc
A bin/lsan-suppressions.txt
28 files changed, 297 insertions(+), 242 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10668/9
--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/exprs/expr-test.cc@7387
PS8, Line 7387:   ObjectPool pool;
> I think this is now unused (and I think clang-tidy might complain).
Good catch. I think the constructor is non-trivial so it can't infer that this 
does nothing.


http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt
File be/src/runtime/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt@83
PS8, Line 83: ADD_BE_TEST(data-stream-test) # TODO: this test leaks
> Is this intended? (i.e. this code change fixes some leaks in data-stream-te
I fixed a couple of easy ones; the hard ones are around the lifecycles of the 
various servers.



--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 15 Jun 2018 23:17:13 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Joe McDonnell (Code Review) 
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 8:

(2 comments)

I'm basically ready to +2 this. Just a couple things.

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/exprs/expr-test.cc@7387
PS8, Line 7387:   ObjectPool pool;
I think this is now unused (and I think clang-tidy might complain).


http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt
File be/src/runtime/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/10668/8/be/src/runtime/CMakeLists.txt@83
PS8, Line 83: ADD_BE_TEST(data-stream-test) # TODO: this test leaks
Is this intended? (i.e. this code change fixes some leaks in 
data-stream-test.cc, are there more that aren't fixed?)



--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 15 Jun 2018 19:46:31 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Tim Armstrong (Code Review) 
Hello Philip Zeyliger, Joe McDonnell,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10668

to look at the new patch set (#8).

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..

IMPALA-2746: part 1: enable LSAN for many backend tests

This turns on leak sanitizer for backend tests that required
relatively small modifications to pass. We suppress a few
leaks, mainly related to the embedded JVM.

Testing:
Ran core tests under ASAN.

Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
---
M be/CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/CMakeLists.txt
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/mem-tracker.cc
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/udf/udf.cc
M be/src/util/CMakeLists.txt
M be/src/util/decompress-test.cc
A bin/lsan-suppressions.txt
28 files changed, 296 insertions(+), 240 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10668/8
--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-12 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt
File be/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt@521
PS7, Line 521: # TODO: IMPALA-2746: we should make this the default.
> are we essentially addressing this?
I think the desired end-state is that we remove the special function and it's 
just on for all backend tests.



--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 00:06:38 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-12 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..


Patch Set 7: Code-Review+1

(1 comment)

Approach looks totally reasonable to me. Thanks!

http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt
File be/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/10668/7/be/CMakeLists.txt@521
PS7, Line 521: # TODO: IMPALA-2746: we should make this the default.
are we essentially addressing this?



--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Tue, 12 Jun 2018 23:13:53 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-12 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..

IMPALA-2746: part 1: enable LSAN for many backend tests

This turns on leak sanitizer for backend tests that required
relatively small modifications to pass. We suppress a few
leaks, mainly related to the embedded JVM.

Testing:
Ran core tests under ASAN.

Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
---
M be/CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/CMakeLists.txt
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/mem-tracker.cc
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/udf/udf.cc
M be/src/util/CMakeLists.txt
M be/src/util/decompress-test.cc
A bin/lsan-suppressions.txt
28 files changed, 295 insertions(+), 239 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10668/7
--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-11 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..

IMPALA-2746: part 1: enable LSAN for many backend tests

This turns on leak sanitizer for backend tests that required
relatively small modifications to pass. We suppress a few
leaks, mainly related to the embedded JVM.

Testing:
Ran core tests under ASAN.

Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
---
M be/CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/CMakeLists.txt
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/mem-tracker.cc
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/udf/udf.cc
M be/src/util/CMakeLists.txt
M be/src/util/decompress-test.cc
A bin/lsan-suppressions.txt
28 files changed, 295 insertions(+), 239 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10668/5
--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-11 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/10668 )

Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests
..

IMPALA-2746: part 1: enable LSAN for many backend tests

This turns on leak sanitizer for backend tests that required
relatively small modifications to pass. We suppress a few
leaks, mainly related to the embedded JVM.

Testing:
Ran core tests under ASAN.

Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
---
M be/CMakeLists.txt
M be/src/catalog/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/codegen/instruction-counter-test.cc
M be/src/common/CMakeLists.txt
M be/src/common/atomic-test.cc
M be/src/common/atomic.h
M be/src/exec/CMakeLists.txt
M be/src/experiments/CMakeLists.txt
M be/src/exprs/CMakeLists.txt
M be/src/exprs/expr-test.cc
M be/src/rpc/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
M be/src/runtime/bufferpool/CMakeLists.txt
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/data-stream-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr-stress.cc
M be/src/runtime/io/disk-io-mgr-stress.h
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/mem-tracker.cc
M be/src/scheduling/CMakeLists.txt
M be/src/service/CMakeLists.txt
M be/src/statestore/CMakeLists.txt
M be/src/udf/udf.cc
M be/src/util/CMakeLists.txt
M be/src/util/decompress-test.cc
A bin/lsan-suppressions.txt
28 files changed, 295 insertions(+), 238 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10668/4
--
To view, visit http://gerrit.cloudera.org:8080/10668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdda092a4eb4bc827c75a8c121e5428ec746b7f4
Gerrit-Change-Number: 10668
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong