[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8765 )

Change subject: IMPALA-6273: fixes subquery tests for functional_hbase
..

IMPALA-6273: fixes subquery tests for functional_hbase

IMPALA-1422 introduced tests that do not work with
the testing setup for hbase. Namely, tinyinttable is
not defined in the functional_hbase database, but
is defined in the functional database. Exhaustive
tests uncovered the issue.

This change makes two changes so that tests work with
functional_hbase:
1) use a table that is present in both functional and
   functional_hbase. the tests needed a subquery result
   with a single int column. tinyinttable is replaced
   with an inline view that provides this single int
   column in a portable manner.
2) nulls are handled differently with hbase (see IMPALA-728)
   so the nulltable used in the tests is set to
   functional.nulltable to avoid inconsistent results across
   input formats.

Testing:
- ran e2e tests with exhaustive exploration strategy for the
  broken test.

Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Reviewed-on: http://gerrit.cloudera.org:8080/8765
Reviewed-by: Dimitris Tsirogiannis 
Tested-by: Impala Public Jenkins
---
M 
testdata/workloads/functional-query/queries/QueryTest/subquery-in-constant-lhs.test
1 file changed, 13 insertions(+), 8 deletions(-)

Approvals:
  Dimitris Tsirogiannis: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 4
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8765 )

Change subject: IMPALA-6273: fixes subquery tests for functional_hbase
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1573/


--
To view, visit http://gerrit.cloudera.org:8080/8765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Tue, 05 Dec 2017 21:10:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8765 )

Change subject: IMPALA-6273: fixes subquery tests for functional_hbase
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Tue, 05 Dec 2017 19:48:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Vuk Ercegovac (Code Review) 
Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8765 )

Change subject: IMPALA-6273: fixes subquery tests for functional_hbase
..


Patch Set 3:

reduced the number of tests that explicitly reference functional so that
test coverage is reduced less. there is one case that remains for which I've
filed a separate jira that describes the issue I ran into with nulls + hbase.


--
To view, visit http://gerrit.cloudera.org:8080/8765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Tue, 05 Dec 2017 19:48:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Vuk Ercegovac (Code Review) 
Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8765

to look at the new patch set (#2).

Change subject: IMPALA-6273: fixes subquery tests for functional_hbase
..

IMPALA-6273: fixes subquery tests for functional_hbase

IMPALA-1422 introduced tests that do not work with
the testing setup for hbase. Namely, tinyinttable is
not defined in the functional_hbase database, but
is defined in the functional database. Exhaustive
tests uncovered the issue.

This change makes two changes so that tests work with
functional_hbase:
1) use a table that is present in both functional and
   functional_hbase. the tests needed a subquery result
   with a single int column. tinyinttable is replaced
   with an inline view that provides this single int
   column in a portable manner.
2) nulls are handled differently with hbase (see IMPALA-728)
   so the nulltable used in the tests is set to
   functional.nulltable to avoid inconsistent results across
   input formats.

Testing:
- ran e2e tests with exhaustive exploration strategy for the
  broken test.

Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
---
M 
testdata/workloads/functional-query/queries/QueryTest/subquery-in-constant-lhs.test
1 file changed, 17 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8765/2
--
To view, visit http://gerrit.cloudera.org:8080/8765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac

[Impala-ASF-CR] IMPALA-6273: fixes subquery tests for functional hbase

2017-12-05 Thread Vuk Ercegovac (Code Review) 
Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8765 )

Change subject: IMPALA-6273: fixes subquery tests for functional_hbase
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8765/1/testdata/workloads/functional-query/queries/QueryTest/subquery-in-constant-lhs.test
File 
testdata/workloads/functional-query/queries/QueryTest/subquery-in-constant-lhs.test:

http://gerrit.cloudera.org:8080/#/c/8765/1/testdata/workloads/functional-query/queries/QueryTest/subquery-in-constant-lhs.test@116
PS1, Line 116: WHERE NULL IN (SELECT d FROM functional.nulltable);
> Consider leaving a comment here about why we're specifying the db explicitl
Done



--
To view, visit http://gerrit.cloudera.org:8080/8765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaa3a3df7362ac6d3ed07aff133dc4b3520bb4e0
Gerrit-Change-Number: 8765
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Tue, 05 Dec 2017 18:41:57 +
Gerrit-HasComments: Yes