[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 13 Dec 2017 23:06:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. IMPALA-6301: Fix test failures when username or group name contains dots Some tests use the local user's group name to construct SQLs, which may lead to syntax errors when group name contains dots. We need to quote the group names in SQL to avoid this error. Besides, a test in test_admission_controller uses '\w+' to match the local user name. This expression cannot match usernames with dots, which causes test failure as well. Instead, we should use '\S+'. Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Reviewed-on: http://gerrit.cloudera.org:8080/8807 Reviewed-by: Thomas Tauber-Marshall Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test M testdata/workloads/functional-query/queries/QueryTest/grant_revoke_kudu.test M tests/authorization/test_grant_revoke.py M tests/custom_cluster/test_admission_controller.py 4 files changed, 31 insertions(+), 31 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, but someone else must approve Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1615/ -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 13 Dec 2017 19:30:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 13 Dec 2017 19:22:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 12 Dec 2017 20:33:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@155 PS2, Line 155: $GROUP_NAME It looks like you didn't quote any of the revoke statements. Do they work without the quotes? http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@494 PS2, Line 494: $GROUP_NAME quote? -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 11 Dec 2017 18:35:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@155 PS2, Line 155: $GROUP_NAME > It looks like you didn't quote any of the revoke statements. Do > they work without the quotes? I was first confused about that I just need to quote group names in tests/authorization/test_grant_revoke.py, then these tests passed. After that, I dug into the logs and found that the GROUP_NAME used in QueryTest/grant_revoke.test and QueryTest/grant_revoke_kudu.test is "Devs"! This is my first group name printed by command 'groups'. However, the python grp package may use group name in /etc/group in which I have only one group name 'quanlong.huang'. This is the reason why I can run pass tests in QueryTest/grant_revoke.test without some GROUP_NAME quoted. I think we should still quote all the GROUP_NAMEs to prevent tests fail on other developer's machines. http://gerrit.cloudera.org:8080/#/c/8807/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@494 PS2, Line 494: $GROUP_NAME > quote? Sure, I missed them! -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 12 Dec 2017 00:38:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8807 to look at the new patch set (#3). Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. IMPALA-6301: Fix test failures when username or group name contains dots Some tests use the local user's group name to construct SQLs, which may lead to syntax errors when group name contains dots. We need to quote the group names in SQL to avoid this error. Besides, a test in test_admission_controller uses '\w+' to match the local user name. This expression cannot match usernames with dots, which causes test failure as well. Instead, we should use '\S+'. Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b --- M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test M testdata/workloads/functional-query/queries/QueryTest/grant_revoke_kudu.test M tests/authorization/test_grant_revoke.py M tests/custom_cluster/test_admission_controller.py 4 files changed, 31 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/8807/3 -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots
Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. IMPALA-6301: Fix test failures when username or group name contains dots Some tests use the local user's group name to construct SQLs, which may lead to syntax errors when group name contains dots. We need to quote the group names in SQL to avoid this error. Besides, a test in test_admission_controller uses '\w+' to match the local user name. This expression cannot match usernames with dots, which causes test failure as well. Instead, we should use '\S+'. Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b --- M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test M testdata/workloads/functional-query/queries/QueryTest/grant_revoke_kudu.test M tests/authorization/test_grant_revoke.py M tests/custom_cluster/test_admission_controller.py 4 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/8807/2 -- To view, visit http://gerrit.cloudera.org:8080/8807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib8ae15bb6a929dc48d3ad2176c8b3fafff87f32b Gerrit-Change-Number: 8807 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang
