[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 06 Jun 2018 21:22:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 2: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 04 Jun 2018 14:02:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 2: (5 comments) Thank you for your review. Just addressed your comments. Please have a look when you have time. http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml File docs/topics/impala_file_formats.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml@115 PS1, Line 115: orc">OR > orc Done http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml@124 PS1, Line 124: > Remove - before 2.12, Impala won't be able to query anyway, right? Done http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@133 PS1, Line 133: > Sure Done http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: > You're right. This comes a bit closer: https://cwiki.apache.org/confluence/ Sure. Thank you for create the JIRA. http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@260 PS1, Line 260: p> : > Sure Done -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 02 Jun 2018 13:02:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Hello Alex Rodoni, Michael Brown, Balazs Jeszenszky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10525 to look at the new patch set (#2). Change subject: IMPALA-6714: [DOCS] ORC file format support .. IMPALA-6714: [DOCS] ORC file format support This document is wrote refering to RCFile and Parquet's docs. The orc-support patch was merged in impala-2.12 and impala-3.0, so we start to support ORC format as an experimental feature since impala-2.12. Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 --- M docs/impala.ditamap M docs/shared/impala_common.xml M docs/topics/impala_file_formats.xml A docs/topics/impala_orc.xml 4 files changed, 336 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/10525/2 -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@93 PS1, Line 93: If you do not have an existing data file to use, begin by creating one in the appropriate format. > OK. This is the same as other formats' docs. Do you think they should all b Yea don't think this is very helpful. Thanks for pointing out this is all over, created IMPALA-7107. http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: Enabling Compression for ORC Tables > I think it's reasonable. There're no details examples in the official site You're right. This comes a bit closer: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+ORC#LanguageManualORC-HiveQLSyntax, but still lacks examples. My concern is that this documents Hive behaviour, not Impala (e.g Hive might change the preferred way of altering compression). I don't feel strongly about this, we can cover it in IMPALA-7107 if need be. -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 01 Jun 2018 13:13:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: (5 comments) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@93 PS1, Line 93: If you do not have an existing data file to use, begin by creating one in the appropriate format. > The example below should be enough, remove. OK. This is the same as other formats' docs. Do you think they should all be removed? http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@133 PS1, Line 133: select * from > Could you make all SQL keywords in uppercase as in the Hive examples below? Sure http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: Enabling Compression for ORC Tables > This section deals mostly with Hive - is there a Hive document that could b I think it's reasonable. There're no details examples in the official site of ORC. For example, https://orc.apache.org/docs/hive-ddl.html http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@260 PS1, Line 260: Most of the types have the same name in Impala except the BINARY type is STRING type in Impala, : and the DATE type is not supported in Impala. > Turn into list (or box, similar to what Parquet has) Sure http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@269 PS1, Line 269: For example, > Add examples of what works, and one which doesn't. Include exception text. Sure -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 31 May 2018 22:03:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@133 PS1, Line 133: select * from Could you make all SQL keywords in uppercase as in the Hive examples below? -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Wed, 30 May 2018 18:45:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: Alex Rodoni is currently most familiar with docs so making them a reviewer. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Tue, 29 May 2018 17:05:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 ) Change subject: IMPALA-6714: [DOCS] ORC file format support .. Patch Set 1: (6 comments) Thanks for doing this! http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml File docs/topics/impala_file_formats.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml@115 PS1, Line 115: parquet orc http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml@124 PS1, Line 124: Before that, create the table using Hive. Remove - before 2.12, Impala won't be able to query anyway, right? http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@93 PS1, Line 93: If you do not have an existing data file to use, begin by creating one in the appropriate format. The example below should be enough, remove. http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: Enabling Compression for ORC Tables This section deals mostly with Hive - is there a Hive document that could be referenced instead including the commands? http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@260 PS1, Line 260: Most of the types have the same name in Impala except the BINARY type is STRING type in Impala, : and the DATE type is not supported in Impala. Turn into list (or box, similar to what Parquet has) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@269 PS1, Line 269: For example, Add examples of what works, and one which doesn't. Include exception text. -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Comment-Date: Tue, 29 May 2018 09:28:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6714: [DOCS] ORC file format support
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10525 Change subject: IMPALA-6714: [DOCS] ORC file format support .. IMPALA-6714: [DOCS] ORC file format support This document is wrote refering to RCFile and Parquet's docs. The orc-support patch was merged in impala-2.12 and impala-3.0, so we start to support ORC format as an experimental feature since impala-2.12. Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 --- M docs/impala.ditamap M docs/shared/impala_common.xml M docs/topics/impala_file_formats.xml A docs/topics/impala_orc.xml 4 files changed, 296 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/10525/1 -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
