[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the last part of the authorization test clean up. This patch rewrites the following tests: - alter database - explain - comment on - function - alter table/view This patch also adds the following authorization tests: - update - upsert - delete The tests in AuthorizationTest.java that have been rewritten into AuthorizationStmtTest.java are removed. Cherry-picks: not for 2.x Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Reviewed-on: http://gerrit.cloudera.org:8080/10841 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 2 files changed, 554 insertions(+), 2,057 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 29 Jun 2018 19:16:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2756/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 29 Jun 2018 15:18:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 29 Jun 2018 15:18:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Fri, 29 Jun 2018 07:32:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the last part of the authorization test clean up. This patch rewrites the following tests: - alter database - explain - comment on - function - alter table/view This patch also adds the following authorization tests: - update - upsert - delete The tests in AuthorizationTest.java that have been rewritten into AuthorizationStmtTest.java are removed. Cherry-picks: not for 2.x Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 2 files changed, 554 insertions(+), 2,057 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/10841/5 -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10841 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the last part of the authorization test clean up. This patch rewrites the following tests: - alter database - explain - comment on - function - alter table/view This patch also adds the following authorization tests: - update - upsert - delete The tests in AuthorizationTest.java that have been rewritten into AuthorizationStmtTest.java are removed. Cherry-picks: not for 2.x Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 2 files changed, 534 insertions(+), 2,057 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/10841/4 -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Vuk Ercegovac Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Fredy Wijaya has posted comments on this change. (
http://gerrit.cloudera.org:8080/10841 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
..
Patch Set 4:
(1 comment)
Carry +1
http://gerrit.cloudera.org:8080/#/c/10841/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:
http://gerrit.cloudera.org:8080/#/c/10841/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2081
PS3, Line 2081: private static String accessError(String object) {
> Don't we need a similar handler for function use error?
Yup, good one. I'll add another case of select that uses a UDF.
--
To view, visit http://gerrit.cloudera.org:8080/10841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Reviewer: Zoram Thanga
Gerrit-Comment-Date: Thu, 28 Jun 2018 22:36:25 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Zoram Thanga has posted comments on this change. (
http://gerrit.cloudera.org:8080/10841 )
Change subject: IMPALA-6802 (part 6): Clean up authorization tests
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10841/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java:
http://gerrit.cloudera.org:8080/#/c/10841/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2081
PS3, Line 2081: private static String dropFunctionError(String object) {
Don't we need a similar handler for function use error?
--
To view, visit http://gerrit.cloudera.org:8080/10841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Reviewer: Vuk Ercegovac
Gerrit-Reviewer: Zoram Thanga
Gerrit-Comment-Date: Thu, 28 Jun 2018 21:29:01 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6802 (part 6): Clean up authorization tests
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10841 Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. IMPALA-6802 (part 6): Clean up authorization tests This is the last part of the authorization test clean up. This patch rewrites the following tests: - alter database - explain - comment on - function - alter table/view This patch also adds the following authorization tests: - update - upsert - delete The tests in AuthorizationTest.java that have been rewritten into AuthorizationStmtTest.java are removed. Cherry-picks: not for 2.x Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 --- M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 2 files changed, 517 insertions(+), 2,057 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/10841/3 -- To view, visit http://gerrit.cloudera.org:8080/10841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id594ce09a821aef4a1debfdd61569a11defd1c55 Gerrit-Change-Number: 10841 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya
