[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code This change increases the log level for the HDFS S3 code to DEBUG to get more information on both Jiras. Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Reviewed-on: http://gerrit.cloudera.org:8080/10596 Reviewed-by: Lars Volker Reviewed-by: Sailesh Mukil Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M fe/src/test/resources/log4j.properties.template 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Lars Volker: Looks good to me, but someone else must approve Sailesh Mukil: Looks good to me, but someone else must approve Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 06 Jun 2018 20:21:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2608/ -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 06 Jun 2018 16:50:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 06 Jun 2018 06:11:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: > > My private build hit IMPALA-7070 when loading the testdata and > > didn't even get to test execution. It printed DEBUG statements as > > expected though and I reached out to some HDFS folks. Should we > > proceed with merging this and accept the risk that it might slow > > down some tests? > > > > I'm in favor. > > I'm in favor too. But we need to remember to disable once we've > fixed these issues. I filed IMPALA-7117 to track removing it and made it a Blocker for future releases. -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 05 Jun 2018 18:14:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Code-Review+1 > My private build hit IMPALA-7070 when loading the testdata and > didn't even get to test execution. It printed DEBUG statements as > expected though and I reached out to some HDFS folks. Should we > proceed with merging this and accept the risk that it might slow > down some tests? > > I'm in favor. I'm in favor too. But we need to remember to disable once we've fixed these issues. -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 05 Jun 2018 17:31:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Code-Review+1 My private build hit IMPALA-7070 when loading the testdata and didn't even get to test execution. It printed DEBUG statements as expected though and I reached out to some HDFS folks. Should we proceed with merging this and accept the risk that it might slow down some tests? I'm in favor. -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 05 Jun 2018 17:29:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: > Surely, we're not shipping fe/src/test/resources, so it doesn't > matter vis-a-vis releases? I didn't double-check that, but we > should have a way to specify log4j for our tests independently of > what we recommend in clusters. +1 to Phil's comment, it can help with testing a lot of Hadoop features that aren't enabled by default. Sharing Lars' sentiment, I've spent quite a lot of time trying to repro a different flaky S3 failure too, with no avail. This will definitely help catch the bug(s) when it happens on a nightly run. But we should also make sure that we turn it off later. -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 05 Jun 2018 16:08:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10596 to look at the new patch set (#2). Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code This change increases the log level for the HDFS S3 code to DEBUG to get more information on both Jiras. Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee --- M fe/src/test/resources/log4j.properties.template 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/10596/2 -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
