[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Wed, 16 May 2018 00:00:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Lars Volker has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..

IMPALA-7032: Disable codegen for CHAR type null literals

Analogous to IMPALA-6435, we have to disable codegen for CHAR type null
literals. Otherwise we will crash in
impala::NullLiteral::GetCodegendComputeFn().

This change adds a test to make sure that the crash is fixed.

Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Reviewed-on: http://gerrit.cloudera.org:8080/10409
Reviewed-by: Lars Volker 
Tested-by: Lars Volker 
---
M be/src/exprs/null-literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Lars Volker: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Lars Volker has removed a vote on this change.

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Removed Verified-1 by Impala Public Jenkins 
--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Patch Set 2:

This was a false positive from the recent Jenkins configuration change to 
report unit test failures. I manually inspected the Jenkins console output and 
could not see any failed tests.


--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Tue, 15 May 2018 23:59:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2478/


--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Tue, 15 May 2018 22:19:17 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2478/


--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Tue, 15 May 2018 18:35:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Patch Set 2: Code-Review+2

(1 comment)

Thanks for the quick review. I addressed your comment in PS2.

Carrying Michael's +2.

http://gerrit.cloudera.org:8080/#/c/10409/1/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
File testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test:

http://gerrit.cloudera.org:8080/#/c/10409/1/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test@48
PS1, Line 48: 
> nit: extra 
Done



--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Tue, 15 May 2018 18:34:55 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Hello Michael Ho,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10409

to look at the new patch set (#2).

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..

IMPALA-7032: Disable codegen for CHAR type null literals

Analogous to IMPALA-6435, we have to disable codegen for CHAR type null
literals. Otherwise we will crash in
impala::NullLiteral::GetCodegendComputeFn().

This change adds a test to make sure that the crash is fixed.

Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
---
M be/src/exprs/null-literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/10409/2
--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10409 )

Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10409/1/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
File testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test:

http://gerrit.cloudera.org:8080/#/c/10409/1/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test@48
PS1, Line 48: 
nit: extra 



--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Tue, 15 May 2018 18:27:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

[Lars Volker (Code Review)]

Lars Volker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10409


Change subject: IMPALA-7032: Disable codegen for CHAR type null literals
..

IMPALA-7032: Disable codegen for CHAR type null literals

Analogous to IMPALA-6435, we have to disable codegen for CHAR type null
literals. Otherwise we will crash in
impala::NullLiteral::GetCodegendComputeFn().

This change adds a test to make sure that the crash is fixed.

Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
---
M be/src/exprs/null-literal.cc
M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test
2 files changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/10409/1
--
To view, visit http://gerrit.cloudera.org:8080/10409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9
Gerrit-Change-Number: 10409
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker