[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Mon, 06 Aug 2018 16:19:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sun, 05 Aug 2018 22:15:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/196/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sun, 05 Aug 2018 19:25:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 11: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2923/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sun, 05 Aug 2018 18:54:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc@151 PS9, Line 151: \ > please : https://blog.csdn.net/gufachongyang02/article/details/21627539 Oh, I see what you are saying. You are right we still need the charset for text/html (and) text/plain content-types. Fixed that and tested it manually. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sun, 05 Aug 2018 18:53:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Hello Anonymous Coward #168, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#11). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Additionally, this commit also sets UTF-8 charset for text/[html/plain] encodings. As per [2] application/json does not require it to be set. Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt [2] https://www.iana.org/assignments/media-types/application/json Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 38 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/11 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Anonymous Coward #168 has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 9: (1 comment) Patch set 11 http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc@151 PS9, Line 151: \ > I don't think that is a standard. Relevant discussion here [1] which refers please : https://blog.csdn.net/gufachongyang02/article/details/21627539 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sat, 04 Aug 2018 02:40:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 10: 21:54:06 [INFO] BUILD FAILURE 21:54:06 [ERROR] Failed to execute goal on project impala-frontend: Could not resolve dependencies for project org.apache.impala:impala-frontend:jar:0.1-SNAPSHOT: Could not transfer artifact org.apache.sentry:sentry-provider-db:jar:2.0.0-cdh6.x-20180731.151011-502571 from/to impala.cdh.repo (https://native-toolchain.s3.amazonaws.com/build/cdh_components/506967/maven): Access denied to: https://native-toolchain.s3.amazonaws.com/build/cdh_components/506967/maven/org/apache/sentry/sentry-provider-db/2.0.0-cdh6.x-SNAPSHOT/sentry-provider-db-2.0.0-cdh6.x-20180731.151011-502571.jar , ReasonPhrase:Forbidden. -> [Help 1] 21:54:06 [ERROR] 21:54:06 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. 21:54:06 [ERROR] Re-run Maven using the -X switch to enable full debug logging. 21:54:06 [ERROR] -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 10 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Sat, 04 Aug 2018 00:17:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2919/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 10 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 21:01:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc@151 PS9, Line 151: \ > Compatible Chinese should add charset=utf-8 I don't think that is a standard. Relevant discussion here [1] which refers to [2] that says "Note: No "charset" parameter is defined for this registration. Adding one really has no effect on compliant recipients." Also, I tried running a sample query in chinese charset and I can see it fine in my firefox browser without UTF-8 charset in the HTTP header. Here is a screenshot [3] [1] https://github.com/request/request/issues/383 [2] http://www.iana.org/assignments/media-types/application/json [3] https://pasteboard.co/HxvPg1X.png -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 21:00:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Anonymous Coward #168 has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 9: (1 comment) other http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/0/9/be/src/util/webserver.cc@151 PS9, Line 151: \ Compatible Chinese should add charset=utf-8 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 03:26:56 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 9: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2911/ -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 03:14:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2911/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 01:56:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 8: Looks like IMPALA-7328, triggering another build. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 8 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 01:56:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2905/ -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 8 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Fri, 03 Aug 2018 01:31:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/165/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 7 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 22:44:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/164/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 6 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 22:25:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/163/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 22:16:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2905/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 8 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 22:15:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 8 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 22:15:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/0 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..
Patch Set 7: Code-Review+2
(2 comments)
Carrying +2
http://gerrit.cloudera.org:8080/#/c/0/4/be/src/util/webserver.cc
File be/src/util/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/0/4/be/src/util/webserver.cc@438
PS4, Line 438: bool raw_json = (arguments.find("json") != arguments.end());
> Could you update webserver.h's comment for this function with what ?json an
Elaborated it a bit more.
http://gerrit.cloudera.org:8080/#/c/0/4/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/0/4/tests/webserver/test_web_pages.py@97
PS4, Line 97: assert content_type ==
requests.get(url).headers['Content-Type']
> Should this be "==" rather than "in"?
Done
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 7
Gerrit-Owner: Bharath Vissapragada
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Thu, 02 Aug 2018 22:14:32 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#7). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 37 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/7 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 7 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 6 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 22:09:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#6). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 33 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/6 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 6 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#5). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 33 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/5 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/0 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..
Patch Set 4: Code-Review+2
(2 comments)
This looks fine to me. I've asked you to add docs for ?raw and ?json in the
header files; my apologies if they exist somewhere and I missed them.
http://gerrit.cloudera.org:8080/#/c/0/4/be/src/util/webserver.cc
File be/src/util/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/0/4/be/src/util/webserver.cc@438
PS4, Line 438: bool raw_json = (arguments.find("json") != arguments.end());
Could you update webserver.h's comment for this function with what ?json and
?raw do. I'm actually a little bit unclear about the distinction based on the
source here and it doesn't seem documented.
http://gerrit.cloudera.org:8080/#/c/0/4/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/0/4/tests/webserver/test_web_pages.py@97
PS4, Line 97: assert content_type in
requests.get(url).headers['Content-Type']
Should this be "==" rather than "in"?
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Vissapragada
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Thu, 02 Aug 2018 15:05:40 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/158/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 07:09:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/0 ) Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/157/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 02 Aug 2018 07:00:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has posted comments on this change. (
http://gerrit.cloudera.org:8080/0 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..
Patch Set 3:
(5 comments)
Fixed flake8 errors.
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@88
PS3, Line 88: d
> flake8: E301 expected 1 blank line, found 0
Done
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
> flake8: E203 whitespace before ':'
Done
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
> flake8: E203 whitespace before ':'
Done
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
> flake8: E201 whitespace after '{'
Done
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
> flake8: E203 whitespace before ':'
Done
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada
Gerrit-Reviewer: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Thu, 02 Aug 2018 06:36:36 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/0 to look at the new patch set (#4). Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 28 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/4 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/0 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@88
PS3, Line 88: d
flake8: E301 expected 1 blank line, found 0
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
flake8: E201 whitespace after '{'
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
flake8: E203 whitespace before ':'
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
flake8: E203 whitespace before ':'
http://gerrit.cloudera.org:8080/#/c/0/3/tests/webserver/test_web_pages.py@92
PS3, Line 92:
flake8: E203 whitespace before ':'
--
To view, visit http://gerrit.cloudera.org:8080/0
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea
Gerrit-Change-Number: 0
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Thu, 02 Aug 2018 06:31:27 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7387: Set correct MIME type for JSON webpages
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/0 Change subject: IMPALA-7387: Set correct MIME type for JSON webpages .. IMPALA-7387: Set correct MIME type for JSON webpages Right now Impala sets "text/plain" as the MIME type for all non-HTML pages. As per RFC-4627[1], JSON's prescribed MIME type is "application/json". Testing: - Inspected HTTP headers manually in the browser. - Added tests. [1] http://www.ietf.org/rfc/rfc4627.txt Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea --- M be/src/util/webserver.cc M be/src/util/webserver.h M tests/webserver/test_web_pages.py 3 files changed, 27 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/0/3 -- To view, visit http://gerrit.cloudera.org:8080/0 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 0 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada
