[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. IMPALA-7399: Emit a junit xml report when trapping errors This patch will cause a junitxml file to be emitted in the case of errors in build scripts. Instead of simply echoing a message to the console, we set up a trap function that also writes out to a junit xml report that can be consumed by jenkins.impala.io. Main things to pay attention to: - New file that gets sourced by all bash scripts when trapping within bash scripts: https://gerrit.cloudera.org/c/11257/1/bin/report_build_error.sh - Installation of the python lib into impala-python venv for use from within python files: https://gerrit.cloudera.org/c/11257/1/bin/impala-python-common.sh - Change to the generate_junitxml.py file itself, for ease of https://gerrit.cloudera.org/c/11257/1/lib/python/impala_py_lib/jenkins/generate_junitxml.py Most of the other changes are to source the new report_build_error.sh script to set up the trap function. Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Reviewed-on: http://gerrit.cloudera.org:8080/11257 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/clean-cmake.sh M bin/clean.sh M bin/create-test-configuration.sh M bin/create_testdata.sh M bin/distcc/distcc_server_setup.sh M bin/impala-python-common.sh M bin/jenkins/all-tests.sh M bin/jenkins/build-all-flag-combinations.sh M bin/jenkins/build-only.sh M bin/make_impala.sh A bin/report_build_error.sh M bin/run-all-tests.sh M bin/run-backend-tests.sh M bin/start-catalogd.sh M bin/start-impalad.sh M bin/start-statestored.sh M buildall.sh M infra/python/bootstrap_virtualenv.py M lib/python/impala_py_lib/jenkins/generate_junitxml.py M shell/make_shell_tarball.sh M testdata/bin/check-schema-diff.sh M testdata/bin/compute-table-stats.sh M testdata/bin/copy-data-sources.sh M testdata/bin/copy-udfs-udas.sh M testdata/bin/create-load-data.sh M testdata/bin/create-table-many-blocks.sh M testdata/bin/generate-load-nested.sh M testdata/bin/kill-all.sh M testdata/bin/kill-hbase.sh M testdata/bin/kill-hive-server.sh M testdata/bin/kill-java-service.sh M testdata/bin/kill-sentry-service.sh M testdata/bin/load-hive-builtins.sh M testdata/bin/load-metastore-snapshot.sh M testdata/bin/load-test-warehouse-snapshot.sh M testdata/bin/run-all.sh M testdata/bin/run-hbase.sh M testdata/bin/run-hive-server.sh M testdata/bin/run-mini-dfs.sh M testdata/bin/run-sentry-service.sh M testdata/bin/setup-hdfs-env.sh M testdata/cluster/admin M testdata/datasets/tpcds/preload M testdata/datasets/tpch/preload M tests/run-custom-cluster-tests.sh M tests/run-process-failure-tests.sh 46 files changed, 159 insertions(+), 68 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 12 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 11 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 23 Aug 2018 18:33:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 11: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3075/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 11 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 23 Aug 2018 15:17:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 11 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 23 Aug 2018 15:16:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 10 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 23 Aug 2018 15:11:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
David Knupp has posted comments on this change. (
http://gerrit.cloudera.org:8080/11257 )
Change subject: IMPALA-7399: Emit a junit xml report when trapping errors
..
Patch Set 10:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py
File lib/python/impala_py_lib/jenkins/generate_junitxml.py:
http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py@164
PS9, Line 164: g_
> Not python2.6-compatible. Use {0}
Done.
I actually waffled on this a bit. I think that it makes more sense to return
the file name after all, and have the caller print (or not) as necessary. But I
fixed it there.
http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh
File testdata/bin/check-schema-diff.sh:
http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh@30
PS9, Line 30: t, we don't call setup_report_build_error.
> just say "we don't call setup_report_build_error".
Done
--
To view, visit http://gerrit.cloudera.org:8080/11257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc
Gerrit-Change-Number: 11257
Gerrit-PatchSet: 10
Gerrit-Owner: David Knupp
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Nithya Janarthanan
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Thu, 23 Aug 2018 00:52:14 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: All outstanding comments have been addressed. -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 10 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 23 Aug 2018 00:52:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/460/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 10 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Thu, 23 Aug 2018 00:06:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#10). Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. IMPALA-7399: Emit a junit xml report when trapping errors This patch will cause a junitxml file to be emitted in the case of errors in build scripts. Instead of simply echoing a message to the console, we set up a trap function that also writes out to a junit xml report that can be consumed by jenkins.impala.io. Main things to pay attention to: - New file that gets sourced by all bash scripts when trapping within bash scripts: https://gerrit.cloudera.org/c/11257/1/bin/report_build_error.sh - Installation of the python lib into impala-python venv for use from within python files: https://gerrit.cloudera.org/c/11257/1/bin/impala-python-common.sh - Change to the generate_junitxml.py file itself, for ease of https://gerrit.cloudera.org/c/11257/1/lib/python/impala_py_lib/jenkins/generate_junitxml.py Most of the other changes are to source the new report_build_error.sh script to set up the trap function. Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc --- M bin/clean-cmake.sh M bin/clean.sh M bin/create-test-configuration.sh M bin/create_testdata.sh M bin/distcc/distcc_server_setup.sh M bin/impala-python-common.sh M bin/jenkins/all-tests.sh M bin/jenkins/build-all-flag-combinations.sh M bin/jenkins/build-only.sh M bin/make_impala.sh A bin/report_build_error.sh M bin/run-all-tests.sh M bin/run-backend-tests.sh M bin/start-catalogd.sh M bin/start-impalad.sh M bin/start-statestored.sh M buildall.sh M infra/python/bootstrap_virtualenv.py M lib/python/impala_py_lib/jenkins/generate_junitxml.py M shell/make_shell_tarball.sh M testdata/bin/check-schema-diff.sh M testdata/bin/compute-table-stats.sh M testdata/bin/copy-data-sources.sh M testdata/bin/copy-udfs-udas.sh M testdata/bin/create-load-data.sh M testdata/bin/create-table-many-blocks.sh M testdata/bin/generate-load-nested.sh M testdata/bin/kill-all.sh M testdata/bin/kill-hbase.sh M testdata/bin/kill-hive-server.sh M testdata/bin/kill-java-service.sh M testdata/bin/kill-sentry-service.sh M testdata/bin/load-hive-builtins.sh M testdata/bin/load-metastore-snapshot.sh M testdata/bin/load-test-warehouse-snapshot.sh M testdata/bin/run-all.sh M testdata/bin/run-hbase.sh M testdata/bin/run-hive-server.sh M testdata/bin/run-mini-dfs.sh M testdata/bin/run-sentry-service.sh M testdata/bin/setup-hdfs-env.sh M testdata/cluster/admin M testdata/datasets/tpcds/preload M testdata/datasets/tpch/preload M tests/run-custom-cluster-tests.sh M tests/run-process-failure-tests.sh 46 files changed, 159 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11257/10 -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 10 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Michael Brown has posted comments on this change. (
http://gerrit.cloudera.org:8080/11257 )
Change subject: IMPALA-7399: Emit a junit xml report when trapping errors
..
Patch Set 9: Code-Review+1
(2 comments)
Phil had good comments. I had looked at an earlier patch set and didn't have
much more to say. This looks good to me now though.
http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py
File lib/python/impala_py_lib/jenkins/generate_junitxml.py:
http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py@164
PS9, Line 164: {}
Not python2.6-compatible. Use {0}
http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh
File testdata/bin/check-schema-diff.sh:
http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh@30
PS9, Line 30: the same trap function used by other shell scripts
just say "we don't call setup_report_build_error".
--
To view, visit http://gerrit.cloudera.org:8080/11257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc
Gerrit-Change-Number: 11257
Gerrit-PatchSet: 9
Gerrit-Owner: David Knupp
Gerrit-Reviewer: David Knupp
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Michael Brown
Gerrit-Reviewer: Nithya Janarthanan
Gerrit-Reviewer: Philip Zeyliger
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:00:43 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 9 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 22 Aug 2018 19:10:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3070/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 9 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Wed, 22 Aug 2018 15:50:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 8 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 21 Aug 2018 23:30:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11257 ) Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/442/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 7 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger Gerrit-Comment-Date: Tue, 21 Aug 2018 23:14:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7399: Emit a junit xml report when trapping errors
Hello Lars Volker, Michael Brown, Nithya Janarthanan, Philip Zeyliger, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11257 to look at the new patch set (#9). Change subject: IMPALA-7399: Emit a junit xml report when trapping errors .. IMPALA-7399: Emit a junit xml report when trapping errors This patch will cause a junitxml file to be emitted in the case of errors in build scripts. Instead of simply echoing a message to the console, we set up a trap function that also writes out the the junit xml report that can be consumed by jenkins.impala.io. Main things to pay attention to: - New file that gets sourced by all bash scripts when trapping within bash scripts: https://gerrit.cloudera.org/c/11257/1/bin/report_build_error.sh - Installation of the python lib into impala-python venv for use from within python files: https://gerrit.cloudera.org/c/11257/1/bin/impala-python-common.sh - Change to the generate_junitxml.py file itself, for ease of https://gerrit.cloudera.org/c/11257/1/lib/python/impala_py_lib/jenkins/generate_junitxml.py Most of the other changes are to source the new report_build_error.sh script to set up the trap function. Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc --- M bin/clean-cmake.sh M bin/clean.sh M bin/create-test-configuration.sh M bin/create_testdata.sh M bin/distcc/distcc_server_setup.sh M bin/impala-python-common.sh M bin/jenkins/all-tests.sh M bin/jenkins/build-all-flag-combinations.sh M bin/jenkins/build-only.sh M bin/make_impala.sh A bin/report_build_error.sh M bin/run-all-tests.sh M bin/run-backend-tests.sh M bin/start-catalogd.sh M bin/start-impalad.sh M bin/start-statestored.sh M buildall.sh M infra/python/bootstrap_virtualenv.py M lib/python/impala_py_lib/jenkins/generate_junitxml.py M shell/make_shell_tarball.sh M testdata/bin/check-schema-diff.sh M testdata/bin/compute-table-stats.sh M testdata/bin/copy-data-sources.sh M testdata/bin/copy-udfs-udas.sh M testdata/bin/create-load-data.sh M testdata/bin/create-table-many-blocks.sh M testdata/bin/generate-load-nested.sh M testdata/bin/kill-all.sh M testdata/bin/kill-hbase.sh M testdata/bin/kill-hive-server.sh M testdata/bin/kill-java-service.sh M testdata/bin/kill-sentry-service.sh M testdata/bin/load-hive-builtins.sh M testdata/bin/load-metastore-snapshot.sh M testdata/bin/load-test-warehouse-snapshot.sh M testdata/bin/run-all.sh M testdata/bin/run-hbase.sh M testdata/bin/run-hive-server.sh M testdata/bin/run-mini-dfs.sh M testdata/bin/run-sentry-service.sh M testdata/bin/setup-hdfs-env.sh M testdata/cluster/admin M testdata/datasets/tpcds/preload M testdata/datasets/tpch/preload M tests/run-custom-cluster-tests.sh M tests/run-process-failure-tests.sh 46 files changed, 159 insertions(+), 72 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11257/9 -- To view, visit http://gerrit.cloudera.org:8080/11257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc Gerrit-Change-Number: 11257 Gerrit-PatchSet: 9 Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Nithya Janarthanan Gerrit-Reviewer: Philip Zeyliger
