[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 20:22:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. The patch also renames test_show_grant_user.py to test_show_grant.py for all tests related to SHOW GRANT statements. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Reviewed-on: http://gerrit.cloudera.org:8080/11663 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1036/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:38:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:24:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3306/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:24:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:22:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1035/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:16:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > that's fine, but since its mostly a file rename fwict, with a test added, i Gotcha. I updated the git commit message. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 16:11:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. The patch also renames test_show_grant_user.py to test_show_grant.py for all tests related to SHOW GRANT statements. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/11663/3 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > A file name change from TestShowGrantUser to TestShowGrant since I think it that's fine, but since its mostly a file rename fwict, with a test added, it would be useful to hint to git that its a rename (not sure when this happens on its own vs. when it needs to be explicitly hinted) -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 15:51:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py File tests/authorization/test_show_grant.py: http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@35 PS1, Line 35: class TestShowGrant(CustomClusterTestSuite): > can you hint this file so that the diff is shown? A file name change from TestShowGrantUser to TestShowGrant since I think it's better for this test to cover both SHOW GRANT ROLE and SHOW GRANT USER. http://gerrit.cloudera.org:8080/#/c/11663/1/tests/authorization/test_show_grant.py@107 PS1, Line 107: """ > nit: I've mostly seen the other, multi-line commenting for this case (e.g., Done -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 12 Oct 2018 15:43:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/11663/2 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1029/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 11 Oct 2018 23:01:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11663 Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients Prior to this patch, SHOW GRANT ROLE/USER always showed NULL in grant_option column because the grant_option column header was set to use BOOLEAN type but the column value was set to use STRING. This mismatch causes HS2 clients to interpret the column value as not set (NULL). The patch fixes the issue by setting the grant_option column value to use BOOLEAN value. Testing: - Ran all FE tests - Added new E2E test running SHOW GRANT statements from HS2 client - Ran all E2E authorization tests Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf --- M fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java M fe/src/main/java/org/apache/impala/util/TResultRowBuilder.java A tests/authorization/test_show_grant.py D tests/authorization/test_show_grant_user.py 4 files changed, 156 insertions(+), 95 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/11663/1 -- To view, visit http://gerrit.cloudera.org:8080/11663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1e175544172b63d36dceedc61e1f47e0f910d7cf Gerrit-Change-Number: 11663 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
