[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-26 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..

IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes

- The following options were documented:
- parquet_read_page_index
- parquet_write_page_index
- parquet_page_row_count_limit

Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Reviewed-on: http://gerrit.cloudera.org:8080/13900
Tested-by: Impala Public Jenkins 
Reviewed-by: Zoltan Borok-Nagy 
---
M docs/impala.ditamap
M docs/topics/impala_parquet.xml
A docs/topics/impala_parquet_page_row_count_limit.xml
A docs/topics/impala_parquet_read_page_index.xml
A docs/topics/impala_parquet_write_page_index.xml
5 files changed, 255 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Zoltan Borok-Nagy: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Fri, 26 Jul 2019 10:26:50 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 5: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/412/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 25 Jul 2019 23:29:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 5:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/412/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 25 Jul 2019 23:18:19 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Alex Rodoni (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13900

to look at the new patch set (#5).

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..

IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes

- The following options were documented:
- parquet_read_page_index
- parquet_write_page_index
- parquet_page_row_count_limit

Change-Id: I46c1941269feff18306863f784aa36f5037da1db
---
M docs/impala.ditamap
M docs/topics/impala_parquet.xml
A docs/topics/impala_parquet_page_row_count_limit.xml
A docs/topics/impala_parquet_read_page_index.xml
A docs/topics/impala_parquet_write_page_index.xml
5 files changed, 255 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13900/5
--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 4: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/411/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 25 Jul 2019 23:14:43 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Alex Rodoni (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13900

to look at the new patch set (#4).

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..

IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes

- The following options were documented:
- parquet_read_page_index
- parquet_write_page_index
- parquet_page_row_count_limit

Change-Id: I46c1941269feff18306863f784aa36f5037da1db
---
M docs/impala.ditamap
A docs/topics/impala_parquet_page_row_count_limit.xml
A docs/topics/impala_parquet_read_page_index.xml
A docs/topics/impala_parquet_write_page_index.xml
4 files changed, 252 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13900/4
--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/411/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 25 Jul 2019 22:49:49 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml
File docs/topics/impala_parquet_write_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@48
PS3, Line 48: 
:   This option enables the same optimization as the 
PARQUET_READ_STATISTICS
:   for writing at the finer grained page level.
: 
> This option is only about writing, so this paragraph doesn't belong here.
Done


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@62
PS3, Line 62:   
: For simple predicates of the forms: slot> 
op> constant> or
: constant> op> slot>, where 
op> is LT,
: LE, GE, GT, and EQ
:   
> This isn't really belong to the write path.
Done


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@73
PS3, Line 73: Read statistics from Parquet pages and use
:   them in query processing.
> Write the Parquet page index when creating Parquet files.
Done


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@78
PS3, Line 78:  Do not use Parquet write page statistics.
> Do not write the Parquet page index when creating Parquet files.
Done



--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 25 Jul 2019 22:49:23 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml
File docs/topics/impala_parquet_write_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@48
PS3, Line 48: 
:   This option enables the same optimization as the 
PARQUET_READ_STATISTICS
:   for writing at the finer grained page level.
: 
This option is only about writing, so this paragraph doesn't belong here.


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@54
PS3, Line 54:   Impala supports filtering based on Parquet statistics:
Impala writes page-level statistics into the Parquet page index:


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@62
PS3, Line 62:   
: For simple predicates of the forms: slot> 
op> constant> or
: constant> op> slot>, where 
op> is LT,
: LE, GE, GT, and EQ
:   
This isn't really belong to the write path.


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@73
PS3, Line 73: Read statistics from Parquet pages and use
:   them in query processing.
Write the Parquet page index when creating Parquet files.


http://gerrit.cloudera.org:8080/#/c/13900/3/docs/topics/impala_parquet_write_page_index.xml@78
PS3, Line 78:  Do not use Parquet write page statistics.
Do not write the Parquet page index when creating Parquet files.



--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Thu, 25 Jul 2019 08:21:48 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 3: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/405/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 24 Jul 2019 17:04:12 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/405/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 24 Jul 2019 16:50:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-24 Thread Alex Rodoni (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13900

to look at the new patch set (#3).

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..

IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page 
indexes

- The following options were documented:
- parquet_read_page_index
- parquet_write_page_index
- parquet_page_row_count_limit

Change-Id: I46c1941269feff18306863f784aa36f5037da1db
---
M docs/impala.ditamap
A docs/topics/impala_parquet_page_row_count_limit.xml
A docs/topics/impala_parquet_read_page_index.xml
A docs/topics/impala_parquet_write_page_index.xml
4 files changed, 267 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/13900/3
--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-24 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml
File docs/topics/impala_parquet_read_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@61
PS2, Line 61: Float
> Float is not supported until PARQUET-1222 is not resolved.
Done


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@75
PS2, Line 75: Read statistics from Parquet pages and use
:   them in query processing.
> Read the page-level statistics from the Parquet page index during query pro
Done


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@80
PS2, Line 80: Do not use Parquet read page statistics.
> Do not use the Parquet page index.
Done


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml
File docs/topics/impala_parquet_write_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@49
PS2, Line 49:   This option enables the same optimization as the 
PARQUET_READ_STATISTICS
:   for writing at the finer grained page level.
> This paragraph doesn't really belong here since here we are talking about w
Removed


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@59
PS2, Line 59: Float
> Float is not supported until PARQUET-1222 is not resolved.
Done


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@63
PS2, Line 63: For simple predicates of the forms: slot> 
op> constant> or
: constant> op> slot>, where 
op> is LT,
: LE, GE, GT, and EQ
> This doesn't really belong here.
Removed


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@73
PS2, Line 73: Read
> Writes page-level statistics.
Done


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@78
PS2, Line 78: Do not use Parquet write page statistics.
> Do not write the Parquet page index.
Done



--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 24 Jul 2019 16:48:55 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-24 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml
File docs/topics/impala_parquet_read_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@61
PS2, Line 61: Float
Float is not supported until PARQUET-1222 is not resolved.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@75
PS2, Line 75: Read statistics from Parquet pages and use
:   them in query processing.
Read the page-level statistics from the Parquet page index during query 
processing and filter out pages based on that.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_read_page_index.xml@80
PS2, Line 80: Do not use Parquet read page statistics.
Do not use the Parquet page index.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml
File docs/topics/impala_parquet_write_page_index.xml:

http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@49
PS2, Line 49:   This option enables the same optimization as the 
PARQUET_READ_STATISTICS
:   for writing at the finer grained page level.
This paragraph doesn't really belong here since here we are talking about 
writing the stats.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@59
PS2, Line 59: Float
Float is not supported until PARQUET-1222 is not resolved.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@63
PS2, Line 63: For simple predicates of the forms: slot> 
op> constant> or
: constant> op> slot>, where 
op> is LT,
: LE, GE, GT, and EQ
This doesn't really belong here.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@73
PS2, Line 73: Read
Writes page-level statistics.


http://gerrit.cloudera.org:8080/#/c/13900/2/docs/topics/impala_parquet_write_page_index.xml@78
PS2, Line 78: Do not use Parquet write page statistics.
Do not write the Parquet page index.



--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Wed, 24 Jul 2019 16:28:02 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2: Verified+1

Build Successful

https://jenkins.impala.io/job/gerrit-docs-auto-test/400/ : Doc tests passed.


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:37:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for Parquet page indexes

2019-07-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13900 )

Change subject: IMPALA-7991 IMPALA-8575: [DOCS] Document the query options for 
Parquet page indexes
..


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/400/

Testing docs change - this change appears to modify docs/ and no code. This is 
experimental - please report any issues to tarmstr...@cloudera.com or on this 
JIRA: IMPALA-7317


--
To view, visit http://gerrit.cloudera.org:8080/13900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c1941269feff18306863f784aa36f5037da1db
Gerrit-Change-Number: 13900
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 23 Jul 2019 22:15:12 +
Gerrit-HasComments: No