[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. IMPALA-8629: (part 1) Add temp KuduStorageHandler This patch adds a temporary KuduStorageHandler so that the Kudu project can change its handler without breaking the integration. It also disabled any tests that depend on the specific handler. A follow up patch will remove the TEMP_KUDU_STORAGE_HANDLER. adjust the KUDU_STORAGE_HANDLER value to be the final value, and re-enable the tests. Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Reviewed-on: http://gerrit.cloudera.org:8080/13561 Tested-by: Impala Public Jenkins Reviewed-by: Thomas Marshall --- M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M tests/custom_cluster/test_kudu.py M tests/query_test/test_kudu.py 4 files changed, 24 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Verified Thomas Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Mon, 10 Jun 2019 16:12:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Sat, 08 Jun 2019 04:57:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Sat, 08 Jun 2019 02:25:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4434/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 23:49:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3548/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 23:12:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Hello Thomas Marshall, Hao Hao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13561 to look at the new patch set (#3). Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. IMPALA-8629: (part 1) Add temp KuduStorageHandler This patch adds a temporary KuduStorageHandler so that the Kudu project can change its handler without breaking the integration. It also disabled any tests that depend on the specific handler. A follow up patch will remove the TEMP_KUDU_STORAGE_HANDLER. adjust the KUDU_STORAGE_HANDLER value to be the final value, and re-enable the tests. Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a --- M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M tests/custom_cluster/test_kudu.py M tests/query_test/test_kudu.py 4 files changed, 24 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13561/3 -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13561/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/13561/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@90 PS1, Line 90: // TODO(IMPALA-8629): Remove this after Kudu adjusts its StorageHandler logic. > We may want to add the Jira number (IMPALA-8629) here? Done http://gerrit.cloudera.org:8080/#/c/13561/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/13561/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@a444 PS2, Line 444: > removed by mistake? Done -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 22:32:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13561/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/13561/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@a444 PS2, Line 444: removed by mistake? -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 21:30:26 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3543/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 21:27:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4431/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 21:07:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Hello Thomas Marshall, Hao Hao, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13561 to look at the new patch set (#2). Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. IMPALA-8629: (part 1) Add temp KuduStorageHandler This patch adds a temporary KuduStorageHandler so that the Kudu project can change its handler without breaking the integration. It also disabled any tests that depend on the specific handler. A follow up patch will remove the TEMP_KUDU_STORAGE_HANDLER. adjust the KUDU_STORAGE_HANDLER value to be the final value, and re-enable the tests. Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a --- M fe/src/main/java/org/apache/impala/catalog/KuduTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java M tests/custom_cluster/test_kudu.py M tests/query_test/test_kudu.py 4 files changed, 24 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13561/2 -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3541/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 20:06:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13561 ) Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. Patch Set 1: Code-Review+1 (1 comment) Just one minor nit. http://gerrit.cloudera.org:8080/#/c/13561/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/13561/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@90 PS1, Line 90: // TODO(ghenke): Remove this after Kudu adjusts its KuduStorageHandler logic. We may want to add the Jira number (IMPALA-8629) here? -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Fri, 07 Jun 2019 19:54:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8629: (part 1) Add temp KuduStorageHandler
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13561 Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler .. IMPALA-8629: (part 1) Add temp KuduStorageHandler This patch adds a temporary KuduStorageHandler so that the Kudu project can change its handler without breaking the integration. A follow up patch will remove the TEMP_KUDU_STORAGE_HANDLER and adjust the KUDU_STORAGE_HANDLER value to be the final value. Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a --- M fe/src/main/java/org/apache/impala/catalog/KuduTable.java 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13561/1 -- To view, visit http://gerrit.cloudera.org:8080/13561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a Gerrit-Change-Number: 13561 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke