[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 13: Thanks for the contribution! -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 13 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 13 Feb 2020 23:08:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 12 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 13 Feb 2020 21:43:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. -Made log asserts more robust by adding a timeout/wait value. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Reviewed-on: http://gerrit.cloudera.org:8080/14782 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/common/impala_test_suite.py M tests/observability/test_log_fragments.py M tests/webserver/test_web_pages.py 6 files changed, 77 insertions(+), 30 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 13 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 11: Agreed, I'll rerun -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 11 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 13 Feb 2020 16:53:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 12 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 13 Feb 2020 16:53:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5332/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 12 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Thu, 13 Feb 2020 16:53:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 11: The failure looks like IMPALA-1995. https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/9129/consoleText -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 11 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 11 Feb 2020 16:08:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 11: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5311/ -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 11 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 22:21:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5187/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 10 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 17:45:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 9: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5185/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 9 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 17:35:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 11: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5311/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 11 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 17:27:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 11 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 17:27:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 10 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 17:27:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. -Made log asserts more robust by adding a timeout/wait value. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/common/impala_test_suite.py M tests/observability/test_log_fragments.py M tests/webserver/test_web_pages.py 6 files changed, 77 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/10 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 10 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. -Made log asserts more robust by adding a timeout/wait value. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/common/impala_test_suite.py M tests/observability/test_log_fragments.py M tests/webserver/test_web_pages.py 6 files changed, 76 insertions(+), 30 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/9 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 9 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/14782/9/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/14782/9/tests/common/impala_test_suite.py@1123 PS9, Line 1123: : flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14782/9/tests/common/impala_test_suite.py@1129 PS9, Line 1129: ) flake8: E999 SyntaxError: invalid syntax -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 9 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 10 Feb 2020 16:51:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/14782 )
Change subject: IMPALA-9182: Print the socket address of the client closing a
session or cancelling a query from the WebUI
..
Patch Set 8:
(1 comment)
Sorry for the slow response here, I lost track of this in the shuffle. Still
concerned about the potential flakiness of the test, but I checked it out and
played around so I could suggest a better solution.
http://gerrit.cloudera.org:8080/#/c/14782/8/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/14782/8/tests/webserver/test_web_pages.py@744
PS8, Line 744: self.assert_impalad_log_contains("INFO", "Cancelled from
Impala\'s debug web "
This is still flaky for me. It fails immediately when I loop it because it
expects exactly one message. There's also an issue with the log buffering
(since it buffers for 5 secs by default).
We could add sleeps, but that's really undesirable in tests for the most part
(unless it's strictly necessary). I prototyped a better version of
assert_impalad_log_contains that retries automatically here:
https://github.com/timarmstrong/impala/tree/log_asserts . I think that would
probably be a better solution.
--
To view, visit http://gerrit.cloudera.org:8080/14782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43
Gerrit-Change-Number: 14782
Gerrit-PatchSet: 8
Gerrit-Owner: Vincent Tran
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Vincent Tran
Gerrit-Comment-Date: Wed, 11 Dec 2019 17:41:25 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 8 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Mon, 02 Dec 2019 17:43:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 4 files changed, 35 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/8 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 8 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py@743 PS7, Line 743: self.assert_impalad_log_contains > This is all a little brittle cause when you run a test cluster with start-i Oh yeah, the dockerised case is another good point. Most of the assert_impalad_log_contains uses are for custom cluster tests, which start a new cluster just for that test. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Wed, 27 Nov 2019 19:36:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/14782 )
Change subject: IMPALA-9182: Print the socket address of the client closing a
session or cancelling a query from the WebUI
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py@743
PS7, Line 743: self.assert_impalad_log_contains
> I think I need to reset the log directory location here. assert_log_contain
This is all a little brittle cause when you run a test cluster with
start-impala-cluster.py for development, it puts the logs in /cluster, but when
it's run as part of a full test run, it puts the logs in /ee_tests.
It's more important for this to pass as part of the full test rul, so
assert_log_contains() is doing the right thing by default. It's just annoying
for local development. If you start your test cluster with the below command it
should be equivalent to the jenkins run...
start-impala-cluster.py" --log_dir="${IMPALA_EE_TEST_LOGS_DIR}"
--
To view, visit http://gerrit.cloudera.org:8080/14782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43
Gerrit-Change-Number: 14782
Gerrit-PatchSet: 7
Gerrit-Owner: Vincent Tran
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Vincent Tran
Gerrit-Comment-Date: Wed, 27 Nov 2019 19:34:26 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py@743 PS7, Line 743: self.assert_impalad_log_contains > I think I need to reset the log directory location here. assert_log_contain I dug a bit more. It looks like assert_impalad_log_contains() fails because gerrit-verify-dryrun runs as a Dockerized cluster. TestLogFragments::test_log_fragments() also uses assert_impalad_log_contains() and it needs the @SkipIfDockerizedCluster.daemon_logs_not_exposed decorator. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Wed, 27 Nov 2019 19:30:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has posted comments on this change. (
http://gerrit.cloudera.org:8080/14782 )
Change subject: IMPALA-9182: Print the socket address of the client closing a
session or cancelling a query from the WebUI
..
Patch Set 7:
(1 comment)
I'll run a private parameterized job this time.
http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py@743
PS7, Line 743: self.assert_impalad_log_contains
I think I need to reset the log directory location here. assert_log_contains()
points it to EE_TEST_LOGS_DIR by default.
self.impala_log_dir = os.getenv('IMPALA_CLUSTER_LOGS_DIR')
--
To view, visit http://gerrit.cloudera.org:8080/14782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43
Gerrit-Change-Number: 14782
Gerrit-PatchSet: 7
Gerrit-Owner: Vincent Tran
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Vincent Tran
Gerrit-Comment-Date: Wed, 27 Nov 2019 02:34:11 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 7: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5301/ -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Wed, 27 Nov 2019 02:10:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 26 Nov 2019 21:33:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5301/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 26 Nov 2019 21:33:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 6 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 26 Nov 2019 21:33:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5147/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 5 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 26 Nov 2019 19:37:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5146/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 6 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 26 Nov 2019 19:36:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14782/5/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/14782/5/be/src/service/impala-http-handler.cc@239 PS5, Line 239:" $0", req.source_socket)); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 5 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran Gerrit-Comment-Date: Tue, 26 Nov 2019 18:53:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 4 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/6 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 6 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 4 files changed, 33 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/5 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 5 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Vincent Tran
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5136/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 4 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 25 Nov 2019 23:46:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5135/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 25 Nov 2019 23:45:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 4: (5 comments) Looks good overall, had a few style comments http://gerrit.cloudera.org:8080/#/c/14782/4/be/src/kudu/util/web_callback_registry.h File be/src/kudu/util/web_callback_registry.h: http://gerrit.cloudera.org:8080/#/c/14782/4/be/src/kudu/util/web_callback_registry.h@65 PS4, Line 65: // Socket address of the source of the request Might be worth documenting what the string looks like, e.g. is it "host:port"? http://gerrit.cloudera.org:8080/#/c/14782/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/14782/4/be/src/service/impala-http-handler.cc@216 PS4, Line 216: c << "Cancelled from Impala's debug web interface by client at " << req.source_socket; Can you use Substitute() instead? We generally prefer that over stringstream. http://gerrit.cloudera.org:8080/#/c/14782/4/be/src/service/impala-http-handler.cc@217 PS4, Line 217: .c_str() .c_str() shouldn't be needed, Status can take a std::string in its constructor. http://gerrit.cloudera.org:8080/#/c/14782/4/be/src/service/impala-http-handler.cc@239 PS4, Line 239: stringstream c; Same comments as above. http://gerrit.cloudera.org:8080/#/c/14782/4/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/4/tests/webserver/test_web_pages.py@733 PS4, Line 733: 1000 Can you make this shorter? Say 30s at most. The problem is that the way sleep() is implemented the query can get stuck for quite a while and interfere with other tests. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 4 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 25 Nov 2019 22:27:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 4 files changed, 36 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/4 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 4 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 ) Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14782/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/3/tests/webserver/test_web_pages.py@743 PS3, Line 743: # flake8: E265 block comment should start with '# ' -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 25 Nov 2019 22:08:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14782 Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI .. IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI This change appends the socket address (HOST:PORT) of the client who made the request to close a session or cancel a query from the coordinator's debug WebUI. Existing statuses: "Cancelled from Impala's debug web interface" "Session closed from Impala's debug web interface" New statuses: "Cancelled from Impala's debug web interface by client at :" "Session closed from Impala's debug web interface by client at :" Testing: -Verified visually that the status message is printed in the impalad log with the socket address when one cancels a query or closes a session. -Added a new e2e test to verify that the new status gets printed in runtime profile and coordinator log when a query is cancelled in this way. Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 --- M be/src/kudu/util/web_callback_registry.h M be/src/service/impala-http-handler.cc M be/src/util/webserver.cc M tests/webserver/test_web_pages.py 4 files changed, 37 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14782/3 -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran Gerrit-Reviewer: Tim Armstrong
