[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 4 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman Gerrit-Comment-Date: Fri, 12 Mar 2021 03:15:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. IMPALA-9218: Add support for locally compiled Hive - Add HIVE_VERSION_OVERRIDE, HIVE_STORAGE_API_VERSION_OVERRIDE, HIVE_METASTORE_THRIFT_DIR_OVERRIDE, HIVE_HOME_OVERRIDE environment variable support to impala-config.sh - When used together with HIVE_SRC_DIR_OVERRIDE allows a user to specify a locally compiled version of Hive for development and the minicluster - Hive jars are expected to have been installed into the local maven repository - Currently only version 3 of Hive is supported due to the absence of API shims for Hive 4.0 Example: ~/hive $ mvn package install -Pdist -DskipTests Example configuration: export HIVE_VERSION_OVERRIDE=3.1.0-SNAPSHOT export HIVE_STORAGE_API_VERSION_OVERRIDE=2.6.0 export HIVE_HOME_OVERRIDE=\ ~/hive/packaging/target/apache-hive-3.1.0-SNAPSHOT-bin/apache-hive-3.1.0-SNAPSHOT-bin export HIVE_SRC_DIR_OVERRIDE=~/hive export HIVE_METASTORE_THRIFT_DIR_OVERRIDE=~/hive/standalone-metastore/src/main/thrift/ Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Reviewed-on: http://gerrit.cloudera.org:8080/17094 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M java/pom.xml 4 files changed, 26 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 5 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 4 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman Gerrit-Comment-Date: Thu, 11 Mar 2021 21:32:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6953/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 4 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman Gerrit-Comment-Date: Thu, 11 Mar 2021 21:32:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 3: Code-Review+2 This looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 3 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman Gerrit-Comment-Date: Wed, 10 Mar 2021 00:43:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8302/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 3 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman Gerrit-Comment-Date: Sun, 07 Mar 2021 16:49:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh@254
PS3, Line 254: export
IMPALA_HIVE_STORAGE_API_VERSION=${HIVE_STORAGE_API_VERSION_OVERRIDE:-"2.3.0.$IMPALA_HIVE_VERSION"}
> line too long (105 > 90)
Going to ignore for this file.
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh@366
PS3, Line 366: export
HIVE_HOME=${HIVE_HOME_OVERRIDE:-"$CDP_COMPONENTS_HOME/apache-hive-${IMPALA_HIVE_VERSION}-bin"}
> line too long (101 > 90)
Going to ignore for this file.
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh@367
PS3, Line 367: export
HIVE_SRC_DIR=${HIVE_SRC_DIR_OVERRIDE:-"${CDP_COMPONENTS_HOME}/hive-${IMPALA_HIVE_VERSION}"}
> line too long (98 > 90)
Going to ignore for this file.
--
To view, visit http://gerrit.cloudera.org:8080/17094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34
Gerrit-Change-Number: 17094
Gerrit-PatchSet: 3
Gerrit-Owner: John Sherman
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: John Sherman
Gerrit-Comment-Date: Sun, 07 Mar 2021 16:31:49 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG@23 PS2, Line 23: export HIVE_VERSION_OVERRIDE=3.1.0-SNAPSHOT > If the long lines were for the description of what the patch is doing, that Done http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py@469 PS2, Line 469: use_override_hive = \ : "HIVE_VERSION_OVERRIDE" in os.environ and os.envi > Nit: for this, I think I would break the line right after the first equals, Done http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py@471 PS2, Line 471: > flake8: E501 line too long (91 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 3 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman Gerrit-Comment-Date: Sun, 07 Mar 2021 16:31:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh@254
PS3, Line 254: export
IMPALA_HIVE_STORAGE_API_VERSION=${HIVE_STORAGE_API_VERSION_OVERRIDE:-"2.3.0.$IMPALA_HIVE_VERSION"}
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh@366
PS3, Line 366: export
HIVE_HOME=${HIVE_HOME_OVERRIDE:-"$CDP_COMPONENTS_HOME/apache-hive-${IMPALA_HIVE_VERSION}-bin"}
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17094/3/bin/impala-config.sh@367
PS3, Line 367: export
HIVE_SRC_DIR=${HIVE_SRC_DIR_OVERRIDE:-"${CDP_COMPONENTS_HOME}/hive-${IMPALA_HIVE_VERSION}"}
line too long (98 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34
Gerrit-Change-Number: 17094
Gerrit-PatchSet: 3
Gerrit-Owner: John Sherman
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: John Sherman
Gerrit-Comment-Date: Sun, 07 Mar 2021 16:30:50 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
John Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. IMPALA-9218: Add support for locally compiled Hive - Add HIVE_VERSION_OVERRIDE, HIVE_STORAGE_API_VERSION_OVERRIDE, HIVE_METASTORE_THRIFT_DIR_OVERRIDE, HIVE_HOME_OVERRIDE environment variable support to impala-config.sh - When used together with HIVE_SRC_DIR_OVERRIDE allows a user to specify a locally compiled version of Hive for development and the minicluster - Hive jars are expected to have been installed into the local maven repository - Currently only version 3 of Hive is supported due to the absence of API shims for Hive 4.0 Example: ~/hive $ mvn package install -Pdist -DskipTests Example configuration: export HIVE_VERSION_OVERRIDE=3.1.0-SNAPSHOT export HIVE_STORAGE_API_VERSION_OVERRIDE=2.6.0 export HIVE_HOME_OVERRIDE=\ ~/hive/packaging/target/apache-hive-3.1.0-SNAPSHOT-bin/apache-hive-3.1.0-SNAPSHOT-bin export HIVE_SRC_DIR_OVERRIDE=~/hive export HIVE_METASTORE_THRIFT_DIR_OVERRIDE=~/hive/standalone-metastore/src/main/thrift/ Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M java/pom.xml 4 files changed, 26 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/17094/3 -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 3 Gerrit-Owner: John Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Sherman
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive
..
Patch Set 2:
(3 comments)
This makes sense to me. Can you add the new HIVE overrides to our
README-build.md?
https://github.com/apache/impala/blob/master/README-build.md
The other thing we may want to mention is that the HIVE_VERSION_OVERRIDE does
need to be 3.* at the moment due to how we use IMPALA_HIVE_MAJOR_VERSION
(though supporting 4.* will happen in the future).
http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG@23
PS2, Line 23: export
HIVE_HOME_OVERRIDE=~/hive/packaging/target/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin
> Not sure what the best choice here is -
If the long lines were for the description of what the patch is doing, that
would bother me, but this is for a code example. Being a bit long here doesn't
bother me much.
That said, I don't think very many people would copy-paste this, so if you want
to break up the lines, you can do line breaks wherever is easiest. Another
option is to use a shorter version number. In other words, 3.1.0-SNAPSHOT
rather than 3.1.0.3000.7.1.1.0-SNAPSHOT.
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py@469
PS2, Line 469: use_override_hive = "HIVE_VERSION_OVERRIDE" in os.environ \
: and os.environ["HIVE_VERSION_OVERRIDE"] != ""
Nit: for this, I think I would break the line right after the first equals,
like:
use_override_hive = \
"HIVE_VERSION_OVERRIDE" in os.environ and
os.environ["HIVE_VERSION_OVERRIDE"] != ""
I think that still fits in 90 characters.
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh@254
PS2, Line 254: export
IMPALA_HIVE_STORAGE_API_VERSION=${HIVE_STORAGE_API_VERSION_OVERRIDE:-"2.3.0.$IMPALA_HIVE_VERSION"}
> I've tried to use good taste in the line length here. I know there is a rec
The indentation here doesn't bother me. Shell scripts make this hard.
--
To view, visit http://gerrit.cloudera.org:8080/17094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34
Gerrit-Change-Number: 17094
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Mon, 22 Feb 2021 19:58:53 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8180/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Sat, 20 Feb 2021 18:12:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
j...@cloudera.com has posted comments on this change. (
http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG@23
PS2, Line 23: export
HIVE_HOME_OVERRIDE=~/hive/packaging/target/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin
Not sure what the best choice here is -
Should I split this line wiht a \ or is it more readable without?
http://gerrit.cloudera.org:8080/#/c/17094/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/17094/1/bin/bootstrap_toolchain.py@459
PS1, Line 459: hadoop = CdpComponent("hadoop")
line length
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh@254
PS2, Line 254: export
IMPALA_HIVE_STORAGE_API_VERSION=${HIVE_STORAGE_API_VERSION_OVERRIDE:-"2.3.0.$IMPALA_HIVE_VERSION"}
I've tried to use good taste in the line length here. I know there is a
recommended line length for C/C++/Java but I've seen examples in this file
where others have traded readability for a bit of violation of line length.
I have split one very long line below though.
I can split the lines if that is preferred by the reviewers. Just ask, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/17094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34
Gerrit-Change-Number: 17094
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Sat, 20 Feb 2021 17:40:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py@471
PS2, Line 471: y
flake8: E501 line too long (91 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh@254
PS2, Line 254: export
IMPALA_HIVE_STORAGE_API_VERSION=${HIVE_STORAGE_API_VERSION_OVERRIDE:-"2.3.0.$IMPALA_HIVE_VERSION"}
line too long (105 > 90)
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh@366
PS2, Line 366: export
HIVE_HOME=${HIVE_HOME_OVERRIDE:-"$CDP_COMPONENTS_HOME/apache-hive-${IMPALA_HIVE_VERSION}-bin"}
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/17094/2/bin/impala-config.sh@367
PS2, Line 367: export
HIVE_SRC_DIR=${HIVE_SRC_DIR_OVERRIDE:-"${CDP_COMPONENTS_HOME}/hive-${IMPALA_HIVE_VERSION}"}
line too long (98 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34
Gerrit-Change-Number: 17094
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Comment-Date: Sat, 20 Feb 2021 17:37:54 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive
j...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17094 Change subject: IMPALA-9218: Add support for locally compiled Hive .. IMPALA-9218: Add support for locally compiled Hive - Add HIVE_VERSION_OVERRIDE, HIVE_STORAGE_API_VERSION_OVERRIDE, HIVE_METASTORE_THRIFT_DIR_OVERRIDE, HIVE_HOME_OVERRIDE environment variable support to impala-config.sh - When used together with HIVE_SRC_DIR_OVERRIDE allows a user to specify a locally compiled version of Hive for development and the minicluster - Hive jars are expected to have been installed into the local maven repository Example: ~/hive $ mvn package install -Pdist -DskipTests Example configuration: export HIVE_VERSION_OVERRIDE=3.1.3000.7.1.1.0-SNAPSHOT export HIVE_STORAGE_API_VERSION_OVERRIDE=2.6.0 export HIVE_HOME_OVERRIDE=~/hive/packaging/target/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin/apache-hive-3.1.3000.7.1.1.0-SNAPSHOT-bin export HIVE_SRC_DIR_OVERRIDE=~/hive export HIVE_METASTORE_THRIFT_DIR_OVERRIDE=~/hive/standalone-metastore/src/main/thrift/ Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 --- M bin/bootstrap_toolchain.py M bin/impala-config.sh M java/pom.xml 3 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/17094/2 -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward
