[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..

IMPALA-9287: Add support for embedded HMS in CDP builds

In some situations, an embedded HMS is enough for catalogd server.
And we've already implemented this in IMPALA-8974. But after
setting USE_CDP_HIVE=true and rebuilt impala, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Reviewed-on: http://gerrit.cloudera.org:8080/15057
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M bin/bootstrap_system.sh
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 36 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 15
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 14: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 14
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Wed, 12 Feb 2020 22:54:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-12 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 13: Code-Review+2

Thanks for seeing the patch through. Looks good to me.


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Wed, 12 Feb 2020 18:02:19 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 14:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5326/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 14
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Wed, 12 Feb 2020 18:02:45 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 14: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 14
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Wed, 12 Feb 2020 18:02:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 13:

> Patch Set 13:
>
> Thanks for making the suggested change. I have triggered a job 
> https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/62 which 
> will run the core tests with the patch. Lets wait to for it to complete 
> (takes about 3-4 hours). The patch looks good to me.

I rerun the job here and it passed: 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/63/


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Tue, 11 Feb 2020 22:57:00 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 13:

Thanks for making the suggested change. I have triggered a job 
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/62 which will 
run the core tests with the patch. Lets wait to for it to complete (takes about 
3-4 hours). The patch looks good to me.


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Tue, 11 Feb 2020 05:02:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 13:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/5195/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Tue, 11 Feb 2020 03:32:49 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-10 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 13:

(3 comments)

> (2 comments)
 >
 > > > (1 comment)
 > >
 > > The error is: cannot found class PartitionExpressionForMetastore.
 > I
 > > add class one by one to keep pom files minimal, all including
 > four
 > > classed.
 >
 > Ah I see. I think this can be fixed by setting metastore.expression.proxy
 > to org.apache.hadoop.hive.metastore.DefaultPartitionExpressionProxy
 > in the hive-site.xml.py if hive_major_version >=3 here:
 > https://github.com/apache/impala/blob/master/fe/src/test/resources/hive-site.xml.py#L93
 >
 > The PartitionExpressionProxy API is only usable by Hive since it
 > uses some of its internal classes which are unavailable to non-hive
 > applications. Refer 
 > https://cwiki.apache.org/confluence/display/Hive/AdminManual+Metastore+3.0+Administration
 > standalone mode for more details.

Thanks for your code view patiently, Vihang. I've already modified code 
according to your advice.

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1065
PS12, Line 1065:   
> I would avoid making any changes to hive-2 profile since they seem unnecess
Done


http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1235
PS12, Line 1235:   runtime
> This dependency can be changed to a runtime scope here for hive-3 profile o
Done


http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml
File shaded-deps/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml@99
PS12, Line 99:   
> See my comment earlier on PartitionExpressionProxy configurations. I think
Done



--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Tue, 11 Feb 2020 02:48:08 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-10 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#13). ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..

IMPALA-9287: Add support for embedded HMS in CDP builds

In some situations, an embedded HMS is enough for catalogd server.
And we've already implemented this in IMPALA-8974. But after
setting USE_CDP_HIVE=true and rebuilt impala, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M bin/bootstrap_system.sh
M fe/pom.xml
M fe/src/test/resources/hive-site.xml.py
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 36 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/13
--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 13
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml
File shaded-deps/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/shaded-deps/pom.xml@99
PS12, Line 99: 
See my comment earlier on PartitionExpressionProxy configurations. I think 
these are not necessary if we change the default configuration values for 
metastore.



--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Mon, 10 Feb 2020 18:46:37 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 12:

(2 comments)

> > (1 comment)
 >
 > The error is: cannot found class PartitionExpressionForMetastore. I
 > add class one by one to keep pom files minimal, all including four
 > classed.

Ah I see. I think this can be fixed by setting metastore.expression.proxy to 
org.apache.hadoop.hive.metastore.DefaultPartitionExpressionProxy in the 
hive-site.xml.py if hive_major_version >=3 here: 
https://github.com/apache/impala/blob/master/fe/src/test/resources/hive-site.xml.py#L93

The PartitionExpressionProxy API is only usable by Hive since it uses some of 
its internal classes which are unavailable to non-hive applications. Refer 
https://cwiki.apache.org/confluence/display/Hive/AdminManual+Metastore+3.0+Administration
 standalone mode for more details.

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1065
PS12, Line 1065:   runtime
I would avoid making any changes to hive-2 profile since they seem unnecessary.


http://gerrit.cloudera.org:8080/#/c/15057/12/fe/pom.xml@1235
PS12, Line 1235:   ${hive.version}
This dependency can be changed to a runtime scope here for hive-3 profile only 
since we don't want to depend on it for compilation.
runtime



--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Mon, 10 Feb 2020 18:45:27 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 12:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/5137/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Thu, 06 Feb 2020 09:38:16 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-06 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 12:

> (1 comment)

The error is: cannot found class PartitionExpressionForMetastore. I add class 
one by one to keep pom files minimal, all including four classed.


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Thu, 06 Feb 2020 08:56:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-06 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 12:

(4 comments)

Thanks for your review. And I've already fixed this as possible.

http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG@7
PS10, Line 7: IMPALA-9287: Add support for embedded HMS in CDP builds
> I suggest modify the title of the JIRA which is more appropriate. Something
Done


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1210
PS10, Line 1210: 
> Since we are removing the test scope this comment can be edited/removed.
Done


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1214
PS10, Line 1214:   3.2.0-m3
> please add a runtime here, along with the comment pointing t
Done


http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1233
PS10, Line 1233:   org.apache.hive
> can you add runtime here? Also, please add a comment as to w
Done



--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Thu, 06 Feb 2020 08:54:15 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-06 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..


Patch Set 12:

> (1 comment)
 >
 > I ran a test with USE_CDP_HIVE=true and it passed:
 > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch-cdp-hive/60/
 >
 > I think we just need to make sure the addition in pom files is
 > minimal.

Thanks for ran test, Quanlong. I've already reduce some unnecessary classes to 
keep pom files minimal.


--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng 
Gerrit-Comment-Date: Thu, 06 Feb 2020 08:52:03 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9287: Add support for embedded HMS in CDP builds

2020-02-06 Thread wangsheng (Code Review)
wangsheng has uploaded a new patch set (#12). ( 
http://gerrit.cloudera.org:8080/15057 )

Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds
..

IMPALA-9287: Add support for embedded HMS in CDP builds

In some situations, an embedded HMS is enough for catalogd server.
And we've already implemented this in IMPALA-8974. But after
setting USE_CDP_HIVE=true and rebuilt impala, the custom cluster
test case test_kudu_table_create_without_hms would failed due to
lacking of related jars. The solution is to add related maven
dependency in $IMPALA_HOME/fe/pom.xml and
$IMPALA_HOME/shaded-deps/pom.xml.

Tests:
  * Ran test_kudu_table_create_without_hms.py by setting
  USE_CDP_HIVE=true locally

Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
---
M bin/bootstrap_system.sh
M fe/pom.xml
M shaded-deps/pom.xml
M tests/custom_cluster/test_kudu_table_create_without_hms.py
4 files changed, 37 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/15057/12
--
To view, visit http://gerrit.cloudera.org:8080/15057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66
Gerrit-Change-Number: 15057
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: wangsheng