[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. The file atomicops-internals-arm64.h is originally from here: https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h and the commit hash is ec021f5. And I changed some instructions to newer version base the original file, such as ldxr + memory barrier was changed to ldaxr which has memory barrier natively. And also added some funtions which impala use. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- M be/src/common/init.cc A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 4 files changed, 481 insertions(+), 0 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 22: Rebasing this patch which the verify job was running prevented it getting merged. I'm going to merge PS22 manually. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 10 Apr 2020 16:55:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 23: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5781/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 23 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 10 Apr 2020 07:12:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#23). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. The file atomicops-internals-arm64.h is originally from here: https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h and the commit hash is ec021f5. And I changed some instructions to newer version base the original file, such as ldxr + memory barrier was changed to ldaxr which has memory barrier natively. And also added some funtions which impala use. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- M be/src/common/init.cc A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 4 files changed, 481 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/23 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 23 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 22: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 10 Apr 2020 03:03:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Apr 2020 22:25:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 22: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5636/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 22 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Apr 2020 22:25:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 21: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5767/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Apr 2020 02:37:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 21: Hi, Tim. This has been modified as your request. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Apr 2020 01:57:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG@13 PS18, Line 13: https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h > Ok cool, I did a diff against that version to review it. Hi, Tim. I agree with you very much, Ultimately we better update to use chromium's platform-independent version. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 09 Apr 2020 01:56:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. The file atomicops-internals-arm64.h is originally from here: https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h and the commit hash is ec021f5. And I changed some instructions to newer version base the original file, such as ldxr + memory barrier was changed to ldaxr which has memory barrier natively. And also added some funtions which impala use. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- M be/src/common/init.cc A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 4 files changed, 481 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/21 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 20: (2 comments) OK, I'm pretty much ready to +2, just had a minor request. http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG@13 PS18, Line 13: Here add arm64 atomic ops implementation. > Hi, Tim, it is originally from here:https://github.com/protocolbuffers/prot Ok cool, I did a diff against that version to review it. I think it would ultimately be nice to update to use chromium's platform-independent versions - I filed IMPALA-9623 for that. But this approach is consistent with the current codebase so OK for now. http://gerrit.cloudera.org:8080/#/c/15300/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/20//COMMIT_MSG@10 PS20, Line 10: Can you include a link to the protobuf repo and mention the commit hash that you got it from. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 08 Apr 2020 17:00:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 20: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5751/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 08 Apr 2020 12:48:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG@13 PS18, Line 13: Here add arm64 atomic ops implementation. > Can you mention where you got the implementations from? I.e. which reposito Hi, Tim, it is originally from here:https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc. And I changed something for newer instructions and for adapt impala http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/common/init.cc@307 PS16, Line 307: #ifndef THREAD_SANITIZER : #ifndef __aarch64__ > nit: Instead of nested ifndefs, can it be the following? Yes, Zoltan, Of course, it can be http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/gutil/cpu.cc File be/src/gutil/cpu.cc: http://gerrit.cloudera.org:8080/#/c/15300/16/be/src/gutil/cpu.cc@274 PS16, Line 274: has_broken_neon_ = false; > Could you add a comment about why can we set it to false here? Hi, Zoltan, broken neon is a bug of an old arm cpu, and it is 32bit cpu. Aarch64 cpu don' t have this issue. You can find details here: https://code.google.com/p/chromium/issues/detail?id=341598 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 08 Apr 2020 12:44:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- M be/src/common/init.cc A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 4 files changed, 481 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/20 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5634/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Sat, 28 Mar 2020 14:16:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- M be/src/common/init.cc A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 4 files changed, 481 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/13 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 9: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5523/ -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Mar 2020 21:04:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 9: I'm not planning to take a look unless you think the extra eyes are needed. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Mar 2020 20:48:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5568/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Mar 2020 16:38:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5569/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Mar 2020 16:28:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 3 files changed, 479 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/9 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5523/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Mar 2020 16:09:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/15300/7/be/src/gutil/atomicops-internals-arm64.h File be/src/gutil/atomicops-internals-arm64.h: http://gerrit.cloudera.org:8080/#/c/15300/7/be/src/gutil/atomicops-internals-arm64.h@183 PS7, Line 183: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15300/7/be/src/gutil/atomicops-internals-arm64.h@198 PS7, Line 198: ); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/15300/7/be/src/gutil/atomicops-internals-arm64.h@198 PS7, Line 198: ); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 23 Mar 2020 15:58:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 3 files changed, 480 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/7 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 4: Code-Review+1 LGTM. Tim or Zoltan, do you want to take a look? -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Sun, 22 Mar 2020 14:35:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 19 Mar 2020 16:31:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5527/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 19 Mar 2020 12:16:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5493/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 19 Mar 2020 11:32:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 3 files changed, 361 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/4 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5355/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 27 Feb 2020 07:37:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15300 Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Different arc have diffent implementation. Here add arm64 atomic ops implementation. Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd --- A be/src/gutil/atomicops-internals-arm64.h M be/src/gutil/atomicops.h M be/src/gutil/cpu.cc 3 files changed, 373 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/15300/3 -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
