[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 4 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 23:33:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. IMPALA-9910: [DOCS] update retry failed queries query option Added why cluster membership changes typically occur. Explained how the coordinator will retry a failed query. Talked about the new query option spool_all_results_for_retries. Incorporated corrections from Patch set 2. Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Reviewed-on: http://gerrit.cloudera.org:8080/16819 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M docs/topics/impala_retry_failed_queries.xml 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 5 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/370/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 4 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 23:26:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 4 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 23:26:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 3: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 3 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 23:24:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/627/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 3 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 18:23:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/627/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 3 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 01 Apr 2021 18:16:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16819 to look at the new patch set (#3). Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. IMPALA-9910: [DOCS] update retry failed queries query option Added why cluster membership changes typically occur. Explained how the coordinator will retry a failed query. Talked about the new query option spool_all_results_for_retries. Incorporated corrections from Patch set 2. Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 --- M docs/topics/impala_retry_failed_queries.xml 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/16819/3 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 3 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 2: (4 comments) Thanks, this is looking better http://gerrit.cloudera.org:8080/#/c/16819/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16819/2//COMMIT_MSG@9 PS2, Line 9: added why cluster membership changes typically occur This seems to be about Patchset 2. The commit message should describe the whole change. Also please use sentences with capital letters and end with a period. http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml File docs/topics/impala_retry_failed_queries.xml: http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml@40 PS2, Line 40: blacklisted by the Impala Coordinator and if a SELECT query fails due to a cluster membership This is too complex. End the sentence with "Coordinator." and then start another with "If ..." http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml@49 PS2, Line 49: spool_all_results_for_retries. Should this say something like "set the spool_all_results_for_retries query option"? http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml@53 PS2, Line 53: ENABLED If the type is BOOLEAN won't this be TRUE ? -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 23:26:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/626/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 22:52:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/626/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 22:31:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16819 to look at the new patch set (#2). Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. IMPALA-9910: [DOCS] update retry failed queries query option added why cluster membership changes typically occur explained how the coordinator will retry a failed query talked about the new query option spool_all_results_for_retries Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 --- M docs/topics/impala_retry_failed_queries.xml 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/16819/2 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 1: (4 comments) I have a few suggestions http://gerrit.cloudera.org:8080/#/c/16819/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16819/1//COMMIT_MSG@9 PS1, Line 9: elaborated the existing content Can you make these into complete sentences please? Take a look at other Impala commit messages to see the standard we are aiming for. http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml File docs/topics/impala_retry_failed_queries.xml: http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml@39 PS1, Line 39: If a SELECT query fails due to a cluster membership change, the Coordinator will cancel and I think we should try to include "Cluster membership changes typically occur when an impalad crashes, or if the node is blacklisted by the Impala Coordinator" from the old text. http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml@40 PS1, Line 40: unregister the running query and then launch a retry of the query. For e.g., if one of the Instead of "For e.g." I think "For example" is clearer http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml@43 PS1, Line 43: executor nodes. This feature will support retrying the entire query and NOT the individual This feature supports -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 31 Mar 2021 21:35:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/609/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Dec 2020 21:55:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/609/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 03 Dec 2020 21:47:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option
Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16819 Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. IMPALA-9910: [DOCS] update retry failed queries query option elaborated the existing content talked about the new query option spool_all_results_for_retries Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 --- M docs/topics/impala_retry_failed_queries.xml 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/16819/1 -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh
