[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4246/ -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 14 May 2019 02:53:19 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3208/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 14 May 2019 01:00:44 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4246/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 14 May 2019 00:47:24 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Code-Review+2 (1 comment) Looks good http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: load_table_ > How about deferring this change to later? Want to make a quick incremental Yes, this is not a blocker. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 14 May 2019 00:22:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13259 to look at the new patch set (#3). Change subject: Improve output for generate-schema-statements.py .. Improve output for generate-schema-statements.py The old output was a big wall of text that made it difficult to read for developers. This patch changes the output to use PrettyTable and output a table with a row for each test table to be loaded or skipped. For example: Target Dataset: tpcds ++---++-+ | DB | Table | Status | Notes | ++---++-+ | tpcds | call_center | SKIP | /test-warehouse/tpcds.call_center contains data | | tpcds | catalog_page | SKIP | /test-warehouse/tpcds.catalog_page contains data| | tpcds | catalog_returns | SKIP | /test-warehouse/tpcds.catalog_returns contains data | | tpcds | catalog_sales | SKIP | /test-warehouse/tpcds.catalog_sales contains data | ... | tpcds | store_returns | SKIP | /test-warehouse/tpcds.store_returns contains data | | tpcds | store_sales | LOAD | /test-warehouse/tpcds.store_sales does not exist or empty. | ... | tpcds_seq_snap | store_sales_unpartitioned | SKIP | format not in included list: ['text/none/none'] | ++---++-+ Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 --- M testdata/bin/generate-schema-statements.py 1 file changed, 74 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/13259/3 -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@538 PS1, Line 538: def _get_component_version(name): > nit: maybe TabularLogOutput or something more verbose? Done http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@622 PS1, Line 622: es > nit: use " for the whole string just like in L616? Done http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@809 PS1, Line 809: ba > I'm still working on it :). I've only done the toolchain-side change so far Done http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: if insert > I was about to comment something about using the --verbose flag, but then I How about deferring this change to later? Want to make a quick incremental improvement here and not scope creep to also creating new log files, etc. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 13 May 2019 23:31:20 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3111/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 May 2019 20:20:20 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: out_status.dump() > hm, I actually went down this path because I was trying to understand why d I was about to comment something about using the --verbose flag, but then I realized that literally nothing in this file uses that flag. I don't have particularly strong feelings. I think it is fine to print to the console, but can we also dump it to a file? I'm more likely to grep the file than to hunt through the console. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 May 2019 20:03:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Hello Vihang Karajgaonkar, Zoltan Borok-Nagy, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13259 to look at the new patch set (#2). Change subject: Improve output for generate-schema-statements.py .. Improve output for generate-schema-statements.py The old output was a big wall of text that made it difficult to read for developers. This patch changes the output to use PrettyTable and output a table with a row for each test table to be loaded or skipped. For example: Target Dataset: tpcds ++---++-+ | DB | Table | Status | Notes | ++---++-+ | tpcds | call_center | SKIP | /test-warehouse/tpcds.call_center contains data | | tpcds | catalog_page | SKIP | /test-warehouse/tpcds.catalog_page contains data| | tpcds | catalog_returns | SKIP | /test-warehouse/tpcds.catalog_returns contains data | | tpcds | catalog_sales | SKIP | /test-warehouse/tpcds.catalog_sales contains data | ... | tpcds | store_returns | SKIP | /test-warehouse/tpcds.store_returns contains data | | tpcds | store_sales | LOAD | /test-warehouse/tpcds.store_sales does not exist or empty. | ... | tpcds_seq_snap | store_sales_unpartitioned | SKIP | format not in included list: ['text/none/none'] | ++---++-+ Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 --- M testdata/bin/generate-schema-statements.py 1 file changed, 74 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/13259/2 -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@809
PS1, Line 809: {}
> I think with Tim's latest change we are now using Python 2.7 from the toolc
I'm still working on it :). I've only done the toolchain-side change so far.
--
To view, visit http://gerrit.cloudera.org:8080/13259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072
Gerrit-Change-Number: 13259
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Tim Armstrong
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Tue, 07 May 2019 18:52:44 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@809
PS1, Line 809: {}
> Python 2.6 doesn't support {}. It needs to be {0}.
I think with Tim's latest change we are now using Python 2.7 from the toolchain
for all these scripts, right? ie since we are using 'impala-python' it's
guaranteed to be 2.7?
--
To view, visit http://gerrit.cloudera.org:8080/13259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072
Gerrit-Change-Number: 13259
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Tue, 07 May 2019 18:39:50 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: out_status.dump() > What do you think about dumping this to a file rather than stdout? I think hm, I actually went down this path because I was trying to understand why different sets of tables were being selected during a data load. I think when you are running 'buildall.sh' this already gets piped to a file, no? It's only if you are explicitly calling load-data.py in which case I think the output's nice. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 May 2019 18:27:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Joe McDonnell has posted comments on this change. (
http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@809
PS1, Line 809: {}
Python 2.6 doesn't support {}. It needs to be {0}.
http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861
PS1, Line 861: out_status.dump()
What do you think about dumping this to a file rather than stdout? I think it
would be more useful for it to go to a file alongside all the SQL files. I
personally don't feel like this output is useful to a developer running these
things from the console.
--
To view, visit http://gerrit.cloudera.org:8080/13259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072
Gerrit-Change-Number: 13259
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Vihang Karajgaonkar
Gerrit-Reviewer: Zoltan Borok-Nagy
Gerrit-Comment-Date: Tue, 07 May 2019 17:50:27 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4168/ -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 May 2019 14:43:25 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: Code-Review+1 (2 comments) LGTM, I'm not sure if there are any tools that depend on the original output, so that's why I only gave it +1. http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@538 PS1, Line 538: class LogOutput(object): nit: maybe TabularLogOutput or something more verbose? http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@622 PS1, Line 622: \' nit: use " for the whole string just like in L616? -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 07 May 2019 14:15:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3099/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 07 May 2019 09:20:16 + Gerrit-HasComments: No
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13259 to review the following change. Change subject: Improve output for generate-schema-statements.py .. Improve output for generate-schema-statements.py The old output was a big wall of text that made it difficult to read for developers. This patch changes the output to use PrettyTable and output a table with a row for each test table to be loaded or skipped. For example: Target Dataset: tpcds ++---++-+ | DB | Table | Status | Notes | ++---++-+ | tpcds | call_center | SKIP | /test-warehouse/tpcds.call_center contains data | | tpcds | catalog_page | SKIP | /test-warehouse/tpcds.catalog_page contains data| | tpcds | catalog_returns | SKIP | /test-warehouse/tpcds.catalog_returns contains data | | tpcds | catalog_sales | SKIP | /test-warehouse/tpcds.catalog_sales contains data | ... | tpcds | store_returns | SKIP | /test-warehouse/tpcds.store_returns contains data | | tpcds | store_sales | LOAD | /test-warehouse/tpcds.store_sales does not exist or empty. | ... | tpcds_seq_snap | store_sales_unpartitioned | SKIP | format not in included list: ['text/none/none'] | ++---++-+ Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 --- M testdata/bin/generate-schema-statements.py 1 file changed, 73 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/13259/1 -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] Improve output for generate-schema-statements.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4168/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 07 May 2019 07:51:00 + Gerrit-HasComments: No
