[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17948/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17948/8//COMMIT_MSG@13 PS8, Line 13: hided nit: hidden -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 8 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 16 Nov 2021 20:02:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9787/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 8 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 16 Nov 2021 16:51:28 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Wenzhe Zhou has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala There are some API changes in the new version of protobuf library. This patch makes necessary changes for Impala code to pass compiling. Upgrade Kudu to version 1754f517b2. With the new version of Kudu, the protobuf symbols in libkudu_client.so are hided. This solved the static initialization conflicts between two copies of protobuf library in impalad's binary - one is linked by Impala itself for KRPC communication, another is linked into Kudu client shared library. Testing: - Passed core DEBUG build and exhaustive release build. - TODO pass a core ASAN build Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 --- M be/src/gutil/dynamic_annotations.h M be/src/kudu/rpc/exactly_once_rpc-test.cc M be/src/kudu/rpc/inbound_call.cc M be/src/kudu/rpc/outbound_call.cc M be/src/kudu/rpc/result_tracker.h M be/src/kudu/rpc/serialization.cc M be/src/kudu/rpc/serialization.h M be/src/kudu/util/pb_util.cc M be/src/kudu/util/protobuf_util.h M bin/impala-config.sh M testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl 11 files changed, 75 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/17948/8 -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 8 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17948/5/be/src/kudu/rpc/result_tracker.h File be/src/kudu/rpc/result_tracker.h: http://gerrit.cloudera.org:8080/#/c/17948/5/be/src/kudu/rpc/result_tracker.h@286 PS5, Line 286:0) > The length of previous line is already 90, have to break it as two lines to Ok, I see. For some reason Gerrit is not showing the 90 character limit line for me. Since this is Kudu code transplanted into Impala, I would also be ok with leaving it however Kudu has it (and ignoring warnings about it). -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 11 Nov 2021 17:52:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9739/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Tue, 09 Nov 2021 03:17:50 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Wenzhe Zhou has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala There are some API changes in the new version of protobuf library. This patch makes necessary changes for Impala code to pass compiling. Upgrade Kudu to 5d39a74a19. With the new version of Kudu, the protobuf symbols in libkudu_client.so are hided. This solved the static initialization conflicts between two copies of protobuf library in impalad's binary - one is linked by Impala itself for KRPC communication, another is linked into Kudu client shared library. Testing: - Passed core DEBUG build and exhaustive release build. - TODO pass a core ASAN build Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 --- M be/src/gutil/dynamic_annotations.h M be/src/kudu/rpc/exactly_once_rpc-test.cc M be/src/kudu/rpc/inbound_call.cc M be/src/kudu/rpc/outbound_call.cc M be/src/kudu/rpc/result_tracker.h M be/src/kudu/rpc/serialization.cc M be/src/kudu/rpc/serialization.h M be/src/kudu/util/pb_util.cc M be/src/kudu/util/protobuf_util.h M bin/impala-config.sh M testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl 11 files changed, 74 insertions(+), 50 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/17948/5 -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/9723/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou Gerrit-Comment-Date: Thu, 04 Nov 2021 22:20:40 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17948 ) Change subject: WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala .. WIP IMPALA-10951 (part 2): Upgrade protobuf library to 3.14.0 for Impala There are some API changes in the new version of protobuf library. This patch makes necessary changes for Impala code to pass compiling. It also adds a work around for the static initializer issue, which is caused by the conflicts between two copies of protobuf library in impalad's binary, one came from Kudu client shared library. Testing: - Passed core DEBUG build and exhaustive DEBUG build. - TODO pass a core ASAN build Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 --- M be/src/kudu/rpc/exactly_once_rpc-test.cc M be/src/kudu/rpc/inbound_call.cc M be/src/kudu/rpc/outbound_call.cc M be/src/kudu/rpc/result_tracker.h M be/src/kudu/rpc/serialization.cc M be/src/kudu/rpc/serialization.h M be/src/kudu/util/pb_util.cc M be/src/kudu/util/protobuf_util.h M be/src/rpc/rpc-mgr.cc M bin/impala-config.sh 10 files changed, 113 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/17948/4 -- To view, visit http://gerrit.cloudera.org:8080/17948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1df4faceff9fda169c9d15fe8b1e69cfabe0d43 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Wenzhe Zhou