[Impala-ASF-CR] IMPALA-4883: Union Codegen
Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6459/7/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: PS7, Line 34: t_batch->CommitLast Is this not used at all ? PS7, Line 45: There is a macro called FOREACH_ROW() which is useful for iterating through rows in a row batch. It will save some cycles as it avoids the multiplication in GetRow(). http://gerrit.cloudera.org:8080/#/c/6459/1/be/src/exec/union-node.h File be/src/exec/union-node.h: PS1, Line 71: tuple_pool_; > Michael, do you think it makes sense to use this approach for now? I'm not I agree that we should not mix in the fix for CodegenMaterializeExprs() in this patch. We probably need to fix other places such as TopNNode. -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer
Michael Ho has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 6: Code-Review+1 Carry previous +1 forward. -- To view, visit http://gerrit.cloudera.org:8080/6107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer
Michael Ho has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 6: (2 comments) I think we should support writing sequence file. This change have fixed some bugs to get the sequence file writer to work but it's unclear to me if the existing tests have enough coverage. May help to think through the testing first before moving it out of the flag. http://gerrit.cloudera.org:8080/#/c/6107/6/be/src/exec/read-write-util.h File be/src/exec/read-write-util.h: PS6, Line 247: DCHECK(val < -112); nit: DCHECK_LT(val, -112); PS6, Line 258: DCHECK(val > 127); nit: DCHECK_GT(val, 127); -- To view, visit http://gerrit.cloudera.org:8080/6107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) First publishing of Apache Impala (incubating) documentation to the Apache web site.
Laurel Hale has uploaded a new change for review. http://gerrit.cloudera.org:8080/6601 Change subject: First publishing of Apache Impala (incubating) documentation to the Apache web site. .. First publishing of Apache Impala (incubating) documentation to the Apache web site. Change-Id: If33c03c9d6e64f3974756df50b0777eeb1333ed8 --- A docs/build/html/commonltr.css A docs/build/html/commonrtl.css A docs/build/html/images/howto_access_control.png A docs/build/html/images/howto_per_node_peak_memory_usage.png A docs/build/html/images/howto_show_histogram.png A docs/build/html/images/howto_static_server_pools_config.png A docs/build/html/images/impala_arch.jpeg A docs/build/html/images/support_send_diagnostic_data.png A docs/build/html/index.html A docs/build/html/shared/ImpalaVariables.html A docs/build/html/shared/impala_common.html A docs/build/html/topics/impala_abort_on_default_limit_exceeded.html A docs/build/html/topics/impala_abort_on_error.html A docs/build/html/topics/impala_admin.html A docs/build/html/topics/impala_admission.html A docs/build/html/topics/impala_aggregate_functions.html A docs/build/html/topics/impala_aliases.html A docs/build/html/topics/impala_allow_unsupported_formats.html A docs/build/html/topics/impala_alter_table.html A docs/build/html/topics/impala_alter_view.html A docs/build/html/topics/impala_analytic_functions.html A docs/build/html/topics/impala_appx_count_distinct.html A docs/build/html/topics/impala_appx_median.html A docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_auditing.html A docs/build/html/topics/impala_authentication.html A docs/build/html/topics/impala_authorization.html A docs/build/html/topics/impala_avg.html A docs/build/html/topics/impala_avro.html A docs/build/html/topics/impala_batch_size.html A docs/build/html/topics/impala_bigint.html A docs/build/html/topics/impala_bit_functions.html A docs/build/html/topics/impala_boolean.html A docs/build/html/topics/impala_breakpad.html A docs/build/html/topics/impala_char.html A docs/build/html/topics/impala_cluster_sizing.html A docs/build/html/topics/impala_comments.html A docs/build/html/topics/impala_complex_types.html A docs/build/html/topics/impala_components.html A docs/build/html/topics/impala_compression_codec.html A docs/build/html/topics/impala_compute_stats.html A docs/build/html/topics/impala_concepts.html A docs/build/html/topics/impala_conditional_functions.html A docs/build/html/topics/impala_config.html A docs/build/html/topics/impala_config_options.html A docs/build/html/topics/impala_config_performance.html A docs/build/html/topics/impala_connecting.html A docs/build/html/topics/impala_conversion_functions.html A docs/build/html/topics/impala_count.html A docs/build/html/topics/impala_create_database.html A docs/build/html/topics/impala_create_function.html A docs/build/html/topics/impala_create_role.html A docs/build/html/topics/impala_create_table.html A docs/build/html/topics/impala_create_view.html A docs/build/html/topics/impala_databases.html A docs/build/html/topics/impala_datatypes.html A docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_ddl.html A docs/build/html/topics/impala_debug_action.html A docs/build/html/topics/impala_decimal.html A docs/build/html/topics/impala_default_order_by_limit.html A docs/build/html/topics/impala_delegation.html A docs/build/html/topics/impala_delete.html A docs/build/html/topics/impala_describe.html A docs/build/html/topics/impala_development.html A docs/build/html/topics/impala_disable_codegen.html A docs/build/html/topics/impala_disable_row_runtime_filtering.html A docs/build/html/topics/impala_disable_streaming_preaggregations.html A docs/build/html/topics/impala_disable_unsafe_spills.html A docs/build/html/topics/impala_disk_space.html A docs/build/html/topics/impala_distinct.html A docs/build/html/topics/impala_dml.html A docs/build/html/topics/impala_double.html A docs/build/html/topics/impala_drop_database.html A docs/build/html/topics/impala_drop_function.html A docs/build/html/topics/impala_drop_role.html A docs/build/html/topics/impala_drop_stats.html A docs/build/html/topics/impala_drop_table.html A docs/build/html/topics/impala_drop_view.html A docs/build/html/topics/impala_exec_single_node_rows_threshold.html A docs/build/html/topics/impala_explain.html A docs/build/html/topics/impala_explain_level.html A docs/build/html/topics/impala_explain_plan.html A docs/build/html/topics/impala_faq.html A docs/build/html/topics/impala_file_formats.html A docs/build/html/topics/impala_fixed_issues.html A docs/build/html/topics/impala_float.html A docs/build/html/topics/impala_functions.html A docs/build/html/topics/impala_functions_overview.html A docs/build/html/topics/impala_grant.html A docs/build/html/topics/impala_group_by.html A docs/build/html/topics/impala_group_concat.html A docs/build/html/topics/impala_hadoop.h
[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP types stored in Kudu. Impala stores TIMESTAMP values in 96-bits and has nanosecond precision. Kudu's timestamp is a 64-bit microsecond delta from the Unix epoch (called UNIXTIME_MICROS), so a conversion is necessary. TODO: As of now, this only supports writing TIMESTAMPs to Kudu. Reading will require the Kudu client to return UNIXTIME_MICROS in a padded slot for Impala. In the meantime, an exception is thrown in the FE when attempting to read from a TIMESTAMP from a Kudu table. Some tests were added using the python Kudu client to read the results, but more tests will be added when Impala can read as well. Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d --- M be/src/exec/kudu-table-sink.cc M be/src/runtime/timestamp-test.cc M be/src/runtime/timestamp-value.h M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java M fe/src/main/java/org/apache/impala/util/KuduUtil.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M tests/query_test/test_kudu.py 7 files changed, 122 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/6526/3 -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Matthew Jacobs
[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6526/2/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:
Line 301: DCHECK(tv->UtcToUnixTimeMicros(&ts_micros));
> This seems to rely on a side effect but it would not execute in a release b
good point, thanks
http://gerrit.cloudera.org:8080/#/c/6526/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
Line 124: String colName = desc.getColumn().getName();
> Nit: move colName into the if block.
Done
http://gerrit.cloudera.org:8080/#/c/6526/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:
Line 1958: AnalyzesOk("create table tab (x timestamp, y timestamp, primary
key(x, y)) " +
> do we have a test where TS is not a PK and/or not a partition column?
no I'll just adjust this one, I don't think both need to be PKs it's not really
covering anything interesting
--
To view, visit http://gerrit.cloudera.org:8080/6526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs
Gerrit-Reviewer: Dan Hecht
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Matthew Jacobs
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause
Lars Volker has posted comments on this change.
Change subject: IMPALA-4166: Add SORT BY sql clause
..
Patch Set 12:
(5 comments)
Thank you Alex for the review. Please see my inline comments and PS13.
http://gerrit.cloudera.org:8080/#/c/6495/9/fe/src/main/java/org/apache/impala/analysis/TablePropertyAnalyzer.java
File fe/src/main/java/org/apache/impala/analysis/TablePropertyAnalyzer.java:
Line 85:*/
Each of the public methods is called at least twice from elsewhere so inlining
them seems wasteful. For cases where we don't have a table yet (e.g. create
table statements), I can't think of an interface that's much better than this.
Should we build lookup tables for the column lists first to address your
performance considerations? We could also try build an interface and dummy
table for cases where we don't have a table yet.
Should we discuss this in a short meeting?
Line 114: }
> Does this mean we need 2 ALTER statements to drop/rename a column?
Yes, currently that's the case. I think we discussed this in person once, too,
but I don't remember what we decided to do. Do you have a preference? Should
the drop/rename statement fail if the columns is still referenced in the sort
by list? Or at least issue a warning?
Line 115: if (!foundColumn) {
Yes, in AnalyzeDDLStmts.java.
http://gerrit.cloudera.org:8080/#/c/6495/9/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:
Line 458:*/
> Preconditions.checkStats(RuntimeEnv.isTestEnv());
Cool, done.
http://gerrit.cloudera.org:8080/#/c/6495/9/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test
File
testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test:
Line 170: # IMPALA-4166: sort by columns are correct when using a partial
column permutation.
> What if neither bool_col or int_col are mentioned in the column permutation
No, constant exprs are removed from the sortby list in the Planner, and for an
empty list we don't create a sort node at all. I added a test to make sure this
works as intended.
--
To view, visit http://gerrit.cloudera.org:8080/6495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Dimitris Tsirogiannis
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Marcel Kornacker
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#13). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166: Add SORT BY sql clause This change adds support for adding SORT BY (...) clauses to CREATE TABLE and ALTER TABLE statements. Examples are: CREATE TABLE t (i INT, j INT, k INT) PARTITIONED BY (l INT) SORT BY (i, j); CREATE TABLE t (i INT, x INT PRIMARY KEY) PARTITION BY HASH(x) PARTITIONS 8 SORT BY(i) STORED AS KUDU; CREATE TABLE t SORT BY (int_col,id) LIKE u; CREATE TABLE t LIKE PARQUET '/foo' SORT BY (id,zip); ALTER TABLE t SORT BY (int_col,id); ALTER TABLE t SORT BY (); SORT BY columns can be specified for all table types, but effectiveness may vary based on table type, for example TEXT tables will not see improved compression. The SORT BY clause must not contain clustering columns for HDFS tables, and must not contain primary key columns for Kudu tables. The columns in the SORT BY clause are stored in the 'sort.by.columns' table property and will result in an additional SORT node being added to the plan before the final table sink. Specifying SORT BY columns also enables clustering during inserts, so the SORT node will contain all partitioning columns first, followed by the SORT BY columns. We do this because SORT BY columns add a SORT node to the plan and adding the clustering columns to the SORT node is cheap. SORT BY columns supersede the sortby() hint, which we will remove in a subsequent change (IMPALA-5144). This change introduces a new TablePropertyAnalyzer class to collect various methods used to analyze table properties. Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 --- M common/thrift/JniCatalog.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java A fe/src/main/java/org/apache/impala/analysis/AlterTableSortByColumnsStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java A fe/src/main/java/org/apache/impala/analysis/TablePropertyAnalyzer.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/Column.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/ddl.test A testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test M testdata/workloads/functional-planner/queries/PlannerTest/insert.test M testdata/workloads/functional-query/queries/QueryTest/alter-table.test M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test M testdata/workloads/functional-query/queries/QueryTest/create-table.test M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test 33 files changed, 1,234 insertions(+), 85 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/6495/13 -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#12). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166: Add SORT BY sql clause This change adds support for adding SORT BY (...) clauses to CREATE TABLE and ALTER TABLE statements. Examples are: CREATE TABLE t (i INT, j INT, k INT) PARTITIONED BY (l INT) SORT BY (i, j); CREATE TABLE t (i INT, x INT PRIMARY KEY) PARTITION BY HASH(x) PARTITIONS 8 SORT BY(i) STORED AS KUDU; CREATE TABLE t SORT BY (int_col,id) LIKE u; CREATE TABLE t LIKE PARQUET '/foo' SORT BY (id,zip); ALTER TABLE t SORT BY (int_col,id); ALTER TABLE t SORT BY (); SORT BY columns can be specified for all table types, but effectiveness may vary based on table type, for example TEXT tables will not see improved compression. The SORT BY clause must not contain clustering columns for HDFS tables, and must not contain primary key columns for Kudu tables. The columns in the SORT BY clause are stored in the 'sort.by.columns' table property and will result in an additional SORT node being added to the plan before the final table sink. Specifying SORT BY columns also enables clustering during inserts, so the SORT node will contain all partitioning columns first, followed by the SORT BY columns. We do this because SORT BY columns add a SORT node to the plan and adding the clustering columns to the SORT node is cheap. SORT BY columns supersede the sortby() hint, which we will remove in a subsequent change (IMPALA-5144). This change introduces a new TablePropertyAnalyzer class to collect various methods used to analyze table properties. Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 --- M common/thrift/JniCatalog.thrift M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java A fe/src/main/java/org/apache/impala/analysis/AlterTableSortByColumnsStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java A fe/src/main/java/org/apache/impala/analysis/TablePropertyAnalyzer.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/Column.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/ddl.test A testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test M testdata/workloads/functional-planner/queries/PlannerTest/insert.test M testdata/workloads/functional-query/queries/QueryTest/alter-table.test M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test M testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test M testdata/workloads/functional-query/queries/QueryTest/create-table.test M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test 33 files changed, 1,234 insertions(+), 85 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/6495/12 -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP
Lars Volker has posted comments on this change.
Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6526/2/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:
Line 301: DCHECK(tv->UtcToUnixTimeMicros(&ts_micros));
This seems to rely on a side effect but it would not execute in a release build.
bool ret = ...; DCHECK(ret);
http://gerrit.cloudera.org:8080/#/c/6526/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
Line 124: String colName = desc.getColumn().getName();
Nit: move colName into the if block.
http://gerrit.cloudera.org:8080/#/c/6526/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:
Line 1958: AnalyzesOk("create table tab (x timestamp, y timestamp, primary
key(x, y)) " +
do we have a test where TS is not a PK and/or not a partition column?
--
To view, visit http://gerrit.cloudera.org:8080/6526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs
Gerrit-Reviewer: Dan Hecht
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Lars Volker
Gerrit-Reviewer: Matthew Jacobs
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3224: De-Cloudera non-docs JIRA URLs
Lars Volker has posted comments on this change. Change subject: IMPALA-3224: De-Cloudera non-docs JIRA URLs .. Patch Set 2: (9 comments) I marked more places that could be wrapped into a single line. I meant to say that there's more of them than the one I highlighted in my last reply - apologies if that was not clear. Now I should have caught all of them. http://gerrit.cloudera.org:8080/#/c/6487/2/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: Line 38: # TODO: We need a better way of managing how these get set. See: nit: single line? Line 185: # See IMPALA-4347 nit: single line? Line 345: # See IMPALA-4347 nit: single line? Line 418: # See IMPALA-4347 nit: single line? http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/db_connection.py File tests/comparison/db_connection.py: Line 837: # IMPALA-2562. nit: single line? http://gerrit.cloudera.org:8080/#/c/6487/2/tests/comparison/discrepancy_searcher.py File tests/comparison/discrepancy_searcher.py: Line 193: 'IMPALA-865') nit: single line? Line 198: 'IMPALA-724') nit: single line? http://gerrit.cloudera.org:8080/#/c/6487/2/tests/custom_cluster/test_kudu_not_available.py File tests/custom_cluster/test_kudu_not_available.py: Line 47: # IMPALA-3233 nit: single line? http://gerrit.cloudera.org:8080/#/c/6487/2/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: Line 904: # IMPALA-2234 nit: single line? -- To view, visit http://gerrit.cloudera.org:8080/6487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea06e89341de234f9005fdc72a2e43f0ab8182 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks
Lars Volker has posted comments on this change. Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks .. Patch Set 1: Code-Review+1 Thank you for fixing this! I had run into this myself, too. -- To view, visit http://gerrit.cloudera.org:8080/6600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No
