[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5031: remove undefined behavior: nullptr member function 
call
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Ho 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5031: remove undefined behavior: nullptr member function 
call
..


IMPALA-5031: remove undefined behavior: nullptr member function call

This member function call on a nullptr to a FragmentInstanceState was
present in data loading, end-to-end tests, and custom cluster tests.

Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
Reviewed-on: http://gerrit.cloudera.org:8080/6714
Reviewed-by: Michael Ho 
Tested-by: Impala Public Jenkins
---
M be/src/runtime/coordinator.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Ho: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Ho 

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5031: remove undefined behavior: nullptr member function 
call
..


Patch Set 1:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/496/

-- 
To view, visit http://gerrit.cloudera.org:8080/6714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Ho 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..


IMPALA-4544: ASAN should ignore SEGV and leaks

The environment variable ASAN_OPTIONS had always bee set to
"handle_segv=0 detect_leaks=0" on Jenkins ASAN jobs in the pre-Apache
era, but this had slipped through the cracks.

Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Reviewed-on: http://gerrit.cloudera.org:8080/6600
Reviewed-by: Jim Apple 
Tested-by: Impala Public Jenkins
---
M bin/run-backend-tests.sh
M bin/start-catalogd.sh
M bin/start-impalad.sh
M bin/start-statestored.sh
4 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-5031: remove undefined behavior: nullptr member function 
call
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6714/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 379:   return (coord_instance_ == nullptr) ? nullptr : 
coord_instance_->executor();
While I agree they are not needed, I find it to be clearer this way.

Unrelatedly, here is a sample backtrace:

/home/ubuntu/Impala/be/src/runtime/fragment-instance-state.h:74:46: runtime 
error: member access within null pointer of type 'impala::FragmentInstanceState'
#0 0x7fcdea60aaf8 in impala::FragmentInstanceState::executor() 
/home/ubuntu/Impala/be/src/runtime/fragment-instance-state.h:74:46
#1 0x7fcdea5a6239 in impala::Coordinator::executor() 
/home/ubuntu/Impala/be/src/runtime/coordinator.cc:379:10
#2 0x7fcdea5b639b in impala::Coordinator::PrintFragmentInstanceInfo() 
/home/ubuntu/Impala/be/src/runtime/coordinator.cc:1143:18
#3 0x7fcdea5acdb8 in impala::Coordinator::Exec() 
/home/ubuntu/Impala/be/src/runtime/coordinator.cc:507:3
#4 0x7fcde40f110f in 
impala::ImpalaServer::QueryExecState::ExecQueryOrDmlRequest(impala::TQueryExecRequest
 const&) /home/ubuntu/Impala/be/src/service/query-exec-state.cc:469:12
#5 0x7fcde40e6835 in 
impala::ImpalaServer::QueryExecState::Exec(impala::TExecRequest*) 
/home/ubuntu/Impala/be/src/service/query-exec-state.cc:158:14
#6 0x7fcde3cf04fc in 
impala::ImpalaServer::ExecuteInternal(impala::TQueryCtx const&, 
std::shared_ptr, bool*, 
std::shared_ptr*) 
/home/ubuntu/Impala/be/src/service/impala-server.cc:829:29
#7 0x7fcde3cecd82 in impala::ImpalaServer::Execute(impala::TQueryCtx*, 
std::shared_ptr, 
std::shared_ptr*) 
/home/ubuntu/Impala/be/src/service/impala-server.cc:775:19
#8 0x7fcde4098e60 in impala::ImpalaServer::query(beeswax::QueryHandle&, 
beeswax::Query const&) 
/home/ubuntu/Impala/be/src/service/impala-beeswax-server.cc:68:29
#9 0x7fcde13efdd7 in beeswax::BeeswaxServiceProcessor::process_query(int, 
apache::thrift::protocol::TProtocol*, apache::thrift::protocol::TProtocol*, 
void*) 
/home/ubuntu/Impala/be/generated-sources/gen-cpp/BeeswaxService.cpp:2979:5
#10 0x7fcde13ef165 in 
beeswax::BeeswaxServiceProcessor::dispatchCall(apache::thrift::protocol::TProtocol*,
 apache::thrift::protocol::TProtocol*, std::string const&, int, void*) 
/home/ubuntu/Impala/be/generated-sources/gen-cpp/BeeswaxService.cpp:2952:3
#11 0x7fcde1347c16 in 
impala::ImpalaServiceProcessor::dispatchCall(apache::thrift::protocol::TProtocol*,
 apache::thrift::protocol::TProtocol*, std::string const&, int, void*) 
/home/ubuntu/Impala/be/generated-sources/gen-cpp/ImpalaService.cpp:1673:12
#12 0x7fcdeccdb48e in 
apache::thrift::TDispatchProcessor::process(boost::shared_ptr,
 boost::shared_ptr, void*) 
/home/ubuntu/Impala/toolchain/thrift-0.9.0-p8/include/thrift/TDispatchProcessor.h:121:12
#13 0x17e40ea in apache::thrift::server::TThreadPoolServer::Task::run() 
(/home/ubuntu/Impala/be/build/debug/service/impalad+0x17e40ea)
#14 0x17c75f8 in apache::thrift::concurrency::ThreadManager::Worker::run() 
(/home/ubuntu/Impala/be/build/debug/service/impalad+0x17c75f8)
#15 0x7fcde4ee2a20 in 
impala::ThriftThread::RunRunnable(boost::shared_ptr,
 impala::Promise*) 
/home/ubuntu/Impala/be/src/rpc/thrift-thread.cc:64:3
#16 0x7fcde4ee916b in boost::_mfi::mf2::operator()(impala::ThriftThread*, 
boost::shared_ptr, 
impala::Promise*) const 
/home/ubuntu/Impala/toolchain/boost-1.57.0-p1/include/boost/bind/mem_fn_template.hpp:280:16
#17 0x7fcde4ee8e8a in void 
boost::_bi::list3, 
boost::_bi::value, 
boost::_bi::value 
>::operator(), boost::_bi::list0>(boost::_bi::type, 
boost::_mfi::mf2&, boost::_bi::list0&, int) 
/home/ubuntu/Impala/toolchain/boost-1.57.0-p1/include/boost/bind/bind.hpp:392:9
#18 0x7fcde4ee894b in boost::_bi::bind_t, 
boost::_bi::list3, 
boost::_bi::value, 
boost::_bi::value > >::operator()() 
/home/ubuntu/Impala/toolchain/boost-1.57.0-p1/include/boost/bind/bind_template.hpp:20:16
#19 0x7fcde4ee7c09 in 
boost::detail::function::void_function_obj_invoker0, 
boost::_bi::list3, 
boost::_bi::value, 
boost::_bi::value > >, 

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change.

Change subject: IMPALA-5031: remove undefined behavior: nullptr member function 
call
..


Patch Set 1: Code-Review+2

(1 comment)

I suppose all current callers of this function are from code path with 
coordinator fragment and that's why we haven't hit any crash yet ?

http://gerrit.cloudera.org:8080/#/c/6714/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS1, Line 379: coord_instance_ == nullptr)
parenthesis is not needed.


-- 
To view, visit http://gerrit.cloudera.org:8080/6714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Michael Ho 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

[Marcel Kornacker (Code Review)]

Marcel Kornacker has uploaded a new patch set (#10).

Change subject: IMPALA-2550: Switch to per-query exec rpc
..

IMPALA-2550: Switch to per-query exec rpc

Coordinator:
- FragmentInstanceState -> BackendState, which in turn records
  FragmentInstanceStats

QueryState
- does query-wide setup in a separate thread (which also launches
  the instance exec threads)
- has a query-wide 'prepared' state at which point all static setup
  is done and all FragmentInstanceStates are accessible

Also renamed QueryExecState to ClientRequestState.

Simplified handling of execution status (in FragmentInstanceState):
- status only transmitted via ReportExecStatus rpc
- in particular, it's not returned anymore from the Cancel rpc

FIS: Fixed bugs related to partially-prepared state (in Close() and 
ReleaseThreadToken())

Change-Id: I20769e420711737b6b385c744cef4851cee3facd
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/codegen/codegen-anyval.h
M be/src/common/status.cc
M be/src/common/status.h
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/exec-node.cc
M be/src/exec/exec-node.h
M be/src/exec/hdfs-avro-table-writer.cc
M be/src/exec/hdfs-avro-table-writer.h
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-table-sink.cc
M be/src/exec/hdfs-table-sink.h
M be/src/exec/hdfs-table-writer.cc
M be/src/exec/hdfs-table-writer.h
M be/src/exprs/expr-test.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/buffered-block-mgr-test.cc
A be/src/runtime/coordinator-backend-state.cc
A be/src/runtime/coordinator-backend-state.h
A be/src/runtime/coordinator-filter-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/data-stream-test.cc
A be/src/runtime/debug-options.cc
A be/src/runtime/debug-options.h
M be/src/runtime/descriptors.cc
M be/src/runtime/descriptors.h
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/mem-tracker.cc
D be/src/runtime/plan-fragment-executor.cc
D be/src/runtime/plan-fragment-executor.h
M be/src/runtime/query-exec-mgr.cc
M be/src/runtime/query-exec-mgr.h
M be/src/runtime/query-state.cc
M be/src/runtime/query-state.h
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/scheduling/query-schedule.h
M be/src/service/CMakeLists.txt
M be/src/service/child-query.cc
M be/src/service/child-query.h
R be/src/service/client-request-state.cc
R be/src/service/client-request-state.h
M be/src/service/fe-support.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-internal-service.cc
M be/src/service/impala-internal-service.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/testutil/desc-tbl-builder.cc
M be/src/testutil/fault-injection-util.h
M be/src/util/error-util-test.cc
M be/src/util/error-util.cc
M be/src/util/error-util.h
M be/src/util/uid-util.h
M common/thrift/ExecStats.thrift
M common/thrift/ImpalaInternalService.thrift
M tests/common/test_result_verifier.py
69 files changed, 3,772 insertions(+), 3,673 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/6535/10
-- 
To view, visit http://gerrit.cloudera.org:8080/6535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I20769e420711737b6b385c744cef4851cee3facd
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

[Marcel Kornacker (Code Review)]

Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-2550: Switch to per-query exec rpc
..


Patch Set 9:

(26 comments)

http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

PS9, Line 293: UpdateExecStats
> The similarity between UpdateExecStats() and UpdateExecStatus() is potentia
renamed.


Line 455: // TODO: we don't track cpu time per node now. Do that.
> More generally we should have an aggregate profile for each backend that in
rephrased


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/coordinator-backend-state.h
File be/src/runtime/coordinator-backend-state.h:

Line 132: const FInstanceExecParams& exec_params_;
> Might be helpful to document what owns the object being referenced.
Done


Line 164:   std::vector instance_params_list_;
> Might be helpful to document what owns the objects being referenced.
Done


Line 175:   /// Protects fields below. Can be held while doing an RPC, so 
SpinLock is a bad idea.
> Our current SpinLock implementation should be fine (it blocks after spinnin
Done


Line 219:   /// TODO: including the median doesn't compile, looks like some 
includes are missing
> This TODO has been in the code since 2012 - maybe just remove it?
Done


Line 253:   /// Root profile for all fragment instances for this fragment
> Stored in obj_pool?
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 364:   f->targets()->push_back(target);
> Maybe:
Done


Line 402:   int num_instances = schedule_.GetNumFragmentInstances();
> nit: intermediate variable seems unnecessary.
Done


Line 410:   // TODO: rename this metric
> There are a handful of minor TODOs like this. I assume there's some reason 
this was already taken care of


Line 938:   // Notify that we completed with an error.
> This comment seems wrong - the cancellation path is used to clean up even i
Done


PS9, Line 956:  
> nit: blank space
Done


Line 956:   // TODO: return here if returned_all_results_? 
> I believe we need to do cancellation even if we returned all results. Havin
i agree that we need to/should cancel as soon as we return all results. i left 
a corresponding todo in the .h file (cleaning all that up as part of this 
change is out of scope).


Line 983:   // TODO: clarify control flow here, it's unclear we should even 
process this status
> Henry had a patch that clarified this and improved the comment: https://ger
i already incorporated that


PS9, Line 1136: VLOG_QU
> delete
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

Line 108: /// TODO: clean up locking behavior; in particular, clarify 
dependency on lock_
> Does any of the locking information in the impala-server.h need to be updat
i didn't change the locking behavior, so no.


PS9, Line 151:  WARN_UNUSED_RESULT;
> nit: long line.
Done


Line 261:   boost::mutex wait_lock_;
> A lot of these locks could safely be SpinLocks - unless they're used with a
out of scope for this change, it's already large enough.


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/debug-options.cc
File be/src/runtime/debug-options.cc:

PS9, Line 71:  (*entry).
> entry->second ?
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/descriptors.cc
File be/src/runtime/descriptors.cc:

Line 507: 
> Extra line
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/fragment-instance-state.h
File be/src/runtime/fragment-instance-state.h:

Line 162:   /// True if and only if Cancel() has been called.
> I had a hard time reasoning about concurrent accesses to this until I reali
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/query-exec-mgr.h
File be/src/runtime/query-exec-mgr.h:

Line 77:   /// Execute instances and decrement refcount.
> I find it clearer to understand as: "Acquires ownership of 'qs'".
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

Line 43: #define RETRY_SLEEP_MS 100
> Make a class-level constant?
this will disappear with krpc


Line 311:   // don't return until every instance is prepared and record the 
first non-OK status
> Comment isn't really accurate - it doesn't record the first non-OK status b
Done


http://gerrit.cloudera.org:8080/#/c/6535/9/be/src/runtime/runtime-state.h
File be/src/runtime/runtime-state.h:

Line 257:   void set_is_cancelled(bool v) { is_cancelled_ = v; }
> Not your change but related. This bool is accessed from multiple threads ye
we only ever change it from false to true, and in particular we don't do any 
compare, so i'm not sure how relevant synchronization is here.

i changed the signature to remove the bool parameter to make this clear.

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..


Patch Set 2:

> Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/494/

Looks flaky to me: https://issues.apache.org/jira/browse/IMPALA-5247

-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/495/

-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/494/

-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Jim Apple (Code Review)]

Hello Lars Volker, Alex Behm,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6600

to look at the new patch set (#2).

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..

IMPALA-4544: ASAN should ignore SEGV and leaks

The environment variable ASAN_OPTIONS had always bee set to
"handle_segv=0 detect_leaks=0" on Jenkins ASAN jobs in the pre-Apache
era, but this had slipped through the cracks.

Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
---
M bin/run-backend-tests.sh
M bin/start-catalogd.sh
M bin/start-impalad.sh
M bin/start-statestored.sh
4 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/6600/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-4544: ASAN should ignore SEGV and leaks

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-4544: ASAN should ignore SEGV and leaks
..


Patch Set 2: Code-Review+2

Carry Alex Behm's +2

-- 
To view, visit http://gerrit.cloudera.org:8080/6600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I055aa25d5ca41419bf3fc8a30a8fb8774ab05b18
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5031: remove undefined behavior: nullptr member function call

[Jim Apple (Code Review)]

Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6714

Change subject: IMPALA-5031: remove undefined behavior: nullptr member function 
call
..

IMPALA-5031: remove undefined behavior: nullptr member function call

This member function call on a nullptr to a FragmentInstanceState was
present in data loading, end-to-end tests, and custom cluster tests.

Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
---
M be/src/runtime/coordinator.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/6714/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2377c14f7ea8f93bb96504dd2319c11ff709cd26
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple