[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

[Balazs Jeszenszky (Code Review)]

Balazs Jeszenszky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8202 )

Change subject: IMPALA-4704: Disallow client connections to imapalad until 
catalog is received.
..


Patch Set 1:

I think the bug report's title is a better than it's description. In 
particular, I'm not sure shutting down the daemon is the best way out of 
situations like this since in most managed environments they will be restarted 
automatically (causing another attempt to get initial catalog update, same as 
if they were left alive).
If for some reason opening the ports later is not possible, I think timing out 
should result in closing the connection with a more descriptive error message 
so that clients can retry.

However, the best solution would be to only open the frontend ports after the 
catalog update is processed. With a load balancer in front of several 
coordinators, this setup would allow for a seamless (i.e. not even a delay due 
to connections waiting for the catalog update to be processed) experience for 
clients.


--
To view, visit http://gerrit.cloudera.org:8080/8202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6
Gerrit-Change-Number: 8202
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac 
Gerrit-Reviewer: Balazs Jeszenszky 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 04 Oct 2017 17:04:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.

[Balazs Jeszenszky (Code Review)]

Balazs Jeszenszky has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8136 )

Change subject: IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8136/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8136/1//COMMIT_MSG@24
PS1, Line 24: Limitations
add: only for HDFS tables


http://gerrit.cloudera.org:8080/#/c/8136/1//COMMIT_MSG@25
PS1, Line 25: --enable_stats_extrapolation=true
Is this really required to be a startup option, wouldn't a query option (SET) 
work? I expect it will be enabled most of the time, and disabling it would be a 
troubleshooting step or workaround for some issues, particularly in planning. 
It would be better not to have to restart to do that.


http://gerrit.cloudera.org:8080/#/c/8136/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:

http://gerrit.cloudera.org:8080/#/c/8136/1/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@67
PS1, Line 67: Stats extrapolation disabled
How would Impala behave if stats are computed with TABLESAMPLE, and then stats 
extrapolation is disabled?


http://gerrit.cloudera.org:8080/#/c/8136/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/8136/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@777
PS1, Line 777: if (totalBytes_ == 0) {
totalBytes_ doesn't get a new value in the above section, why not make this 
check at the beginning, as it was?



--
To view, visit http://gerrit.cloudera.org:8080/8136
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3e72471ac563adada4a4156033a85852b7c8b7
Gerrit-Change-Number: 8136
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Balazs Jeszenszky 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 27 Sep 2017 09:58:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile

[Balazs Jeszenszky (Code Review)]

Balazs Jeszenszky has posted comments on this change.

Change subject: IMPALA-5784 : Separate planner and user set query options in 
profile
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7721/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

Line 151:   summary_profile_.AddInfoString("Query Options (non default, after 
planning)",
> this is probably okay, but i wonder if it'd be clearer if we instead either
I'd change 'before planning' and 'after planning' to 'manually set' and 
'planner set', and make the lists mutually exclusive. If mutually exclusive 
isn't worth it, 'after planning' could be called 'including planner set'.


-- 
To view, visit http://gerrit.cloudera.org:8080/7721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Balazs Jeszenszky 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5804 (step-1): Cherry-pick KUDU-2087

[Balazs Jeszenszky (Code Review)]

Balazs Jeszenszky has posted comments on this change.

Change subject: IMPALA-5804 (step-1): Cherry-pick KUDU-2087
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7689/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-5804 (step-1): Cherry-pick KUDU-2087
nit: This should be IMPALA-5129 instead.


-- 
To view, visit http://gerrit.cloudera.org:8080/7689
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1541e41722c5f718d152bd531f14f270edc76d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Balazs Jeszenszky 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

[Balazs Jeszenszky (Code Review)]

Balazs Jeszenszky has posted comments on this change.

Change subject: IMPALA-5778: clarify --read_size option.
..


Patch Set 1: Code-Review+1

Looks good.

-- 
To view, visit http://gerrit.cloudera.org:8080/7623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c20a9d55f89170b11f569c90b7f2949ddbe4211
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Balazs Jeszenszky 
Gerrit-HasComments: No