[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-10 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8230 )

Change subject: Allow the SASL protocol service name to be configurable
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/8230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e30fe4461893b67527333259579e2304b19af1e
Gerrit-Change-Number: 8230
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Tue, 10 Oct 2017 18:16:31 +
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: [DOCS] Mention Kerberos and TLS for Kudu security
..


Patch Set 1:

The link will be https://kudu.apache.org/docs/security.html, but it's not 
published quite yet.

-- 
To view, visit http://gerrit.cloudera.org:8080/6634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1266ad38468ef2e987aff54db35e6cafdacc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-07 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5390/2/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

Line 421: resultSchema.addToColumns(new TColumn("Partition Specifier", 
Type.STRING.toThrift()));
> Maybe Range Partition Specifier?
In the Kudu web UI we are calling it 'RANGE (col1, col2, col3, ...) 
PARTITIONS'.  You can see a screenshot here: https://imgur.com/a/VNlMA.


-- 
To view, visit http://gerrit.cloudera.org:8080/5390
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5b2fdd02938a42fa59ec98884e4ac915dd1f65
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review) 
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5382

to look at the new patch set (#3).

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..

Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

This commit also removes the now unused `DISTRIBUTE`, `SPLIT`, and
`BUCKETS` keywords that were going to be newly released in Impala 2.6,
but are now unused. Additionally, a few remaining uses of the
`DISTRIBUTE BY` syntax has been switched to `PARTITION BY`.

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
34 files changed, 204 insertions(+), 219 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5382/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 2:

PS2 build: 
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/6174/console

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5382/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

PS1, Line 287: DISTRIBUTE BY
> This is no longer true. The clause is "PARTITION BY".
Done


http://gerrit.cloudera.org:8080/#/c/5382/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

PS1, Line 1964: into 2
> Is this valid syntax?
no this was a bad find/replace.


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

PS1, Line 799: DISTRIBUTE
> Hm, that should be PARTITION.
Done


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/tests/test_cursor.py
File tests/comparison/tests/test_cursor.py:

PS1, Line 79: DISTRIBUTE
> PARTITION
Done


PS1, Line 83: DISTRIBUTE
> PARTITION
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review) 
Dan Burkert has uploaded a new patch set (#2).

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..

Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

This commit also removes the now unused `DISTRIBUTE`, `SPLIT`, and
`BUCKETS` keywords that were going to be newly released in Impala 2.6,
but are now unused. Additionally, a few remaining uses of the
`DISTRIBUTE BY` syntax has been switched to `PARTITION BY`.

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
34 files changed, 202 insertions(+), 217 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5382/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 1:

Kicked off a build here: 
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/6171/console

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Dan Burkert (Code Review) 
Hello Matthew Jacobs, Alex Behm,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/5382

to review the following change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..

Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
31 files changed, 188 insertions(+), 194 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5382/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Matthew Jacobs

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-06 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for 
fragments with Kudu scan node
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4639/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

PS1, Line 137: 
KUDU_RETURN_IF_ERROR(kudu::client::KuduScanToken::DeserializeIntoScanner(
 :   scan_node_->kudu_client(), scan_token, ),
> @Kudu-team: Is this worth accounting for?
This operation doesn't require any RPCs, so it should be fast.


PS1, Line 159: scanner_->Close();
> @Kudu-team: Is this worth accounting for?
If the scan node doesn't scan until completion, calling Close may issue an 
async RPC to the tserver to close the scanner.  However, I doubt y'all don't 
finish the scan, and the RPC is not waited on, so this should be fast.


-- 
To view, visit http://gerrit.cloudera.org:8080/4639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c793930799fdcaff53e705f94b52cadac2f53a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes