[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Update Impala docs for 2.10 release Commit hash = 40ec6d0080638efaf3260672ab54ea4674896c5e Several new HTML files for this release. Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Reviewed-on: http://gerrit.cloudera.org:8080/8511 Reviewed-by: Michael Brown Tested-by: John Russell --- M docs/build/html/index.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_default_spillable_buffer_size.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M docs/build/html/topics/impala_fixed_issues.html M docs/build/html/topics/impala_hbase.html M docs/build/html/topics/impala_hints.html M docs/build/html/topics/impala_incompatible_changes.html M docs/build/html/topics/impala_joins.html M docs/build/html/topics/impala_known_issues.html M docs/build/html/topics/impala_kudu.html M docs/build/html/topics/impala_logging.html M docs/build/html/topics/impala_map.html M docs/build/html/topics/impala_math_functions.html A docs/build/html/topics/impala_max_row_size.html A docs/build/html/topics/impala_min_spillable_buffer_size.html M docs/build/html/topics/impala_new_features.html M docs/build/html/topics/impala_partitioning.html M docs/build/html/topics/impala_perf_joins.html M docs/build/html/topics/impala_perf_stats.html M docs/build/html/topics/impala_query_options.html M docs/build/html/topics/impala_reserved_words.html M docs/build/html/topics/impala_scalability.html M docs/build/html/topics/impala_select.html M docs/build/html/topics/impala_shell_commands.html M docs/build/html/topics/impala_shell_running_commands.html M docs/build/html/topics/impala_ssl.html M docs/build/html/topics/impala_string_functions.html M docs/build/html/topics/impala_struct.html M docs/build/html/topics/impala_subqueries.html A docs/build/html/topics/impala_tablesample.html M docs/build/html/topics/impala_upgrading.html M docs/build/html/topics/impala_views.html A docs/build/impala-2.10.pdf M impala-docs.html 43 files changed, 3,570 insertions(+), 1,118 deletions(-) Approvals: Michael Brown: Looks good to me, approved John Russell: Verified -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: merged Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 3: Verified+1 Oops, ran the verification job by mistake instead of +1'ing it through gerrit. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 13 Nov 2017 23:04:44 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
Hello Bharath Vissapragada, Michael Brown, Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8511 to look at the new patch set (#3). Change subject: Update Impala docs for 2.10 release .. Update Impala docs for 2.10 release Commit hash = 40ec6d0080638efaf3260672ab54ea4674896c5e Several new HTML files for this release. Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 --- M docs/build/html/index.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_default_spillable_buffer_size.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M docs/build/html/topics/impala_fixed_issues.html M docs/build/html/topics/impala_hbase.html M docs/build/html/topics/impala_hints.html M docs/build/html/topics/impala_incompatible_changes.html M docs/build/html/topics/impala_joins.html M docs/build/html/topics/impala_known_issues.html M docs/build/html/topics/impala_kudu.html M docs/build/html/topics/impala_logging.html M docs/build/html/topics/impala_map.html M docs/build/html/topics/impala_math_functions.html A docs/build/html/topics/impala_max_row_size.html A docs/build/html/topics/impala_min_spillable_buffer_size.html M docs/build/html/topics/impala_new_features.html M docs/build/html/topics/impala_partitioning.html M docs/build/html/topics/impala_perf_joins.html M docs/build/html/topics/impala_perf_stats.html M docs/build/html/topics/impala_query_options.html M docs/build/html/topics/impala_reserved_words.html M docs/build/html/topics/impala_scalability.html M docs/build/html/topics/impala_select.html M docs/build/html/topics/impala_shell_commands.html M docs/build/html/topics/impala_shell_running_commands.html M docs/build/html/topics/impala_ssl.html M docs/build/html/topics/impala_string_functions.html M docs/build/html/topics/impala_struct.html M docs/build/html/topics/impala_subqueries.html A docs/build/html/topics/impala_tablesample.html M docs/build/html/topics/impala_upgrading.html M docs/build/html/topics/impala_views.html A docs/build/impala-2.10.pdf M impala-docs.html 43 files changed, 3,570 insertions(+), 1,118 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8511/3 -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8511/2/impala-docs.html File impala-docs.html: http://gerrit.cloudera.org:8080/#/c/8511/2/impala-docs.html@131 PS2, Line 131: HTML Documentation for Impala 2.10 : PDF Documentation for Impala 2.10 > Nit: indent two spaces to the left, as these items are part of the same uno Done. Ah, I see it was because ll 126-127 have consecutive tags with the same indentation.I'll give an extra indent to ll 127-133 so lines can be copied between "latest release" and "older releases" without changing indentation. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 13 Nov 2017 22:27:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 ) Change subject: [DOCS] Remove unnecessary 'incubator' from URLs .. Patch Set 1: (1 comment) Excellent idea! http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml File docs/topics/impala_langref_unsupported.xml: http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml@207 PS1, Line 207: http://sentry.apache.org/"; scope="external" format="html"> Might as well shorten this opening tag to . That way it picks up the Sentry-related modification from impala_keydefs.ditamap, the line is shorter, and link maintenance is easier in future (link can be changed again - to https:// or whatever - without touching any topics/*.xml files). -- To view, visit http://gerrit.cloudera.org:8080/8524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e Gerrit-Change-Number: 8524 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Sat, 11 Nov 2017 21:05:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: I also checked the size and contents of impala-2.10.pdf to make sure it really was the latest built version, not an older version of impala.pdf from the asf-site repo. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Thu, 09 Nov 2017 22:54:59 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
Hello Bharath Vissapragada, Michael Brown, Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8511 to look at the new patch set (#2). Change subject: Update Impala docs for 2.10 release .. Update Impala docs for 2.10 release Commit hash = 40ec6d0080638efaf3260672ab54ea4674896c5e Several new HTML files for this release. Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 --- M docs/build/html/index.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_array.html A docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_datetime_functions.html A docs/build/html/topics/impala_default_spillable_buffer_size.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M docs/build/html/topics/impala_fixed_issues.html M docs/build/html/topics/impala_hbase.html M docs/build/html/topics/impala_hints.html M docs/build/html/topics/impala_incompatible_changes.html M docs/build/html/topics/impala_joins.html M docs/build/html/topics/impala_known_issues.html M docs/build/html/topics/impala_kudu.html M docs/build/html/topics/impala_logging.html M docs/build/html/topics/impala_map.html M docs/build/html/topics/impala_math_functions.html A docs/build/html/topics/impala_max_row_size.html A docs/build/html/topics/impala_min_spillable_buffer_size.html M docs/build/html/topics/impala_new_features.html M docs/build/html/topics/impala_partitioning.html M docs/build/html/topics/impala_perf_joins.html M docs/build/html/topics/impala_perf_stats.html M docs/build/html/topics/impala_query_options.html M docs/build/html/topics/impala_reserved_words.html M docs/build/html/topics/impala_scalability.html M docs/build/html/topics/impala_select.html M docs/build/html/topics/impala_shell_commands.html M docs/build/html/topics/impala_shell_running_commands.html M docs/build/html/topics/impala_ssl.html M docs/build/html/topics/impala_string_functions.html M docs/build/html/topics/impala_struct.html M docs/build/html/topics/impala_subqueries.html A docs/build/html/topics/impala_tablesample.html M docs/build/html/topics/impala_upgrading.html M docs/build/html/topics/impala_views.html A docs/build/impala-2.10.pdf M impala-docs.html 43 files changed, 3,563 insertions(+), 1,111 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8511/2 -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 2: I realized what the hiccup was in the procedure - checking out asf-site overwrote any existing files under build/html but left any entirely new ones in place. So my git adds and git commit -a only touched entirely new files. I re-copied the latest build and re-added for patch set 2 to pick up all the modified files. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Thu, 09 Nov 2017 22:54:11 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 1: Looks like somehow my 'git add *.html' only picked up new HTML files, not changed ones. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Thu, 09 Nov 2017 22:28:52 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8511 ) Change subject: Update Impala docs for 2.10 release .. Patch Set 1: Laurel and I are proofreading now, this is mainly an FYI for Michael and Bharath as to when the 2.10 docs get pushed. -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Thu, 09 Nov 2017 22:24:04 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) Update Impala docs for 2.10 release
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8511 Change subject: Update Impala docs for 2.10 release .. Update Impala docs for 2.10 release Commit hash = 40ec6d0080638efaf3260672ab54ea4674896c5e Several new HTML files for this release. Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 --- A docs/build/html/topics/impala_buffer_pool_limit.html A docs/build/html/topics/impala_default_spillable_buffer_size.html A docs/build/html/topics/impala_max_row_size.html A docs/build/html/topics/impala_min_spillable_buffer_size.html A docs/build/html/topics/impala_tablesample.html A docs/build/impala-2.10.pdf M impala-docs.html 7 files changed, 1,022 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/8511/1 -- To view, visit http://gerrit.cloudera.org:8080/8511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: newchange Gerrit-Change-Id: Idea1f417d404b99dad9fb8255849867f1e67e767 Gerrit-Change-Number: 8511 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
Hello Greg Rahn, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8418 to look at the new patch set (#3). Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb --- M docs/topics/impala_known_issues.xml 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8418/3 -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8418/2/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/8418/2/docs/topics/impala_known_issues.xml@951 PS2, Line 951: Medium > I think TSBs probably use a different scale though. Most of the medium seve Sure! Changed. http://gerrit.cloudera.org:8080/#/c/8418/2/docs/topics/impala_known_issues.xml@951 PS2, Line 951: Medium > I agree it's a little strange. But Cloudera issued a technical service bull Done http://gerrit.cloudera.org:8080/#/c/8418/2/docs/topics/impala_known_issues.xml@951 PS2, Line 951: Medium > Missed this on the first pass - shouldn't this be high? Done -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 07 Nov 2017 22:21:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@171 PS2, Line 171: p> > This seems redundant, as that's what "Allow any TLS version of 1.2 higher." Done http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@171 PS2, Line 171: p> > Hmm I was trying to come up a subtle way to indicate, "consider using this Done. I'll take out that line. http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@177 PS2, Line 177: lable. The daemons f > The daemon doesn't start. Specifically, we get an error like this: Done http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@188 PS2, Line 188: > nit: whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 06 Nov 2017 23:53:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
Hello Bharath Vissapragada, Henry Robinson, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8401 to look at the new patch set (#3). Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. IMPALA-5473: [DOCS] Document TLS min version & cipher options Under the doc JIRA IMPALA-6065. Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e --- M docs/topics/impala_ssl.xml 1 file changed, 71 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/8401/3 -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8418/2/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/8418/2/docs/topics/impala_known_issues.xml@951 PS2, Line 951: Medium > Missed this on the first pass - shouldn't this be high? I agree it's a little strange. But Cloudera issued a technical service bulletin (TSB) about the issue and it was only rated "medium" there. We are in somewhat new territory with how the TSB info relates to the upstream docs. My impulse was not to deviate greatly from whatever info came from the support group. -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 06 Nov 2017 20:35:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8418/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/8418/1/docs/topics/impala_known_issues.xml@936 PS1, Line 936: Examine the HDFS_SCAN_NODE portion of a query profile that scans the > This unfortunately won't give accurate info for all queries: if the query i Done http://gerrit.cloudera.org:8080/#/c/8418/1/docs/topics/impala_known_issues.xml@937 PS1, Line 937: suspected table. Use a query that performs a full table scan, and materializes the column > It might be helpful to note common cases where uncompressed Parquet is/isn' Done -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 03 Nov 2017 20:37:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
Hello Greg Rahn, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8418 to look at the new patch set (#2). Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb --- M docs/topics/impala_known_issues.xml 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8418/2 -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps
John Russell has abandoned this change. ( http://gerrit.cloudera.org:8080/7983 ) Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps .. Abandoned Suggested workaround was not a robust or future-proof solution. -- To view, visit http://gerrit.cloudera.org:8080/7983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4b67cd7762f682c3a054e0d9641080aa51801c83 Gerrit-Change-Number: 7983 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8421 ) Change subject: IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue .. Patch Set 1: Do I understand from the discussion in TSB-252 that this Known Issue item should wait for some specific Apache Impala announcement before incorporating into the docs? -- To view, visit http://gerrit.cloudera.org:8080/8421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93e99aec2fcbc12f94678e60ebb9d150e72fc77d Gerrit-Change-Number: 8421 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Mon, 30 Oct 2017 23:30:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8421 Change subject: IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue .. IMPALA-5638: [DOCS] Add known issue for Impala-Kudu-Sentry issue Change-Id: I93e99aec2fcbc12f94678e60ebb9d150e72fc77d --- M docs/topics/impala_known_issues.xml 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/8421/1 -- To view, visit http://gerrit.cloudera.org:8080/8421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I93e99aec2fcbc12f94678e60ebb9d150e72fc77d Gerrit-Change-Number: 8421 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 2: (1 comment) I folded all relevant issue numbers and links into the one item. Please check if it's all accurate or if we need to split IMPALA-4978 and IMPALA-5253 into separate known issues. http://gerrit.cloudera.org:8080/#/c/7388/2/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/7388/2/docs/topics/impala_known_issues.xml@156 PS2, Line 156: This problem might occur immediately after an upgrade, due to changes in cluster : management software that supplies the --hostname flag : automatically to the Impala-related daemons. > It's a bit hard to understand *what* kind of changes would cause this, and Done -- To view, visit http://gerrit.cloudera.org:8080/7388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib039d0102878f1c05470371f581cb258287b9bc0 Gerrit-Change-Number: 7388 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 30 Oct 2017 22:01:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue
Hello Lars Volker, Henry Robinson, Sailesh Mukil, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7388 to look at the new patch set (#3). Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue Because there was no obvious subcategory of known issues to put this one in, I made a new subcategory 'startup issues'. Change-Id: Ib039d0102878f1c05470371f581cb258287b9bc0 --- M docs/topics/impala_known_issues.xml 1 file changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7388/3 -- To view, visit http://gerrit.cloudera.org:8080/7388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib039d0102878f1c05470371f581cb258287b9bc0 Gerrit-Change-Number: 7388 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 1: This was announced by Cloudera as TSB-225. Traditionally, TSBs get an equivalent Known Issue or similar in release notes. I think the best approach is to make a version-agnostic issue in upstream docs and be more explicit about fixed CDH maintenance releases in the equivalent downstream note. -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 30 Oct 2017 21:20:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8418 Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb --- M docs/topics/impala_known_issues.xml 1 file changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/8418/1 -- To view, visit http://gerrit.cloudera.org:8080/8418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I731eb0e029dc3cc251f4df0c5a8ad281c81595cb Gerrit-Change-Number: 8418 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 2: (2 comments) I'll punt to Sailesh for the answer to one of Henry's questions. http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@171 PS2, Line 171: This value is used in some organizations to disallow TLS 1.0 and 1.1. > This seems redundant, as that's what "Allow any TLS version of 1.2 higher." Hmm I was trying to come up a subtle way to indicate, "consider using this value if your organization is security-conscious". I'm not an expert on TLS/SSL vulns but I did turn up this one that suggests some problems are in both 1.0 and 1.1 but not 1.2. https://nakedsecurity.sophos.com/2013/02/07/boffins-crack-https-encryptionin-lucky-thirteen-attack/ http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@177 PS2, Line 177: TLSv1.2 may not work > How does it 'not work' - does the daemon fail to start, or does the daemon Good question for Sailesh! -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Oct 2017 23:04:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 2: (4 comments) I included the "long-form" description of the RHEL/CentOS issue from Sailesh's email. http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml@145 PS1, Line 145: . In , you can use startup : options for the impal > I assume you meant catalogd and statestored in 2 of these? Done http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml@158 PS1, Line 158: > mention this the default may be? Right, the default is stated on the next line. http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml@177 PS1, Line 177: s of , TLSv1.2 may not work for > Elaborate on the default state a little bit: "Default is empty and then Imp Done http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml@182 PS1, Line 182: > Could you also please add a note saying that TLSv1.2 may not work on CentOS Done -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 27 Oct 2017 19:35:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
Hello Bharath Vissapragada, Henry Robinson, Michael Brown, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8401 to look at the new patch set (#2). Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. IMPALA-5473: [DOCS] Document TLS min version & cipher options Under the doc JIRA IMPALA-6065. Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e --- M docs/topics/impala_ssl.xml 1 file changed, 71 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/8401/2 -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml File docs/topics/impala_ssl.xml: http://gerrit.cloudera.org:8080/#/c/8401/1/docs/topics/impala_ssl.xml@177 PS1, Line 177: using the --ssl_cipher_list configuration setting Elaborate on the default state a little bit: "Default is empty and then Impala uses the default cipher list for that platform." -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 26 Oct 2017 21:16:01 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 ) Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. Patch Set 1: I added a couple of questions under IMPALA-6065 for things I wasn't sure about. -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 26 Oct 2017 20:53:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8401 Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options .. IMPALA-5473: [DOCS] Document TLS min version & cipher options Under the doc JIRA IMPALA-6065. Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e --- M docs/topics/impala_ssl.xml 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/8401/1 -- To view, visit http://gerrit.cloudera.org:8080/8401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e Gerrit-Change-Number: 8401 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint
Hello Alex Behm, Mala Chikka Kempanna, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8336 to look at the new patch set (#4). Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint Add some boilerplate wording and reuse the same text in several likely spots where readers might expect it (under the pages for performance tuning with joins, hints, views, and subqueries). Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f --- M docs/shared/impala_common.xml M docs/topics/impala_hints.xml M docs/topics/impala_perf_joins.xml M docs/topics/impala_subqueries.xml M docs/topics/impala_views.xml 5 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8336/4 -- To view, visit http://gerrit.cloudera.org:8080/8336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f Gerrit-Change-Number: 8336 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mala Chikka Kempanna
[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8336 ) Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8336/3/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/8336/3/docs/shared/impala_common.xml@2869 PS3, Line 2869: in the query block containing the hint. It does not affect the join order > I suggest removing the "nested within those table references part" because Done -- To view, visit http://gerrit.cloudera.org:8080/8336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f Gerrit-Change-Number: 8336 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mala Chikka Kempanna Gerrit-Comment-Date: Fri, 20 Oct 2017 20:13:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint
Hello Alex Behm, Mala Chikka Kempanna, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8336 to look at the new patch set (#3). Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint Add some boilerplate wording and reuse the same text in several likely spots where readers might expect it (under the pages for performance tuning with joins, hints, views, and subqueries). Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f --- M docs/shared/impala_common.xml M docs/topics/impala_hints.xml M docs/topics/impala_perf_joins.xml M docs/topics/impala_subqueries.xml M docs/topics/impala_views.xml 5 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8336/3 -- To view, visit http://gerrit.cloudera.org:8080/8336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f Gerrit-Change-Number: 8336 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Mala Chikka Kempanna
[Impala-ASF-CR] IMPALA-6803: [DOCS] Clarify scope of STRAIGHT JOIN hint
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8336 ) Change subject: IMPALA-6803: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8336/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8336/1//COMMIT_MSG@7 PS1, Line 7: [DOCS] Clarify scope of STRAIGHT_JOIN hint > IMPALA-6083 Done http://gerrit.cloudera.org:8080/#/c/8336/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/8336/1/docs/shared/impala_common.xml@2869 PS1, Line 2869: in the topmost query block where the hint occurs. It does not affect the join order > "topmost" is confusing. It is simply the query block in which the hint appe Done http://gerrit.cloudera.org:8080/#/c/8336/1/docs/shared/impala_common.xml@2870 PS1, Line 2870: of any queries nested within those table references, such as subqueries or views. > of any nested queries, such as views, inline views or WHERE-clause subqueri Done http://gerrit.cloudera.org:8080/#/c/8336/1/docs/shared/impala_common.xml@2872 PS1, Line 2872: whichever top-level or nested queries need a specific join order. > apply the hint to all query blocks that need a fixed join order Done -- To view, visit http://gerrit.cloudera.org:8080/8336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f Gerrit-Change-Number: 8336 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mala Chikka Kempanna Gerrit-Comment-Date: Thu, 19 Oct 2017 19:42:46 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Clarify scope of STRAIGHT JOIN hint
Hello Alex Behm, Mala Chikka Kempanna, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8336 to look at the new patch set (#2). Change subject: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. [DOCS] Clarify scope of STRAIGHT_JOIN hint Add some boilerplate wording and reuse the same text in several likely spots where readers might expect it (under the pages for performance tuning with joins, hints, views, and subqueries). Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f --- M docs/shared/impala_common.xml M docs/topics/impala_hints.xml M docs/topics/impala_perf_joins.xml M docs/topics/impala_subqueries.xml M docs/topics/impala_views.xml 5 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8336/2 -- To view, visit http://gerrit.cloudera.org:8080/8336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f Gerrit-Change-Number: 8336 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Mala Chikka Kempanna
[Impala-ASF-CR] [DOCS] Clarify scope of STRAIGHT JOIN hint
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8336 Change subject: [DOCS] Clarify scope of STRAIGHT_JOIN hint .. [DOCS] Clarify scope of STRAIGHT_JOIN hint Add some boilerplate wording and reuse the same text in several likely spots where readers might expect it (under the pages for performance tuning with joins, hints, views, and subqueries). Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f --- M docs/shared/impala_common.xml M docs/topics/impala_hints.xml M docs/topics/impala_perf_joins.xml M docs/topics/impala_subqueries.xml M docs/topics/impala_views.xml 5 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8336/1 -- To view, visit http://gerrit.cloudera.org:8080/8336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd8e4d8e5260f5a2b7b5c52dc3269bb373b9c76f Gerrit-Change-Number: 8336 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 ) Change subject: [DOCS] Fix alphabetical ordering of query options .. Patch Set 2: Code-Review+2 OK, promoting to +2. -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Comment-Date: Thu, 12 Oct 2017 20:24:57 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 ) Change subject: [DOCS] Fix alphabetical ordering of query options .. Patch Set 2: Sure, why not. Oh for some automation around all that. -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Comment-Date: Thu, 12 Oct 2017 20:05:48 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8265 to look at the new patch set (#2). Change subject: [DOCS] Fix alphabetical ordering of query options .. [DOCS] Fix alphabetical ordering of query options There were 2 DE options out of order amongst the DI ones: DEBUG_ACTION DEFAULT_JOIN_DISTRIBUTION_MODE DEFAULT_ORDER_BY_LIMIT DISABLE_CODEGEN DECIMAL_V2 DEFAULT_SPILLABLE_BUFFER_SIZE Moved DECIMAL_V2 and DEFAULT_SPILLABLE_BUFFER_SIZE to the right respective positions. Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 --- M docs/impala.ditamap 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8265/2 -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8265 ) Change subject: [DOCS] Fix alphabetical ordering of query options .. Patch Set 1: This is easy to verify from a newly built PDF. The reordered topics are under SQL Language Reference > SQL Statements > SET Statement > Query Options for SET Statement. -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Comment-Date: Thu, 12 Oct 2017 17:46:50 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix alphabetical ordering of query options
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8265 Change subject: [DOCS] Fix alphabetical ordering of query options .. [DOCS] Fix alphabetical ordering of query options There were 2 DE options out of order amongst the DI ones: DEBUG_ACTION DEFAULT_JOIN_DISTRIBUTION_MODE DEFAULT_ORDER_BY_LIMIT DISABLE_CODEGEN DECIMAL_V2 DEFAULT_SPILLABLE_BUFFER_SIZE Moved DECIMAL_V2 and DEFAULT_SPILLABLE_BUFFER_SIZE to the right respective positions. Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 --- M docs/impala.ditamap 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8265/1 -- To view, visit http://gerrit.cloudera.org:8080/8265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib43d868489c4daaf584e932c19eeb568faf1ebc8 Gerrit-Change-Number: 8265 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 7: Code-Review+2 Maybe I have to carry over Tim's +2 since I did another patch set after that. -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 7 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 07 Oct 2017 00:15:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 7: Verification job appeared to succeed, but didn't find the commit ready to go in push_to_asf.py and it wasn't in master. Perhaps it got messed up because I was running 2 verification jobs simultaneously. Trying again. -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 7 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 07 Oct 2017 00:00:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
Hello Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8003 to look at the new patch set (#7). Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool In particular, the new query options: BUFFER_POOL_LIMIT MAX_ROW_SIZE MIN_SPILLABLE_BUFFER_SIZE DEFAULT_SPILLABLE_BUFFER_SIZE Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml A docs/topics/impala_buffer_pool_limit.xml A docs/topics/impala_default_spillable_buffer_size.xml A docs/topics/impala_max_row_size.xml A docs/topics/impala_min_spillable_buffer_size.xml M docs/topics/impala_scalability.xml 8 files changed, 622 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/8003/7 -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 7 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_buffer_pool_limit.xml File docs/topics/impala_buffer_pool_limit.xml: http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_buffer_pool_limit.xml@53 PS5, Line 53: : : > This area of behaviour in the code is a bit of a mess and subject to change Done http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_default_spillable_buffer_size.xml File docs/topics/impala_default_spillable_buffer_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_default_spillable_buffer_size.xml@72 PS5, Line 72: spill-to-disk operations. Reducing this value may reduce memory consumption. > The last sentence I think creates a lot of potential for confusion. The con Done http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_default_spillable_buffer_size.xml@73 PS5, Line 73: > Impala daemons? Done http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_max_row_size.xml File docs/topics/impala_max_row_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_max_row_size.xml@40 PS5, Line 40: , but that is not guaranteed.) Applies when : constructing intermediate or final rows in the result set. This setting prevents : out-of-control memory use when accessing columns containing huge strings. : > This summary is wrong (the behaviour is subtle). The query option has zero Done http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_max_row_size.xml@69 PS5, Line 69: his setting. > This is correct but I'm concerned some users might take it the wrong way. T OK, will do. But is it not reasonable to worry a little if some rows are > 512 KB? I would imagine that some subtle change (adding or removing a host, HDFS rebalancing, changing the WHERE condition, updating some rows in a Kudu table, changing an impalad config setting) could cause big-row queries to fail where previously they succeeded. http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_min_spillable_buffer_size.xml File docs/topics/impala_min_spillable_buffer_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_min_spillable_buffer_size.xml@49 PS5, Line 49: > Same comments as default_spillable_buffer_size. OK. I added a summary in the first paragraph, which like the DEFAULT_ topic was originally blank. I copied the wording about the tradeoff with a too-high value... but could a user actually lower this setting below 64KB? I got the impression maybe 64KB was already at the low end of the allowable range. http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_scalability.xml@570 PS5, Line 570:On each host that participates in the query, each such operator in a query requires memory > I think this background is helpful for users to understand the implications OK, used your suggested wording. http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_scalability.xml@572 PS5, Line 572:up front for each operator that supports spill-to-disk that is sufficient to execute the > Could we keep this around but make clear that it describes the behaviour in Let's revisit that later. Trying to tease out what is needed in a "Previously," section could be problematic so close to the deadline. http://gerrit.cloudera.org:8080/#/c/8003/5/docs/topics/impala_scalability.xml@627 PS5, Line 627: > Should we mention the old names parenthetically (it was ScratchBytesWritten Done -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 7 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 06 Oct 2017 23:23:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7999/4/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/7999/4/docs/shared/impala_common.xml@1227 PS4, Line 1227: COMPUTE INCREMENTAL STATS during the lifetime of a table, > (or vice versa) Done http://gerrit.cloudera.org:8080/#/c/7999/4/docs/shared/impala_common.xml@1243 PS4, Line 1243: be cached on every impalad host that is eligible to be a coordinator. > as it must be cached on the catalogd and on every ... Done http://gerrit.cloudera.org:8080/#/c/7999/4/docs/shared/impala_common.xml@1244 PS4, Line 1244: If this metadata for a table exceeds 2 GB, you might experience service downtime. > It's worse than that. If the aggregate metadata of *all* tables combined ge Done http://gerrit.cloudera.org:8080/#/c/7999/4/docs/topics/impala_partitioning.xml File docs/topics/impala_partitioning.xml: http://gerrit.cloudera.org:8080/#/c/7999/4/docs/topics/impala_partitioning.xml@612 PS4, Line 612: as new partitions are added, Impala includes a variation of this statement that is intended for use with > How about: Done http://gerrit.cloudera.org:8080/#/c/7999/4/docs/topics/impala_perf_stats.xml File docs/topics/impala_perf_stats.xml: http://gerrit.cloudera.org:8080/#/c/7999/4/docs/topics/impala_perf_stats.xml@361 PS4, Line 361: COMPUTE STATS statement might take hours, or even days. For such tables, use > Sorry, I disagree with the "For such tables, use COMPUTE INCREMENTAL STATS" OK, since this bit is just a pointer to the real writeup elsewhere, why don't I delete the entirely rather than trying to find some softer wording. -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 06 Oct 2017 22:22:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
Hello Greg Rahn, Silvius Rus, Alex Behm, Mostafa Mokhtar, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7999 to look at the new patch set (#5). Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS Explain how doing COMPUTE INCREMENTAL STATS for the first time starts over and discards any previous stats from COMPUTE STATS. As a consequence, moved some wording and examples into impala_common.xml so that content could be used in multiple places. Also made a new subtopic on the "Partitioning" page because I saw COMPUTE INCREMENTAL STATS wasn't mentioned there. Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 --- M docs/shared/impala_common.xml M docs/topics/impala_compute_stats.xml M docs/topics/impala_partitioning.xml M docs/topics/impala_perf_stats.xml 4 files changed, 172 insertions(+), 110 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/7999/5 -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 5 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
Hello Greg Rahn, Silvius Rus, Alex Behm, Mostafa Mokhtar, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7999 to look at the new patch set (#4). Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS Explain how doing COMPUTE INCREMENTAL STATS for the first time starts over and discards any previous stats from COMPUTE STATS. As a consequence, moved some wording and examples into impala_common.xml so that content could be used in multiple places. Also made a new subtopic on the "Partitioning" page because I saw COMPUTE INCREMENTAL STATS wasn't mentioned there. Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 --- M docs/shared/impala_common.xml M docs/topics/impala_compute_stats.xml M docs/topics/impala_partitioning.xml M docs/topics/impala_perf_stats.xml 4 files changed, 180 insertions(+), 107 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/7999/4 -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 2: (3 comments) OK, I think this is about is far as we can go given the scope of the original request, to clarify that you use CS or CIS but not both. I got more details consulting with Alex but that would require something like a tutorial or deep dive to cover what's happening and the tradeoffs for each aspect. http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1233 PS2, Line 1233: When you run COMPUTE INCREMENTAL STATS on a table for the first time, > I suggest some minor rephrasing to drive home the "don't switch mantra" a l Done http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1245 PS2, Line 1245: added or inserted into, you can run COMPUTE INCREMENTAL STATS for the active > Sorry my phrasing might have been misleading. By "active" partitions I mean OK, after consulting with Alex I'm paring this wording way back. Just too many ways that someone could do extra work that was counterproductive or didn't have the benefit that they assumed. http://gerrit.cloudera.org:8080/#/c/7999/3/docs/topics/impala_partitioning.xml File docs/topics/impala_partitioning.xml: http://gerrit.cloudera.org:8080/#/c/7999/3/docs/topics/impala_partitioning.xml@623 PS3, Line 623: is a shortcut for partitioned tables that works on a : subset of partitions rather than the entire table. > How about: Done -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 06 Oct 2017 21:26:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 1: Any committer, for example Lars. (/* +hint,hint */) -- To view, visit http://gerrit.cloudera.org:8080/8190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2662fc79d588f22a24a5067429a57b3c0d0f0f0 Gerrit-Change-Number: 8190 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 06 Oct 2017 18:22:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Tagging in Lars to the review in case he would like to do the +2 based on Greg's +1. (I consider Greg the best arbiter of what makes sense to cover in terms of the built-in functions.) -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 06 Oct 2017 18:21:52 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
John Russell has posted comments on this change. (
http://gerrit.cloudera.org:8080/7999 )
Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
..
Patch Set 2:
(19 comments)
Almost finished with the comments. I'll touch base with Alex to get a little
more clarification about which stats are safe to, or make sense to, DROP
INCREMENTAL STATS for.
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1224
PS2, Line 1224: For a particular table, use either COMPUTE
STATS or
> Yes!
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1228
PS2, Line 1228: DROP STATS and
: DROP INCREMENTAL STATS)
> They are not required if you *exactly* what you are doing, but that does no
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1228
PS2, Line 1228: DROP STATS and
: DROP INCREMENTAL STATS)
> are these drops required?
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1234
PS2, Line 1234: the statistics are computed again from scratch
regardless of whether you previously ran
> regardless of whether the table has existing stats.
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1236
PS2, Line 1236: for scanning the entire table when switching from
COMPUTE STATS to
> when running COMPUTE INCREMENTAL STATS for the first time on a given table.
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1243
PS2, Line 1243: be cached on every impalad host. If
this metadata for a table exceeds
> more specifically, impalads that are also coordinators?
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1243
PS2, Line 1243: be cached on every impalad host. If
this metadata for a table exceeds
> Yes
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1244
PS2, Line 1244: 2 GB, a serious error can occur. If only a limited
number of partitions are actively being
> If the aggregate metadata of all tables exceeds 2 GB you may experience ser
Done. "Serious error" was my compromise I always used for MySQL, where the open
source tradition leaned towards saying "crash" but the enterprise focus
suggested something more euphemistic.
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1247
PS2, Line 1247: does not affect
> Fine with me to expand this to add my earlier explanation of what the "incr
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1247
PS2, Line 1247: does not affect
> does that mean lack of stats has not affect on optimization or something el
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1247
PS2, Line 1247: does not affect
> fair pointer for me, but my comment is about whether this wording is clear
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1247
PS2, Line 1247: does not affect
> Please see my explanation on what "incremental" stats is in previous patch
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1248
PS2, Line 1248: optimizations such as partition pruning.
> such as partition pruning or join ordering.
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1248
PS2, Line 1248: optimizations such as partition pruning.
> Actually I would remove partition pruning because stats have nothing to do
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_partitioning.xml
File docs/topics/impala_partitioning.xml:
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_partitioning.xml@611
PS2, Line 611: frequently
> remove
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_partitioning.xml@623
PS2, Line 623: is a shortcut
> I don't know what "shortcut" means here. I'd remove it.
I'm looking for a way to convey that it's faster to do COMPUTE INCREMENTAL
STATS on a partitioned table than COMPUTE STATS. But the time savings only
happens if you do C.I.S. multiple times, that is, because the table keeps
getting new partitions.
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_perf_stats.xml
File docs/topics/impala_perf_stats.xml:
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_perf_stats.xml@361
PS2, Line 361: COMPUTE STATS statement might take
hours, or even days. That situation is where you switch
> Rephrase to avoid "switch" since switching is bad
Done
http://gerrit.cloudera.org:8080/#/c/7999/2/docs/topics/impala_perf_stats.xml@361
PS2, Line 361: That situation is where you switch
> I'd reword this part ("That situation is where ..."). Suggest
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
Hello Greg Rahn, Silvius Rus, Alex Behm, Mostafa Mokhtar, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7999 to look at the new patch set (#3). Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS Explain how doing COMPUTE INCREMENTAL STATS for the first time starts over and discards any previous stats from COMPUTE STATS. As a consequence, moved some wording and examples into impala_common.xml so that content could be used in multiple places. Also made a new subtopic on the "Partitioning" page because I saw COMPUTE INCREMENTAL STATS wasn't mentioned there. Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 --- M docs/shared/impala_common.xml M docs/topics/impala_compute_stats.xml M docs/topics/impala_partitioning.xml M docs/topics/impala_perf_stats.xml 4 files changed, 184 insertions(+), 107 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/7999/3 -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 1: Lars, should be ready for +2 from any committer. -- To view, visit http://gerrit.cloudera.org:8080/8190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2662fc79d588f22a24a5067429a57b3c0d0f0f0 Gerrit-Change-Number: 8190 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 06 Oct 2017 17:40:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2190: [DOCS] from timestamp() and to timestamp()
John Russell has posted comments on this change. (
http://gerrit.cloudera.org:8080/8046 )
Change subject: IMPALA-2190: [DOCS] from_timestamp() and to_timestamp()
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@791
PS2, Line 791: For efficient date and time calculations, where
possible you store temporal
> Strange sentence: either?
I think this was transposed over from my draft where I was writing up
from_timestamp() and to_timestamp() at the same time. to_timestamp() also
covers the case where you are storing date/time as BIGINT. Why don't I delete
this sentence here.
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@794
PS2, Line 794: into arbitrary formats for reporting purposes.
> into arbitrary string formats
Done
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@797
PS2, Line 797: Because Impala implicitly converts string values in
the recognized -MM-dd HH:mm:ss
> Slightly inaccurate. I'd recommend rephrasing to something like:
Done
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@799
PS2, Line 799: dates/times directly to a different format in your
query output.
> to a different format using from_timestamp()
Done
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@815
PS2, Line 815: -- Reformat string literal representing date/time.
> Nice example!
Done
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@824
PS2, Line 824: select from_timestamp('1984-09-25', 'MMM dd, ');
> Might be good to have a complete example that makes use of all the timestam
Done
http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@2188
PS2, Line 2188: A string argument, plus another string argument
representing the
> Need to document the pattern pieces and their meaning, e.g.:
You know, I thought the complete list was under EXTRACT or TRUNC but now I
don't see anything that matches up exactly. E.g. S isn't recognized for
year; I can't find any variation like Mon that spells out the entire month
instead of the short form. The closest is probably the explanation under
from_unixtime(). Let's make that optional for this go-round, I'll mention
from_unixtime() as the source of truth for now.
--
To view, visit http://gerrit.cloudera.org:8080/8046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f6dfd3fb99a70975d712bbef6c05900eddadd27
Gerrit-Change-Number: 8046
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Andre Calfa
Gerrit-Reviewer: Greg Rahn
Gerrit-Reviewer: John Russell
Gerrit-Comment-Date: Fri, 06 Oct 2017 05:56:01 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2190: [DOCS] from timestamp() and to timestamp()
Hello Greg Rahn, Alex Behm, Andre Calfa, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8046 to look at the new patch set (#3). Change subject: IMPALA-2190: [DOCS] from_timestamp() and to_timestamp() .. IMPALA-2190: [DOCS] from_timestamp() and to_timestamp() These functions have been around for a while but didn't get picked up in the big wave of built-in functions documented in Impala 2.3. Change-Id: I5f6dfd3fb99a70975d712bbef6c05900eddadd27 (cherry picked from commit 60b7540c9938c6d4fcff26d610cd8c0b0ef6cbce) --- M docs/topics/impala_datetime_functions.xml 1 file changed, 144 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/8046/3 -- To view, visit http://gerrit.cloudera.org:8080/8046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f6dfd3fb99a70975d712bbef6c05900eddadd27 Gerrit-Change-Number: 8046 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Andre Calfa Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
Hello Greg Rahn, Silvius Rus, Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7999 to look at the new patch set (#2). Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS Explain how doing COMPUTE INCREMENTAL STATS for the first time starts over and discards any previous stats from COMPUTE STATS. As a consequence, moved some wording and examples into impala_common.xml so that content could be used in multiple places. Also made a new subtopic on the "Partitioning" page because I saw COMPUTE INCREMENTAL STATS wasn't mentioned there. Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 --- M docs/shared/impala_common.xml M docs/topics/impala_compute_stats.xml M docs/topics/impala_partitioning.xml M docs/topics/impala_perf_stats.xml 4 files changed, 182 insertions(+), 107 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/7999/2 -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus
[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 ) Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7999/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/7999/1/docs/shared/impala_common.xml@1226 PS1, Line 1226: and the statistics are computed again from the beginning. Therefore, expect a one-time > from scratch Done http://gerrit.cloudera.org:8080/#/c/7999/1/docs/shared/impala_common.xml@1241 PS1, Line 1241: -- by -1 under #Rows and false under Incremental stats. > I suggest you leave out the -1 under #Rows part since that may be confusing Done. The extra details could make good additions to the 'DROP STATS' and 'background on incremental stats' topics, but let's save that for a followup gerrit. http://gerrit.cloudera.org:8080/#/c/7999/1/docs/topics/impala_partitioning.xml File docs/topics/impala_partitioning.xml: http://gerrit.cloudera.org:8080/#/c/7999/1/docs/topics/impala_partitioning.xml@611 PS1, Line 611: Because the COMPUTE STATS statement can be resource-intensive to run frequently > This advice isn't prescriptive enough for my taste. We should state very cl OK, why don't I fold that into the 'incremental_stats_after_full' note below, and rearrange the text so that note comes earlier. Support is always asking for advice to be in "big red boxes" and the idiom is the most eye-catching way we have to do that. (The original text in the note box is reused on 3 pages: "Partitioning", "Performance - Statistics", and "COMPUTE STATS". I'll include the expanded version of the note in all 3 places.) http://gerrit.cloudera.org:8080/#/c/7999/1/docs/topics/impala_partitioning.xml@613 PS1, Line 613: that is optimized for processing partitioned tables. > I wouldn't say that incremental stats is "optimized" for partitioned tables Done -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Silvius Rus Gerrit-Comment-Date: Fri, 06 Oct 2017 05:21:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 4: (1 comment) Hoping the next reply is "LGTM, +2" and no takebacks. :-) http://gerrit.cloudera.org:8080/#/c/8191/4/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/8191/4/docs/topics/impala_alter_table.xml@66 PS4, Line 66: ALTER TABLE name ALTER [COLUMN] column_name > Ack Just to confirm, no doc change needed as a result of this exchange? -- To view, visit http://gerrit.cloudera.org:8080/8191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d Gerrit-Change-Number: 8191 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 06 Oct 2017 04:49:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 3: No, you're the voice of authority on this one, please +2 if happy. -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Thu, 05 Oct 2017 23:31:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@967 PS1, Line 967: although the encryption layer : adds overhead that might lessen the benefit of the caching. > The closest thing I can think of as being related to this is IMPALA-5909, w OK, sentence removed. -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Thu, 05 Oct 2017 22:51:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Hello Joe McDonnell, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8200 to look at the new patch set (#3). Change subject: IMPALA-4623: [DOCS] Document file handle caching .. IMPALA-4623: [DOCS] Document file handle caching Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f --- M docs/impala_keydefs.ditamap M docs/topics/impala_known_issues.xml M docs/topics/impala_scalability.xml 3 files changed, 92 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/8200/3 -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
Hello Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8003 to look at the new patch set (#6). Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool In particular, the new query options: BUFFER_POOL_LIMIT MAX_ROW_SIZE MIN_SPILLABLE_BUFFER_SIZE DEFAULT_SPILLABLE_BUFFER_SIZE Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml A docs/topics/impala_buffer_pool_limit.xml A docs/topics/impala_default_spillable_buffer_size.xml A docs/topics/impala_max_row_size.xml A docs/topics/impala_min_spillable_buffer_size.xml M docs/topics/impala_scalability.xml 8 files changed, 600 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/8003/6 -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 6 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8191/3/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/8191/3/docs/topics/impala_alter_table.xml@1014 PS3, Line 1014: or compacted > This is not correct. Only storage attribute changes get applied to compacte Done. That's a good distinction, I'll spell it out more fully. -- To view, visit http://gerrit.cloudera.org:8080/8191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d Gerrit-Change-Number: 8191 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 05 Oct 2017 20:54:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
Hello Greg Rahn, Thomas Tauber-Marshall, Ambreen Kazi, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8191 to look at the new patch set (#4). Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax ALTER TABLE syntax for changing Kudu column default and storage attributes. Also SET COMMENT for non-Kudu tables. Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d --- M docs/topics/impala_alter_table.xml 1 file changed, 69 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/8191/4 -- To view, visit http://gerrit.cloudera.org:8080/8191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d Gerrit-Change-Number: 8191 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Hello Joe McDonnell, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8200 to look at the new patch set (#2). Change subject: IMPALA-4623: [DOCS] Document file handle caching .. IMPALA-4623: [DOCS] Document file handle caching Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f --- M docs/impala_keydefs.ditamap M docs/topics/impala_known_issues.xml M docs/topics/impala_scalability.xml 3 files changed, 94 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/8200/2 -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_known_issues.xml@338 PS1, Line 338: continuously appended by an HDFS mechanism > This also applies if an HDFS file is overwritten in place. Done -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Thu, 05 Oct 2017 20:48:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 ) Change subject: IMPALA-4623: [DOCS] Document file handle caching .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml File docs/topics/impala_scalability.xml: http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@967 PS1, Line 967: although the encryption layer : adds overhead that might lessen the benefit of the caching. > I'm not familiar with this overhead. What is this referring to? I had written in the notes from our conversation HDFS encryption adds overhead". >From when we were thinking about all the other complicating factors, like Sentry GRANT/REVOKE. http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@973 PS1, Line 973: 20 thousand > Just curious: How do you decide to use "20 thousand" vs "20,000"? For big numbers, I try to stick with either spelled-out forms or obvious powers of 2. (Like I would say 65536 with no comma.) There are so many other separator conventions internationally (https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html) I don't want to be too US-centric. http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@991 PS1, Line 991: evict any stale file handles from the cache > The file handles won't actually be evicted directly. The new metadata will Done http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@995 PS1, Line 995: To evaluate the effectiveness of file handle caching for a particular workload, issue the : PROFILE statement in impala-shell or examine query : profiles in the Impala web UI. Look for the ratio of CachedFileHandlesHitCount : (ideally, should be high) to CachedFileHandlesMissCount (ideally, should be low). : Before starting any evaluation, run some representative queries to warm up the cache, : because the first time each data file is accessed is always recorded as a cache miss. > I'm not sure this belongs here, but information about the cache across the Let's be inclusive for this first iteration and then fine-tune later if needed. We tend to be skimpy with such information which is a weakness IMO. -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Thu, 05 Oct 2017 20:48:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8165 ) Change subject: IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8165/2/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/8165/2/docs/topics/impala_known_issues.xml@320 PS2, Line 320: The slowdown only occurs when processing Parquet files that were generated by Hive, and > Lockup happens when reading a timestamp column, not any column within the f Done -- To view, visit http://gerrit.cloudera.org:8080/8165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c Gerrit-Change-Number: 8165 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Thu, 05 Oct 2017 20:33:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown
Hello Attila Jeges, Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8165 to look at the new patch set (#3). Change subject: IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown .. IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c --- M docs/topics/impala_known_issues.xml 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8165/3 -- To view, visit http://gerrit.cloudera.org:8080/8165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c Gerrit-Change-Number: 8165 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: (1 comment) I pulled the numeric aspect of trunc() out of Date/Time Functions and added it into the existing trunc() / dtrunc() entry under Arithmetic Functions. Because we have so many cases of multiple names/aliases for the same function, our practice is to cover them all together rather than make individual entries for each. http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml@2174 PS3, Line 2174: dt> : > Why don't we add a pointer from dtrunc / truncate to here. Those are covere Done -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Thu, 05 Oct 2017 18:36:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Hello Greg Rahn, Alex Behm, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8189 to look at the new patch set (#4). Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. IMPALA-5529: [DOCS] New trunc() signatures Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 --- M docs/topics/impala_datetime_functions.xml M docs/topics/impala_math_functions.xml 2 files changed, 170 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8189/4 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul
[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 1: OK, looks like the those other *utc* names are not directly related. Let's confine this gerrit to strictly the utc_timestamp() function. -- To view, visit http://gerrit.cloudera.org:8080/8190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2662fc79d588f22a24a5067429a57b3c0d0f0f0 Gerrit-Change-Number: 8190 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Thu, 05 Oct 2017 18:08:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml File docs/topics/impala_buffer_pool_limit.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml@53 PS4, Line 53: MiB > MB. I may have mixed up MB / KB and MiB / KiB in a few places throughout. M Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml File docs/topics/impala_max_row_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@68 PS4, Line 68:
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
Hello Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8003 to look at the new patch set (#5). Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool In particular, the new query options: BUFFER_POOL_LIMIT MAX_ROW_SIZE MIN_SPILLABLE_BUFFER_SIZE <- Maybe the 'spillable' part of the name will change to 'spill', as used in other BP-related discussions. Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml A docs/topics/impala_buffer_pool_limit.xml A docs/topics/impala_default_spillable_buffer_size.xml A docs/topics/impala_max_row_size.xml A docs/topics/impala_min_spillable_buffer_size.xml M docs/topics/impala_scalability.xml 8 files changed, 600 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/8003/5 -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 5 Gerrit-Owner: John Russell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. Patch Set 4: (21 comments) http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml File docs/topics/impala_buffer_pool_limit.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml@39 PS4, Line 39: Defines the size in bytes of an internal buffer for allocating memory during queries. > First sentence isn't accurate. Something like this might be better: "Define Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml@53 PS4, Line 53: MiB MB. I may have mixed up MB / KB and MiB / KiB in a few places throughout. MB / KB = powers of 2, MiB / KiB = powers of 10. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml@53 PS4, Line 53: his default is represented by a value : of 0. > The default is actually that the query option is unset. 0 means a limit of Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml@69 PS4, Line 69: set buffer_pool_limit=8GB; > It can also be expressed as a percentage of mem_limit (e.g. 80%), which may Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_default_spillable_buffer_size.xml File docs/topics/impala_default_spillable_buffer_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_default_spillable_buffer_size.xml@44 PS4, Line 44: > Do we document somewhere the supported byte suffixes (e.g. B, KB, MB, GB pl Done. I'll reuse wording to that effect from the MEM_LIMIT page. I trust that of these new query options, only BUFFER_LIMIT accepts a percentage, the others are purely sizes in bytes, correct? http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_default_spillable_buffer_size.xml@49 PS4, Line 49: > I think it's confusing to say that the default varies, since the query opti Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_default_spillable_buffer_size.xml@50 PS4, Line 50: 65536 to 2097152, depending on the > Feel free to ignore, but might be easier to read if they were human-readabl Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_default_spillable_buffer_size.xml@59 PS4, Line 59: consider increasing the DEFAULT_SPILLABLE_BUFFER_SIZE setting. > Would it be helpful to elaborate here? E.g. "Larger buffer sizes will resul Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_default_spillable_buffer_size.xml@61 PS4, Line 61: > It's implied but would it make sense to state the inverse. I.e. decreasing Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml File docs/topics/impala_max_row_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@47 PS4, Line 47: 524288 > 512K to be human-readable? Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@56 PS4, Line 56: accomodate > sp: accommodate That and 'separate' vs. 'seperate' are my kryptonite. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@57 PS4, Line 57: the total bytes stored in the largest row. > It's left ambiguous whether queries processing rows larger than MAX_ROW_SIZ Good point. In my testing I tried to come close to the boundary with a 530 K row size and was surprised that the query succeeded. Oops, I see this ties in to the initial description of the option purpose, which I left blank by mistake. I'll fill that in above. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@82 PS4, Line 82: 500 KB string and a 30 KB These are actually KiB. I didn't mean to actually cut it so close (530,000 vs. 524,288 limit). I couldn't make this slightly-too-large row cause a failure. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@95 PS4, Line 95: KiB Agh, KiB again where it should be KB. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@109 PS4, Line 109: Increase the max_row_size query option (currently 512.00 KB) to process larger rows. Wrap these very long error message lines. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_min_spillable_buffer_size.xml File docs/topics/impala_min_spillable_buffer_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_min_spillable_buffer_size.xml@38 PS4, Line 38: MIN_SPILLABLE_BUFFER_SIZE query option > I think most of the comments I made on DEFAULT_SPILLABLE_BUFFER_SIZE have a Done. Please doublecheck whether the wording I lifted from the DEFAULT_ page also makes sense here. E.g. is it even possible to lower the MIN_ setting to less than 64 KB, or could you only ev
[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
Hello Greg Rahn, Thomas Tauber-Marshall, Ambreen Kazi, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8191 to look at the new patch set (#3). Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax ALTER TABLE syntax for changing Kudu column default and storage attributes. Also SET COMMENT for non-Kudu tables. Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d --- M docs/topics/impala_alter_table.xml 1 file changed, 68 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/8191/3 -- To view, visit http://gerrit.cloudera.org:8080/8191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d Gerrit-Change-Number: 8191 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
John Russell has posted comments on this change. (
http://gerrit.cloudera.org:8080/8191 )
Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:
http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@67
PS2, Line 67: ]
> extraneous?
Done
http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@69
PS2, Line 69: COMMENT 'comment_text'
> This does parse, but it will always give an error because Kudu doesn't supp
Done. Let's take out this COMMENT part because I added lines 73-75 for SET
COMMENT for non-Kudu tables.
http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@71
PS2, Line 71: {
> missing the closing '}'
Done
http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@1038
PS2, Line 1038: any newly inserted rows
> These attributes may in some cases end up applied to existing rows as Kudu
Done
--
To view, visit http://gerrit.cloudera.org:8080/8191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d
Gerrit-Change-Number: 8191
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell
Gerrit-Reviewer: Ambreen Kazi
Gerrit-Reviewer: Greg Rahn
Gerrit-Reviewer: John Russell
Gerrit-Reviewer: Thomas Tauber-Marshall
Gerrit-Reviewer: Todd Lipcon
Gerrit-Comment-Date: Wed, 04 Oct 2017 18:02:06 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7983 ) Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps .. Patch Set 2: Let me see about looping in the original requester who probably isn't looking at this gerrit. I was hoping for some more back-and-forth ending in a clear decision about how to handle suboptimal-but-what-we-have-today details w.r.t. UDFs. -- To view, visit http://gerrit.cloudera.org:8080/7983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b67cd7762f682c3a054e0d9641080aa51801c83 Gerrit-Change-Number: 7983 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 03 Oct 2017 22:30:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8200 Change subject: IMPALA-4623: [DOCS] Document file handle caching .. IMPALA-4623: [DOCS] Document file handle caching Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f --- M docs/impala_keydefs.ditamap M docs/topics/impala_known_issues.xml M docs/topics/impala_scalability.xml 3 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/8200/1 -- To view, visit http://gerrit.cloudera.org:8080/8200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f Gerrit-Change-Number: 8200 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool
John Russell has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8003 ) Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool .. IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool In particular, the new query options: BUFFER_POOL_LIMIT MAX_ROW_SIZE MIN_SPILLABLE_BUFFER_SIZE <- Maybe the 'spillable' part of the name will change to 'spill', as used in other BP-related discussions. Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e --- M docs/impala.ditamap M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml A docs/topics/impala_buffer_pool_limit.xml A docs/topics/impala_default_spillable_buffer_size.xml A docs/topics/impala_max_row_size.xml A docs/topics/impala_min_spillable_buffer_size.xml M docs/topics/impala_scalability.xml 8 files changed, 506 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/8003/4 -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5383: [DOCS] Document unpartitioned Kudu tables
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8180 ) Change subject: IMPALA-5383: [DOCS] Document unpartitioned Kudu tables .. Patch Set 3: (1 comment) Thomas, good catch. I rearranged the CDATA [ ] delimiters to allow tags in the first part while preserving the < characters unescaped in the second part. Also had to rebase to make the substitution resolve. http://gerrit.cloudera.org:8080/#/c/8180/3/docs/topics/impala_create_table.xml File docs/topics/impala_create_table.xml: http://gerrit.cloudera.org:8080/#/c/8180/3/docs/topics/impala_create_table.xml@483 PS3, Line 483: -- Single partition. Only for > When I built this locally, these tags were present in the output. Done -- To view, visit http://gerrit.cloudera.org:8080/8180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b466e1e482d62de84253c0cb406668fd5ad5eb Gerrit-Change-Number: 8180 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 02 Oct 2017 23:11:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5383: [DOCS] Document unpartitioned Kudu tables
Hello Thomas Tauber-Marshall, Ambreen Kazi, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8180 to look at the new patch set (#4). Change subject: IMPALA-5383: [DOCS] Document unpartitioned Kudu tables .. IMPALA-5383: [DOCS] Document unpartitioned Kudu tables Change-Id: Ia2b466e1e482d62de84253c0cb406668fd5ad5eb --- M docs/impala_keydefs.ditamap M docs/topics/impala_create_table.xml 2 files changed, 25 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/8180/4 -- To view, visit http://gerrit.cloudera.org:8080/8180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia2b466e1e482d62de84253c0cb406668fd5ad5eb Gerrit-Change-Number: 8180 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax
John Russell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax ALTER TABLE syntax for changing Kudu column default and storage attributes. Also SET COMMENT for non-Kudu tables. Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d --- M docs/topics/impala_alter_table.xml 1 file changed, 69 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/8191/2 -- To view, visit http://gerrit.cloudera.org:8080/8191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d Gerrit-Change-Number: 8191 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml@2174 PS3, Line 2174: trunc(numeric n), : trunc(decimal d, integer scale) Why don't we add a pointer from dtrunc / truncate to here. Those are covered under "Mathematical Functions". Actually it feels strange to have trunc() doing double duty as a date/time functiona and a math function, both listed on the Date/Time Functions page. But I don't want to make entries labelled "trunc()" on both pages. Maybe I can reuse some of the text and examples for numeric trunc() under truncate() on the math functions page. -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Mon, 02 Oct 2017 17:15:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8190 Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. IMPALA-3504: [DOCS] Document utc_timestamp() This function seems to be related to unix_micros_to_utc_timestamp() and utc_to_unix_micros() which are also not currently documented. Did they all come in at the same time or have the *unix_micros* ones existed for a while? Change-Id: Ia2662fc79d588f22a24a5067429a57b3c0d0f0f0 --- M docs/topics/impala_datetime_functions.xml 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/8190/1 -- To view, visit http://gerrit.cloudera.org:8080/8190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2662fc79d588f22a24a5067429a57b3c0d0f0f0 Gerrit-Change-Number: 8190 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-2190: [DOCS] from timestamp() and to timestamp()
John Russell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8046 ) Change subject: IMPALA-2190: [DOCS] from_timestamp() and to_timestamp() .. IMPALA-2190: [DOCS] from_timestamp() and to_timestamp() These functions have been around for a while but didn't get picked up in the big wave of built-in functions documented in Impala 2.3. Change-Id: I5f6dfd3fb99a70975d712bbef6c05900eddadd27 (cherry picked from commit 60b7540c9938c6d4fcff26d610cd8c0b0ef6cbce) --- M docs/topics/impala_datetime_functions.xml 1 file changed, 142 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/8046/2 -- To view, visit http://gerrit.cloudera.org:8080/8046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5f6dfd3fb99a70975d712bbef6c05900eddadd27 Gerrit-Change-Number: 8046 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. IMPALA-5529: [DOCS] New trunc() signatures Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 --- M docs/topics/impala_datetime_functions.xml 1 file changed, 136 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8189/3 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5383: [DOCS] Document unpartitioned Kudu tables
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8180 ) Change subject: IMPALA-5383: [DOCS] Document unpartitioned Kudu tables .. Patch Set 3: Thomas, can I tag you in for a few Kudu-related reviews for 5.13, in place of MJ? -- To view, visit http://gerrit.cloudera.org:8080/8180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b466e1e482d62de84253c0cb406668fd5ad5eb Gerrit-Change-Number: 8180 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Fri, 29 Sep 2017 22:43:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5383: [DOCS] Document unpartitioned Kudu tables
John Russell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8180 ) Change subject: IMPALA-5383: [DOCS] Document unpartitioned Kudu tables .. IMPALA-5383: [DOCS] Document unpartitioned Kudu tables Change-Id: Ia2b466e1e482d62de84253c0cb406668fd5ad5eb --- M docs/topics/impala_create_table.xml 1 file changed, 22 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/8180/3 -- To view, visit http://gerrit.cloudera.org:8080/8180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia2b466e1e482d62de84253c0cb406668fd5ad5eb Gerrit-Change-Number: 8180 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8165 ) Change subject: IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8165/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: http://gerrit.cloudera.org:8080/#/c/8165/1/docs/topics/impala_known_issues.xml@316 PS1, Line 316: of slowdown depends on factors such as the number of cores and number of threads involved in the query. > State explicitly that slowdowns of up to 30x have been observed for scan-he Done -- To view, visit http://gerrit.cloudera.org:8080/8165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c Gerrit-Change-Number: 8165 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Comment-Date: Fri, 29 Sep 2017 18:40:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown
Hello Attila Jeges, Alex Behm, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8165 to look at the new patch set (#2). Change subject: IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown .. IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c --- M docs/topics/impala_known_issues.xml 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8165/2 -- To view, visit http://gerrit.cloudera.org:8080/8165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c Gerrit-Change-Number: 8165 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Mostafa Mokhtar
[Impala-ASF-CR] IMPALA-992: [DOCS] Document impala-shell 'rerun' command
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8044 ) Change subject: IMPALA-992: [DOCS] Document impala-shell 'rerun' command .. Patch Set 3: Code-Review+2 One tiny invisible change to make the new subtopic easier to link to. I'll carry over Alex's +2. -- To view, visit http://gerrit.cloudera.org:8080/8044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78b353af3b3d8386c243f884b37442b5283a96a8 Gerrit-Change-Number: 8044 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Fri, 29 Sep 2017 18:30:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-992: [DOCS] Document impala-shell 'rerun' command
Hello Tianyi Wang, Sailesh Mukil, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8044 to look at the new patch set (#3). Change subject: IMPALA-992: [DOCS] Document impala-shell 'rerun' command .. IMPALA-992: [DOCS] Document impala-shell 'rerun' command Change-Id: I78b353af3b3d8386c243f884b37442b5283a96a8 --- M docs/impala_keydefs.ditamap M docs/topics/impala_shell_commands.xml M docs/topics/impala_shell_running_commands.xml 3 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/8044/3 -- To view, visit http://gerrit.cloudera.org:8080/8044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78b353af3b3d8386c243f884b37442b5283a96a8 Gerrit-Change-Number: 8044 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR] IMPALA-992: [DOCS] Document impala-shell 'rerun' command
John Russell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8044 ) Change subject: IMPALA-992: [DOCS] Document impala-shell 'rerun' command .. IMPALA-992: [DOCS] Document impala-shell 'rerun' command Change-Id: I78b353af3b3d8386c243f884b37442b5283a96a8 --- M docs/topics/impala_shell_commands.xml M docs/topics/impala_shell_running_commands.xml 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/8044/2 -- To view, visit http://gerrit.cloudera.org:8080/8044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I78b353af3b3d8386c243f884b37442b5283a96a8 Gerrit-Change-Number: 8044 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8165 Change subject: IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown .. IMPALA-3316: [DOCS] Add known issue for timezone conversion slowdown Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c --- M docs/topics/impala_known_issues.xml 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8165/1 -- To view, visit http://gerrit.cloudera.org:8080/8165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9933ced07e339d589f7f74173cfebe938084e65c Gerrit-Change-Number: 8165 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] [DOCS] Fill in release note subtopics for Apache Impala 2.10
John Russell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/7958 ) Change subject: [DOCS] Fill in release note subtopics for Apache Impala 2.10 .. [DOCS] Fill in release note subtopics for Apache Impala 2.10 Primarily just pointing to the list of issues in the changelog. Those cover the different use cases for the different parts of the release notes -- fixed issues, new features, and incompatible changes. Change-Id: Ide38c1e1c64dac287b180b39ebb8e7735d457ce3 --- M docs/impala_keydefs.ditamap M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_new_features.xml 4 files changed, 54 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/7958/3 -- To view, visit http://gerrit.cloudera.org:8080/7958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide38c1e1c64dac287b180b39ebb8e7735d457ce3 Gerrit-Change-Number: 7958 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell
[Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps
John Russell has posted comments on this change. Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps .. Patch Set 2: Tim and Michael, I added you as reviewers based on your frequent activity in be/src/exprs/. If someone else is more familiar with the compilation aspect w.r.t. TIMESTAMP, please suggest any other reviewer. -- To view, visit http://gerrit.cloudera.org:8080/7983 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b67cd7762f682c3a054e0d9641080aa51801c83 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5894: [DOCS] Clarify placement of STRAIGHT JOIN hint
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/8031 Change subject: IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint .. IMPALA-5894: [DOCS] Clarify placement of STRAIGHT_JOIN hint "immediately after the SELECT keyword" was mentioned in a few places for STRAIGHT_JOIN. I reworded all instances to mention that [DISTINCT | ALL] can also come before the hint name. Change-Id: I3cac1afccc132f389b2017ad217fdf7e7b04513a --- M docs/shared/impala_common.xml M docs/topics/impala_hints.xml M docs/topics/impala_perf_joins.xml 3 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/8031/1 -- To view, visit http://gerrit.cloudera.org:8080/8031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3cac1afccc132f389b2017ad217fdf7e7b04513a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell
