[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build, which succeeded. Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Reviewed-on: http://gerrit.cloudera.org:8080/4771 Reviewed-by: Tim Armstrong Tested-by: Internal Jenkins --- M bin/bootstrap_toolchain.py M bin/impala-config.sh 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Jim Apple has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build, which succeeded. Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb --- M bin/bootstrap_toolchain.py M bin/impala-config.sh 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4771/3 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4771 to look at the new patch set (#3). Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build, which succeeded. Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb --- M bin/bootstrap_toolchain.py M bin/impala-config.sh 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4771/3 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/2/bin/impala-config.sh File bin/impala-config.sh: Line 56: : ${IMPALA_TOOLCHAIN_BUILD_ID=249-2267164200} > This could use a bit more explanation. How should a person discover this va Done -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Jim Apple has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4771/2//COMMIT_MSG Commit Message: PS2, Line 10: cceeded I think the reason Gerrit displays these in blue while the first two letters are black is because "cceeded" is a 7-character git hash :-) http://gerrit.cloudera.org:8080/#/c/4771/2/bin/impala-config.sh File bin/impala-config.sh: Line 56: : ${IMPALA_TOOLCHAIN_BUILD_ID=249-2267164200} This could use a bit more explanation. How should a person discover this value? When should it be changed? -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Michael Brown has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: PS1, Line 91: file_name = "{0}-{1}-{2}-{3}.tar.gz".format(product, version, compiler, label) : url_path = "/{0}/{1}/{2}-{3}/{1}-{2}-{3}-{4}.tar.gz".format(toolchain_build_id, product, : version, compiler, label) > Would you be agreeable to using kwargs in str.format()? That would allow yo Good idea. -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build, which succeeded. Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb --- M bin/bootstrap_toolchain.py M bin/impala-config.sh 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4771/2 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Michael Brown has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: PS1, Line 91: file_name = "{0}-{1}-{2}-{3}.tar.gz".format(product, version, compiler, label) : url_path = "/{0}/{1}/{2}-{3}/{1}-{2}-{3}-{4}.tar.gz".format(toolchain_build_id, product, : version, compiler, label) Would you be agreeable to using kwargs in str.format()? That would allow you to have more readable format strings. formatted_str = '{key1}/{key2}'.format(key1=value1, key2=value2) -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4771 Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build, which succeeded. Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb --- M bin/bootstrap_toolchain.py M bin/impala-config.sh 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4771/1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong