[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6069/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
> Got the same comment from Jim. Stopped doing it this way. Not really a good
I think it is a good use of time. It should take roughly 90 seconds.


-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Laurel Hale (Code Review)]

Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..


Patch Set 3:

Please review these so we can get them pushed to master.

-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Laurel Hale (Code Review)]

Laurel Hale has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..


Patch Set 3:

(6 comments)

Ambreen, I addressed your comment about the audience=Cloudera in 
impala_common.xml. Please review and +1 if you can. Thanks.

http://gerrit.cloudera.org:8080/#/c/6069/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
> In the commit message, have a blank line after this one. Otherwise it's tre
Got the same comment from Jim. Stopped doing it this way. Not really a good use 
of time to redo for this.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 1475: . 
  : You can specify a single directory, or a 
comma-separated list of di
> I would say just take out the whole phrase.
Done


http://gerrit.cloudera.org:8080/#/c/6069/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS2, Line 3665: "hidden">
> replace with 'hidden' -- There was a separate gerrit to replace all of thes
Done


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_resources.xml
File docs/topics/impala_perf_resources.xml:

PS1, Line 78: such as cgroups
> Question for MJ, whether the reference to cgroups is appropriate anymore at
Did you add him to the review? I don't see it.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_testing.xml
File docs/topics/impala_perf_testing.xml:

PS1, Line 46: 
: 
> Watch out for trailing spaces or tabs on these new blank lines.
I'm very careful about these. I insert a space and then a return to keep the 
chunks of text manageable. Don't think any change is necessary here.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS1, Line 505: On systems using cluster management software or those not using 
cluster management
 : software
> That's a little bit convoluted phrasing. Let's find an SME on the dev team 
Just checked in with Alex B. to find an LZO setup guru on the Impala team.


-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Laurel Hale (Code Review)]

Laurel Hale has uploaded a new patch set (#3).

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..

IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Most of these fixes involved hiding the paragraphs with
the DITA attribute 'audience="hidden"' and then inserting
a paragraph suitable for upstream documentation. This
hides the mention of Cloudera Manager in the rendered
documentation. In a subsequent cleanup project, the
"Cloudera Manager" mentions will be removed from the
XML. This patch set (#3) includes another change to
impala_common.xml requested by Ambreen. I've replaced
three instances of 'audience="Cloudera"' with
'audience="hidden".'

Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
---
M docs/shared/impala_common.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_txtfile.xml
6 files changed, 60 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Ambreen Kazi (Code Review)]

Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6069/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS2, Line 3665: "Cloudera"
replace with 'hidden' -- There was a separate gerrit to replace all of these 
and it's already been merged --  looks like this one got left out.


-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Laurel Hale (Code Review)]

Laurel Hale has uploaded a new patch set (#2).

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..

IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Most of these fixes involved hiding the paragraphs with
the DITA attribute 'audience="hidden"' and then inserting
a paragraph suitable for upstream documentation. This
hides the mention of Cloudera Manager in the rendered
documentation. In a subsequent cleanup project, the
"Cloudera Manager" mentions will be removed from the
XML. This patch includes a fix to impala_common.xml
requested by John Russell.

Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
---
M docs/shared/impala_common.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_txtfile.xml
6 files changed, 56 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[John Russell (Code Review)]

John Russell has posted comments on this change.

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6069/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
In the commit message, have a blank line after this one. Otherwise it's treated 
like a single very long line in notifications.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 1475:  or the
  : equivalent configuration option in your cluster 
management software
I would say just take out the whole phrase.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_resources.xml
File docs/topics/impala_perf_resources.xml:

PS1, Line 78: such as cgroups
Question for MJ, whether the reference to cgroups is appropriate anymore at all.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_testing.xml
File docs/topics/impala_perf_testing.xml:

PS1, Line 46: 
: 
Watch out for trailing spaces or tabs on these new blank lines.


http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS1, Line 505: On systems using cluster management software or those not using 
cluster management
 : software
That's a little bit convoluted phrasing. Let's find an SME on the dev team who 
can sanity check the LZO setup instructions and add them as a reviewer.


-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale 
Gerrit-Reviewer: Ambreen Kazi 
Gerrit-Reviewer: John Russell 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph s

[Laurel Hale (Code Review)]

Laurel Hale has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6069

Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most 
of these fixes involved hiding the paragraphs with the DITA attribute 
'audience="hidden"' and then inserting a paragraph suitable for upstream 
documentation. This hides the mention of Cloudera 
..

IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal.
Most of these fixes involved hiding the paragraphs with
the DITA attribute 'audience="hidden"' and then inserting
a paragraph suitable for upstream documentation. This
hides the mention of Cloudera Manager in the rendered
documentation. In a subsequent cleanup project, the
"Cloudera Manager" mentions will be removed from the
XML.

Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
---
M docs/shared/impala_common.xml
M docs/topics/impala_perf_resources.xml
M docs/topics/impala_perf_skew.xml
M docs/topics/impala_perf_testing.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_txtfile.xml
6 files changed, 49 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6069/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale