[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..


IMPALA-4454: test_kudu.TestShowCreateTable flaky

The cause of the flakiness is Kudu CREATE TABLE operations
that are sometimes taking a long time, leading to timeouts
in the hiveserver2 connection. This patch adds the ability
for tests using the 'conn' pytest fixture to specify a
timeout to connect(), and sets a timeout of 5 minutes for
this test.

Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
Reviewed-on: http://gerrit.cloudera.org:8080/5040
Reviewed-by: Michael Brown 
Reviewed-by: Alex Behm 
Tested-by: Internal Jenkins
---
M tests/conftest.py
M tests/query_test/test_kudu.py
2 files changed, 14 insertions(+), 5 deletions(-)

Approvals:
  Michael Brown: Looks good to me, but someone else must approve
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Thomas Tauber-Marshall 

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py
File tests/conftest.py:

PS1, Line 331:   use_unique_conn = __call_cls_method_if_exists(request.cls, 
"auto_create_db")
> Instead of hard coding 45 in several places, can you create a constant for 
Added a constant, but it seems weird to mention the JIRA here since this is 
fairly general purpose and mentioning the JIRA in the actual test should be 
enough for anyone who's curious.


http://gerrit.cloudera.org:8080/#/c/5040/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

PS1, Line 205: # For IMPALA-4454
> Can you mention the Jira here, so that when someone else comes across this 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change.

Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py
File tests/conftest.py:

PS1, Line 331:   timeout = __call_cls_method_if_exists(request.cls, 
"get_conn_timeout") or 45
Instead of hard coding 45 in several places, can you create a constant for use 
in all the places 45 is hardcoded? Also please have a comment pointing to the 
Jira so a user understands why it's here.


http://gerrit.cloudera.org:8080/#/c/5040/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

PS1, Line 205: return 60 * 5 # 5 minutes
Can you mention the Jira here, so that when someone else comes across this 
code, he has a reference for the intent?


-- 
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

[Thomas Tauber-Marshall (Code Review)]

Thomas Tauber-Marshall has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5040

Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..

IMPALA-4454: test_kudu.TestShowCreateTable flaky

The cause of the flakiness is Kudu CREATE TABLE operations
that are sometimes taking a long time, leading to timeouts
in the hiveserver2 connection. This patch adds the ability
for tests using the 'conn' pytest fixture to specify a
timeout to connect(), and sets a timeout of 5 minutes for
this test.

Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
---
M tests/conftest.py
M tests/query_test/test_kudu.py
2 files changed, 11 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/5040/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2727c27ff66140ac4043bcad332cd4e1d72b255f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall