[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. IMPALA-5342: Add comments of loaded tables in the response of GetTables This commit changes the response of HiveServer2 GetTables request to return the comments (if any) of loaded tables. For unloaded tables or for tables with no comments an empty string is returned. Testing: - Added a new Frontend test. Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Reviewed-on: http://gerrit.cloudera.org:8080/6933 Reviewed-by: Dimitris Tsirogiannis Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/MetadataOp.java M fe/src/test/java/org/apache/impala/service/FrontendTest.java 2 files changed, 48 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Dimitris Tsirogiannis: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/615/ -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/614/ -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/613/ -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 3: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Alex Behm has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: Line 218: // comments[i][j] are the comments of tableNames[j] in dbs[i]. > is the comment Done Line 291: comment = table.getMetaStoreTable().getParameters().get("comment"); > Is there an HMS constant for this? Couldn't find any. Let me know if you've seen one. http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: Line 184: Db testDb = addTestDb(dbName, "Stores tables with comments"); > Should we fix this for DB comments as well? Or does that already work as ex Good question. Actually, the HS2 API doesn't seem to include the comment in the GetSchemas request, so I am not sure we should include it. -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. IMPALA-5342: Add comments of loaded tables in the response of GetTables This commit changes the response of HiveServer2 GetTables request to return the comments (if any) of loaded tables. For unloaded tables or for tables with no comments an empty string is returned. Testing: - Added a new Frontend test. Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d --- M fe/src/main/java/org/apache/impala/service/MetadataOp.java M fe/src/test/java/org/apache/impala/service/FrontendTest.java 2 files changed, 48 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/6933/2 -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Alex Behm has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: Line 218: // comments[i][j] are the comments of tableNames[j] in dbs[i]. is the comment Line 291: comment = table.getMetaStoreTable().getParameters().get("comment"); Is there an HMS constant for this? http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: Line 184: Db testDb = addTestDb(dbName, "Stores tables with comments"); Should we fix this for DB comments as well? Or does that already work as expected? -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis Gerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6933 Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. IMPALA-5342: Add comments of loaded tables in the response of GetTables This commit changes the response of HiveServer2 GetTables request to return the comments (if any) of loaded tables. For unloaded tables or for tables with no comments an empty string is returned. Testing: - Added a new Frontend test. Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d --- M fe/src/main/java/org/apache/impala/service/MetadataOp.java M fe/src/test/java/org/apache/impala/service/FrontendTest.java 2 files changed, 48 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/6933/1 -- To view, visit http://gerrit.cloudera.org:8080/6933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61f327168a93ceb4bd60b47474f39bfa405ae07d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis