[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 06 Oct 2017 22:29:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. IMPALA-5529: [DOCS] New trunc() signatures Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Reviewed-on: http://gerrit.cloudera.org:8080/8189 Reviewed-by: Greg Rahn Reviewed-by: Thomas Tauber-Marshall Tested-by: Impala Public Jenkins --- M docs/topics/impala_datetime_functions.xml M docs/topics/impala_math_functions.xml 2 files changed, 170 insertions(+), 17 deletions(-) Approvals: Greg Rahn: Looks good to me, but someone else must approve Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 5 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/163/ -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 06 Oct 2017 22:24:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 06 Oct 2017 21:59:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: I lack context here, but I'll ask Thomas to have another look. He was one of the reviewers of the original change. -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 06 Oct 2017 19:29:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Tagging in Lars to the review in case he would like to do the +2 based on Greg's +1. (I consider Greg the best arbiter of what makes sense to cover in terms of the built-in functions.) -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 06 Oct 2017 18:21:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Fri, 06 Oct 2017 17:37:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: (1 comment) I pulled the numeric aspect of trunc() out of Date/Time Functions and added it into the existing trunc() / dtrunc() entry under Arithmetic Functions. Because we have so many cases of multiple names/aliases for the same function, our practice is to cover them all together rather than make individual entries for each. http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml@2174 PS3, Line 2174: dt> : > Why don't we add a pointer from dtrunc / truncate to here. Those are covere Done -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Thu, 05 Oct 2017 18:36:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Hello Greg Rahn, Alex Behm, Kim Jin Chul, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8189 to look at the new patch set (#4). Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. IMPALA-5529: [DOCS] New trunc() signatures Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 --- M docs/topics/impala_datetime_functions.xml M docs/topics/impala_math_functions.xml 2 files changed, 170 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8189/4 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 3: > (1 comment) There should be TRUNC(timestamp) and TRUNC(number) -- Oracle docs have exactly this. https://docs.oracle.com/database/121/SQLRF/functions237.htm#SQLRF06150 https://docs.oracle.com/database/121/SQLRF/functions236.htm#SQLRF06151 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Mon, 02 Oct 2017 22:15:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8189/3/docs/topics/impala_datetime_functions.xml@2174 PS3, Line 2174: trunc(numeric n), : trunc(decimal d, integer scale) Why don't we add a pointer from dtrunc / truncate to here. Those are covered under "Mathematical Functions". Actually it feels strange to have trunc() doing double duty as a date/time functiona and a math function, both listed on the Date/Time Functions page. But I don't want to make entries labelled "trunc()" on both pages. Maybe I can reuse some of the text and examples for numeric trunc() under truncate() on the math functions page. -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Mon, 02 Oct 2017 17:15:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures
John Russell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. IMPALA-5529: [DOCS] New trunc() signatures Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 --- M docs/topics/impala_datetime_functions.xml 1 file changed, 136 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8189/3 -- To view, visit http://gerrit.cloudera.org:8080/8189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice4753dee4f7b8e09c35508a9cad1e36f4ab2826 Gerrit-Change-Number: 8189 Gerrit-PatchSet: 3 Gerrit-Owner: John Russell