[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

This commit also removes the now unused `DISTRIBUTE`, `SPLIT`, and
`BUCKETS` keywords that were going to be newly released in Impala 2.6,
but are now unused. Additionally, a few remaining uses of the
`DISTRIBUTE BY` syntax has been switched to `PARTITION BY`.

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Reviewed-on: http://gerrit.cloudera.org:8080/5382
Reviewed-by: Matthew Jacobs 
Tested-by: Internal Jenkins
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
34 files changed, 204 insertions(+), 219 deletions(-)

Approvals:
  Matthew Jacobs: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 3:

I submitted this for a gvo:

http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/615/

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dan Burkert (Code Review)]

Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5382

to look at the new patch set (#3).

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..

Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

This commit also removes the now unused `DISTRIBUTE`, `SPLIT`, and
`BUCKETS` keywords that were going to be newly released in Impala 2.6,
but are now unused. Additionally, a few remaining uses of the
`DISTRIBUTE BY` syntax has been switched to `PARTITION BY`.

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
34 files changed, 204 insertions(+), 219 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5382/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 2:

FYI I submitted a private jenkins test run for this change:

http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/6175/

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dimitris Tsirogiannis (Code Review)]

Dimitris Tsirogiannis has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 2:

PS2 build: 
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/6174/console

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5382/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

PS1, Line 287: DISTRIBUTE BY
> This is no longer true. The clause is "PARTITION BY".
Done


http://gerrit.cloudera.org:8080/#/c/5382/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

PS1, Line 1964: into 2
> Is this valid syntax?
no this was a bad find/replace.


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

PS1, Line 799: DISTRIBUTE
> Hm, that should be PARTITION.
Done


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/tests/test_cursor.py
File tests/comparison/tests/test_cursor.py:

PS1, Line 79: DISTRIBUTE
> PARTITION
Done


PS1, Line 83: DISTRIBUTE
> PARTITION
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dan Burkert (Code Review)]

Dan Burkert has uploaded a new patch set (#2).

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..

Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

This commit also removes the now unused `DISTRIBUTE`, `SPLIT`, and
`BUCKETS` keywords that were going to be newly released in Impala 2.6,
but are now unused. Additionally, a few remaining uses of the
`DISTRIBUTE BY` syntax has been switched to `PARTITION BY`.

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
34 files changed, 202 insertions(+), 217 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5382/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dimitris Tsirogiannis (Code Review)]

Dimitris Tsirogiannis has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5382/1/docs/topics/impala_create_table.xml
File docs/topics/impala_create_table.xml:

PS1, Line 287: DISTRIBUTE BY
This is no longer true. The clause is "PARTITION BY".


http://gerrit.cloudera.org:8080/#/c/5382/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

PS1, Line 1964: into 2
Is this valid syntax?


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

PS1, Line 799: DISTRIBUTE
Hm, that should be PARTITION.


http://gerrit.cloudera.org:8080/#/c/5382/1/tests/comparison/tests/test_cursor.py
File tests/comparison/tests/test_cursor.py:

PS1, Line 79: DISTRIBUTE
PARTITION


PS1, Line 83: DISTRIBUTE
PARTITION


-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..


Patch Set 1:

Kicked off a build here: 
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/6171/console

-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-HasComments: No

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

[Dan Burkert (Code Review)]

Hello Matthew Jacobs, Alex Behm,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/5382

to review the following change.

Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE
..

Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
---
M common/thrift/CatalogObjects.thrift
M docs/topics/impala_create_table.xml
M docs/topics/impala_reserved_words.xml
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/bin/generate-schema-statements.py
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/tpcds/tpcds_kudu_template.sql
M testdata/datasets/tpch/tpch_kudu_template.sql
M testdata/datasets/tpch/tpch_schema_template.sql
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M 
testdata/workloads/functional-query/queries/QueryTest/kudu-timeouts-catalogd.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_delete.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/comparison/db_connection.py
M tests/comparison/tests/test_cursor.py
M tests/query_test/test_cancellation.py
M tests/query_test/test_kudu.py
M tests/shell/test_shell_commandline.py
31 files changed, 188 insertions(+), 194 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5382/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32fdd5ef26c532f7a30220db52bdfbf228165922
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Matthew Jacobs