[native-toolchain-CR] More GCC 7 fixes
Tim Armstrong has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 4: Verified+1 Build ID is 415-a56999c8bb -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[native-toolchain-CR] More GCC 7 fixes
Tim Armstrong has submitted this change and it was merged. Change subject: More GCC 7 fixes .. More GCC 7 fixes My previous patch didn't fix all the build issues - I was building in a pre-existing workspace with some packages already built with GCC 4.9.2. This fixes the remaining compile issues. This also adds LLVM 3.9, with the same patch we applied to LLVM 3.8 because it is needed to support the new GCC C++11 ABI. LLVM 3.8 remains the default. Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 --- M buildall.sh M functions.sh A source/boost/boost-1.57.0-patches/0003-cpp-int-missing-casts.patch M source/boost/build.sh M source/cyrus-sasl/build.sh M source/flatbuffers/build.sh M source/krb5/build.sh A source/llvm/llvm-3.9.1-patches/0001-llvm-link-struct-types.patch 8 files changed, 249 insertions(+), 9 deletions(-) Approvals: Jim Apple: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve; Verified -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong
[native-toolchain-CR] More GCC 7 fixes
Jim Apple has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[native-toolchain-CR] More GCC 7 fixes
Tim Armstrong has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7220/3/source/cyrus-sasl/build.sh File source/cyrus-sasl/build.sh: Line 48: # -fgnu89-inline: work around linker error with multiple definitions of libc functions. > So -fgnu89-inline is more permissive? The online documentation I found for It just has slightly different semantics - without the flag some of these functions get emitted into the object file with a linkage that disallows multiple definitions. With the flag the functions either aren't emitted or are emitted with something like "linkonce" linkage. -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[native-toolchain-CR] More GCC 7 fixes
Jim Apple has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7220/3/source/cyrus-sasl/build.sh File source/cyrus-sasl/build.sh: Line 48: # -fgnu89-inline: work around problems with system headers where libc functions like > Tried to be a bit more specific. So -fgnu89-inline is more permissive? The online documentation I found for this flag is sparse. -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[native-toolchain-CR] More GCC 7 fixes
Tim Armstrong has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 4: Code-Review+1 carry +1 from Jim -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[native-toolchain-CR] More GCC 7 fixes
Tim Armstrong has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7220/3/source/cyrus-sasl/build.sh File source/cyrus-sasl/build.sh: Line 48: # -fgnu89-inline: work around linker error with multiple definitions of libc functions. > Can you be more specific about this? Tried to be a bit more specific. -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[native-toolchain-CR] More GCC 7 fixes
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7220 to look at the new patch set (#4). Change subject: More GCC 7 fixes .. More GCC 7 fixes My previous patch didn't fix all the build issues - I was building in a pre-existing workspace with some packages already built with GCC 4.9.2. This fixes the remaining compile issues. This also adds LLVM 3.9, with the same patch we applied to LLVM 3.8 because it is needed to support the new GCC C++11 ABI. LLVM 3.8 remains the default. Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 --- M buildall.sh M functions.sh A source/boost/boost-1.57.0-patches/0003-cpp-int-missing-casts.patch M source/boost/build.sh M source/cyrus-sasl/build.sh M source/flatbuffers/build.sh M source/krb5/build.sh A source/llvm/llvm-3.9.1-patches/0001-llvm-link-struct-types.patch 8 files changed, 249 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/20/7220/4 -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple
[native-toolchain-CR] More GCC 7 fixes
Jim Apple has posted comments on this change. Change subject: More GCC 7 fixes .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7220/3/source/cyrus-sasl/build.sh File source/cyrus-sasl/build.sh: Line 48: # -fgnu89-inline: work around linker error with multiple definitions of libc functions. Can you be more specific about this? -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes
[native-toolchain-CR] More GCC 7 fixes
Tim Armstrong has uploaded a new patch set (#3). Change subject: More GCC 7 fixes .. More GCC 7 fixes My previous patch didn't fix all the build issues - I was building in a pre-existing workspace with some packages already built with GCC 4.9.2. This fixes the remaining compile issues. This also adds LLVM 3.9, with the same patch we applied to LLVM 3.8 because it is needed to support the new GCC C++11 ABI. LLVM 3.8 remains the default. Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 --- M buildall.sh M functions.sh A source/boost/boost-1.57.0-patches/0003-cpp-int-missing-casts.patch M source/boost/build.sh M source/cyrus-sasl/build.sh M source/flatbuffers/build.sh M source/krb5/build.sh A source/llvm/llvm-3.9.1-patches/0001-llvm-link-struct-types.patch 8 files changed, 248 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/20/7220/3 -- To view, visit http://gerrit.cloudera.org:8080/7220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibeaac85be762487de27019c2dac018d64e80f587 Gerrit-PatchSet: 3 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong
