Re: [PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.12 [iotdb]
codecov[bot] commented on PR #12457: URL: https://github.com/apache/iotdb/pull/12457#issuecomment-2087868365 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12457?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 42.92%. Comparing base [(`b91abb5`)](https://app.codecov.io/gh/apache/iotdb/commit/b91abb5164466f9fac89ed7405751a1a80902397?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`18472a4`)](https://app.codecov.io/gh/apache/iotdb/pull/12457?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12457 +/- ## + Coverage 42.90% 42.92% +0.01% Complexity 69 69 Files 3102 3102 Lines191668 191668 Branches 2283522835 + Hits 8224482274 +30 + Misses 109424 109394 -30 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12457?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.11 [iotdb]
dependabot[bot] commented on PR #12263: URL: https://github.com/apache/iotdb/pull/12263#issuecomment-2087803617 Superseded by #12457. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.11 [iotdb]
dependabot[bot] closed pull request #12263: Bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.11 URL: https://github.com/apache/iotdb/pull/12263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.jacoco:jacoco-maven-plugin from 0.8.10 to 0.8.12 [iotdb]
dependabot[bot] opened a new pull request, #12457: URL: https://github.com/apache/iotdb/pull/12457 Bumps [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.10 to 0.8.12. Release notes Sourced from https://github.com/jacoco/jacoco/releases;>org.jacoco:jacoco-maven-plugin's releases. 0.8.12 New Features JaCoCo now officially supports Java 22 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1596;>#1596). Experimental support for Java 23 class files (GitHub https://redirect.github.com/jacoco/jacoco/issues/1553;>#1553). Fixed bugs Branches added by the Kotlin compiler for functions with default arguments and having more than 32 parameters are filtered out during generation of report (GitHub https://redirect.github.com/jacoco/jacoco/issues/1556;>#1556). Branch added by the Kotlin compiler version 1.5.0 and above for reading from lateinit property is filtered out during generation of report (GitHub https://redirect.github.com/jacoco/jacoco/issues/1568;>#1568). Non-functional Changes JaCoCo now depends on ASM 9.7 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1600;>#1600). 0.8.11 New Features JaCoCo now officially supports Java 21 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1520;>#1520). Experimental support for Java 22 class files (GitHub https://redirect.github.com/jacoco/jacoco/issues/1479;>#1479). Part of bytecode generated by the Java compilers for exhaustive switch expressions is filtered out during generation of report (GitHub https://redirect.github.com/jacoco/jacoco/issues/1472;>#1472). Part of bytecode generated by the Java compilers for record patterns is filtered out during generation of report (GitHub https://redirect.github.com/jacoco/jacoco/issues/1473;>#1473). Fixed bugs Instrumentation should not cause VerifyError when the last local variable of method parameters is overridden in the method body to store a value of type long or double (GitHub https://redirect.github.com/jacoco/jacoco/issues/893;>#893). Restore exec file compatibility with versions from 0.7.5 to 0.8.8 in case of class files with zero line numbers (GitHub https://redirect.github.com/jacoco/jacoco/issues/1492;>#1492). Non-functional Changes jacoco-maven-plugin now requires at least Java 8 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1466;>#1466, https://redirect.github.com/jacoco/jacoco/issues/1468;>#1468). JaCoCo build now requires at least Maven 3.5.4 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1467;>#1467). Maven 3.9.2 should not produce warnings for jacoco-maven-plugin (GitHub https://redirect.github.com/jacoco/jacoco/issues/1468;>#1468). JaCoCo build now requires JDK 17 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1482;>#1482). JaCoCo now depends on ASM 9.6 (GitHub https://redirect.github.com/jacoco/jacoco/issues/1518;>#1518). Commits https://github.com/jacoco/jacoco/commit/dbfb6f2ad904158b5b40a93fea222e263aeaf9ab;>dbfb6f2 Prepare release 0.8.12 https://github.com/jacoco/jacoco/commit/a50585b9e0770c363c56d887a8f639dc05411073;>a50585b Upgrade maven-plugin-plugin to 3.6.4 (https://redirect.github.com/jacoco/jacoco/issues/1604;>#1604) https://github.com/jacoco/jacoco/commit/fd63cc5478bcd7b32e2070d93ead8c879b423841;>fd63cc5 Configure labels that Dependabot assigns to PRs (https://redirect.github.com/jacoco/jacoco/issues/1603;>#1603) https://github.com/jacoco/jacoco/commit/03a53334c1e3a28ed587feb5adbfa3c0aa536990;>03a5333 Add configuration for Dependabot to simplify updates of ASM (https://redirect.github.com/jacoco/jacoco/issues/1601;>#1601) https://github.com/jacoco/jacoco/commit/40ff9fb3b13bb484344936dde4a90b083b79cdbd;>40ff9fb Upgrade ASM to 9.7 (https://redirect.github.com/jacoco/jacoco/issues/1600;>#1600) https://github.com/jacoco/jacoco/commit/907717832435f5085b67d02e1eeec5b63b0f415b;>9077178 Happy birthday Java 22! (https://redirect.github.com/jacoco/jacoco/issues/1596;>#1596) https://github.com/jacoco/jacoco/commit/7edd1b511a174a663f633c34ae8c951a0ae77d20;>7edd1b5 Bump actions/setup-java from 4.1.0 to 4.2.1 (https://redirect.github.com/jacoco/jacoco/issues/1594;>#1594) https://github.com/jacoco/jacoco/commit/e50b547bc26ff198acfd16311c028f340af38699;>e50b547 Upgrade ECJ to 3.37.0 (https://redirect.github.com/jacoco/jacoco/issues/1590;>#1590) https://github.com/jacoco/jacoco/commit/a1144d02ff0f89d6603214676730a2d5616cf466;>a1144d0 Upgrade maven-site-plugin to 3.12.1 (https://redirect.github.com/jacoco/jacoco/issues/1586;>#1586) https://github.com/jacoco/jacoco/commit/04b0141d6ae5e6d1f00f15341b29dd4734ab778a;>04b0141 Bump actions/setup-java from 4.0.0 to 4.1.0 (https://redirect.github.com/jacoco/jacoco/issues/1587;>#1587) Additional commits viewable in https://github.com/jacoco/jacoco/compare/v0.8.10...v0.8.12;>compare view
Re: [PR] Lift the storage limit for tag and attribute management [iotdb]
JackieTien97 commented on code in PR #12447:
URL: https://github.com/apache/iotdb/pull/12447#discussion_r1584515815
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagManager.java:
##
@@ -212,20 +209,18 @@ public void removeIndex(String tagKey, String tagValue,
IMeasurementMNode mea
// init memory size
int memorySize = 0;
Review Comment:
make it as long
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagManager.java:
##
@@ -181,18 +180,16 @@ public void addIndex(String tagKey, String tagValue,
IMeasurementMNode measur
int memorySize = 0;
Review Comment:
make it as long
##
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagLogFile.java:
##
@@ -129,14 +129,12 @@ public static ByteBuffer parseByteBuffer(FileChannel
fileChannel, long position)
ByteBuffer byteBuffers = ByteBuffer.allocate(blockNum * MAX_LENGTH);
byteBuffers.put(byteBuffer);
byteBuffers.position(4); // Skip blockNum
-List blockOffset = new ArrayList<>();
-blockOffset.add(position);
for (int i = 1; i < blockNum; i++) {
- blockOffset.add(ReadWriteIOUtils.readLong(byteBuffers));
+ Long nextPosition = ReadWriteIOUtils.readLong(byteBuffers);
Review Comment:
```suggestion
long nextPosition = ReadWriteIOUtils.readLong(byteBuffers);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Try to Fix IoTConsensus CI [iotdb]
codecov[bot] commented on PR #12456: URL: https://github.com/apache/iotdb/pull/12456#issuecomment-2084839126 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12456?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 42.90%. Comparing base [(`b91abb5`)](https://app.codecov.io/gh/apache/iotdb/commit/b91abb5164466f9fac89ed7405751a1a80902397?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`544c123`)](https://app.codecov.io/gh/apache/iotdb/pull/12456?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #12456 +/- ## - Coverage 42.90% 42.90% -0.01% Complexity 69 69 Files 3102 3102 Lines191668 191668 Branches 2283522835 - Hits 8224482230 -14 - Misses 109424 109438 +14 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12456?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Feature/move stuff to the extras repository take 2 [iotdb]
HTHou merged PR #12373: URL: https://github.com/apache/iotdb/pull/12373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix health_chech bug [iotdb]
HTHou merged PR #12450: URL: https://github.com/apache/iotdb/pull/12450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove backup [iotdb]
HTHou merged PR #12455: URL: https://github.com/apache/iotdb/pull/12455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump golang.org/x/net from 0.17.0 to 0.23.0 in /iotdb-connector/grafana-plugin [iotdb]
HTHou merged PR #12379: URL: https://github.com/apache/iotdb/pull/12379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [rel/1.3] Fixed rest insertTablet http api lost data event [iotdb]
HTHou closed pull request #12386: [rel/1.3] Fixed rest insertTablet http api lost data event URL: https://github.com/apache/iotdb/pull/12386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix compaction selector ut [iotdb]
OneSizeFitsQuorum merged PR #12442: URL: https://github.com/apache/iotdb/pull/12442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Modify initConfigManager() [iotdb]
OneSizeFitsQuorum merged PR #12452: URL: https://github.com/apache/iotdb/pull/12452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize LoadCache interfaces [iotdb]
sonarcloud[bot] commented on PR #12441: URL: https://github.com/apache/iotdb/pull/12441#issuecomment-2084468995 ## [](https://sonarcloud.io/dashboard?id=apache_iotdb=12441) **Quality Gate failed** Failed conditions  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb=12441=new_coverage=list) (required ≥ 80%)  [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb=12441) (required ≥ A) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb=12441) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
