[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..


[c++client] use ATTRIBUTE_DEPRECATED attribute

Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.

Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute (if compiling with clang).

Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Reviewed-on: http://gerrit.cloudera.org:8080/4529
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 29 insertions(+), 14 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 1305: "Snapshot Timestamps be greater than the unix 
epoch.")
> is there a way that we can return the error status returned by SetSnapshotM
We wouldn't get that far here really, the error returned otherwise is an 
overflow error b/c of the unsigned int and I didnt think that would be 
preferred.


http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/tests/util.py
File python/kudu/tests/util.py:

Line 122: self.snapshot_timestamp = datetime.datetime.utcnow()
> there is no guarantee that the snapshot timestamp will be in between the de
Since this op is being flushed why would it not be guaranteed? Since its 
blocking the call, would that not guarantee that the latest observed timestamp 
after the op is at least less than this "snapshot timestamp"?  I get that using 
the latest observed timestamp is probably better form but I want to make sure I 
understand, also the TestScanAtSnapshot C++ test seems to also use system time, 
so we may need to fix that as well if its an issue.


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [util] minor clean-up on kudu::Subprocess

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [util] minor clean-up on kudu::Subprocess
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4502/2/src/kudu/benchmarks/tpch/tpch_real_world.cc
File src/kudu/benchmarks/tpch/tpch_real_world.cc:

PS2, Line 303:   Status s = dbgen_proc->Kill(SIGKILL);
 :   if (!s.ok()) {
 : LOG(WARNING) << "Failed to send SIGKILL to dbgen: " << 
s.ToString();
 :   }
 :   s = dbgen_proc->Wait(nullptr);
 :   if (!s.ok()) {
 : LOG(WARNING) << "Failed to await for dbgen exit: " << 
s.ToString();
 :   }
Why aren't these fatal? That is, why not CHECK_OK(...)?


http://gerrit.cloudera.org:8080/#/c/4502/2/src/kudu/util/subprocess.cc
File src/kudu/util/subprocess.cc:

PS2, Line 422: *ret = cached_rc_;
If you want to allow ret to be nullptr, you should also add a  check here 
before the assignment.


-- 
To view, visit http://gerrit.cloudera.org:8080/4502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd058382e4519b323aebb4c992d9088496a341cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [tools] Implement a manual leader step down for a tablet

[Dinesh Bhat (Code Review)]

Hello David Ribeiro Alves, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4533

to review the following change.

Change subject: [tools] Implement a manual leader_step_down for a tablet
..

[tools] Implement a manual leader_step_down for a tablet

This change introduces a leader_step_down functionality
under 'kudu tablet'. This tool may be handy to recover from
situations when a single tablet server is overloaded and we want
to kick off  a new election to balance the load across the clusters.
Although it is not guaranteed that a different replica will be elected
as the leader, this is an optimistic effort to elect a new tablet
server as the leader for the given tablet in the cluster.

Also snuck in a small change to display host:port details with
'kudu tablet list  --list_tablets' command.

Change-Id: Ia046a28a2008f4f5d1e955f57752a32a1ddc5ab8
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 185 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/4533/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia046a28a2008f4f5d1e955f57752a32a1ddc5ab8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [util] minor clean-up on kudu::Subprocess

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4502

to look at the new patch set (#2).

Change subject: [util] minor clean-up on kudu::Subprocess
..

[util] minor clean-up on kudu::Subprocess

Do not call CHECK_EQ() in case where it's possible to report
on error via the return value.

Change-Id: Idd058382e4519b323aebb4c992d9088496a341cc
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/util/subprocess.cc
3 files changed, 38 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/4502/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4502
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd058382e4519b323aebb4c992d9088496a341cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

[Ninad Shringarpure (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4526

to look at the new patch set (#4).

Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned 
tablets to a separate section
..

[web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a 
separate section

Created separate vectors for live and tombstone tablets based on their 
TabletDataState_Name.
Table would be displayed only if there are tablets belonging in its respective 
category.

Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
---
M src/kudu/tserver/tserver-path-handlers.cc
1 file changed, 59 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4529

to look at the new patch set (#3).

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..

[c++client] use ATTRIBUTE_DEPRECATED attribute

Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.

Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute (if compiling with clang).

Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 29 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4529/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/client.h
File src/kudu/client/client.h:

PS2, Line 1710: KuduScanBatch*
> Nit: in this case the argument is included in the string, in the others it'
Because one can be confused a bit: in this case the deprecated function's name 
is the same as the function it's obsoleted by.  I added the parameter type to 
resolve the ambiguity.

I'm open to other options here; the only requirements are to report about the 
deprecated method, suggest the alternative method, and keep the user less 
frustrated by the message.


http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:

PS2, Line 88: explicit
> Isn't this only desirable for single-arg constructors?
Since this is multi-parameter constructor with by-default values, it might 
happen that one-arg usage will implicitly create an object.

Actually, the Tidy Bot noticed that, not me :)
I'm just addressing its comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] [WIP][java] KUDU-1563. Add support for INSERT IGNORE

[Brock Noland (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4523

to look at the new patch set (#3).

Change subject: [WIP][java] KUDU-1563. Add support for INSERT IGNORE
..

[WIP][java] KUDU-1563. Add support for INSERT IGNORE

Implements java support for the `INSERT IGNORE' operation

TODO - more tests

Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
---
A java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
4 files changed, 87 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4523/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] ensure every gflag is defined outside of a namespace

[Adar Dembo (Code Review)]

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4505

to look at the new patch set (#2).

Change subject: ensure every gflag is defined outside of a namespace
..

ensure every gflag is defined outside of a namespace

The gflags docs recommend that all gflags be defined globally, outside of any
namespace. This patch moves a couple gflags out of their respective namespaces
accordingly. It shouldn't be backwards incompatible in any way.

Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
---
M src/kudu/master/master_options.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/server/server_base_options.cc
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tserver/tablet_server_options.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/memory/memory.cc
M src/kudu/util/striped64-test.cc
11 files changed, 60 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4505/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea2cb97539d19feae5e86f3873dab741b08e37b1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] release notes: prepare for 1.1

[Adar Dembo (Code Review)]

Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4532

Change subject: release_notes: prepare for 1.1
..

release_notes: prepare for 1.1

This is merely mechanical, moving the 1.0 release notes to
prior_release_notes.adoc and preparing new sections in release_notes.adoc
for 1.1.0.

Change-Id: Id9fca5e62a7179186e89ffc7249213693467f39b
---
M docs/prior_release_notes.adoc
M docs/release_notes.adoc
2 files changed, 151 insertions(+), 133 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4532/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9fca5e62a7179186e89ffc7249213693467f39b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 

[kudu-CR] [java-client] IN-list predicate

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java-client] IN-list predicate
..


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4530/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java:

Line 91:   /** IN-list values. */
May want to indicate that the outer array (the actual "list") is sorted.


PS1, Line 330:   /**
 :* Creates a new builder for an IN list predicate.
 :*
 :* Only values of the correct type for the column may be added 
to the builder.
 :*
 :* @param column the column schema
 :* @return the IN list builder
 :*/
 :   public static InListBuilder newInListBuilder(ColumnSchema 
column) {
 : return new InListBuilder(column);
 :   }
I don't really see the advantage of this indirection vs. just making the 
InListBuilder constructor public.


Line 363:   public KuduPredicate(ColumnSchema column, byte[][] inListValues) {
Why is this public? Shouldn't clients go through the builder?


PS1, Line 580:   case IS_NOT_NULL: {
 : return newIsNotNullPredicate(column);
 :   }
Whoops. What was the effect of missing this?


PS1, Line 596:   /**
 :* Compares two bounds based on the type of this predicate's 
column.
 :* @param a the first serialized value
 :* @param b the second serialized value
 :* @return the comparison of the serialized values based on 
the column type
 :*/
Update the param list.


Line 825:* Builder for an IN-list predicate.
I don't really like this abstraction, for a couple reasons:
1. Given the various addValue() variants, it suggests that it's possible to add 
values of different types in the same predicate.
2. Once you strip that away, all that's left is the ability to add a list of 
values, and there's no need for a builder to get that.

What about a generic KuduPredicate factory method that takes a List of 
values? That way the language guarantees that all of the values are of the same 
type, modulo funky casting. I expect that it'll be hard to implement the switch 
statement in addValue() this way, but maybe there's a clever approach to do it. 
Or maybe you force callers to provide the data type as an additional argument.


http://gerrit.cloudera.org:8080/#/c/4530/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java:

PS1, Line 448: case IS_NOT_NULL: break;
And here too; what was the effect of missing this?


-- 
To view, visit http://gerrit.cloudera.org:8080/4530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia556196963153f9db64d67bc699f96cb920ecac6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 12:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/2986/12/src/kudu/client/predicate-test.cc
File src/kudu/client/predicate-test.cc:

Line 546:   }
consider adding a test cases for
 1. value IN (NULL)
 2. value IN (NULL, )


http://gerrit.cloudera.org:8080/#/c/2986/12/src/kudu/client/scan_predicate.cc
File src/kudu/client/scan_predicate.cc:

Line 122:   vector vals_list;
vals_list.reserve(vals_.size()) ?


http://gerrit.cloudera.org:8080/#/c/2986/12/src/kudu/common/column_predicate.cc
File src/kudu/common/column_predicate.cc:

PS12, Line 334:   values_.erase(std::remove_if(values_.begin(), 
values_.end(),
  :[] (const void* v){
  :  return 
!other.CheckValueInRange(v);
  :  
an optimization opportunity if we expect IN() lists to be large.  Get the upper 
and lower bounds of range and then found corresponding boundaries in the 
values_.  If the range does not cover the list, copy the values in the range 
into a temporary array and swap with values_.


Line 352: case PredicateType::IsNotNull: return;
What if it was IN (NULL) predicate?


PS12, Line 501:   } else if (predicate_type_ == PredicateType::Equality) {
  : return column_.type_info()->Compare(lower_, other.lower_) 
== 0;
  :   } else if (predicate_type_ == PredicateType::Range) {
  : return (lower_ == other.lower_ ||
  : (lower_ != nullptr && other.lower_ != nullptr &&
  :  column_.type_info()->Compare(lower_, other.lower_) 
== 0)) &&
  :(upper_ == other.upper_ ||
  : (upper_ != nullptr && other.upper_ != nullptr &&
  :  column_.type_info()->Compare(upper_, other.upper_) 
== 0));
  :   } else if (predicate_type_ == PredicateType::InList) {
  : if (values_.size() != other.values_.size()) return false;
  : for (int i = 0; i < values_.size(); i++) {
  :   if (column_.type_info()->Compare(values_[i], 
other.values_[i]) != 0) return false;
  : }
  :   }
May be, it's time to start using the switch() here instead?


PS12, Line 537: other
Is this by-copy capture?  Consider replacing with by-reference capture to avoid 
copying.


PS12, Line 532: void ColumnPredicate::MergeInLists(const ColumnPredicate& 
other) {
  :   // We iterate through the values_ list and remove elements 
that dont
  :   // exist in the other ColumnPredicate's list
  :   // Each list vector is sorted and contains only unique values.
  :   values_.erase(std::remove_if(values_.begin(), values_.end(),
  :[this, other](const void *v) {
  :  return 
!other.CheckValueInList(v);
  :  
This looks strange to me: given the name of the method, I would expect it to 
_merge_ lists, i.e. add the values from other.values_ which are not present in 
this->values_

Consider renaming this method to something like 'IntersectInLists'.


http://gerrit.cloudera.org:8080/#/c/2986/12/src/kudu/common/key_util.cc
File src/kudu/common/key_util.cc:

PS12, Line 154: if (predicate->predicate_type() == PredicateType::Equality) 
{
  :   memcpy(row->mutable_cell_ptr(*col_idx_it), 
predicate->raw_lower(), size);
  :   pushed_predicates++;
  :   final_predicate = predicate;
  : } else if (predicate->predicate_type() == 
PredicateType::Range) {
  :   if (predicate->raw_upper() != nullptr) {
  : memcpy(row->mutable_cell_ptr(*col_idx_it), 
predicate->raw_upper(), size);
  : pushed_predicates++;
  : final_predicate = predicate;
  :   }
  :   // After the first column with a range constraint we stop 
pushing
  :   // constraints into the upper bound. Instead, we push 
minimum values
  :   // to the remaining columns (below), which is the 
maximally tight
  :   // constraint.
  :   break;
  : } else if (predicate->predicate_type() == 
PredicateType::InList) {
  :   // Since the InList predicate is a sorted vector of 
values, the last
  :   // value would provide an Inclusive Upper Bound that can 
be pushed.
  :   memcpy(row->mutable_cell_ptr(*col_idx_it), 
predicate->raw_values().back(), size);
  :   pushed_predicates++;
  :   final_predicate = predicate;
  : } else {
  : 

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 14: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate.cc
File src/kudu/client/scan_predicate.cc:

Line 122:   vector vals_list;
> Not done?
Woops, had a bad rebase.  It was done in revision 11, and then I somehow lost 
it in 12.


-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/client.h
File src/kudu/client/client.h:

PS2, Line 1710: KuduScanBatch*
Nit: in this case the argument is included in the string, in the others it's 
not. Why is that?


http://gerrit.cloudera.org:8080/#/c/4529/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:

PS2, Line 88: explicit
Isn't this only desirable for single-arg constructors?


-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 13:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate.cc
File src/kudu/client/scan_predicate.cc:

Line 122:   vector vals_list;
> Done
Not done?


-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [java-client] IN-list predicate

[Dan Burkert (Code Review)]

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4530

Change subject: [java-client] IN-list predicate
..

[java-client] IN-list predicate

Change-Id: Ia556196963153f9db64d67bc699f96cb920ecac6
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
5 files changed, 672 insertions(+), 144 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/4530/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia556196963153f9db64d67bc699f96cb920ecac6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 

[kudu-CR] metrics: move SCOPED LATENCY METRIC to metrics.h

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: metrics: move SCOPED_LATENCY_METRIC to metrics.h
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f1287ade44c60236d2859b5e528ce7e365645ef
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] metrics: move SCOPED LATENCY METRIC to metrics.h

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has submitted this change and it was merged.

Change subject: metrics: move SCOPED_LATENCY_METRIC to metrics.h
..


metrics: move SCOPED_LATENCY_METRIC to metrics.h

Addresses a simple TODO.

Change-Id: I1f1287ade44c60236d2859b5e528ce7e365645ef
Reviewed-on: http://gerrit.cloudera.org:8080/4469
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
---
M src/kudu/consensus/log_metrics.h
M src/kudu/util/metrics.h
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f1287ade44c60236d2859b5e528ce7e365645ef
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4529

to look at the new patch set (#2).

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..

[c++client] use ATTRIBUTE_DEPRECATED attribute

Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.

Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute (if compiling with clang).

Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 28 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4529/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [c++client] use ATTRIBUTE DEPRECATED attribute

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4529

Change subject: [c++client] use ATTRIBUTE_DEPRECATED attribute
..

[c++client] use ATTRIBUTE_DEPRECATED attribute

Added the deprecated attribute to the methods/functions marked as such
in the C++ client API.

Also, added -Wdocumentation-deprecated-sync flag to spot cases when
a method marked as deprecated by in-line doc lacks corresponding
deprecation attribute.

Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
---
M CMakeLists.txt
M src/kudu/client/client.h
M src/kudu/client/schema.h
3 files changed, 33 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4529/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a48587d1132ada7da63953d7da6cae0f84a0baf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

PS1, Line 215:   // Set the verbosity of the commands to WARNING(2) and above.
 :   // If the user had explicitly specified verbosity, then user's
 :   // verbosity level is honored. Since '--v' depends on 
minloglevel
 :   // specifying either of them on CLI will override this setting.
 :   if 
(google::GetCommandLineFlagInfoOrDie("minloglevel").is_default &&
 :   google::GetCommandLineFlagInfoOrDie("v").is_default) {
 : google::SetCommandLineOption("minloglevel",
 :  
SimpleItoa(google::GLOG_WARNING).c_str());
 :   }
> That's correct. --v controls VLOG(LOG at lowest level, which is INFO), and 
Yes, I think I can make peace with WARNING or higher. Maybe even INFO. Todd is 
right that most uses of the tool are debug-related, and so more information is 
generally better.


-- 
To view, visit http://gerrit.cloudera.org:8080/4447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [misc] : Remove few more warnings

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [misc] : Remove few more warnings
..


[misc] : Remove few more warnings

Observed few warnings with fresh builds:
[365/1113] Building CXX object 
src/kudu/common/CMakeFiles/kudu_common_exported.dir/row_operations.cc.o
../../src/kudu/common/row_operations.cc: In member function ‘std::string 
kudu::DecodedRowOperation::ToString(const kudu::Schema&) const’:
../../src/kudu/common/row_operations.cc:58:1: warning: control reaches end of 
non-void function [-Wreturn-type]
 }
 ^
[403/1113] Building CXX object 
src/kudu/common/CMakeFiles/kudu_common.dir/row_operations.cc.o
../../src/kudu/common/row_operations.cc: In member function ‘std::string 
kudu::DecodedRowOperation::ToString(const kudu::Schema&) const’:
../../src/kudu/common/row_operations.cc:58:1: warning: control reaches end of 
non-void function [-Wreturn-type]
 }
 ^
[516/1113] Building CXX object src/kudu/benchmarks/CMakeFiles/rle.dir/rle.cc.o
../../src/kudu/benchmarks/rle.cc: In function ‘void kudu::BooleanRLE()’:
../../src/kudu/benchmarks/rle.cc:93:10: warning: variable ‘run_length’ set but 
not used [-Wunused-but-set-variable]
   size_t run_length;
  ^
[575/1113] Building CXX object 
src/kudu/cfile/CMakeFiles/cfile.dir/compression_codec.cc.o
In file included from ../../src/kudu/cfile/compression_codec.h:24:0,
 from ../../src/kudu/cfile/compression_codec.cc:26:
../../src/kudu/gutil/macros.h:102:0: warning: "DISALLOW_COPY_AND_ASSIGN" 
redefined
 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
 ^
In file included from ../../thirdparty/installed-deps/include/snappy.h:45:0,
 from ../../src/kudu/cfile/compression_codec.cc:20:
../../thirdparty/installed-deps/include/snappy-stubs-public.h:79:0: note: this 
is the location of the previous definition
 #define DISALLOW_COPY_AND_ASSIGN(TypeName) \
 ^

Also added a trivial comment update.

Change-Id: I89b96d52dfed6b38f17cf8cdebeed840fb32f98d
Reviewed-on: http://gerrit.cloudera.org:8080/4518
Reviewed-by: Adar Dembo 
Tested-by: Alexey Serbin 
---
M src/kudu/benchmarks/rle.cc
M src/kudu/codegen/row_projector.cc
M src/kudu/common/row_operations.cc
M src/kudu/gutil/macros.h
4 files changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89b96d52dfed6b38f17cf8cdebeed840fb32f98d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 

[kudu-CR] [misc] : Remove few more warnings

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [misc] : Remove few more warnings
..


Patch Set 2: Verified+1

I verified the patch, building in release and debug configurations at 
ve0518.halxg.cloudera.com.

-- 
To view, visit http://gerrit.cloudera.org:8080/4518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89b96d52dfed6b38f17cf8cdebeed840fb32f98d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2986/12/src/kudu/client/predicate-test.cc
File src/kudu/client/predicate-test.cc:

Line 106:   int CountMatchedRows(vector values, vector test_values) {
const vector& values?
const vector& test_values?


-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 12: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] consensus: fix some clang-tidy warnings

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: consensus: fix some clang-tidy warnings
..


consensus: fix some clang-tidy warnings

This fixes most of the clang-tidy warnings in the consensus module. I'm
preparing to do some refactoring in the module, so I figured it was
better to do the tidy ahead of time rather than fighting the clang-tidy
bot when I moved some code.

Change-Id: Ieaaafe0bbc6b809b379f25e2076453dea973a37f
Reviewed-on: http://gerrit.cloudera.org:8080/4454
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta.h
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/leader_election.h
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_anchor_registry.cc
M src/kudu/consensus/log_anchor_registry.h
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/log_index.cc
M src/kudu/consensus/log_metrics.h
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_reader.h
M src/kudu/consensus/log_util.h
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/consensus/raft_consensus_state-test.cc
M src/kudu/consensus/raft_consensus_state.h
M src/kudu/tablet/tablet_bootstrap-test.cc
39 files changed, 189 insertions(+), 219 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaaafe0bbc6b809b379f25e2076453dea973a37f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[Alexey Serbin (Code Review)]

Alexey Serbin has submitted this change and it was merged.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


[twitter-demo] use AUTO_FLUSH_BACKGROUND session

Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.

Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Reviewed-on: http://gerrit.cloudera.org:8080/4477
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 61 insertions(+), 115 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..


Patch Set 4:

> my point was that we should make sure to stress it a bit so that
 > over time we will hit flush/flush async over different stages of
 > the auto flushing.  The way you're doing it now, you always call
 > flush at precise intervals, my suggestion was that you spin insert
 > enough rows to actually get background batches being inserted while
 > calling flush/flush async at random times, possibly increasing the
 > coverage. would that make sense?

Getting it stressed as you described certainly makes sense.  However, given 
current run times of the test I would not put that test in here.  Probably, we 
can add such a test into the integration test bundle?  Or it's OK to add a test 
which runs additional 5 minutes in TSAN configuration?

As I see it, the purpose of this test is to make sure there aren't errors, 
deadlocks or missed/unflushed batchers while calling Flush/FlushAsync in 
AUTO_FLUSH_BACKGROUND mode.  From that perspective, exploring behavior of the 
client/server in all phases besides the very first one it is no different than 
calling Flush/AsyncFlush in any other regular session.  The only phase of 
interest in that context is when there is contention on detaching the current 
batcher by auto-flusher and the call of explicit flush.

What do you think?

-- 
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 5:

nah, that all I wanted. thanks

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/2986

to look at the new patch set (#12).

Change subject: KUDU-1363: Add IN-list predicate type
..

KUDU-1363: Add IN-list predicate type

Adds support for clients to provide a set of equalities for a given
column. Support for using IN list predicates from the Java client will
be in a follow-up commit.

Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_predicate-internal.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/value.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/common.proto
M src/kudu/common/key_util.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
16 files changed, 723 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/2986/12
-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Document Impala and Spark integration known issues & limitations

[Dan Burkert (Code Review)]

Hello Alexey Serbin, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4443

to look at the new patch set (#4).

Change subject: Document Impala and Spark integration known issues & limitations
..

Document Impala and Spark integration known issues & limitations

Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
---
M docs/developing.adoc
M docs/kudu_impala_integration.adoc
2 files changed, 36 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4443/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I993a09a00f5ab0049fec95e967abc1740b44dc8d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/2986

to look at the new patch set (#11).

Change subject: KUDU-1363: Add IN-list predicate type
..

KUDU-1363: Add IN-list predicate type

Adds support for clients to provide a set of equalities for a given
column. Support for using IN list predicates from the Java client will
be in a follow-up commit.

Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_predicate-internal.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/value.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/common.proto
M src/kudu/common/key_util.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
16 files changed, 724 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/2986/11
-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate.cc
File src/kudu/client/scan_predicate.cc:

Line 120: Status InListPredicateData::AddToScanSpec(ScanSpec* spec, Arena* 
arena) {
> Not much I can do about this, it's a virtual method.
You can comment out the parameter name, like 'Arena* /*arena*/' and it'll 
squelch the warning.


-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [tools]: Keep the verbosity of CLI at FATAL and above

[Dinesh Bhat (Code Review)]

Dinesh Bhat has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4447/1/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

PS1, Line 215: FLAGS_minloglevel = google::GLOG_FATAL;
 :   }
 :   return show_help;
 : }
 : 
 : int main(int argc, char** argv) {
 :   bool show_help = ParseCommandLineFlags(, );
 :   FLAGS_logtostderr = true;
 :   k
> Also, --vmodule affects only the verbose logging stuff, like VLOG(), right 
That's correct. --v controls VLOG(LOG at lowest level, which is INFO), and 
minloglevel controls LOG levels and typically you would want use one of these. 
My understanding is that, consumers of these additional gflags are either 
ops/support or developers. So for these audience, keeping the knobs at more 
granularity(file level) might help in the long run than keeping the loglevel 
knobs at library. My initial intention of this change was to get rid of INFO 
level messages on CLI like "Opened FS with uuid: ", and I am glad it led to 
some interesting discussions on this topic. 

Folks, are we concluding that we should keep the loglevels for CLI at WARNINGS 
and above then ? If the user explicitly specifies a loglevel via --minloglevel 
or --v, then we can honor that. Also, all this impacts to 'kudu' toolset alone. 
We also seem to be converging that we don't want to be under a contract about 
machine-readability of the 'kudu' output to keep the CLI more flexible.


-- 
To view, visit http://gerrit.cloudera.org:8080/4447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [c++client/samples] added README for the sample

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4517

to look at the new patch set (#3).

Change subject: [c++client/samples] added README for the sample
..

[c++client/samples] added README for the sample

Added README in AsciiDoctor format describing how to build the sample.

Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 91 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/2986

to look at the new patch set (#10).

Change subject: KUDU-1363: Add IN-list predicate type
..

KUDU-1363: Add IN-list predicate type

Adds support for clients to provide a set of equalities for a given
column. Support for using IN list predicates from the Java client will
be in a follow-up commit.

Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
---
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_predicate-internal.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/value.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/common.proto
M src/kudu/common/key_util.cc
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
16 files changed, 720 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/2986/10
-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1363: Add IN-list predicate type

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1363: Add IN-list predicate type
..


Patch Set 9:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/predicate-test.cc
File src/kudu/client/predicate-test.cc:

Line 38: using std::set;
> warning: using decl 'set' is unused [misc-unused-using-decls]
Done


http://gerrit.cloudera.org:8080/#/c/2986/7/src/kudu/client/scan_predicate-internal.h
File src/kudu/client/scan_predicate-internal.h:

Line 112:   std::vector vals_;
> This wasn't possible?
It's possible, but it would require copying the vector into a 
vector in the ctor.  I think it's easier to just keep it 
the way it is.


http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate-internal.h
File src/kudu/client/scan_predicate-internal.h:

Line 23: #include "kudu/client/value.h"
> warning: #includes are not sorted properly [llvm-include-order]
Done


http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/client/scan_predicate.cc
File src/kudu/client/scan_predicate.cc:

Line 120: Status InListPredicateData::AddToScanSpec(ScanSpec* spec, Arena* 
arena) {
> warning: parameter 'arena' is unused [misc-unused-parameters]
Not much I can do about this, it's a virtual method.


Line 122:   vector vals_list;
> Size this up front with vals_.size()?
Done


http://gerrit.cloudera.org:8080/#/c/2986/9/src/kudu/common/column_predicate.cc
File src/kudu/common/column_predicate.cc:

Line 181:   if (values_.size() == 0) {
> warning: the 'empty' method should be used to check for emptiness instead o
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sameer Abhyankar 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sameer Abhyankar 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

[Ninad Shringarpure (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4526

to look at the new patch set (#3).

Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned 
tablets to a separate section
..

[web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a 
separate section

Created separate vectors for live and tombstone tablets based on their 
TabletDataState_Name.

Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
---
M src/kudu/tserver/tserver-path-handlers.cc
1 file changed, 63 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] consensus: fix some clang-tidy warnings

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: consensus: fix some clang-tidy warnings
..


Patch Set 2:

the one remaining warning is fixed by the next patch in this series

-- 
To view, visit http://gerrit.cloudera.org:8080/4454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaaafe0bbc6b809b379f25e2076453dea973a37f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a separate section

[Ninad Shringarpure (Code Review)]

Ninad Shringarpure has uploaded a new patch set (#2).

Change subject: [web-ui] KUDU-1588 /tablets page should separate out tombstoned 
tablets to a separate section
..

[web-ui] KUDU-1588 /tablets page should separate out tombstoned tablets to a 
separate section

Created separate vectors for live and tombstone tablets based on their 
TabletDataState_Name.

Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
---
M src/kudu/tserver/tserver-path-handlers.cc
1 file changed, 63 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/4526/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4526
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0aa9b67749234c5d68899a82d6b1493633bb78c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ninad Shringarpure 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [client-test] one more test for AUTO FLUSH BACKGROUND

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [client-test] one more test for AUTO_FLUSH_BACKGROUND
..


Patch Set 4:

my point was that we should make sure to stress it a bit so that over time we 
will hit flush/flush async over different stages of the auto flushing.  The way 
you're doing it now, you always call flush at precise intervals, my suggestion 
was that you spin insert enough rows to actually get background batches being 
inserted while calling flush/flush async at random times, possibly increasing 
the coverage. would that make sense?

-- 
To view, visit http://gerrit.cloudera.org:8080/4492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bd5d248d4d44393689c8da81ed669395c393257
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] consensus: fix some clang-tidy warnings

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: consensus: fix some clang-tidy warnings
..


Patch Set 2:

still missing some tidy warnings right?

-- 
To view, visit http://gerrit.cloudera.org:8080/4454
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaaafe0bbc6b809b379f25e2076453dea973a37f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [java client] Reinstate KUDU-1364's behavior, fix NPE

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: [java client] Reinstate KUDU-1364's behavior, fix NPE
..


Patch Set 1: Code-Review+2

thanks for fixing this.
yeah, it'd be good to have directed tests for this stuff, though it would take 
quite some time to assemble a fw to do it. the inability to write those is 
likely the reason why the other patches were flawed.

-- 
To view, visit http://gerrit.cloudera.org:8080/4501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e0ed23fbf4c655037b77173a187c3fa11de4f63
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1637 - [python] Add Support for < and > Predicates

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4524

to look at the new patch set (#2).

Change subject: KUDU-1637 - [python] Add Support for < and > Predicates
..

KUDU-1637 - [python] Add Support for < and > Predicates

Currently the python client doesn't support < and > predicates.
This patch adds that support and includes changes to existing tests.

Change-Id: Ic78dcf58949277fc8363d4d5b3bfa6067932a823
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
4 files changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4524/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic78dcf58949277fc8363d4d5b3bfa6067932a823
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1637 - [python] Add Support for < and > Predicates

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1637 - [python] Add Support for < and > Predicates
..


Patch Set 1:

Yea, the test_scan_rows_string_predicate_and_projection test uses <= and >=.

-- 
To view, visit http://gerrit.cloudera.org:8080/4524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic78dcf58949277fc8363d4d5b3bfa6067932a823
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No