[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test

[David Ribeiro Alves (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5233

to look at the new patch set (#2).

Change subject: Allow to skip the scan part of full_stack-insert-scan-test
..

Allow to skip the scan part of full_stack-insert-scan-test

This test is good to microbenchmark/run perf on writes but
the scan part of the test introduces noise in this case.

This patch adds a flag to allow to skip the scan part of
the test.

Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
---
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/5233/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Allow to skip the scan part of full_stack-insert-scan-test
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5233/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc
File src/kudu/integration-tests/full_stack-insert-scan-test.cc:

PS1, Line 275:   NO_FATALS(DoTestScans());
 : }
 : 
 : TES
> nit: may be, move this into the DoTestScans() itself?
Done


PS1, Line 286:   vector threads(kNumInsertClients);
 :   CountDownLatch start_latch(kNumInsertClients + 1);
 :   for (int i = 0; i < kNumInsertClients; ++i) {
 :
> ditto
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Finish incomplete sentence in 
docs/design-docs/rpc-retry-and-failover.md
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5228/2/docs/design-docs/rpc-retry-and-failover.md
File docs/design-docs/rpc-retry-and-failover.md:

PS2, Line 186: all that
 : is required is that the service definition enables the 
appropriate option
> nit: may be re-phrase this part of the sentence as:
this was not changed in this patch, right? mind if we leave it?


-- 
To view, visit http://gerrit.cloudera.org:8080/5228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a390d76d053dd34f20c058a1733ba949143d2b3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Remove/downgrade a few very verbose useless log statements

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Remove/downgrade a few very verbose useless log statements
..


Patch Set 2:

are these useful in your opinion? i know they can be reduced that way but why 
keep typing that flag if they never provide value? for instance if the 
maintenance manager if disabled, do we really need to know about it every 100 
msecs?

-- 
To view, visit http://gerrit.cloudera.org:8080/5226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7863f067f49cc7432e8ca3b532a208d3c4005300
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

[David Ribeiro Alves (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5223

to look at the new patch set (#2).

Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
..

Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

While running fuzz-itest in dist-test with slow mode, asan, it's
often flaky due to timeouts. This test is the main culprit
as it often takes 13 minutes to complete.

This reduces the number of operations in this test and
'update_multiplier' to half for all build types but TSAN (we had already
reduced ops in this case) making it non-flaky.

Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/5223/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
..


Patch Set 1:

What I mention in the commit message is that I measured this in asan.
my guess is that this test will always some degree of flakyness (some roll of 
the dice might generate a fuzz batch with many slow operations) so makes sense 
to reduce the batches overall IMO.
Updated the commit message to reflect this.

-- 
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5223/1/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:

PS1, Line 488: update_multiplier = 500
>From the commit message, I thought the intention was to reduce number of 
>mutations only for the ASAN builds.

However, in this case the number of mutations would decrease also for non-ASAN 
builds.  If that was the original intention (i.e. reduce number of operations 
for _both_ ASAN and regular modes), it would be nice to reflect that in the 
commit message.  If not, then may be it's worth updating this and add if/else 
involving the ADDRESS_SANITIZER macro?


-- 
To view, visit http://gerrit.cloudera.org:8080/5223
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73220ed342d2417ad65bf1ae705499cab7a9b10
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Finish incomplete sentence in 
docs/design-docs/rpc-retry-and-failover.md
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5228/2/docs/design-docs/rpc-retry-and-failover.md
File docs/design-docs/rpc-retry-and-failover.md:

PS2, Line 186: all that
 : is required is that the service definition enables the 
appropriate option
nit: may be re-phrase this part of the sentence as:

..., enable the appropriate option in the service definition.


-- 
To view, visit http://gerrit.cloudera.org:8080/5228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a390d76d053dd34f20c058a1733ba949143d2b3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Remove/downgrade a few very verbose useless log statements

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Remove/downgrade a few very verbose useless log statements
..


Patch Set 2:

> Uploaded patch set 2.

Instead of that, why not to use '-vmodule' flag?

-- 
To view, visit http://gerrit.cloudera.org:8080/5226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7863f067f49cc7432e8ca3b532a208d3c4005300
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Allow to skip the scan part of full stack-insert-scan-test

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Allow to skip the scan part of full_stack-insert-scan-test
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5233/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc
File src/kudu/integration-tests/full_stack-insert-scan-test.cc:

PS1, Line 275:   if (FLAGS_skip_scans) {
 : LOG(INFO) << "Skipped scan part of the test.";
 : return;
 :   }
nit: may be, move this into the DoTestScans() itself?


PS1, Line 286:   if (FLAGS_skip_scans) {
 : LOG(INFO) << "Skipped scan part of the test.";
 : return;
 :   }
ditto


-- 
To view, visit http://gerrit.cloudera.org:8080/5233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] WIP: [iwyu] first pass

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4738

to look at the new patch set (#5).

Change subject: WIP: [iwyu] first pass
..

WIP: [iwyu] first pass

Updated C++ source files in accordance with include-what-you-use
recommendations:
  * remove unused header files
  * add missing header files
  * use forward declarations when possible

As a result, time of compilation reduced ~10% if building with GNU make
in parallel with 48 jobs (make -j48) at ve0518.halxg.cloudera.com:

prior:
  real  1m21.858s
  user  33m26.685s
  sys 2m19.831s

after:
  real  1m12.686s
  user  30m26.891s
  sys 2m7.627s

The next step is automating the checks, so the IWYU check would run
automatically (like the LINT build).

Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
---
M src/kudu/benchmarks/rle.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch-schemas.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/block_compression.h
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/bloomfile.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/compression-test.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/cfile/compression_codec.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/gvint_block.cc
M src/kudu/cfile/gvint_block.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/index_block.h
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/index_btree.h
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/resource_metrics.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-internal.h
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/client/tablet-internal.h
M src/kudu/client/tablet_server-internal.cc
M src/kudu/client/tablet_server-internal.h
M src/kudu/client/value-internal.h
M src/kudu/client/value.cc
M src/kudu/client/value.h
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/codegen/code_cache.cc
M src/kudu/codegen/code_cache.h
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/code_generator.h
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
M src/kudu/codegen/jit_wrapper.cc
M src/kudu/codegen/jit_wrapper.h
M src/kudu/codegen/module_builder.cc
M src/kudu/codegen/module_builder.h
M src/kudu/codegen/precompiled.cc
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M 

[kudu-CR] IWYU: first pass

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4738

to look at the new patch set (#4).

Change subject: IWYU: first pass
..

IWYU: first pass

Updated the C++ source files in accordance with include-what-you-use
recommendations:
  * removed unused header files
  * added missing header files
  * using forward declarations instead of including header files

As a result, time of compilation reduced ~10% if building with GNU make
in parallel with 48 jobs (make -j48) at ve0518.halxg.cloudera.com:

prior:
  real  1m21.858s
  user  33m26.685s
  sys 2m19.831s

after:
  real  1m12.686s
  user  30m26.891s
  sys 2m7.627s

The next step is automating the checks, so the IWYU check would run
automatically (like the LINT build).

Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
---
M src/kudu/benchmarks/rle.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch-schemas.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/block_compression.h
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/bloomfile.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/compression-test.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/cfile/compression_codec.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/gvint_block.cc
M src/kudu/cfile/gvint_block.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/index_block.h
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/index_btree.h
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/resource_metrics.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-internal.h
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/client/tablet-internal.h
M src/kudu/client/tablet_server-internal.cc
M src/kudu/client/tablet_server-internal.h
M src/kudu/client/value-internal.h
M src/kudu/client/value.cc
M src/kudu/client/value.h
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/codegen/code_cache.cc
M src/kudu/codegen/code_cache.h
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/code_generator.h
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
M src/kudu/codegen/jit_wrapper.cc
M src/kudu/codegen/jit_wrapper.h
M src/kudu/codegen/module_builder.cc
M src/kudu/codegen/module_builder.h
M src/kudu/codegen/precompiled.cc
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M 

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

[Brock Noland (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4491

to look at the new patch set (#12).

Change subject: KUDU-1563. Add support for INSERT IGNORE
..

KUDU-1563. Add support for INSERT IGNORE

Adds `INSERT IGNORE' operation which behaves like a
normal `INSERT' except in the case when a duplicate
row error would be raised by the primary key having been
previously inserted.

Follows upsert backend/c++ patch 56c431585ed7ad07ef.

Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/wire_protocol.proto
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/local_tablet_writer.h
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/row_op.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tablet/transactions/transaction.cc
M src/kudu/tablet/transactions/transaction.h
M src/kudu/tablet/transactions/write_transaction.cc
24 files changed, 333 insertions(+), 72 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/4491/12
-- 
To view, visit http://gerrit.cloudera.org:8080/4491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Brock Noland 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Implement feature flag support on WriteRpc and add flag for INSERT IGNORE

[Brock Noland (Code Review)]

Brock Noland has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5241

Change subject: Implement feature flag support on WriteRpc and add flag for 
INSERT IGNORE
..

Implement feature flag support on WriteRpc and add flag for INSERT IGNORE

Change-Id: I68133e9b92658e56152cdf00ba3f7f10b30e961b
---
M src/kudu/client/batcher.cc
M src/kudu/client/client-test.cc
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
6 files changed, 54 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/5241/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68133e9b92658e56152cdf00ba3f7f10b30e961b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 

[kudu-CR] IWYU: first pass

[Alexey Serbin (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4738

to look at the new patch set (#3).

Change subject: IWYU: first pass
..

IWYU: first pass

Updated the C++ source files in accordance with include-what-you-use
recommendations:
  * removed unused header files
  * added missing header files
  * using forward declarations instead of including header files

As a result, time of compilation reduced ~10% if building with GNU make
in parallel with 48 jobs (make -j48) at ve0518.halxg.cloudera.com:

prior:
  real  1m21.858s
  user  33m26.685s
  sys 2m19.831s

after:
  real  1m12.686s
  user  30m26.891s
  sys 2m7.627s

The next step is automating the checks, so the IWYU check would run
automatically (like the LINT build).

Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa
---
M src/kudu/benchmarks/rle.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch-schemas.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/benchmarks/wal_hiccup.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/binary_prefix_block.h
M src/kudu/cfile/block_cache-test.cc
M src/kudu/cfile/block_cache.cc
M src/kudu/cfile/block_cache.h
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/block_compression.h
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/bloomfile.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/compression-test.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/cfile/compression_codec.h
M src/kudu/cfile/encoding-test.cc
M src/kudu/cfile/gvint_block.cc
M src/kudu/cfile/gvint_block.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_block.cc
M src/kudu/cfile/index_block.h
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/index_btree.h
M src/kudu/cfile/mt-bloomfile-test.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/cfile/type_encodings.h
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.h
M src/kudu/client/error-internal.cc
M src/kudu/client/error-internal.h
M src/kudu/client/error_collector.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/predicate-test.cc
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
M src/kudu/client/resource_metrics.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_predicate.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-internal.h
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.cc
M src/kudu/client/table_creator-internal.h
M src/kudu/client/tablet-internal.h
M src/kudu/client/tablet_server-internal.cc
M src/kudu/client/tablet_server-internal.h
M src/kudu/client/value-internal.h
M src/kudu/client/value.cc
M src/kudu/client/value.h
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/codegen/code_cache.cc
M src/kudu/codegen/code_cache.h
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/code_generator.h
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/compilation_manager.h
M src/kudu/codegen/jit_wrapper.cc
M src/kudu/codegen/jit_wrapper.h
M src/kudu/codegen/module_builder.cc
M src/kudu/codegen/module_builder.h
M src/kudu/codegen/precompiled.cc
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M 

[kudu-CR] KUDU-798 (part 3) Remove the clock from MvccManager

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-798 (part 3) Remove the clock from MvccManager
..


Patch Set 1:

hum turns out this is a bad idea without the rest of the safe time advancement 
stuff. merging this into follow up patches.

-- 
To view, visit http://gerrit.cloudera.org:8080/5240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

[kudu-CR] KUDU-798 (part 3) Remove the clock from MvccManager

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5240

Change subject: KUDU-798 (part 3) Remove the clock from MvccManager
..

KUDU-798 (part 3) Remove the clock from MvccManager

All mvcc transactions are now started at a timestamp so there is no
need for MvccManager to assign timestamps. Without this there
was a single place where we used the clock, outside of checks:
We used the clock in WaitForCleanSnapshotAtTimestamp() to make sure
the clock was past the timestamp before waiting on the snapshot to
be clean.

While this didn't make much sense, since the clean timestamp
shouldn't ever move past the current clock value, this is currently
a proxy to waiting for "safe time" on leader side transactions.
Until we properly handle that in follow up patches this check was
moved to where we handle snapshot scans in TabletService.

Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/mvcc-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/mvcc.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tablet/transactions/write_transaction.h
M src/kudu/tserver/tablet_service.cc
12 files changed, 86 insertions(+), 106 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/5240/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 

[kudu-CR] KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

[David Ribeiro Alves (Code Review)]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5057

to look at the new patch set (#9).

Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from 
mvcc
..

KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc

This patch completely removes the APIs that allow automatic timestamp
assignment and automatic safe time adjustment from Mvcc.

The previous patch took care of making sure these APIs were
unused in regular TabletServer operations. This patch completes
that by removing the APIs from Mvcc and changing tests appropriately.

Because, for non-tserver based tests, timestamp assignment and
transaction start are now done under a lock this does introduce
a slowdown in tests like mt-tablet-test. I measured about 10% slowdown
on an mvcc-stressing config of mt-tablet-test (run config and
perf stats in the end of this commit message).

However this patch series does not add any overhead on the actual
tablet server write path. In fact, this even simplifies it in some
circumstances: for instance, we were advancing safe time twice for
leader side txns: one when it was consensus committed and one when
the apply was complete. Due to this, there was even a moderate
speedup in this more important case, measured with
full_stack-insert-scan-test, (run config and perf stats below)
of about 9%.

===
full_stack-insert-scan-test run config:

bin/full_stack-insert-scan-test \
--gtest_filter=*MRSOnlyStressTest* \
--inserts_per_client=20 \
--concurrent_inserts=10 \
--rows_per_batch=1 \
--skip_scans

Results on master before this patch series:

 344086.766163 task-clock#5.659 CPUs utilized
14,435,389 context-switches  #0.042 M/sec
91,225 cpu-migrations#0.265 K/sec
   112,036 page-faults   #0.326 K/sec
   956,637,266,040 cycles#2.780 GHz
stalled-cycles-frontend
stalled-cycles-backend
   577,637,169,921 instructions  #0.60  insns per cycle
   109,720,205,884 branches  #  318.874 M/sec
   730,807,372 branch-misses #0.67% of all branches

  60.807013290 seconds time elapsed

Results on master after this patch series:

 328574.272742 task-clock#5.932 CPUs utilized
13,820,330 context-switches  #0.042 M/sec
   170,370 cpu-migrations#0.519 K/sec
   111,997 page-faults   #0.341 K/sec
   911,264,247,114 cycles#2.773 GHz
stalled-cycles-frontend
stalled-cycles-backend
   572,898,176,369 instructions  #0.63  insns per cycle
   108,872,113,035 branches  #  331.347 M/sec
   728,934,228 branch-misses #0.67% of all branches

  55.387672052 seconds time elapsed

===
mt-tablet-test run config:

bin/mt-tablet-test \
--gtest_filter=*0*DoTestAllAtOnce* \
--num_counter_threads=0 \
--num_slowreader_threads=0 \
--flusher_backoff=1.0 \
--flusher_initial_frequency_ms=1 \
--inserts_per_thread=100 \
--num_summer_threads=0 \
--gtest_repeat=3 \
--tablet_test_flush_threshold_mb=2000 \
--minloglevel=10

Results on master before this patch series:

 618894.806683 task-clock#7.716 CPUs utilized
 7,243,713 context-switches  #0.012 M/sec
   782 cpu-migrations#0.001 K/sec
 1,457,677 page-faults   #0.002 M/sec
 1,794,712,092,284 cycles#2.900 GHz
stalled-cycles-frontend
stalled-cycles-backend
   648,757,335,519 instructions  #0.36  insns per cycle
   128,766,989,780 branches  #  208.060 M/sec
   790,345,583 branch-misses #0.61% of all branches

  80.204388663 seconds time elapsed

Result on master after this patch series:

 620594.911121 task-clock#7.012 CPUs utilized
17,645,922 context-switches  #0.028 M/sec
 1,163 cpu-migrations#0.002 K/sec
 1,252,812 page-faults   #0.002 M/sec
 1,775,937,664,119 cycles#2.862 GHz
stalled-cycles-frontend
stalled-cycles-backend
   757,882,564,990 instructions  #0.43  insns per cycle
   155,500,757,477 branches  #  250.567 M/sec
   982,110,478 branch-misses #0.63% of all branches

  88.500973260 seconds time elapsed

Change-Id: I6cd0b8aa52e4b0f5c0f4872d806e76387f6b9538
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diskrowset-test-base.h
M 

[kudu-CR] [WIP][spark] - Java Spark API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5172

to look at the new patch set (#10).

Change subject: [WIP][spark] - Java Spark API
..

[WIP][spark] - Java Spark API

Currently, the Kudu Spark API is only supported for Scala. This
patch introduces Java compatibility for Spark. This will later
be useful for the creation of a Kudu pyspark API since py4j
will be used to wrap the library.

Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
---
M java/kudu-spark/pom.xml
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduContext.scala
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/BaseJavaKuduSparkTest.java
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/JavaKuduContextTest.java
4 files changed, 412 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5172/10
-- 
To view, visit http://gerrit.cloudera.org:8080/5172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [WIP][spark] - Java Spark API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5172

to look at the new patch set (#9).

Change subject: [WIP][spark] - Java Spark API
..

[WIP][spark] - Java Spark API

Currently, the Kudu Spark API is only supported for Scala. This
patch introduces Java compatibility for Spark. This will later
be useful for the creation of a Kudu pyspark API since py4j
will be used to wrap the library.

Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
---
M java/kudu-spark/pom.xml
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduContext.scala
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/BaseJavaKuduSparkTest.java
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/JavaKuduContextTest.java
4 files changed, 412 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5172/9
-- 
To view, visit http://gerrit.cloudera.org:8080/5172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [WIP][spark] - Java Spark API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5172

to look at the new patch set (#7).

Change subject: [WIP][spark] - Java Spark API
..

[WIP][spark] - Java Spark API

Currently, the Kudu Spark API is only supported for Scala. This
patch introduces Java compatibility for Spark. This will later
be useful for the creation of a Kudu pyspark API since py4j
will be used to wrap the library.

Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
---
M java/kudu-spark/pom.xml
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduContext.scala
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduRDD.scala
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/BaseJavaKuduSparkTest.java
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/JavaKuduContextTest.java
5 files changed, 460 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5172/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [WIP][spark] - Java Spark API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5172

to look at the new patch set (#6).

Change subject: [WIP][spark] - Java Spark API
..

[WIP][spark] - Java Spark API

Currently, the Kudu Spark API is only supported for Scala. This
patch introduces Java compatibility for Spark. This will later
be useful for the creation of a Kudu pyspark API since py4j
will be used to wrap the library.

Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
---
M java/kudu-spark/pom.xml
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduContext.scala
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduRDD.scala
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/BaseJavaKuduSparkTest.java
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/JavaKuduContextTest.java
5 files changed, 462 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5172/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [WIP][spark] - Java Spark API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5172

to look at the new patch set (#5).

Change subject: [WIP][spark] - Java Spark API
..

[WIP][spark] - Java Spark API

Currently, the Kudu Spark API is only supported for Scala. This
patch introduces Java compatibility for Spark. This will later
be useful for the creation of a Kudu pyspark API since py4j
will be used to wrap the library.

Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
---
M java/kudu-spark/pom.xml
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduContext.scala
A 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/api/java/JavaKuduRDD.scala
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/BaseJavaKuduSparkTest.java
A 
java/kudu-spark/src/test/java/org/apache/kudu/spark/kudu/JavaKuduContextTest.java
5 files changed, 462 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5172/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87c5ba73a0139b05e9a03157078be31534ea5488
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5237

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..

KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column 
is not set

Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/5237/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng 

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has abandoned this change.

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..


Abandoned

RowKeyStringify format check failed

-- 
To view, visit http://gerrit.cloudera.org:8080/5236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iad549a2366367b259be45ec538e9f8a221e15d68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5236

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..

KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column 
is not set

Change-Id: Iad549a2366367b259be45ec538e9f8a221e15d68
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/5236/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad549a2366367b259be45ec538e9f8a221e15d68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng 

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has abandoned this change.

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..


Abandoned

There is a typo in this change.
My test environment and git are not on the same machine. I made a typo when 
retyped the change. sorry

-- 
To view, visit http://gerrit.cloudera.org:8080/5235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie6c872e491fcf7f91974a7572b1e45c35ea18ecd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has abandoned this change.

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..


Abandoned

There is a typo in this change.
My test environment and git are not on the same machine. I made a typo when 
retyped the change. sorry

-- 
To view, visit http://gerrit.cloudera.org:8080/5234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6a39fd57ebd8490daf161c8e86f8386ac81e43cb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5235

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..

KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column 
is not set

Change-Id: Ie6c872e491fcf7f91974a7572b1e45c35ea18ecd
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/5235/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6c872e491fcf7f91974a7572b1e45c35ea18ecd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng 

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[YanlongZheng (Code Review)]

YanlongZheng has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5234

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
..

KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column 
is not set

Change-Id: I6a39fd57ebd8490daf161c8e86f8386ac81e43cb
---
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/5234/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a39fd57ebd8490daf161c8e86f8386ac81e43cb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: YanlongZheng