[kudu-CR] [jepsen.kudu] some updates
Alexey Serbin has posted comments on this change. Change subject: [jepsen.kudu] some updates .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/5500/5/java/kudu-jepsen/README.md File java/kudu-jepsen/README.md: > Glad to see this filled out, though we should still update the rest (especi That's fixed in https://gerrit.cloudera.org/#/c/5551 PS5, Line 12: The Knossos take > "Knossos takes" Done PS5, Line 19: MacOS X > "macOS" Done PS5, Line 23: xhyve > Is this a typo or a real thing? https://github.com/mist64/xhyve PS5, Line 24: their clock, which is managed by their own NTP servers, > "their clock (which is managed by their own NTP servers)" Done PS5, Line 25: their clock > Drop Done PS5, Line 44: MacOS X > "macOS" Done PS5, Line 50: MacOS X > "macOS" Done -- To view, visit http://gerrit.cloudera.org:8080/5500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] some updates
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5500 to look at the new patch set (#6). Change subject: [jepsen.kudu] some updates .. [jepsen.kudu] some updates Updated jepsen.kudu test scenarios: * More robust NTP-related operations * Added additional nemeses * README.md: added notes on Docker for Mac * Starting up master server: wait for the catalog manager * Run multiple test scenarios in the scope of the register test Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61 --- M java/kudu-jepsen/README.md M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj 5 files changed, 235 insertions(+), 58 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/6 -- To view, visit http://gerrit.cloudera.org:8080/5500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5488 to look at the new patch set (#2). Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER .. KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER This adds a test for the case where an ALTER TABLE adds a column, and then we read the old history of that row from prior to the addition of the column. We make sure that the default value of the new column is returned. Change-Id: Id7d44f6e2fe4d3cae03e0024c70e9f2ae84b614c --- M src/kudu/integration-tests/alter_table-test.cc M src/kudu/tablet/compaction.cc 2 files changed, 47 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/5488/2 -- To view, visit http://gerrit.cloudera.org:8080/5488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7d44f6e2fe4d3cae03e0024c70e9f2ae84b614c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart
Hello Mike Percy, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5598 to review the following change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart MiniCluster and ExternalMiniCluster utility classes follow opposite semantics for restart. For eg, ExternalMiniCluster::Restart() expects that all the nodes must be shutdown before we do restart, whereas MiniCluster::Restart() expects that all servers are up and running so that it can internally execute shutdown and start in that order. This patch changes the semantics of MiniCluster::Restart() to follow that of ExternalMiniCluster::Restart() to keep the consistent and the existing tests are modified to follow the new semantics of MiniCluster::Restart(). Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633 --- M src/kudu/client/client-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/master/master-test.cc M src/kudu/master/mini_master.cc M src/kudu/master/mini_master.h M src/kudu/tserver/mini_tablet_server.cc 9 files changed, 17 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/5598/1 -- To view, visit http://gerrit.cloudera.org:8080/5598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1655. Update docs for ASF maven repository coordinates
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1655. Update docs for ASF maven repository coordinates .. KUDU-1655. Update docs for ASF maven repository coordinates - Update Maven Artifacts - Update Kudu Integration with Spark using --packages Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Reviewed-on: http://gerrit.cloudera.org:8080/5581 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M docs/developing.adoc 1 file changed, 18 insertions(+), 22 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He Gerrit-Reviewer: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1655. Update docs for ASF maven repository coordinates
Todd Lipcon has posted comments on this change. Change subject: KUDU-1655. Update docs for ASF maven repository coordinates .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He Gerrit-Reviewer: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1655. Update docs for ASF maven repository coordinates
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5600 Change subject: KUDU-1655. Update docs for ASF maven repository coordinates .. KUDU-1655. Update docs for ASF maven repository coordinates - Update Maven Artifacts - Update Kudu Integration with Spark using --packages Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Reviewed-on: http://gerrit.cloudera.org:8080/5581 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon (cherry picked from commit 286f2356260bd747109daf2c14301b3e5b7719f0) --- M docs/developing.adoc 1 file changed, 18 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5600/1 -- To view, visit http://gerrit.cloudera.org:8080/5600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.2.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jun He
[kudu-CR](branch-1.2.x) KUDU-1655. Update docs for ASF maven repository coordinates
Todd Lipcon has posted comments on this change. Change subject: KUDU-1655. Update docs for ASF maven repository coordinates .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-1.2.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1655. Update docs for ASF maven repository coordinates
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1655. Update docs for ASF maven repository coordinates .. KUDU-1655. Update docs for ASF maven repository coordinates - Update Maven Artifacts - Update Kudu Integration with Spark using --packages Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Reviewed-on: http://gerrit.cloudera.org:8080/5581 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon (cherry picked from commit 286f2356260bd747109daf2c14301b3e5b7719f0) Reviewed-on: http://gerrit.cloudera.org:8080/5600 Tested-by: Todd Lipcon --- M docs/developing.adoc 1 file changed, 18 insertions(+), 22 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/5600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ddafd84dbf2a977e8b7faea78d3b38968c4e19e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-1.2.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5601 to review the following change. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. KUDU-1818. Add link to Cloudera training in FAQ Additionally I snuck in a formatting fix I noticed for a later FAQ entry. Change-Id: Ic5bb14c4b5d54a5b43ac5c15611377e901d9c47a --- M faq.md 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5601/1 -- To view, visit http://gerrit.cloudera.org:8080/5601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic5bb14c4b5d54a5b43ac5c15611377e901d9c47a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] Kudu Jepsen Tests - Initial Commit
Alexey Serbin has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/5492/12/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: PS12, Line 358: /opt/apache-maven-3.3.9/bin Are we ready to migrate to the new maven to build everything Java? If doing so, why not to transition to Java8 for everything as well? >From the other side, if we are using Java8 and just for kudu-jepsen, why not >to leave it as a special profile/configuration? At least, that works right >now, and since we are not about to run kudu-jepsen as a pre-commit >verification test, having a separate profile for kudu-jepsen makes sense IMO. PS12, Line 369: /opt/apache-maven-3.3.9/bin/mvn If this path is used twice already, may be introduce a variable for that and use it everywhere? http://gerrit.cloudera.org:8080/#/c/5492/12/build-support/jenkins/toolchains.xml File build-support/jenkins/toolchains.xml: PS12, Line 13: an extra-space -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bb14c4b5d54a5b43ac5c15611377e901d9c47a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-HasComments: No
[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. KUDU-1818. Add link to Cloudera training in FAQ Additionally I snuck in a formatting fix I noticed for a later FAQ entry. Change-Id: Ic5bb14c4b5d54a5b43ac5c15611377e901d9c47a Reviewed-on: http://gerrit.cloudera.org:8080/5601 Reviewed-by: Jean-Daniel Cryans Tested-by: Jean-Daniel Cryans --- M faq.md 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/5601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5bb14c4b5d54a5b43ac5c15611377e901d9c47a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] Restructure release notes in preparation for 1.2 release
Hello Jean-Daniel Cryans, John Russell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5602 to review the following change. Change subject: Restructure release notes in preparation for 1.2 release .. Restructure release notes in preparation for 1.2 release * Moved the 1.1 release notes to the Prior Release Notes page * On the Prior Release Notes page, removed the list of known limitations, upgrade instructions, compatibility notes, etc for each of the past releases. Those things aren't very useful in the case of the prior releases, and it would generally be better for people to refer to the documentation corresponding to that particular release if they are interested in those details. * Moved the current version Known Issues and Limitations documentation to a new separate docs page. Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 --- A docs/known_issues.adoc M docs/prior_release_notes.adoc M docs/release_notes.adoc M docs/support/jekyll-templates/document.html.erb 4 files changed, 234 insertions(+), 410 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/5602/1 -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell
[kudu-CR] Restructure release notes in preparation for 1.2 release
Jean-Daniel Cryans has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 1: (3 comments) Mind also generating site we can look at while reviewing? http://gerrit.cloudera.org:8080/#/c/5602/1/docs/prior_release_notes.adoc File docs/prior_release_notes.adoc: Line 37: release for a list of known issues and limitations. Could link to this page: http://kudu.apache.org/releases/ http://gerrit.cloudera.org:8080/#/c/5602/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line 47: 1.0 1.1? PS1, Line 49: 1.0 1.1? -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5603 to review the following change. Change subject: thirdparty: Link curl against el6 workaround openssl .. thirdparty: Link curl against el6 workaround openssl This patch enables HTTPS support for thirdparty libcurl as well as links thirdparty libcurl against the el6 workaround openssl when applicable. Part of this patch pulled out of Todd's https://gerrit.cloudera.org/5015 This patch restores the capability to use HTTPS from libcurl for tests while also maintaining support for posting to the dist_test cluster from CentOS 6. Change-Id: I19e6be946853a80dad0f496839212887e76db06f --- M thirdparty/build-definitions.sh 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5603/1 -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Adar Dembo has posted comments on this change. Change subject: thirdparty: Link curl against el6 workaround openssl .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5603/1//COMMIT_MSG Commit Message: Line 7: thirdparty: Link curl against el6 workaround openssl Should probably add a note about why we can't just remove curl from thirdparty and use the system libcurl (since the answer was non-obvious). http://gerrit.cloudera.org:8080/#/c/5603/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 505: CXXFLAGS="$EXTRA_CXXFLAGS $CURL_EXTRA_CXXFLAGS" \ Curl is C-based, so I'm surprised this works. Shouldn't it be CFLAGS? -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin
Alexey Serbin has posted comments on this change.
Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
..
Patch Set 7:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/.gitignore
File java/kudu-jepsen/.gitignore:
Line 1: .lein-failures
> Could you add comments explaining why we need each one?
Done
http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/README.md
File java/kudu-jepsen/README.md:
Line 22: List of required packages For Debian/Ubuntu machines if us:
> Could you reformat this sentence? It has some grammar issues and multiple c
Done
PS7, Line 23: krb5-admin-server krb5-kdc krb5-user
: libsasl2-modules libsasl2-modules-gssapi-mit lsb-release ntp
openssl
> Nit: reformat this into an actual markdown list.
Done.
Actually, I automated that, so this comment and corresponding monkey work is
not necessary anymore.
PS7, Line 27: on
> of
Done
http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/pom.xml
File java/kudu-jepsen/pom.xml:
PS7, Line 29:
:
:
> Why is this necessary? Aren't all properties empty by default?
I thought it's better to explicitly declare those.
Besides, as it turned out, properties are not empty by default. At least, when
the property is not listed here and used like in element below for
clojure-maven-plugin, it is evaluated to "${sshKeyPath}" (!sic). Since
"${sshKeyPath}" is not "", that breaks the test.
I'm going to leave them as is. If you know the better way to deal with that --
let me know.
Line 102: --master-nodes=${masterNodes}
--tserver-nodes=${tserverNodes} --ssh-key-path=${sshKeyPath}
> Nit: could you separate each argument on its own line so this is more reada
Done
--
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Restructure release notes in preparation for 1.2 release
Todd Lipcon has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5602/1/docs/prior_release_notes.adoc File docs/prior_release_notes.adoc: Line 37: release for a list of known issues and limitations. > Could link to this page: http://kudu.apache.org/releases/ Done http://gerrit.cloudera.org:8080/#/c/5602/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line 49: 1.0 > 1.1? I left these as 1.0 since I think the point is that it's compatible going back to 1.0. Got a suggestion of a more clear way to say that? "1.0 or 1.1" is OK now but when we have four or five minor releases that's going to look ugly. -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Restructure release notes in preparation for 1.2 release
John Russell has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5602/1/docs/known_issues.adoc File docs/known_issues.adoc: PS1, Line 36: Key columns cannot be altered What's the significance of "altered" here? In a later bullet it says the primary key can't be changed. Type and nullability can't be changed for any column. Is this statement saying the name of the column can't be changed, or does it mean the same as the later bullet "A table's primary key cannot be changed"? PS1, Line 38: Key columns must not be null Might be clearer to say that all columns in the primary key must be NOT NULL. http://gerrit.cloudera.org:8080/#/c/5602/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line 34: == New features I'm interested to see a list of new features other than the Impala-oriented syntax. PS1, Line 37: Optimizations I'm interested to see a list of optimizations. -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Restructure release notes in preparation for 1.2 release
Todd Lipcon has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5602/1/docs/known_issues.adoc File docs/known_issues.adoc: PS1, Line 36: Key columns cannot be altered > What's the significance of "altered" here? In a later bullet it says the pr yep. This commit is just moving this content, didn't want to rewrite at the moment. I will address in a separate commit. PS1, Line 38: Key columns must not be null > Might be clearer to say that all columns in the primary key must be NOT NUL same http://gerrit.cloudera.org:8080/#/c/5602/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line 34: == New features > I'm interested to see a list of new features other than the Impala-oriented yep, the actual content will be in the next commit up for review quite soon now -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] run tests from clojure-maven-plugin
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5500 to look at the new patch set (#7). Change subject: [jepsen.kudu] run tests from clojure-maven-plugin .. [jepsen.kudu] run tests from clojure-maven-plugin Changes to allow the jepsen Kudu tests to run from the maven plugin clojure-maven-plugin. To run the tests on, execute the following command in the $REPO_ROOT/java/kudu-jepsen directory: mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0,t1,t2,t3,t4" Also updated jepsen.kudu test scenarios: * Added additional nemeses * Starting up master server: wait for the catalog manager * Run multiple test scenarios in the scope of the register test Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61 --- M java/kudu-jepsen/.gitignore A java/kudu-jepsen/README.adoc D java/kudu-jepsen/README.md M java/kudu-jepsen/pom.xml M java/kudu-jepsen/resources/kudu.flags M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj A java/kudu-jepsen/src/utils/kudu_test_runner.clj 12 files changed, 823 insertions(+), 168 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/7 -- To view, visit http://gerrit.cloudera.org:8080/5500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin
Alexey Serbin has abandoned this change. Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin .. Abandoned Merged into a single patch: https://gerrit.cloudera.org/#/c/5500 -- To view, visit http://gerrit.cloudera.org:8080/5551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Restructure release notes in preparation for 1.2 release
Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo, John Russell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5602 to look at the new patch set (#2). Change subject: Restructure release notes in preparation for 1.2 release .. Restructure release notes in preparation for 1.2 release * Moved the 1.1 release notes to the Prior Release Notes page * On the Prior Release Notes page, removed the list of known limitations, upgrade instructions, compatibility notes, etc for each of the past releases. Those things aren't very useful in the case of the prior releases, and it would generally be better for people to refer to the documentation corresponding to that particular release if they are interested in those details. * Moved the current version Known Issues and Limitations documentation to a new separate docs page. Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 --- A docs/known_issues.adoc M docs/prior_release_notes.adoc M docs/release_notes.adoc M docs/support/jekyll-templates/document.html.erb 4 files changed, 235 insertions(+), 410 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/5602/2 -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia6684706ec9c0b774ec11805cab1d4a3f02412f0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] WIP: release notes for 1.2
Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo, John Russell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5604 to review the following change. Change subject: WIP: release notes for 1.2 .. WIP: release notes for 1.2 Change-Id: I08326171dd2bf6097a7594b95adca946bb5922eb --- M docs/release_notes.adoc M docs/schema_design.adoc 2 files changed, 141 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5604/1 -- To view, visit http://gerrit.cloudera.org:8080/5604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08326171dd2bf6097a7594b95adca946bb5922eb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mike Percy
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Mike Percy has posted comments on this change. Change subject: thirdparty: Link curl against el6 workaround openssl .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5603/1//COMMIT_MSG Commit Message: Line 7: thirdparty: Link curl against el6 workaround openssl > Should probably add a note about why we can't just remove curl from thirdpa Done http://gerrit.cloudera.org:8080/#/c/5603/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 505: CXXFLAGS="$EXTRA_CXXFLAGS $CURL_EXTRA_CXXFLAGS" \ > Curl is C-based, so I'm surprised this works. Shouldn't it be CFLAGS? Ah, indeed. It was not taking effect. When I use CFLAGS configure complains that CPPFLAGS should be used for include directories. So I did that and it is converting my -I to -isystem after specifying it via CPPFLAGS. So I guess it works now. Added a comment about that. -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5603 to look at the new patch set (#2). Change subject: thirdparty: Link curl against el6 workaround openssl .. thirdparty: Link curl against el6 workaround openssl This patch enables HTTPS support for thirdparty libcurl as well as links thirdparty libcurl against the el6 workaround openssl when applicable. Part of this patch pulled out of Todd's https://gerrit.cloudera.org/5015 This patch restores the capability to use HTTPS from libcurl for tests while also maintaining support for posting to the dist_test cluster from CentOS 6. We considered (and attempted) depending on the system libcurl instead of including it in thirdparty, however the system libcurl links against the system openssl libraries. On CentOS 6, we build and test against the CentOS 6.4 version of openssl, which does not provide the symbols needed by the system version of libcurl. So, we are required to provide, as part of thirdparty, any library needing to be linked against openssl, and ensure that we build it against the el6-workaround openssl version. Change-Id: I19e6be946853a80dad0f496839212887e76db06f --- M thirdparty/build-definitions.sh 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5603/2 -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Adar Dembo has posted comments on this change. Change subject: thirdparty: Link curl against el6 workaround openssl .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5603/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: PS2, Line 506: even though curl is mostly written in C Was that surprising because CPPFLAGS sounds like it means "C plus plus flags"? It's actually not; CPPFLAGS means "C preprocessor flags", and it's typical for autotools to consume include directory customizations via CPPFLAGS (I forgot about this when I suggested CFLAGS; sorry about that). If that's what you meant, could you remove the comment, since autotools are behaving as expected? Or if you meant "I was expecting to pass the include directory via CFLAGS", then just rewrite the comment as "Note: curl shows a message asking for CPPFLAGS to be used for include directories, not CFLAGS", to avoid misdirecting the reader into thinking this is somehow to do with the programming language that curl was written in (C vs. C++). -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Mike Percy has posted comments on this change. Change subject: thirdparty: Link curl against el6 workaround openssl .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5603/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: PS2, Line 506: even though curl is mostly written in C > Was that surprising because CPPFLAGS sounds like it means "C plus plus flag Ahh... ya know, I always thoughts CXXFLAGS and CPPFLAGS were synonyms. Thanks for the explanation! I'll update the comment. -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] thirdparty: Link curl against el6 workaround openssl
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5603 to look at the new patch set (#3). Change subject: thirdparty: Link curl against el6 workaround openssl .. thirdparty: Link curl against el6 workaround openssl This patch enables HTTPS support for thirdparty libcurl as well as links thirdparty libcurl against the el6 workaround openssl when applicable. Part of this patch pulled out of Todd's https://gerrit.cloudera.org/5015 This patch restores the capability to use HTTPS from libcurl for tests while also maintaining support for posting to the dist_test cluster from CentOS 6. We considered (and attempted) depending on the system libcurl instead of including it in thirdparty, however the system libcurl links against the system openssl libraries. On CentOS 6, we build and test against the CentOS 6.4 version of openssl, which does not provide the symbols needed by the system version of libcurl. So, we are required to provide, as part of thirdparty, any library needing to be linked against openssl, and ensure that we build it against the el6-workaround openssl version. Change-Id: I19e6be946853a80dad0f496839212887e76db06f --- M thirdparty/build-definitions.sh 1 file changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5603/3 -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Initial draft of release notes and doc updates for 1.2
Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo, John Russell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5604 to look at the new patch set (#2). Change subject: Initial draft of release notes and doc updates for 1.2 .. Initial draft of release notes and doc updates for 1.2 Change-Id: I08326171dd2bf6097a7594b95adca946bb5922eb --- M docs/known_issues.adoc M docs/release_notes.adoc M docs/schema_design.adoc 3 files changed, 191 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5604/2 -- To view, visit http://gerrit.cloudera.org:8080/5604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08326171dd2bf6097a7594b95adca946bb5922eb Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1733. Update consistency semantics doc
Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo, John Russell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5605 to review the following change. Change subject: KUDU-1733. Update consistency semantics doc .. KUDU-1733. Update consistency semantics doc Change-Id: I5a59315e70531c8904470c026030f4cc2107ca5b --- M docs/transaction_semantics.adoc 1 file changed, 22 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/5605/1 -- To view, visit http://gerrit.cloudera.org:8080/5605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a59315e70531c8904470c026030f4cc2107ca5b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Mike Percy
[kudu-CR] [KUDU-90] Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total size.
Jun He has posted comments on this change.
Change subject: [KUDU-90] Add a header checksum to our RPC protocol Added
4-byte checksum into the RPC protocol. Checksum is inserted immediately after
total_size.
..
Patch Set 3:
(5 comments)
As the cost of computing CRC-32C is quite low, we may still consider to have it
if TLS is only optional.
http://gerrit.cloudera.org:8080/#/c/5578/3//COMMIT_MSG
Commit Message:
Line 7: [KUDU-90] Add a header checksum to our RPC protocol
> nit: follow the format used by other commit messages (KUDU-90. Add a header
Done
Line 8: Added 4-byte checksum into the RPC protocol.
> nit: please add a blank line before this one
Done
Line 25: This is a non-backward compatible change.
> I think it's too late to make a non-backward-compatible change. We should f
For the checksum, I think it makes sense to have the checksum for the whole
message.
For the compatibility issue, a straightforward way is to add an optional field
in pb header schema to store CRC. But this will complicate the checksum
computation and also will add 4-byte data in header object.
Feature flags sounds like another good way to solve the compatibility issue.
If TLS will be always enabled, we don't need additional CRC. But if it is
optional, I think CRC is still valuable if we only care network error instead
of integrity.
So if TLS is enabled, we can skip CRC, otherwise, we add CRC for the new
protocol. I think enabling TLS will face the similar compatibility problem.
Please let me know your comments. Thanks.
http://gerrit.cloudera.org:8080/#/c/5578/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java:
Line 74: public static final int INT_SIZE_IN_BYTES = 4;
> Integer.SIZE / 8
Done
http://gerrit.cloudera.org:8080/#/c/5578/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcChecksum.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcChecksum.java:
Line 26: public class TestRpcChecksum {
> this is nice as a unit test but would be good to actually inject invalid ch
This is a great idea. Will add it once we decide how to proceed.
--
To view, visit http://gerrit.cloudera.org:8080/5578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf71ed4d4ac924445606b0d6fcf477d025243c74
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He
Gerrit-Reviewer: Jun He
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] KUDU-90. Add a header checksum to our RPC protocol
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5578 to look at the new patch set (#4). Change subject: KUDU-90. Add a header checksum to our RPC protocol .. KUDU-90. Add a header checksum to our RPC protocol Added 4-byte checksum into the RPC protocol. Checksum is inserted immediately after total_size. The new message framing will be total_size: (32-bit big-endian integer) the size of the rest of the message, not including this 4-byte header header_checksum: (32-bit big-endian integer) CRC-32C the checksum of header (excluding varint-prefixed header size field) - CRC-32C computation in C++ uses `kudu/util/crc.h`. - CRC-32C computation in Java is based on hadoop-common class, `org.apache.hadoop.util.PureJavaCrc32C` header: varint-prefixed header protobuf - client->server messages use the RequestHeader protobuf - server->client messages use the ResponseHeader protobuf ... This is a non-backward compatible change. Change-Id: Icf71ed4d4ac924445606b0d6fcf477d025243c74 --- M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java A java/kudu-client/src/main/java/org/apache/kudu/util/Crc32C.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcChecksum.java M src/kudu/rpc/constants.h M src/kudu/rpc/serialization.cc 6 files changed, 763 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/5578/4 -- To view, visit http://gerrit.cloudera.org:8080/5578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf71ed4d4ac924445606b0d6fcf477d025243c74 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He Gerrit-Reviewer: Jun He Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-734. Add test coverage for encodings and strings
Jun He has posted comments on this change.
Change subject: KUDU-734. Add test coverage for encodings and strings
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5588/1//COMMIT_MSG
Commit Message:
Line 9: added a TestEncodings class to check various encodings for all column
types
> I'm not sure this belongs in the Java client tests. We already have similar
Thanks for the explanation.
I found that `TestRowResult` has covered setting/getting all of the available
column types.
This test improved the coverage by setting/getting all of the available primary
key types, which is not covered by TestKeyEncoding.
I think I can merge it into TestKeyEncoding class.
I will push the new change.
http://gerrit.cloudera.org:8080/#/c/5588/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestStrings.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestStrings.java:
Line 51: public void testMultiStringColumnsInsert() throws Exception {
> I think this is already covered by TestKuduClient#testStrings() (the right-
Done
Line 90: public void testUTF8StringEncoding() throws Exception {
> I think this is already covered by TestKuduClient#testUTF8 added in df02bb4
Not a problem. I will remove it.
--
To view, visit http://gerrit.cloudera.org:8080/5588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3fbeb0f889a4c454a48d11a6e42c7da0e58a329
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He
Gerrit-Reviewer: Jun He
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] [jepsen.kudu] run tests from the clojure-maven-plugin
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#8).
Change subject: [jepsen.kudu] run tests from the clojure-maven-plugin
..
[jepsen.kudu] run tests from the clojure-maven-plugin
This patch adds functionality to run the kudu-jepsen tests
from the clojure-maven-plugin. To run the tests against already
provisioned Kudu cluster with master node m0 and tserver nodes {t0..t4},
execute the following in the $REPO_ROOT/java/kudu-jepsen directory:
mvn test -DmasterNodes=m0 -DtserverNodes="t0,t1,t2,t3,t4"
after bulding the top-level project with
mvn compile -Pjepsen
Besides, this patch contains additional updates on kudu-jepsen code and
the scenarios for the read/write register linearizability test:
* Added additional nemeses
* Run multiple test scenarios in the scope of the register test
* Starting up master server: wait for the catalog manager
* Other unsorted fixes for more robust operation
Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
---
M java/kudu-jepsen/.gitignore
A java/kudu-jepsen/README.adoc
D java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/client.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
12 files changed, 845 insertions(+), 169 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/5500/8
--
To view, visit http://gerrit.cloudera.org:8080/5500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea1903fae6c2f0371091c773c5ae9b0abbbfbe61
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
